[Koha-bugs] [Bug 11399] batch rebuild items tables

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11399

Jonathan Druart  changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=14858

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11399] batch rebuild items tables

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11399

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

Summary|batch Rebuild Items Tables  |batch rebuild items tables

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11399] batch Rebuild Items Tables

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11399

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||tomasco...@gmail.com

--- Comment #12 from Tomás Cohen Arazi tomasco...@gmail.com ---
Patches pushed to master.

Thanks Stephane!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11399] batch Rebuild Items Tables

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11399

--- Comment #10 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 32512
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32512action=edit
[PASSED QA] Bug 11399: QA fixes

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11399] batch Rebuild Items Tables

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11399

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #29156|0   |1
is obsolete||
  Attachment #31518|0   |1
is obsolete||

--- Comment #9 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 32511
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32511action=edit
[PASSED QA] Bug 11399: batch Rebuild Items Tables

You can/must use it when you change items mapping.
this script rebuilds the non-MARC DB items table from the MARC values

usage : batchRebuildItemsTables.pl [ -h ][ -c ][ -t ][ -where ]

Options:
   -h --help   (or without arguments) shows this help message
   -c  Confirm: rebuild non marc DB (may be long)
   -t  test only, change nothing in DB
   --where add where condition on default query
   (eg. -where 'biblio.biblionumber100')

(copied test plan)
to test it :

create a test item (eg on biblionumber 3) with a non mapped subfield with a
test value.
check real items DB row ( SELECT * from items where biblionumber=3 ) = non
mapped value is in more_subfields_xml
map the non mapped subfield with unused items column
re-check in Db that nothing changes
run ./batchRebuildItemsTables.pl -c --where 'biblio.biblionumber=3'
check real items DB row ( SELECT * from items where biblionumber=3 ) = new
mapped value is not in more_subfields_xml anymore but in the mapped column

Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com
Work as described, no koha-qa errors.
Add a new item to record, save with value in unmapped subfield ('x')
Change mapping, run script, value on newly mapped column

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11399] batch Rebuild Items Tables

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11399

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11399] batch Rebuild Items Tables

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11399

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #11 from Kyle M Hall k...@bywatersolutions.com ---
Note, I found it a bit confusing that a test run required both -t *and* -c. I
would expect each to be independent, and use of both would be the same as -t
alone. However, we have no formal guidelines for this yet, so I do not feel it
is proper to fail qa on this point.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11399] batch Rebuild Items Tables

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11399

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Blocks||13023

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11399] batch Rebuild Items Tables

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11399

stephane.dela...@biblibre.com changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11399] batch Rebuild Items Tables

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11399

--- Comment #8 from stephane.dela...@biblibre.com ---
Created attachment 31518
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31518action=edit
followup : QA fixes

followup : QA fixes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11399] batch Rebuild Items Tables

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11399

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11399] batch Rebuild Items Tables

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11399

--- Comment #7 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Comment on attachment 29156
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29156
[SIGNED-OFF] Bug 11399: batch Rebuild Items Tables

Review of attachment 29156:
 -- 
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.htmlbug=11399attachment=29156)
-

2 small things from code review:

::: misc/batchRebuildItemsTables.pl
@@ +1,4 @@
 +#!/usr/bin/perl
 +use 5.10.0;
 +use strict;
 +use warnings;

Please switch to: use Modern::Perl; :)

@@ +94,5 @@
 +}
 +}
 +
 +$dbh-do(UPDATE systempreferences SET value=$CataloguingLog WHERE 
 variable='CataloguingLog');
 +$dbh-do(UPDATE systempreferences SET value=$dontmerge where 
 variable='dontmerge');

Please switch to using placeholders instead of variables.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11399] batch Rebuild Items Tables

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11399

Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:

   What|Removed |Added

  Attachment #23593|0   |1
is obsolete||

--- Comment #6 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com ---
Created attachment 29156
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29156action=edit
[SIGNED-OFF] Bug 11399: batch Rebuild Items Tables

You can/must use it when you change items mapping.
this script rebuilds the non-MARC DB items table from the MARC values

usage : batchRebuildItemsTables.pl [ -h ][ -c ][ -t ][ -where ]

Options:
   -h --help   (or without arguments) shows this help message
   -c  Confirm: rebuild non marc DB (may be long)
   -t  test only, change nothing in DB
   --where add where condition on default query
   (eg. -where 'biblio.biblionumber100')

(copied test plan)
to test it :

create a test item (eg on biblionumber 3) with a non mapped subfield with a
test value.
check real items DB row ( SELECT * from items where biblionumber=3 ) = non
mapped value is in more_subfields_xml
map the non mapped subfield with unused items column
re-check in Db that nothing changes
run ./batchRebuildItemsTables.pl -c --where 'biblio.biblionumber=3'
check real items DB row ( SELECT * from items where biblionumber=3 ) = new
mapped value is not in more_subfields_xml anymore but in the mapped column

Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com
Work as described, no koha-qa errors.
Add a new item to record, save with value in unmapped subfield ('x')
Change mapping, run script, value on newly mapped column

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11399] batch Rebuild Items Tables

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11399

Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||bgkrie...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11399] batch Rebuild Items Tables

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11399

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #2 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Hi Stephane, I am a bit confused about the use of this, because I think we
don't keep the item information in the MARC any more?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11399] batch Rebuild Items Tables

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11399

--- Comment #3 from stephane.dela...@biblibre.com ---
(In reply to Katrin Fischer from comment #2)
 Hi Stephane, I am a bit confused about the use of this, because I think we
 don't keep the item information in the MARC any more?

Hi Katrin, in fact, informations about items aren't stored directly in MARC.
However, when editing a record, MARC items informations can be regenerated
temporarily (that's what serves '1' when we call the function
'GetMarcBiblio($biblionumber,1)'). When a mapping is changed in MARC
bibliographic framework or Koha to MARC mapping (admin/koha2marclinks.pl on
items), it does not change the existing items. For example in UNIMARC, without
this patch, if I want to link the 995$j with items.stocknumber, this
information will remain in items.more_subfields_xml for old items as long as
they have not been modified manually. This script forces rewriting of items
taking new mapping into account (in our example, all 995$j will then be moved
from items.more_subfields_xml to items.stocknumber).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11399] batch Rebuild Items Tables

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11399

--- Comment #4 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Hi Stephane, that makes sense - maybe we should change the bug description? I
think this will only be needed if you change the mapping from a before unmapped
field or when you map an unmapped one (more_subfields_xml)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11399] batch Rebuild Items Tables

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11399

stephane.dela...@biblibre.com changed:

   What|Removed |Added

  Attachment #23575|0   |1
is obsolete||

--- Comment #5 from stephane.dela...@biblibre.com ---
Created attachment 23593
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23593action=edit
proposed patch

new patch (only change git description and script help message).

to test it : 

create a test item (eg on biblionumber 3) with a non mapped subfield with a
test value.
check real items DB row ( SELECT * from items where biblionumber=3 ) = non
mapped value is in more_subfields_xml
map the non mapped subfield with unused items column
re-check in Db that nothing changes
run ./batchRebuildItemsTables.pl -c --where 'biblio.biblionumber=3'
check real items DB row ( SELECT * from items where biblionumber=3 ) = new
mapped value is not in more_subfields_xml anymore but in the mapped column

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11399] batch Rebuild Items Tables

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11399

--- Comment #1 from stephane.dela...@biblibre.com ---
Created attachment 23575
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23575action=edit
proposed patch

./batchRebuildItemsTables.pl -h (or without arguments = shows this screen)
./batchRebuildBiblioTables.pl -c (c like confirm = rebuild non marc DB (may be
long)
-t = test only, change nothing in DB
-where = optionnal where condition on default query (eg. -where
'biblio.biblionumber  100')

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11399] batch Rebuild Items Tables

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11399

stephane.dela...@biblibre.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11399] batch Rebuild Items Tables

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11399

stephane.dela...@biblibre.com changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |stephane.delaune@biblibre.c
   ||om

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/