[Koha-bugs] [Bug 11580] returnBeforeExpiry and closed day

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11580

--- Comment #23 from Jonathan Druart  
---
Created attachment 66888
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66888=edit
Bug 11580: Add one more test and clear the cache

Make sure we are not just returning J-1 and clear the cache before and
after the tests.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11580] returnBeforeExpiry and closed day

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11580

Alex Arnaud  changed:

   What|Removed |Added

 CC||alex.arn...@biblibre.com

--- Comment #22 from Alex Arnaud  ---
Here is a fix about Jonathan's comment.
I don't know which status to choose for this BZ since it has been pushed to
master...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11580] returnBeforeExpiry and closed day

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11580

--- Comment #21 from Alex Arnaud  ---
Created attachment 66886
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66886=edit
Bug 11580 - Fix expiry calculation and rewrite tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11580] returnBeforeExpiry and closed day

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11580

--- Comment #20 from Jonathan Druart  
---
I think the correct change is:

+my $calendar = Koha::Calendar->new( branchcode => $branch );
+if ( $calendar->is_holiday($datedue) ) {
+# Don't return on a closed day
+$datedue = $calendar->prev_open_day($datedue);
+}

Because if expiry date is not a close day, the date due must be the expiry
date.

But then tests from t/db_dependent/Circulation/CalcDateDue.t are failing

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11580] returnBeforeExpiry and closed day

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11580

--- Comment #19 from Jonathan Druart  
---
This change breaks test, please fix ASAP:

t/db_dependent/Circulation/CalcDateDue.t .. 1/5 
#   Failed test 'date expiry'
#   at t/db_dependent/Circulation/CalcDateDue.t line 54.
#  got: '2012-12-31T23:59:00'
# expected: '2013-01-01T23:59:00'
# Looks like you failed 1 test of 5.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11580] returnBeforeExpiry and closed day

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11580

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #18 from Jonathan Druart  
---
Pushed to master for 17.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11580] returnBeforeExpiry and closed day

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11580

Patrick Robitaille  changed:

   What|Removed |Added

 CC||patrick.robitai...@ccsr.qc.
   ||ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11580] returnBeforeExpiry and closed day

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11580

--- Comment #17 from Kyle M Hall  ---
Created attachment 66707
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66707=edit
Bug 11580 [QA Followup]

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11580] returnBeforeExpiry and closed day

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11580

--- Comment #16 from Kyle M Hall  ---
Created attachment 66706
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66706=edit
BUG 11580 : Added unit test

Added one unit test when the syspref useDaysMode is active.
This does not move code anymore

Signed-off-by: Katrin Fischer 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11580] returnBeforeExpiry and closed day

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11580

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #65779|0   |1
is obsolete||
  Attachment #65780|0   |1
is obsolete||

--- Comment #15 from Kyle M Hall  ---
Created attachment 66705
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66705=edit
Bug 11580 - If returnBeforeExpiry is ON, use calendar to calculate return date
not on closed day (depending on useDaysMode)

Test plan:
1. ReturnBeforeExpiry is activated
2. useDaysMode is different from "circulation rules only"
3. Set expiry date of a patron to a near date
4. Set a closed day on calendar for this date
5. Do a checkout

Without patch, return date will be patron expiration date
With the patch, return date will be last open day before patron expiration day

Signed-off-by: Claire Gravely 

Signed-off-by: Katrin Fischer 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11580] returnBeforeExpiry and closed day

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11580

Kyle M Hall  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11580] returnBeforeExpiry and closed day

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11580

Kyle M Hall  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |k...@bywatersolutions.com
   |y.org   |
 CC||k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11580] returnBeforeExpiry and closed day

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11580

--- Comment #14 from Katrin Fischer  ---
Created attachment 65780
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65780=edit
[SIGNED OFF] BUG 11580 : Added unit test

Added one unit test when the syspref useDaysMode is active.
This does not move code anymore

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11580] returnBeforeExpiry and closed day

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11580

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #58740|0   |1
is obsolete||
  Attachment #64681|0   |1
is obsolete||

--- Comment #13 from Katrin Fischer  ---
Created attachment 65779
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65779=edit
[SIGNED OFF] Bug 11580 - If returnBeforeExpiry is ON, use calendar to calculate
return date not on closed day (depending on useDaysMode)

Test plan:
1. ReturnBeforeExpiry is activated
2. useDaysMode is different from "circulation rules only"
3. Set expiry date of a patron to a near date
4. Set a closed day on calendar for this date
5. Do a checkout

Without patch, return date will be patron expiration date
With the patch, return date will be last open day before patron expiration day

Signed-off-by: Claire Gravely 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11580] returnBeforeExpiry and closed day

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11580

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11580] returnBeforeExpiry and closed day

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11580

Baptiste  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #12 from Baptiste  ---
Moving code isn't the purpose of this patch, I removed my changes concerning
Koha::Calendar and used a function from C4::Calendar

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11580] returnBeforeExpiry and closed day

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11580

Baptiste  changed:

   What|Removed |Added

  Attachment #60621|0   |1
is obsolete||

--- Comment #11 from Baptiste  ---
Created attachment 64681
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64681=edit
BUG 11580 : Added unit test

Added one unit test when the syspref useDaysMode is active.
This does not move code anymore

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11580] returnBeforeExpiry and closed day

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11580

--- Comment #10 from Baptiste  ---
I don't quite understand what is supposed to be done.
Shall we move the whole fonction in which this code is added toward
Koha::Calendar ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11580] returnBeforeExpiry and closed day

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11580

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #9 from Owen Leonard  ---
Setting to 'Failed QA' based on Comment 8

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11580] returnBeforeExpiry and closed day

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11580

Srdjan Jankovic  changed:

   What|Removed |Added

 CC||srd...@catalyst.net.nz

--- Comment #8 from Srdjan Jankovic  ---
This kind of looks wrong. Koha namespace should not be depending on C4 (apart
from unfortunate Context). Koha::Calendar should not use C4::Calendar. The
other way around is OK.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11580] returnBeforeExpiry and closed day

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11580

Sophie MEYNIEUX  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11580] returnBeforeExpiry and closed day

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11580

--- Comment #7 from Baptiste  ---
Created attachment 60621
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60621=edit
BUG 11580 : Added unit test

Added one unit test when the syspref useDaysMode is active.  To perform it I
had to put the function add_holiday in the perl module Koha/Calendar.pm from
the script tools/newHolidays.pl, in order to use the function in the tests.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11580] returnBeforeExpiry and closed day

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11580

--- Comment #6 from Katrin Fischer  ---
Hi Baptiste, 

I think all three options should have a specific behaviour for calculating due
dates when the patron _doesn't_ expire before the calculated due date:

- ... the calendar to push the due date to the next open day
- ... the calendar to sktip all closed days
- ... circulation rules only (ignore the calendar altogether)

But when you use ReturnExpiry to shorten the due date and it's before the
calculated due date I think you are right that the behaviour of the first 2
will be the same.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11580] returnBeforeExpiry and closed day

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11580

Baptiste  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |baptiste.wojtkowski@biblibr
   |ity.org |e.com
 CC||baptiste.wojtkowski@biblibr
   ||e.com

--- Comment #5 from Baptiste  ---
I take it to add the tests, but I don't understand why there are 3 options for
UseDaysModes despite 2 of them have exactly the same behaviour in all function
in which they are called, shouldn't we delete the "caleandar", which doesn't
have the specified behaviour ?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11580] returnBeforeExpiry and closed day

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11580

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #4 from Katrin Fischer  ---
*** Bug 17806 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11580] returnBeforeExpiry and closed day

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11580

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #3 from Jonathan Druart  
---
Hi Sophie,
Please provide tests for this change.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11580] returnBeforeExpiry and closed day

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11580

Claire Gravely  changed:

   What|Removed |Added

  Attachment #57562|0   |1
is obsolete||

--- Comment #2 from Claire Gravely  ---
Created attachment 58740
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58740=edit
Bug 11580 - If returnBeforeExpiry is ON, use calendar to calculate return date
not on closed day (depending on useDaysMode)

Test plan:
1. ReturnBeforeExpiry is activated
2. useDaysMode is different from "circulation rules only"
3. Set expiry date of a patron to a near date
4. Set a closed day on calendar for this date
5. Do a checkout

Without patch, return date will be patron expiration date
With the patch, return date will be last open day before patron expiration day

Signed-off-by: Claire Gravely 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11580] returnBeforeExpiry and closed day

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11580

Claire Gravely  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11580] returnBeforeExpiry and closed day

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11580

Sophie MEYNIEUX  changed:

   What|Removed |Added

 CC||sophie.meyni...@biblibre.co
   ||m
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11580] returnBeforeExpiry and closed day

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11580

--- Comment #1 from Sophie MEYNIEUX  ---
Created attachment 57562
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57562=edit
Bug 11580 - If returnBeforeExpiry is ON, use calendar to calculate return date
not on closed day (depending on useDaysMode)

Test plan:
1. ReturnBeforeExpiry is activated
2. useDaysMode is different from "circulation rules only"
3. Set expiry date of a patron to a near date
4. Set a closed day on calendar for this date
5. Do a checkout

Without patch, return date will be patron expiration date
With the patch, return date will be last open day before patron expiration day

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11580] returnBeforeExpiry and closed day

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11580

Marjorie Barry-Vila marjorie.barry-v...@ccsr.qc.ca changed:

   What|Removed |Added

Version|3.12|master

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/