[Koha-bugs] [Bug 11815] Convert BorrowersTitles to an authorised value

2020-02-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11815

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |BLOCKED

--- Comment #9 from Katrin Fischer  ---
Currently BLOCKED by the dependency on bug 20307.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11815] Convert BorrowersTitles to an authorised value

2020-02-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11815

David Nind  changed:

   What|Removed |Added

  Attachment #98657|0   |1
is obsolete||

--- Comment #8 from David Nind  ---
Created attachment 98668
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98668=edit
Bug 11815: Convert BorrowersTitles to an authorised value

This patch removes the BorrowersTitles system preference in favor of
using authorized values to store patron titles.

To test, apply the patch and run the database update.

 - In Administration -> Authorized values, locate the category
   'PATRON_TITLE'.
 - Create two or more authorized values with new patron titles.
 - In Administration -> System preferences -> Patrons, there should be
   no entry for BorrowersTitles.
 - Create or edit a patron. Under "Salutation" your authorized values
   should appear correctly.
 - Log in to the OPAC and go to "Your personal details." Confirm that
   the correct values are shown there.
 - Remove all PATRON_TITLE authorized values and confirm that the
   "Salutation" field no longer appears on the staff client or OPAC
   patron entry form.

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11815] Convert BorrowersTitles to an authorised value

2020-02-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11815

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11815] Convert BorrowersTitles to an authorised value

2020-02-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11815

Owen Leonard  changed:

   What|Removed |Added

  Attachment #98656|0   |1
is obsolete||

--- Comment #7 from Owen Leonard  ---
Created attachment 98657
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98657=edit
Bug 11815: Convert BorrowersTitles to an authorised value

This patch removes the BorrowersTitles system preference in favor of
using authorized values to store patron titles.

To test, apply the patch and run the database update.

 - In Administration -> Authorized values, locate the category
   'PATRON_TITLE'.
 - Create two or more authorized values with new patron titles.
 - In Administration -> System preferences -> Patrons, there should be
   no entry for BorrowersTitles.
 - Create or edit a patron. Under "Salutation" your authorized values
   should appear correctly.
 - Log in to the OPAC and go to "Your personal details." Confirm that
   the correct values are shown there.
 - Remove all PATRON_TITLE authorized values and confirm that the
   "Salutation" field no longer appears on the staff client or OPAC
   patron entry form.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11815] Convert BorrowersTitles to an authorised value

2020-02-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11815

Owen Leonard  changed:

   What|Removed |Added

  Attachment #94637|0   |1
is obsolete||

--- Comment #6 from Owen Leonard  ---
Created attachment 98656
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98656=edit
Bug 11815: Convert BorrowersTitles to an authorised value

This patch removes the BorrowersTitles system preference in favor of
using authorized values to store patron titles.

To test, apply the patch and run the database update.

 - In Administration -> Authorized values, locate the category
   'PATRON_TITLE'.
 - Create two or more authorized values with new patron titles.
 - In Administration -> System preferences -> Patrons, there should be
   no entry for BorrowersTitles.
 - Create or edit a patron. Under "Salutation" your authorized values
   should appear correctly.
 - Log in to the OPAC and go to "Your personal details." Confirm that
   the correct values are shown there.
 - Remove all PATRON_TITLE authorized values and confirm that the
   "Salutation" field no longer appears on the staff client or OPAC
   patron entry form.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11815] Convert BorrowersTitles to an authorised value

2020-02-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11815

Owen Leonard  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11815] Convert BorrowersTitles to an authorised value

2020-02-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11815

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

--- Comment #5 from David Nind  ---
Patch no longer applies 8-(

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11815] Convert BorrowersTitles to an authorised value

2020-01-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11815

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com

--- Comment #4 from David Nind  ---
Two queries from testing:

1) Does the Description (OPAC) text for the authorized value appear anywhere? I
had two different values for Description and Description (OPAC). On the OPAC I
could only see what is in the Description.

2) I'm getting this error when trying to search in OPAC and staff interface
(even though it is not in the test plan) - can post the full error somewhere if
required: 
> Error trace
> DBIx::Class::Storage::DBI::_dbh_execute(): 'localization.translation' isn't 
> in GROUP BY at /kohadevbox/koha/Koha/Objects.pm line 130
>  at /usr/share/perl5/DBIx/Class/Exception.pm line 77
> in DBIx::Class::Exception::throw at /usr/share/perl5/DBIx/Class/Exception.pm 
> line 77

Otherwise, everything works as expected.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11815] Convert BorrowersTitles to an authorised value

2019-11-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11815

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
Summary|convert BorrowersTitles to  |Convert BorrowersTitles to
   |an authorised value |an authorised value

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11815] convert BorrowersTitles to an authorised value

2019-10-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11815

--- Comment #3 from Owen Leonard  ---
(In reply to Séverine Queune from comment #2)

> Is the 'borrowers.title' sql field supposed to be cleaned after deleting the
> linked value

The field is NOT expected to be cleared when the authorized value is removed.
This is consistent with the current behavior of Koha, where removing the
contents of the BorrowersTitles preference doesn't affect patron data. I do
agree that it is confusing!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11815] convert BorrowersTitles to an authorised value

2019-10-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11815

Séverine Queune  changed:

   What|Removed |Added

 CC||severine.que...@bulac.fr

--- Comment #2 from Séverine Queune  ---
Hi Owen,

Everything work as described, I only have a question about the last point.
After deleting all the valued in PATRON_TITLE, "Salutations" fields are
correctly hidden on both OPAC and staff client, but until I modify the patron,
the salutation I first saved is still displayed on different pages and
breadcrumbs, for example :
 - /koha/circ/circulation.pl?
 - /koha/members/moremember.pl?
 - /koha/opac-main.pl
 - /koha/opac-user.pl
 - /koha/opac-memberentry.pl

Is the 'borrowers.title' sql field supposed to be cleaned after deleting the
linked value, or does the patch behaves as you excepted and so I just have to
sign it ?
Thank you !

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11815] convert BorrowersTitles to an authorised value

2019-10-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11815

Owen Leonard  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11815] convert BorrowersTitles to an authorised value

2019-10-23 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11815

--- Comment #1 from Owen Leonard  ---
Created attachment 94637
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94637=edit
Bug 11815: Convert BorrowersTitles to an authorised value

This patch removes the BorrowersTitles system preference in favor of
using authorized values to store patron titles.

To test, apply the patch and run the database update.

 - In Administration -> Authorized values, locate the category
   'PATRON_TITLE'.
 - Create two or more authorized values with new patron titles.
 - In Administration -> System preferences -> Patrons, there should be
   no entry for BorrowersTitles.
 - Create or edit a patron. Under "Salutation" your authorized values
   should appear correctly.
 - Log in to the OPAC and go to "Your personal details." Confirm that
   the correct values are shown there.
 - Remove all PATRON_TITLE authorized values and confirm that the
   "Salutation" field no longer appears on the staff client or OPAC
   patron entry form.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11815] convert BorrowersTitles to an authorised value

2019-07-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11815

Martin Renvoize  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com
 Depends on||20307


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20307
[Bug 20307] Language overlay for authorized values
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11815] convert BorrowersTitles to an authorised value

2019-07-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11815

Owen Leonard  changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|gmcha...@gmail.com  |oleon...@myacpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/