[Koha-bugs] [Bug 11870] Add more informations to histsearch.pl results

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11870

José-Mario Monteiro-Santos  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||jose-mario.monteiro-santos@
   ||inlibro.com

--- Comment #12 from José-Mario Monteiro-Santos 
 ---
Patch failed to apply

Applying: Bug 11870: Add more informations to histsearch.pl results
fatal: sha1 information is lacking or useless (C4/Acquisition.pm).
error: could not build fake ancestor
Patch failed at 0001 Bug 11870: Add more informations to histsearch.pl results

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11870] Add more informations to histsearch.pl results

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11870

Fridolin SOMERS  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=20892

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11870] Add more informations to histsearch.pl results

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11870

Julian Maurice  changed:

   What|Removed |Added

  Attachment #75355|0   |1
is obsolete||

--- Comment #11 from Julian Maurice  ---
Created attachment 75356
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75356=edit
Bug 11870: Add more informations to histsearch.pl results

- Basket group closed date and delivery place (in basketgroup column)
- Additional order fields (one column for each additional field)

Depends on bugs 11844 and 11708

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11870] Add more informations to histsearch.pl results

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11870

Julian Maurice  changed:

   What|Removed |Added

 Status|BLOCKED |Needs Signoff

--- Comment #10 from Julian Maurice  ---
Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11870] Add more informations to histsearch.pl results

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11870

Julian Maurice  changed:

   What|Removed |Added

  Attachment #25717|0   |1
is obsolete||

--- Comment #9 from Julian Maurice  ---
Created attachment 75355
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75355=edit
Bug 11870: Add more informations to histsearch.pl results

- Basket group closed date and delivery place (in basketgroup column)
- Additional order fields (one column for each additional field)

Depends on bugs 11844 and 11708

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11870] Add more informations to histsearch.pl results

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11870

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 CC||victor.grous...@biblibre.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11870] Add more informations to histsearch.pl results

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11870

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||marjorie.barry-vila@collect
   ||o.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11870] Add more informations to histsearch.pl results

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11870

Fridolin SOMERS  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #8 from Fridolin SOMERS  ---
Needs rebase on master.
Especially method C4::Koha::GetAuthValCodeFromField has been removed by Bug
17249

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11870] Add more informations to histsearch.pl results

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11870

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #7 from Katrin Fischer  ---
I think I agree with Jonathan here: In order to have some consistency I'd add a
searchable flag in the field configuration and use that to determine if the
field shows up in the result list and if it's searchable. 
This would copy the behaviour from the additional subscription fields.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11870] Add more informations to histsearch.pl results

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11870

--- Comment #6 from Jonathan Druart  
---
(In reply to Julian Maurice from comment #5)
> (In reply to Owen Leonard from comment #4)
> > (In reply to Jonathan Druart from comment #3)
> > > Julian, there is a "searchable" flag in the additional_fields table, I 
> > > think
> > > you should use it to know if we want to display fields in the search form.
> > 
> > Does this comment change whether this bug is ready for signoff?
> 
> I don't think so, as the patch only display more data in results. It doesn't
> change the form.
> Jonathan, are you suggesting we *have to* display these searchable fields in
> the form ?

The current behavior (for subscriptions) is to not display fields which are not
searchable.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11870] Add more informations to histsearch.pl results

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11870

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |BLOCKED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11870] Add more informations to histsearch.pl results

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11870

--- Comment #5 from Julian Maurice  ---
(In reply to Owen Leonard from comment #4)
> (In reply to Jonathan Druart from comment #3)
> > Julian, there is a "searchable" flag in the additional_fields table, I think
> > you should use it to know if we want to display fields in the search form.
> 
> Does this comment change whether this bug is ready for signoff?

I don't think so, as the patch only display more data in results. It doesn't
change the form.
Jonathan, are you suggesting we *have to* display these searchable fields in
the form ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11870] Add more informations to histsearch.pl results

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11870

--- Comment #4 from Owen Leonard  ---
(In reply to Jonathan Druart from comment #3)
> Julian, there is a "searchable" flag in the additional_fields table, I think
> you should use it to know if we want to display fields in the search form.

Does this comment change whether this bug is ready for signoff?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11870] Add more informations to histsearch.pl results

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11870

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #3 from Jonathan Druart  
---
Julian, there is a "searchable" flag in the additional_fields table, I think
you should use it to know if we want to display fields in the search form.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11870] Add more informations to histsearch.pl results

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11870

Zeno Tajoli  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11870] Add more informations to histsearch.pl results

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11870

Indranil Das Gupta indr...@gmail.com changed:

   What|Removed |Added

 CC||indr...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11870] Add more informations to histsearch.pl results

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11870

Jacek Ablewicz a...@biblos.pk.edu.pl changed:

   What|Removed |Added

 CC||a...@biblos.pk.edu.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11870] Add more informations to histsearch.pl results

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11870

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11870] Add more informations to histsearch.pl results

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11870

--- Comment #2 from Julian Maurice julian.maur...@biblibre.com ---
Test plan:
1/ Add some additional fields (see bug 11844)
2/ Create some order lines in different baskets (filling additional fields with
data)
3/ Attach some of these baskets to basketgroups
4/ Fill basketgroups deliveryplace (using free delivery place textarea or the
dropdown list)
5/ Close some of these basketgroups
6/ Go to advanced order line search and run a search.
7/ You should see basketgroup closed date and delivery place in basketgroup
column, and one additional column for each additional field.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11870] Add more informations to histsearch.pl results

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11870

--- Comment #1 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 25717
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25717action=edit
Bug 11870: Add more informations to histsearch.pl results

- Basket group closed date and delivery place (in basketgroup column)
- Additional order fields (one column for each additional field)

Depends on bugs 11844 and 11708

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/