subject:"\[Koha\-bugs\] \[Bug 11879\] Add a new borrower field \: main contact method."

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

2018-04-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

--- Comment #114 from Katrin Fischer  ---
Created attachment 73990
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73990=edit
Bug 11879: (QA follow-up) Fix problems found in code review

Signed-off-by: Lucie Gay 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

2018-04-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

--- Comment #112 from Katrin Fischer  ---
Created attachment 73988
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73988=edit
Bug 11879: Schema updates

Signed-off-by: Lucie Gay 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

2018-04-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

--- Comment #113 from Katrin Fischer  ---
Created attachment 73989
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73989=edit
Bug 11879: (follow-up) Streamline markup and make label corrections

This patch makes minor markup corrections to the patron detail page
template:

- Simplify the SWITCH markup
- Add "primary" to primary phone label
- Correct case on label
- Add IF statement to hide label if there is no primary contact
  method

Signed-off-by: Lucie Gay 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

2018-04-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #72632|0   |1
is obsolete||

--- Comment #111 from Katrin Fischer  ---
Created attachment 73987
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73987=edit
Bug 11879: Add the "Main contact method" field in borrower informations.

This patch adds the "Main Contact Method" field in the borrower modification
form.

This field is useful for reporting purposes, or to know which contact method to
use first when trying to contact a borrower.

Following Nicolas' fix, removed a $branch variable from patch, since it has
been suppressed in Bug 17284.

Test case :
* Edit a borrower's informations. The "Main Contact Method" selectbox should
appear in the form and its value should be saved correctly.

Sponsored-by: CCSR 

Signed-off-by: Lucie Gay 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

2018-04-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

--- Comment #110 from Katrin Fischer  ---
Almost finished, but will have to continue later!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

2018-04-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Katrin Fischer  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de
   |y.org   |
 CC||katrin.fisc...@bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

2018-03-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

--- Comment #109 from Aurélie  ---
Lucie et Aurélie : first test during Hackfest 2018 for us! 
A new dropdown select to chose the main contact method = OK
The selected field appears in the patron's detail page = OK

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

2018-03-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

--- Comment #105 from sandbo...@biblibre.com  ---
Created attachment 72632
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72632=edit
Bug 11879: Add the "Main contact method" field in borrower informations.

This patch adds the "Main Contact Method" field in the borrower modification
form.

This field is useful for reporting purposes, or to know which contact method to
use first when trying to contact a borrower.

Following Nicolas' fix, removed a $branch variable from patch, since it has
been suppressed in Bug 17284.

Test case :
* Edit a borrower's informations. The "Main Contact Method" selectbox should
appear in the form and its value should be saved correctly.

Sponsored-by: CCSR 

Signed-off-by: Lucie Gay 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

2018-03-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

--- Comment #108 from sandbo...@biblibre.com  ---
Created attachment 72635
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72635=edit
Bug 11879: Follow-up - code review

Signed-off-by: Lucie Gay 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

2018-03-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

--- Comment #107 from sandbo...@biblibre.com  ---
Created attachment 72634
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72634=edit
Bug 11879: Follow-up - Streamline markup and make label corrections

This patch makes minor markup corrections to the patron detail page
template:

- Simplify the SWITCH markup
- Add "primary" to primary phone label
- Correct case on label
- Add IF statement to hide label if there is no primary contact
  method

Signed-off-by: Lucie Gay 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

2018-03-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

--- Comment #106 from sandbo...@biblibre.com  ---
Created attachment 72633
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72633=edit
Bug 11879: Changes to Koha's schemas

Signed-off-by: Lucie Gay 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

2018-03-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

sandbo...@biblibre.com  changed:

   What|Removed |Added

  Attachment #71957|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

2018-03-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

sandbo...@biblibre.com  changed:

   What|Removed |Added

  Attachment #71958|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

2018-03-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

sandbo...@biblibre.com  changed:

   What|Removed |Added

  Attachment #71955|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

2018-03-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

sandbo...@biblibre.com  changed:

   What|Removed |Added

  Attachment #71956|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

2018-03-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

sandbo...@biblibre.com  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||sandbo...@biblibre.com

--- Comment #104 from sandbo...@biblibre.com  ---
Patch tested with a sandbox, by Lucie Gay 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

2018-02-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

--- Comment #103 from Charles Farmer  ---
Much tighter patches this time, thanks to Mark's comments. I'll review the
changes one by one:

1) members/moremember.pl was adapted to reduce the diff's length. In previous
iterations, many additional variables were passed to the templates --
borrowernumber, othernames, etc. -- but these are not necessary anymore, thanks
to the patron objects. The template moremember-brief.tt was adapted to reflect
these changes.

2) borrowers_primary_contact_method.sql is now adding columns at the very end
of the table, in order to keep the existing columns in the same order.

3) `lastseen` had no reason whatsoever to be here. Kept the field the way it
already was in the tables where we added primary_contact_method.

4) whitespace changes were rolled back, according to the minimum diff
policy(TM)

5) I'm definitely responsible for the moremember.tt screwup code duplication;
it appeared in patch #69028 when I must've rebased. It's now removed from this
patch.

6) Indentation was corrected in opac-memberentry.pl

This code should also pass qa -c 4.

Needs signoff.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

2018-02-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

--- Comment #102 from Charles Farmer  ---
Created attachment 71958
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71958=edit
Bug 11879: Follow-up - code review

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

2018-02-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Charles Farmer  changed:

   What|Removed |Added

  Attachment #69050|0   |1
is obsolete||

--- Comment #101 from Charles Farmer  ---
Created attachment 71957
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71957=edit
Bug 11879: Follow-up - Streamline markup and make label corrections

This patch makes minor markup corrections to the patron detail page
template:

- Simplify the SWITCH markup
- Add "primary" to primary phone label
- Correct case on label
- Add IF statement to hide label if there is no primary contact
  method

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

2018-02-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Charles Farmer  changed:

   What|Removed |Added

  Attachment #69029|0   |1
is obsolete||

--- Comment #100 from Charles Farmer  ---
Created attachment 71956
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71956=edit
Bug 11879: Changes to Koha's schemas

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

2018-02-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Charles Farmer  changed:

   What|Removed |Added

  Attachment #69028|0   |1
is obsolete||

--- Comment #99 from Charles Farmer  ---
Created attachment 71955
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71955=edit
Bug 11879: Add the "Main contact method" field in borrower informations.

This patch adds the "Main Contact Method" field in the borrower modification
form.

This field is useful for reporting purposes, or to know which contact method to
use first when trying to contact a borrower.

Following Nicolas' fix, removed a $branch variable from patch, since it has
been suppressed in Bug 17284.

Test case :
* Edit a borrower's informations. The "Main Contact Method" selectbox should
appear in the form and its value should be saved correctly.

Sponsored-by: CCSR 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

2018-01-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

--- Comment #98 from M. Tompsett  ---
Comment on attachment 69050
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69050
Bug 11879: Follow-up - Streamline markup and make label corrections

Review of attachment 69050:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=11879=69050)
-

::: koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
@@ +293,5 @@
> +Secondary email
> +[% CASE 'fax' %]
> +Fax
> +[% END %]
> +

This is nicer and friendlier on the po files, I'm sure. I believe it was done
the other way because of a misunderstanding of HTML 1
(https://wiki.koha-community.org/wiki/Coding_Guidelines#HTML_Templates). The
SWITCH isn't allowed inside HTML tags, that is  is really
bad.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

2018-01-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

--- Comment #97 from M. Tompsett  ---
Comment on attachment 69029
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69029
Bug 11879: Changes to Koha's schemas

Review of attachment 69029:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=11879=69029)
-

None of these have lastseen, as mentioned in the other patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

2018-01-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

--- Comment #96 from M. Tompsett  ---
Comment on attachment 69028
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69028
Bug 11879: Add the "Main contact method" field in borrower informations.

Review of attachment 69028:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=11879=69028)
-

::: installer/data/mysql/atomicupdate/borrowers_primary_contact_method.sql
@@ +1,2 @@
> +ALTER TABLE `borrowers` ADD COLUMN `primary_contact_method` VARCHAR(45) NULL 
> DEFAULT NULL AFTER `lastseen`;
> +ALTER TABLE `deletedborrowers` ADD COLUMN `primary_contact_method` 
> VARCHAR(45) NULL DEFAULT NULL AFTER `overdrive_auth_token`;

deletedborrowers and borrowers should maintain the same field order.

::: installer/data/mysql/kohastructure.sql
@@ +1682,4 @@
>`lang` varchar(25) NOT NULL default 'default', -- lang to use to send 
> notices to this patron
>`login_attempts` int(4) default 0, -- number of failed login attemps
>`overdrive_auth_token` text default NULL, -- persist OverDrive auth token
> +  `lastseen` datetime default NULL, -- last time a patron has been seed 
> (connected at the OPAC or staff interface)

This adds lastseen, but the borrowers_primary_contact_method did not add it at
all.

::: installer/data/mysql/updatedatabase.pl
@@ +14968,4 @@
>  }
>  }
>  
> +

Totally not necessary to touch this.

::: koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
@@ +538,5 @@
>  
>  [% UNLESS nophone && nophonepro && nomobile && noemail && noemailpro && 
> nofax %]
>
> +Contact
> +

Keep whitespace changes separate.

@@ +602,4 @@
> [% IF ( mandatoryemailpro ) %] class="required">Required[% END %]
>  
>  [% END %]
> +[% UNLESS nofax %]

Keep whitespace changes separate.

@@ +664,5 @@
> +[% END %]
> + [% END %]
> +   
> +
> +

This is the only place where you can really get away with these minor
whitespace changes on the END and /ol.

::: koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
@@ +275,5 @@
> +[% ELSE %]
> +[% guarantor.firstname | html %] [% guarantor.surname | html 
> %]
> +[% END %]
> +
> +[% END %]

Where did this ELSIF clause come from?! This has nothing to do with
primary_contact_method.

::: opac/opac-memberentry.pl
@@ +93,5 @@
>  libraries => \@libraries,
>  OPACPatronDetails => C4::Context->preference('OPACPatronDetails'),
>  );
> +my 
> $check_BorrowerMandatoryField=C4::Context->preference("BorrowerMandatoryField");
> +my @field_check=split(/\|/,$check_BorrowerMandatoryField);

Something is strange about this indentation. I would expect the same
indentation level.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

2017-11-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

--- Comment #95 from Owen Leonard  ---
Created attachment 69050
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69050=edit
Bug 11879: Follow-up - Streamline markup and make label corrections

This patch makes minor markup corrections to the patron detail page
template:

- Simplify the SWITCH markup
- Add "primary" to primary phone label
- Correct case on label
- Add IF statement to hide label if there is no primary contact
  method

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

2017-11-08 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

David Bourgault  changed:

   What|Removed |Added

 CC||david.bourga...@inlibro.com
 Status|Patch doesn't apply |Needs Signoff

--- Comment #94 from David Bourgault  ---
Rebased patches.

Test plan is same as before:
0) Apply patch
1) updatedatabase.pl
2) In the staff client, edit a patron's contact info. There should be a new
dropdown select to choose the main contact method
3) Save the form. The selected field should appear in the patron's detail page.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

2017-11-08 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

David Bourgault  changed:

   What|Removed |Added

  Attachment #65812|0   |1
is obsolete||

--- Comment #93 from David Bourgault  ---
Created attachment 69029
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69029=edit
Bug 11879: Changes to Koha's schemas

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

2017-11-08 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

David Bourgault  changed:

   What|Removed |Added

  Attachment #65811|0   |1
is obsolete||

--- Comment #92 from David Bourgault  ---
Created attachment 69028
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69028=edit
Bug 11879: Add the "Main contact method" field in borrower informations.

This patch adds the "Main Contact Method" field in the borrower modification
form.

This field is useful for reporting purposes, or to know which contact method to
use first when trying to contact a borrower.

Following Nicolas' fix, removed a $branch variable from patch, since it has
been suppressed in Bug 17284.

Test case :
* Edit a borrower's informations. The "Main Contact Method" selectbox should
appear in the form and its value should be saved correctly.

Sponsored-by: CCSR 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

2017-10-03 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Alex Buckley  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||alexbuck...@catalyst.net.nz

--- Comment #91 from Alex Buckley  ---
Hi Philippe

Sorry but when applying your patch I got the following merge errors (see
below), the issues are in moremember.tt and moremember.pl. Can you please
rebase against master and then I will be more than happy to test again:

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 11879: Add the "Main contact method" field in borrower
informations.
Using index info to reconstruct a base tree...
M   installer/data/mysql/kohastructure.sql
M   installer/data/mysql/updatedatabase.pl
M   koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
M   koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
M   koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt
M   members/memberentry.pl
M   members/moremember.pl
M   opac/opac-memberentry.pl
Falling back to patching base and 3-way merge...
Auto-merging opac/opac-memberentry.pl
Auto-merging members/moremember.pl
CONFLICT (content): Merge conflict in members/moremember.pl
Auto-merging members/memberentry.pl
Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
Auto-merging installer/data/mysql/updatedatabase.pl
Auto-merging installer/data/mysql/kohastructure.sql
Failed to merge in the changes.
Patch failed at 0001 Bug 11879: Add the "Main contact method" field in borrower
informations.
The copy of the patch that failed is found in:
   /home/vagrant/kohaclone/.git/rebase-apply/patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in
/tmp/Bug-11879-Add-the-Main-contact-method-field-in-bor-uOjbTv.patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

2017-09-20 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Patrick Robitaille  changed:

   What|Removed |Added

 CC||patrick.robitai...@ccsr.qc.
   ||ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

2017-08-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Philippe Audet-Fortin  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

2017-08-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Philippe Audet-Fortin  changed:

   What|Removed |Added

  Attachment #63239|0   |1
is obsolete||

--- Comment #90 from Philippe Audet-Fortin  
---
Created attachment 65812
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65812=edit
Bug 11879: Changes to Koha's schemas

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

2017-08-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Philippe Audet-Fortin  changed:

   What|Removed |Added

  Attachment #63238|0   |1
is obsolete||

--- Comment #89 from Philippe Audet-Fortin  
---
Created attachment 65811
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65811=edit
Bug 11879: Add the "Main contact method" field in borrower informations.

This patch adds the "Main Contact Method" field in the borrower modification
form.

This field is useful for reporting purposes, or to know which contact method to
use first when trying to contact a borrower.

Following Nicolas' fix, removed a $branch variable from patch, since it has
been suppressed in Bug 17284.

Test case :
* Edit a borrower's informations. The "Main Contact Method" selectbox should
appear in the form and its value should be saved correctly.

Sponsored-by: CCSR 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

2017-05-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Josef Moravec  changed:

   What|Removed |Added

 CC||josef.mora...@gmail.com
 Status|Needs Signoff   |Failed QA

--- Comment #88 from Josef Moravec  ---
I found some issues with this patchset:
1) It removes field overdrive_auth_token field from tables borrowers and
deletedborrowers
2) Automic update and kohastructure has to be consistent in field order, in
atomic, the new field is added after 'privacy', in kohastructure at the end -
it is bad

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

2017-05-08 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Philippe Audet-Fortin  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff
 CC||philippe.audet-fortin@inlib
   ||ro.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

2017-05-08 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Philippe Audet-Fortin  changed:

   What|Removed |Added

  Attachment #58592|0   |1
is obsolete||

--- Comment #86 from Philippe Audet-Fortin  
---
Created attachment 63238
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63238=edit
Bug 11879: Add the "Main contact method" field in borrower informations.

This patch adds the "Main Contact Method" field in the borrower modification
form.

This field is useful for reporting purposes, or to know which contact method to
use first when trying to contact a borrower.

Following Nicolas' fix, removed a $branch variable from patch, since it has
been suppressed in Bug 17284.

Test case :
* Edit a borrower's informations. The "Main Contact Method" selectbox should
appear in the form and its value should be saved correctly.

Sponsored-by: CCSR 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

2017-05-08 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Philippe Audet-Fortin  changed:

   What|Removed |Added

  Attachment #58593|0   |1
is obsolete||

--- Comment #87 from Philippe Audet-Fortin  
---
Created attachment 63239
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63239=edit
Bug 11879: Changes to Koha's schemas

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

2017-03-20 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Jesse Maseto  changed:

   What|Removed |Added

 CC||je...@bywatersolutions.com
 Status|Needs Signoff   |Patch doesn't apply

--- Comment #85 from Jesse Maseto  ---
This patch does not apply.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

2017-03-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Indranil Das Gupta  changed:

   What|Removed |Added

 CC||indr...@l2c2.co.in
   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=14872

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

2017-01-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Charles Farmer  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

2017-01-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Charles Farmer  changed:

   What|Removed |Added

  Attachment #58591|0   |1
is obsolete||

--- Comment #83 from Charles Farmer  ---
Created attachment 58592
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58592=edit
Bug 11879: Add the "Main contact method" field in borrower informations.

This patch adds the "Main Contact Method" field in the borrower modification
form.

This field is useful for reporting purposes, or to know which contact method to
use first when trying to contact a borrower.

Following Nicolas' fix, removed a $branch variable from patch, since it has
been suppressed in Bug 17284.

Test case :
* Edit a borrower's informations. The "Main Contact Method" selectbox should
appear in the form and its value should be saved correctly.

Sponsored-by: CCSR 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

2017-01-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

--- Comment #84 from Charles Farmer  ---
Created attachment 58593
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58593=edit
Bug 11879: Changes to Koha's schemas

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

2017-01-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Charles Farmer  changed:

   What|Removed |Added

  Attachment #58580|0   |1
is obsolete||

--- Comment #82 from Charles Farmer  ---
Created attachment 58591
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58591=edit
Bug 11879: Add the "Main contact method" field in borrower informations.

This patch adds the "Main Contact Method" field in the borrower modification
form.

This field is useful for reporting purposes, or to know which contact method to
use first when trying to contact a borrower.

Following Nicolas' fix, removed a $branch variable from patch, since it has
been suppressed in Bug 17284.

Test case :
* Edit a borrower's informations. The "Main Contact Method" selectbox should
appear in the form and its value should be saved correctly.

Sponsored-by: CCSR 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

2017-01-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Charles Farmer  changed:

   What|Removed |Added

 CC||charles.far...@inlibro.com

--- Comment #81 from Charles Farmer  ---
Mark, when you say the schema files were not generated correctly, do you mean
that you want to see the file hash change in the patch? I know you can't
override it afterwards if you decide to regenerate them again because the
script doesn't allow it, but I thought these files were generated again by the
RM upon release.

Anyway, I'll submit a separate patch for the schemas with the output of the
script _as is_.

And sorry for that messy rebase, that borrower table appearing a thousand lines
before caught me by surprise.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

2017-01-04 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Jonathan Druart  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #80 from Jonathan Druart  
---
- Schema files should be moved to a separate patch
- Changes to kohastructure are wrong, please double check.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

2017-01-03 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

--- Comment #79 from M. Tompsett  ---
Comment on attachment 58580
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58580
Bug 11879: Add the "Main contact method" field in borrower informations.

Review of attachment 58580:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=11879=58580)
-

I don't believe the Borrower.pm, BorrowerModification.pm, and
Deletedborrower.pm were generated using the appropriate scripts.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

2017-01-03 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Charles Farmer  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

2017-01-03 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Charles Farmer  changed:

   What|Removed |Added

  Attachment #56286|0   |1
is obsolete||

--- Comment #78 from Charles Farmer  ---
Created attachment 58580
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58580=edit
Bug 11879: Add the "Main contact method" field in borrower informations.

This patch adds the "Main Contact Method" field in the borrower modification
form.

This field is useful for reporting purposes, or to know which contact method to
use first when trying to contact a borrower.

Test case :
* Edit a borrower's informations. The "Main Contact Method" selectbox should
appear in the form and its value should be saved correctly.

Sponsored-by: CCSR 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

2017-01-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Patch doesn't apply

--- Comment #77 from Jonathan Druart  
---
The patch does not apply, please rebase.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

2016-12-01 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Nicole C. Engard  changed:

   What|Removed |Added

 CC|neng...@gmail.com   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

2016-10-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Nicolas Legrand  changed:

   What|Removed |Added

  Attachment #56285|0   |1
is obsolete||

--- Comment #76 from Nicolas Legrand  ---
Created attachment 56286
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56286=edit
Bug 11879: Add the "Main contact method" field in borrower informations.

This patch adds the "Main Contact Method" field in the borrower modification
form.

This field is useful for reporting purposes, or to know which contact method to
use first when trying to contact a borrower.

Test case :
* Edit a borrower's informations. The "Main Contact Method" selectbox should
appear in the form and its value should be saved correctly.

Sponsored-by: CCSR ( http://www.ccsr.qc.ca )
Signed-off-by: Nicolas Legrand 

Removed a $branch variable from patch, since it has been suppressed in
Bug 17284.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

2016-10-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Nicolas Legrand  changed:

   What|Removed |Added

  Attachment #55946|0   |1
is obsolete||

--- Comment #75 from Nicolas Legrand  ---
Created attachment 56285
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56285=edit
Bug 11879: Add the "Main contact method" field in borrower informations.

This patch adds the "Main Contact Method" field in the borrower modification
form.

This field is useful for reporting purposes, or to know which contact method to
use first when trying to contact a borrower.

Test case :
* Edit a borrower's informations. The "Main Contact Method" selectbox should
appear in the form and its value should be saved correctly.

Sponsored-by: CCSR ( http://www.ccsr.qc.ca )
Signed-off-by: Nicolas Legrand 

Removed a $branch variable from patch, since it has been suppressed in
Bug 17284.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

2016-10-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Nicolas Legrand  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

2016-09-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Charles Farmer  changed:

   What|Removed |Added

  Attachment #53708|0   |1
is obsolete||
  Attachment #53709|0   |1
is obsolete||
  Attachment #53710|0   |1
is obsolete||
  Attachment #53711|0   |1
is obsolete||
  Attachment #53712|0   |1
is obsolete||
  Attachment #53713|0   |1
is obsolete||

--- Comment #74 from Charles Farmer  ---
Created attachment 55946
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55946=edit
Bug 11879: Add the "Main contact method" field in borrower informations.

This patch adds the "Main Contact Method" field in the borrower modification
form.

This field is useful for reporting purposes, or to know which contact method to
use first when trying to contact a borrower.

Test case :
* Edit a borrower's informations. The "Main Contact Method" selectbox should
appear in the form and its value should be saved correctly.

Sponsored-by: CCSR ( http://www.ccsr.qc.ca )

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

2016-09-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Charles Farmer  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

2016-09-08 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Chris Cormack  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||ch...@bigballofwax.co.nz

--- Comment #73 from Chris Cormack  ---
Should be an easy to solve conflict, just a conflict on memberentrygen.tt to do
with the CSRF protection.

Happy to test again when it is sorted.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

2016-07-25 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

M. Tompsett  changed:

   What|Removed |Added

 CC|mtomp...@hotmail.com|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

2016-07-25 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

--- Comment #72 from Mehdi Hamidi  ---
Created attachment 53713
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53713=edit
Bug 11879 - QA Follow-up

updatedatabase.pl no longer adds column primary_contact_method to table
borrowers
Fixed the incorrectly capitalized label and added the ':' in front of it(opac
and intranet).
Changed mobile phone to other phone in intranet and added a switch case in
moremember.tt
to display the correct label.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

2016-07-25 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

--- Comment #71 from Mehdi Hamidi  ---
Created attachment 53712
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53712=edit
Bug 11879 - Fix syspref BorrowerUnwantedField

How I tested:
Apply 1st patch
Apply this patch
Edit syspref BorrowerUnwantedField to exclude fields
Edit patron's contact information
Make sure that fields do not longer appear in drop down for Main contact

Wors as expected

http://bugs.koha-community.org/show_bug.cgi?id=11879
Signed-off-by: Marc Veron 

Signed-off-by: Kyle M Hall 
Signed-off-by: Aleisha 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

2016-07-25 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

--- Comment #69 from Mehdi Hamidi  ---
Created attachment 53710
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53710=edit
Bug 11879 - QA Follow-up

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

2016-07-25 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

--- Comment #68 from Mehdi Hamidi  ---
Created attachment 53709
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53709=edit
Bug 11879 QA follow-up

Changed "Mobile Phone" to Other Phone, modified deletedborrowers table
structute and added the field in opac

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

2016-07-25 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

--- Comment #70 from Mehdi Hamidi  ---
Created attachment 53711
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53711=edit
Bug 11879 - Add a new borrower field : main contact method. (Was: Rebased on
current master for testing)

http://bugs.koha-community.org/show_bug.cgi?id=11879

To test this patch:
Update database
Edit a borrower's informations.
The "Main Contact Method" selectbox appears in the form and its
value is correctly.

Works as expected.
For handling of syspref BorrowerUnwantedField use second patch-

Signed-off-by: Marc Veron 

Signed-off-by: Kyle M Hall 
Signed-off-by: Aleisha 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

2016-07-25 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

--- Comment #67 from Mehdi Hamidi  ---
Created attachment 53708
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53708=edit
Bug 11879 - Update BDIx schema and show main contact method in moremember.pl

Signed-off-by: Aleisha 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

2016-07-25 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Mehdi Hamidi  changed:

   What|Removed |Added

  Attachment #53707|1   |0
   is patch||
  Attachment #53707|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

2016-07-25 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Mehdi Hamidi  changed:

   What|Removed |Added

  Attachment #50433|0   |1
is obsolete||
  Attachment #52616|0   |1
is obsolete||
  Attachment #52617|0   |1
is obsolete||
  Attachment #52619|0   |1
is obsolete||
  Attachment #52620|0   |1
is obsolete||
  Attachment #53695|0   |1
is obsolete||

--- Comment #66 from Mehdi Hamidi  ---
Created attachment 53707
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53707=edit
Bug 11879 - Add a new borrower field : main contact method

Signed-off-by: Aleisha 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

2016-07-25 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Mehdi Hamidi  changed:

   What|Removed |Added

  Attachment #53705|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

2016-07-25 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

--- Comment #65 from Mehdi Hamidi  ---
Created attachment 53705
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53705=edit
Bug 11879 - Add a new borrower field : main contact method

Signed-off-by: Aleisha 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

2016-07-25 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Mehdi Hamidi  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

2016-07-25 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Mehdi Hamidi  changed:

   What|Removed |Added

  Attachment #53229|0   |1
is obsolete||

--- Comment #64 from Mehdi Hamidi  ---
Created attachment 53695
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53695=edit
Bug 11879 - QA Follow-up

updatedatabase.pl no longer adds column primary_contact_method to table
borrowers
Fixed the incorrectly capitalized label and added the ':' in front of it(opac
and intranet).
Changed mobile phone to other phone in intranet and added a switch case in
moremember.tt
to display the correct label.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

2016-07-25 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Mehdi Hamidi  changed:

   What|Removed |Added

  Attachment #53688|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

2016-07-25 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Mehdi Hamidi  changed:

   What|Removed |Added

  Attachment #50433|1   |0
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

2016-07-25 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Eric Bégin  changed:

   What|Removed |Added

 CC|remi.mayrand-provencher@inL |
   |ibro.com,   |
   |simith.dolive...@inlibro.co |
   |m   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

2016-07-25 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Mehdi Hamidi  changed:

   What|Removed |Added

   Assignee|simith.dolive...@inlibro.co |mehdi.ham...@inlibro.com
   |m   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

2016-07-25 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

--- Comment #63 from Mehdi Hamidi  ---
Please discard my last comment.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

2016-07-25 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Mehdi Hamidi  changed:

   What|Removed |Added

  Attachment #52618|0   |1
is obsolete||

--- Comment #62 from Mehdi Hamidi  ---
Created attachment 53688
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53688=edit
Bug 11879 - QA Follow-up

Fixed tests, they now work without any fails

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

2016-07-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Mehdi Hamidi  changed:

   What|Removed |Added

 CC||mehdi.ham...@inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

2016-07-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #61 from Owen Leonard  ---
(In reply to Jonathan Druart from comment #40)
> QA comment:
> - The second patch modifies "Other phone" with "Mobile phone". "Other phone"
> is used in master atm

This is still true. Also, in both the OPAC and staff client the "main contact
method" label is incorrectly capitalized. Template guidelines say that only the
first letter should be upper case. There should also be a ":" after the label:

"Main contact method:"

Is there a plan for some functionality which is based on this setting?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

2016-07-08 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

--- Comment #60 from Mehdi Hamidi  ---
Created attachment 53229
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53229=edit
Bug 11879 - updatedatabase.pl no longer adds column primary_contact_method to
table borrowers

Signed-off-by: mehdi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

2016-07-08 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Mehdi Hamidi  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

2016-07-08 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Marc Véron  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #59 from Marc Véron  ---
installer/data/mysql/updatedatabase.pl adds a field primary_contact_method to
borrowers

That makes borrowers_primary_contact_method.sql fail (adding fields to
borrowers, deletedborrowers, borrower_modifications).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

2016-06-20 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Mehdi Hamidi  changed:

   What|Removed |Added

  Attachment #50433|0   |1
is obsolete||

--- Comment #56 from Mehdi Hamidi  ---
Created attachment 52618
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52618=edit
Bug 11879 - QA Follow-up

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

2016-06-20 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Mehdi Hamidi  changed:

   What|Removed |Added

  Attachment #52607|0   |1
is obsolete||

--- Comment #57 from Mehdi Hamidi  ---
Created attachment 52619
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52619=edit
Bug 11879 - Add a new borrower field : main contact method. (Was: Rebased on
current master for testing)

http://bugs.koha-community.org/show_bug.cgi?id=11879

To test this patch:
Update database
Edit a borrower's informations.
The "Main Contact Method" selectbox appears in the form and its
value is correctly.

Works as expected.
For handling of syspref BorrowerUnwantedField use second patch-

Signed-off-by: Marc Veron 

Signed-off-by: Kyle M Hall 
Signed-off-by: Aleisha 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

2016-06-20 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Mehdi Hamidi  changed:

   What|Removed |Added

  Attachment #52608|0   |1
is obsolete||

--- Comment #58 from Mehdi Hamidi  ---
Created attachment 52620
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52620=edit
Bug 11879 - Fix syspref BorrowerUnwantedField

How I tested:
Apply 1st patch
Apply this patch
Edit syspref BorrowerUnwantedField to exclude fields
Edit patron's contact information
Make sure that fields do not longer appear in drop down for Main contact

Wors as expected

http://bugs.koha-community.org/show_bug.cgi?id=11879
Signed-off-by: Marc Veron 

Signed-off-by: Kyle M Hall 
Signed-off-by: Aleisha 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

2016-06-20 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Mehdi Hamidi  changed:

   What|Removed |Added

  Attachment #48559|0   |1
is obsolete||

--- Comment #55 from Mehdi Hamidi  ---
Created attachment 52617
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52617=edit
Bug 11879 QA follow-up

Changed "Mobile Phone" to Other Phone, modified deletedborrowers table
structute and added the field in opac

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

2016-06-20 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Mehdi Hamidi  changed:

   What|Removed |Added

  Attachment #52615|0   |1
is obsolete||

--- Comment #54 from Mehdi Hamidi  ---
Created attachment 52616
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52616=edit
Bug 11879 - Update BDIx schema and show main contact method in moremember.pl

Signed-off-by: Aleisha 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

2016-06-20 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Mehdi Hamidi  changed:

   What|Removed |Added

  Attachment #52614|0   |1
is obsolete||

--- Comment #53 from Mehdi Hamidi  ---
Created attachment 52615
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52615=edit
Bug 11879 - Update BDIx schema and show main contact method in moremember.pl

Signed-off-by: Aleisha 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

2016-06-20 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Mehdi Hamidi  changed:

   What|Removed |Added

  Attachment #48558|0   |1
is obsolete||

--- Comment #52 from Mehdi Hamidi  ---
Created attachment 52614
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52614=edit
Bug 11879 - Update BDIx schema and show main contact method in moremember.pl

Signed-off-by: Aleisha 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

2016-06-20 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Mehdi Hamidi  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

2016-06-20 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Mehdi Hamidi  changed:

   What|Removed |Added

  Attachment #48557|0   |1
is obsolete||

--- Comment #51 from Mehdi Hamidi  ---
Created attachment 52608
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52608=edit
Bug 11879 - Fix syspref BorrowerUnwantedField

How I tested:
Apply 1st patch
Apply this patch
Edit syspref BorrowerUnwantedField to exclude fields
Edit patron's contact information
Make sure that fields do not longer appear in drop down for Main contact

Wors as expected

http://bugs.koha-community.org/show_bug.cgi?id=11879
Signed-off-by: Marc Veron 

Signed-off-by: Kyle M Hall 
Signed-off-by: Aleisha 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

2016-06-20 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Mehdi Hamidi  changed:

   What|Removed |Added

  Attachment #48556|0   |1
is obsolete||

--- Comment #50 from Mehdi Hamidi  ---
Created attachment 52607
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52607=edit
Bug 11879 - Add a new borrower field : main contact method. (Was: Rebased on
current master for testing)

http://bugs.koha-community.org/show_bug.cgi?id=11879

To test this patch:
Update database
Edit a borrower's informations.
The "Main Contact Method" selectbox appears in the form and its
value is correctly.

Works as expected.
For handling of syspref BorrowerUnwantedField use second patch-

Signed-off-by: Marc Veron 

Signed-off-by: Kyle M Hall 
Signed-off-by: Aleisha 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

2016-04-21 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

--- Comment #49 from Owen Leonard  ---
Sorry, this does not apply anymore!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

2016-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Rémi Mayrand-Provencher  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #48 from Rémi Mayrand-Provencher 
 ---
Added "after" in the atomic update, changed status to needs signoff! Thank you!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

2016-04-19 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

--- Comment #47 from Rémi Mayrand-Provencher 
 ---
Created attachment 50433
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50433=edit
Bug 11879 - QA Follow-up

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

2016-04-05 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #46 from Owen Leonard  ---
I'm guessing this is 'Failed QA' based on Comment 45.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

2016-03-27 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

M. Tompsett  changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com

--- Comment #45 from M. Tompsett  ---
When ALTER'ing it is a good idea to put "AFTER" as part of the SQL statement so
that upgrades and fresh installs are guaranteed to have the same field order.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

2016-03-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Rémi Mayrand-Provencher  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

2016-03-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Rémi Mayrand-Provencher  changed:

   What|Removed |Added

  Attachment #48078|0   |1
is obsolete||

--- Comment #42 from Rémi Mayrand-Provencher 
 ---
Created attachment 48557
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48557=edit
Bug 11879 - Fix syspref BorrowerUnwantedField

How I tested:
Apply 1st patch
Apply this patch
Edit syspref BorrowerUnwantedField to exclude fields
Edit patron's contact information
Make sure that fields do not longer appear in drop down for Main contact

Wors as expected

http://bugs.koha-community.org/show_bug.cgi?id=11879
Signed-off-by: Marc Veron 

Signed-off-by: Kyle M Hall 
Signed-off-by: Aleisha 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

2016-03-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

--- Comment #44 from Rémi Mayrand-Provencher 
 ---
Created attachment 48559
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48559=edit
Bug 11879 QA follow-up

Changed "Mobile Phone" to Other Phone, modified deletedborrowers table
structute and added the field in opac

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

2016-03-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Rémi Mayrand-Provencher  changed:

   What|Removed |Added

  Attachment #48079|0   |1
is obsolete||

--- Comment #43 from Rémi Mayrand-Provencher 
 ---
Created attachment 48558
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48558=edit
Bug 11879 - Update BDIx schema and show main contact method in moremember.pl

Signed-off-by: Aleisha 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new borrower field : main contact method.

2016-03-02 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Rémi Mayrand-Provencher  changed:

   What|Removed |Added

  Attachment #48077|0   |1
is obsolete||

--- Comment #41 from Rémi Mayrand-Provencher 
 ---
Created attachment 48556
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48556=edit
Bug 11879 - Add a new borrower field : main contact method. (Was: Rebased on
current master for testing)

http://bugs.koha-community.org/show_bug.cgi?id=11879

To test this patch:
Update database
Edit a borrower's informations.
The "Main Contact Method" selectbox appears in the form and its
value is correctly.

Works as expected.
For handling of syspref BorrowerUnwantedField use second patch-

Signed-off-by: Marc Veron 

Signed-off-by: Kyle M Hall 
Signed-off-by: Aleisha 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

1 2 >

1 - 100 of 160 matches

Mail list logo