[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Andrew Fuerste-Henry  changed:

   What|Removed |Added

 Blocks||31659


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31659
[Bug 31659] Add SMSAlertNumber to options in borrowers.primary_contact_method
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #210 from David Cook  ---
It looks like there's no way to set a default for this field...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Jonathan Druart  changed:

   What|Removed |Added

   Keywords|rel_21_11_candidate |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Kyle M Hall  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|Pushed to master|RESOLVED

--- Comment #209 from Kyle M Hall  ---
Enhancement not backported for 21.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

--- Comment #208 from Jonathan Druart  ---
Pushed to master for 21.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||21.11.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||28701
 Status|ASSIGNED|Passed QA

--- Comment #207 from Jonathan Druart  ---
I will push as it but it would be great to have it part of the REST API spec.

See bug 28701.


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28701
[Bug 28701] primary_contact_method not part of the REST API spec
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

--- Comment #206 from Jonathan Druart  ---
Created attachment 122778
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122778=edit
Bug 11879: Remove primary_contact_method from REST API

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

--- Comment #205 from Tomás Cohen Arazi  ---
(In reply to Jonathan Druart from comment #204)
> (In reply to Katrin Fischer from comment #191)
> > I am not sure if we will need changes to the API Patron/Patrons routes too.
> > Something else to look into.
> 
> Yes, I think we should. Tomas can you confirm?

Yes. We need to add it or remove it explicitly in to_api_mapping. I would
remove it if you ask me. We can add /patrons/:patron_id/default_contact_method
to deal with it.

If you prefer to keep it, I vote for making it an enum with valid values. I
would do the same on the DB.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Jonathan Druart  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com

--- Comment #204 from Jonathan Druart  ---
(In reply to Katrin Fischer from comment #191)
> I am not sure if we will need changes to the API Patron/Patrons routes too.
> Something else to look into.

Yes, I think we should. Tomas can you confirm?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Katrin Fischer  changed:

   What|Removed |Added

   Keywords||rel_21_11_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

David Nind  changed:

   What|Removed |Added

  Text to go in the||This enhancement adds a
  release notes||"Main contact method"
   ||dropdown list field to the
   ||patron modification form in
   ||the staff interface and
   ||OPAC.
   ||
   ||This field is useful
   ||for reporting purposes, or
   ||to know which contact
   ||method to use first when
   ||trying to contact a patron.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

--- Comment #203 from Kyle M Hall  ---
Created attachment 120950
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120950=edit
Bug 11879: Remove the 'unwanted' preferences from the main contact method
pull-down menu in the OPAC

Signed-off-by: David Nind 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

--- Comment #202 from Kyle M Hall  ---
Created attachment 120949
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120949=edit
Bug 11879: (follow up) Some fixes and code cleanup

- Display the value in the patron detail page
- Adds support for BorrowerUnwantedField (staff)
- Removes unecessary code in opac/opac-memberentry.pl

Sponsored-by: CCSR ( http://www.ccsr.qc.ca )

Signed-off-by: David Nind 

Signed-off-by: David Nind 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

--- Comment #201 from Kyle M Hall  ---
Created attachment 120948
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120948=edit
Bug 11879: Schema update for Borrower tables

Signed-off-by: David Nind 

Signed-off-by: David Nind 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Kyle M Hall  changed:

   What|Removed |Added

 Attachment #118985|0   |1
is obsolete||
 Attachment #118986|0   |1
is obsolete||
 Attachment #118987|0   |1
is obsolete||
 Attachment #118988|0   |1
is obsolete||

--- Comment #200 from Kyle M Hall  ---
Created attachment 120947
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120947=edit
Bug 11879: Add a new field to patron record: main contact method

This patch adds the "Main Contact Method" field in the borrower
modification form.

This field is useful for reporting purposes, or to
know which contact method to use first when trying to contact a borrower.

Test plan:
0) Apply patch
1) updatedatabase.pl
2) In the staff client, edit a patron's contact info. There should be a new
dropdown select to choose the main contact method
3) In the opac page, edit the personal details.There should be a new dropdown
select to choose the main contact method.
4) Save the form. It should work.

Sponsored-by: CCSR ( http://www.ccsr.qc.ca )
Signed-off-by: David Nind 

Signed-off-by: David Nind 

Signed-off-by: David Nind 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Kyle M Hall  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

David Nind  changed:

   What|Removed |Added

 Attachment #118962|0   |1
is obsolete||

--- Comment #199 from David Nind  ---
Created attachment 118988
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118988=edit
Bug 11879: Remove the 'unwanted' preferences from the main contact method
pull-down menu in the OPAC

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

David Nind  changed:

   What|Removed |Added

 Attachment #118961|0   |1
is obsolete||

--- Comment #198 from David Nind  ---
Created attachment 118987
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118987=edit
Bug 11879: (follow up) Some fixes and code cleanup

- Display the value in the patron detail page
- Adds support for BorrowerUnwantedField (staff)
- Removes unecessary code in opac/opac-memberentry.pl

Sponsored-by: CCSR ( http://www.ccsr.qc.ca )

Signed-off-by: David Nind 

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

David Nind  changed:

   What|Removed |Added

 Attachment #118960|0   |1
is obsolete||

--- Comment #197 from David Nind  ---
Created attachment 118986
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118986=edit
Bug 11879: Schema update for Borrower tables

Signed-off-by: David Nind 

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

David Nind  changed:

   What|Removed |Added

 Attachment #118959|0   |1
is obsolete||

--- Comment #196 from David Nind  ---
Created attachment 118985
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118985=edit
Bug 11879: Add a new field to patron record: main contact method

This patch adds the "Main Contact Method" field in the borrower
modification form.

This field is useful for reporting purposes, or to
know which contact method to use first when trying to contact a borrower.

Test plan:
0) Apply patch
1) updatedatabase.pl
2) In the staff client, edit a patron's contact info. There should be a new
dropdown select to choose the main contact method
3) In the opac page, edit the personal details.There should be a new dropdown
select to choose the main contact method.
4) Save the form. It should work.

Sponsored-by: CCSR ( http://www.ccsr.qc.ca )
Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

--- Comment #195 from Alexis Ripetti  ---
Created attachment 118962
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118962=edit
Bug 11879: Remove the 'unwanted' preferences from the main contact method
pull-down menu in the OPAC

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Alexis Ripetti  changed:

   What|Removed |Added

 Attachment #112560|0   |1
is obsolete||

--- Comment #194 from Alexis Ripetti  ---
Created attachment 118961
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118961=edit
Bug 11879: (follow up) Some fixes and code cleanup

- Display the value in the patron detail page
- Adds support for BorrowerUnwantedField (staff)
- Removes unecessary code in opac/opac-memberentry.pl

Sponsored-by: CCSR ( http://www.ccsr.qc.ca )

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Alexis Ripetti  changed:

   What|Removed |Added

 Attachment #112559|0   |1
is obsolete||

--- Comment #193 from Alexis Ripetti  ---
Created attachment 118960
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118960=edit
Bug 11879: Schema update for Borrower tables

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Alexis Ripetti  changed:

   What|Removed |Added

 Attachment #112557|0   |1
is obsolete||

--- Comment #192 from Alexis Ripetti  ---
Created attachment 118959
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118959=edit
Bug 11879: Add a new field to patron record: main contact method

This patch adds the "Main Contact Method" field in the borrower
modification form.

This field is useful for reporting purposes, or to
know which contact method to use first when trying to contact a borrower.

Test plan:
0) Apply patch
1) updatedatabase.pl
2) In the staff client, edit a patron's contact info. There should be a new
dropdown select to choose the main contact method
3) In the opac page, edit the personal details.There should be a new dropdown
select to choose the main contact method.
4) Save the form. It should work.

Sponsored-by: CCSR ( http://www.ccsr.qc.ca )

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Alexis Ripetti  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #191 from Katrin Fischer  ---
There is one small glitch here: It allows you to hide the field using the
"*unwanted*" preferences, but the pulldown itself does not change according to
the hidden fields. I feel that if a library decides to hide "Fax" in the OPAC,
we should also remove this entry from the pull down. 

I think it should not be too hard to do (I hope I am right), can you please
check?

I am not sure if we will need changes to the API Patron/Patrons routes too.
Something else to look into.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

David Nind  changed:

   What|Removed |Added

 Attachment #112064|0   |1
is obsolete||

--- Comment #190 from David Nind  ---
Created attachment 112560
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112560=edit
Bug 11879: (follow up) Some fixes and code cleanup

- Display the value in the patron detail page
- Adds support for BorrowerUnwantedField (staff)
- Removes unecessary code in opac/opac-memberentry.pl

Sponsored-by: CCSR ( http://www.ccsr.qc.ca )

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

David Nind  changed:

   What|Removed |Added

 Attachment #112063|0   |1
is obsolete||

--- Comment #189 from David Nind  ---
Created attachment 112559
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112559=edit
Bug 11879: Schema update for Borrower tables

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

David Nind  changed:

   What|Removed |Added

 Attachment #112062|0   |1
is obsolete||

--- Comment #188 from David Nind  ---
Created attachment 112557
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112557=edit
Bug 11879: Add a new field to patron record: main contact method

This patch adds the "Main Contact Method" field in the borrower
modification form.

This field is useful for reporting purposes, or to
know which contact method to use first when trying to contact a borrower.

Test plan:
0) Apply patch
1) updatedatabase.pl
2) In the staff client, edit a patron's contact info. There should be a new
dropdown select to choose the main contact method
3) In the opac page, edit the personal details.There should be a new dropdown
select to choose the main contact method.
4) Save the form. It should work.

Sponsored-by: CCSR ( http://www.ccsr.qc.ca )
Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Maryse Simard  changed:

   What|Removed |Added

 CC||maryse.sim...@inlibro.com
 Status|Failed QA   |Needs Signoff

--- Comment #187 from Maryse Simard  ---
I've rebased the patch and added a follow up to fix the problem concerning
display on the detail page and other code cleaning.

The schema update has also been extracted from the first patch and the commit
message adjusted to be a bit more telling.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

--- Comment #186 from Maryse Simard  ---
Created attachment 112064
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112064=edit
Bug 11879: (follow up) Some fixes and code cleanup

- Display the value in the patron detail page
- Adds support for BorrowerUnwantedField (staff)
- Removes unecessary code in opac/opac-memberentry.pl

Sponsored-by: CCSR ( http://www.ccsr.qc.ca )

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Maryse Simard  changed:

   What|Removed |Added

 Attachment #100843|0   |1
is obsolete||

--- Comment #184 from Maryse Simard  ---
Created attachment 112062
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112062=edit
Bug 11879: Add a new field to patron record: main contact method

This patch adds the "Main Contact Method" field in the borrower
modification form.

This field is useful for reporting purposes, or to
know which contact method to use first when trying to contact a borrower.

Test plan:
0) Apply patch
1) updatedatabase.pl
2) In the staff client, edit a patron's contact info. There should be a new
dropdown select to choose the main contact method
3) In the opac page, edit the personal details.There should be a new dropdown
select to choose the main contact method.
4) Save the form. It should work.

Sponsored-by: CCSR ( http://www.ccsr.qc.ca )
Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

--- Comment #185 from Maryse Simard  ---
Created attachment 112063
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112063=edit
Bug 11879: Schema update for Borrower tables

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

--- Comment #183 from Blou  ---
Ok, the patches were squashed due to the difficulties to apply them separately.
 Some dependencies issues.
Someone here will work on it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Blou  changed:

   What|Removed |Added

   Assignee|mehdi.ham...@inlibro.com|bin@inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

--- Comment #182 from Blou  ---
You squashed the patches and lost the authors?
Or did Bin Wen do that before?  
I'm trying to figure if everything is in the single patch currently presented.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

--- Comment #181 from Blou  ---
You squashed the patches and lost the authors?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Michal Denar  changed:

   What|Removed |Added

 CC||blac...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Owen Leonard  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #180 from Owen Leonard  ---
> 2) In the staff client, edit a patron's contact info. There should be a new
> dropdown select to choose the main contact method

I see this during the edit process but I don't see the information on the
patron detail page (moremember.pl). It looks like only the template was
changed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

David Nind  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

David Nind  changed:

   What|Removed |Added

 Attachment #100817|0   |1
is obsolete||

--- Comment #179 from David Nind  ---
Created attachment 100843
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100843=edit
Bug 11879: Add a new field to patron record: main contact method

Fixed the problem mentioned above.

Test plan is same as before:
0) Apply patch
1) updatedatabase.pl
2) In the staff client, edit a patron's contact info. There should be a new
dropdown select to choose the main contact method
3) In the opac page, edit the personal details.There should be a new dropdown
select to choose the main contact method.
4) Save the form. It should work.

Signed-off-by: David Nind 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Bin Wen  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Bin Wen  changed:

   What|Removed |Added

  Attachment #96432|0   |1
is obsolete||

--- Comment #178 from Bin Wen  ---
Created attachment 100817
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100817=edit
Bug 11879 - Add a new field to patron record: main contact method

Fixed the problem mentioned above.

Test plan is same as before:
0) Apply patch
1) updatedatabase.pl
2) In the staff client, edit a patron's contact info. There should be a new
dropdown select to choose the main contact method
3) In the opac page, edit the personal details.There should be a new dropdown
select to choose the main contact method.
4) Save the form. It should work.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

David Nind  changed:

   What|Removed |Added

 CC||da...@davidnind.com
 Status|Needs Signoff   |Patch doesn't apply

--- Comment #177 from David Nind  ---
Patch no longer applies 8-(

(Not sure of the correct protocol here - paste the message from git bz, or just
say the patch no longer applies).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

--- Comment #176 from Bin Wen  ---
Created attachment 96432
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96432=edit
Bug 11879 - Add a new field to patron record: main contact method

Fixed the problem mentioned above.

Test plan is same as before:
0) Apply patch
1) updatedatabase.pl
2) In the staff client, edit a patron's contact info. There should be a new
dropdown select to choose the main contact method
3) In the opac page, edit the personal details.There should be a new dropdown
select to choose the main contact method.
4) Save the form. It should work.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Bin Wen  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Bin Wen  changed:

   What|Removed |Added

  Attachment #88400|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Bin Wen  changed:

   What|Removed |Added

  Attachment #88399|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Bin Wen  changed:

   What|Removed |Added

  Attachment #88398|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Bin Wen  changed:

   What|Removed |Added

  Attachment #88397|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Bin Wen  changed:

   What|Removed |Added

  Attachment #88395|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Bin Wen  changed:

   What|Removed |Added

  Attachment #88396|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Bin Wen  changed:

   What|Removed |Added

  Attachment #88398|1   |0
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Bin Wen  changed:

   What|Removed |Added

  Attachment #88399|1   |0
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Bin Wen  changed:

   What|Removed |Added

  Attachment #88400|1   |0
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Bin Wen  changed:

   What|Removed |Added

  Attachment #88396|1   |0
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Bin Wen  changed:

   What|Removed |Added

  Attachment #88395|1   |0
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Bin Wen  changed:

   What|Removed |Added

  Attachment #88394|1   |0
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Bin Wen  changed:

   What|Removed |Added

  Attachment #94467|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Bin Wen  changed:

   What|Removed |Added

  Attachment #94465|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Bin Wen  changed:

   What|Removed |Added

  Attachment #94466|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Bin Wen  changed:

   What|Removed |Added

  Attachment #88397|1   |0
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Bin Wen  changed:

   What|Removed |Added

  Attachment #88394|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Bin Wen  changed:

   What|Removed |Added

  Attachment #94468|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Bin Wen  changed:

   What|Removed |Added

  Attachment #94464|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Bin Wen  changed:

   What|Removed |Added

  Attachment #94463|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Bin Wen  changed:

   What|Removed |Added

  Attachment #94461|0   |1
is obsolete||

--- Comment #175 from Bin Wen  ---
Created attachment 94468
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94468=edit
Bug 11879: (follow-up) Corrected OPAC and removed unrelated changes

modified:   koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember-brief.tt
modified:  
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt

Signed-off-by: Bin Wen 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Bin Wen  changed:

   What|Removed |Added

  Attachment #94458|0   |1
is obsolete||

--- Comment #172 from Bin Wen  ---
Created attachment 94465
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94465=edit
Bug 11879: (QA follow-up) Fix problems found in code review

Signed-off-by: Lucie Gay 

Signed-off-by: Katrin Fischer 

Signed-off-by: Hayley Mapley 
Signed-off-by: Bin Wen 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Bin Wen  changed:

   What|Removed |Added

  Attachment #94460|0   |1
is obsolete||

--- Comment #174 from Bin Wen  ---
Created attachment 94467
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94467=edit
Bug 11879: Remove unecessary code in controller

- adds the field required is defined in BorrowerMandatoryField (staff
only)
- removes code from controller (not needed, we can follow existing
pattern)
- does not send patron's attribute separately (we have the 'patron'
variable already)

Need to be done:
- same changes for the OPAC
- remove extra changes made to moremember-brief.tt (if bugfix it needs
to be moved on a separate bug report)
- deal with PatronSelfModificationBorrowerUnwantedField and
PatronSelfRegistrationBorrowerUnwantedField

I first thought it would have replaced AutoEmailPrimaryAddress, but it
actually only needed for display purpose, how/where can we explain that?
Are release notes enough?

Signed-off-by: Hayley Mapley 
Signed-off-by: Bin Wen 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Bin Wen  changed:

   What|Removed |Added

  Attachment #94457|0   |1
is obsolete||

--- Comment #171 from Bin Wen  ---
Created attachment 94464
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94464=edit
Bug 11879: (follow-up) Streamline markup and make label corrections

This patch makes minor markup corrections to the patron detail page
template:

- Simplify the SWITCH markup
- Add "primary" to primary phone label
- Correct case on label
- Add IF statement to hide label if there is no primary contact
  method

Signed-off-by: Lucie Gay 

Signed-off-by: Katrin Fischer 

Signed-off-by: Hayley Mapley 
Signed-off-by: Bin Wen 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Bin Wen  changed:

   What|Removed |Added

  Attachment #94459|0   |1
is obsolete||

--- Comment #173 from Bin Wen  ---
Created attachment 94466
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94466=edit
Bug 11879: Schema updates

Signed-off-by: Lucie Gay 

Signed-off-by: Katrin Fischer 

Signed-off-by: Hayley Mapley 
Signed-off-by: Bin Wen 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Bin Wen  changed:

   What|Removed |Added

  Attachment #94456|0   |1
is obsolete||

--- Comment #170 from Bin Wen  ---
Created attachment 94463
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94463=edit
Bug 11879: Add the "Main contact method" field in borrower informations.

This patch adds the "Main Contact Method" field in the borrower modification
form.

This field is useful for reporting purposes, or to know which contact method to
use first when trying to contact a borrower.

Following Nicolas' fix, removed a $branch variable from patch, since it has
been suppressed in Bug 17284.

Test case :
* Edit a borrower's informations. The "Main Contact Method" selectbox should
appear in the form and its value should be saved correctly.

Sponsored-by: CCSR 

Signed-off-by: Lucie Gay 

Signed-off-by: Katrin Fischer 

Signed-off-by: Hayley Mapley 
Signed-off-by: Bin Wen 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Bin Wen  changed:

   What|Removed |Added

  Attachment #93854|0   |1
is obsolete||

--- Comment #167 from Bin Wen  ---
Created attachment 94459
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94459=edit
Bug 11879: Schema updates

Signed-off-by: Lucie Gay 

Signed-off-by: Katrin Fischer 

Signed-off-by: Hayley Mapley 
Signed-off-by: Bin Wen 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Bin Wen  changed:

   What|Removed |Added

  Attachment #93852|0   |1
is obsolete||

--- Comment #165 from Bin Wen  ---
Created attachment 94457
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94457=edit
Bug 11879: (follow-up) Streamline markup and make label corrections

This patch makes minor markup corrections to the patron detail page
template:

- Simplify the SWITCH markup
- Add "primary" to primary phone label
- Correct case on label
- Add IF statement to hide label if there is no primary contact
  method

Signed-off-by: Lucie Gay 

Signed-off-by: Katrin Fischer 

Signed-off-by: Hayley Mapley 
Signed-off-by: Bin Wen 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Bin Wen  changed:

   What|Removed |Added

  Attachment #93853|0   |1
is obsolete||

--- Comment #166 from Bin Wen  ---
Created attachment 94458
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94458=edit
Bug 11879: (QA follow-up) Fix problems found in code review

Signed-off-by: Lucie Gay 

Signed-off-by: Katrin Fischer 

Signed-off-by: Hayley Mapley 
Signed-off-by: Bin Wen 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Bin Wen  changed:

   What|Removed |Added

  Attachment #93851|0   |1
is obsolete||

--- Comment #164 from Bin Wen  ---
Created attachment 94456
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94456=edit
Bug 11879: Add the "Main contact method" field in borrower informations.

This patch adds the "Main Contact Method" field in the borrower modification
form.

This field is useful for reporting purposes, or to know which contact method to
use first when trying to contact a borrower.

Following Nicolas' fix, removed a $branch variable from patch, since it has
been suppressed in Bug 17284.

Test case :
* Edit a borrower's informations. The "Main Contact Method" selectbox should
appear in the form and its value should be saved correctly.

Sponsored-by: CCSR 

Signed-off-by: Lucie Gay 

Signed-off-by: Katrin Fischer 

Signed-off-by: Hayley Mapley 
Signed-off-by: Bin Wen 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Bin Wen  changed:

   What|Removed |Added

  Attachment #93901|0   |1
is obsolete||

--- Comment #169 from Bin Wen  ---
Created attachment 94461
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94461=edit
Bug 11879: (follow-up) Corrected OPAC and removed unrelated changes

modified:   koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember-brief.tt
modified:  
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Bin Wen  changed:

   What|Removed |Added

  Attachment #93855|0   |1
is obsolete||

--- Comment #168 from Bin Wen  ---
Created attachment 94460
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94460=edit
Bug 11879: Remove unecessary code in controller

- adds the field required is defined in BorrowerMandatoryField (staff
only)
- removes code from controller (not needed, we can follow existing
pattern)
- does not send patron's attribute separately (we have the 'patron'
variable already)

Need to be done:
- same changes for the OPAC
- remove extra changes made to moremember-brief.tt (if bugfix it needs
to be moved on a separate bug report)
- deal with PatronSelfModificationBorrowerUnwantedField and
PatronSelfRegistrationBorrowerUnwantedField

I first thought it would have replaced AutoEmailPrimaryAddress, but it
actually only needed for display purpose, how/where can we explain that?
Are release notes enough?

Signed-off-by: Hayley Mapley 
Signed-off-by: Bin Wen 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Lisette Scheer  changed:

   What|Removed |Added

 CC||lisettesla...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Bin Wen  changed:

   What|Removed |Added

  Attachment #93900|0   |1
is obsolete||

--- Comment #163 from Bin Wen  ---
Created attachment 93901
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93901=edit
Bug 11879: (follow-up) Corrected OPAC and removed unrelated changes

modified:   koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember-brief.tt
modified:  
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Bin Wen  changed:

   What|Removed |Added

  Attachment #93856|0   |1
is obsolete||

--- Comment #162 from Bin Wen  ---
Created attachment 93900
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93900=edit
Bug 11879: (follow-up) Corrected OPAC and removed unrelated changes

Signed-off-by: Hayley Mapley 
Signed-off-by: Bin Wen 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Bin Wen  changed:

   What|Removed |Added

  Attachment #88400|0   |1
is obsolete||

--- Comment #161 from Bin Wen  ---
Created attachment 93856
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93856=edit
Bug 11879: (follow-up) Corrected OPAC and removed unrelated changes

Signed-off-by: Hayley Mapley 
Signed-off-by: Bin Wen 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Bin Wen  changed:

   What|Removed |Added

  Attachment #88399|0   |1
is obsolete||

--- Comment #160 from Bin Wen  ---
Created attachment 93855
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93855=edit
Bug 11879: Remove unecessary code in controller

- adds the field required is defined in BorrowerMandatoryField (staff
only)
- removes code from controller (not needed, we can follow existing
pattern)
- does not send patron's attribute separately (we have the 'patron'
variable already)

Need to be done:
- same changes for the OPAC
- remove extra changes made to moremember-brief.tt (if bugfix it needs
to be moved on a separate bug report)
- deal with PatronSelfModificationBorrowerUnwantedField and
PatronSelfRegistrationBorrowerUnwantedField

I first thought it would have replaced AutoEmailPrimaryAddress, but it
actually only needed for display purpose, how/where can we explain that?
Are release notes enough?

Signed-off-by: Hayley Mapley 
Signed-off-by: Bin Wen 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Bin Wen  changed:

   What|Removed |Added

  Attachment #88397|0   |1
is obsolete||

--- Comment #158 from Bin Wen  ---
Created attachment 93853
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93853=edit
Bug 11879: (QA follow-up) Fix problems found in code review

Signed-off-by: Lucie Gay 

Signed-off-by: Katrin Fischer 

Signed-off-by: Hayley Mapley 
Signed-off-by: Bin Wen 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Bin Wen  changed:

   What|Removed |Added

  Attachment #88398|0   |1
is obsolete||

--- Comment #159 from Bin Wen  ---
Created attachment 93854
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93854=edit
Bug 11879: Schema updates

Signed-off-by: Lucie Gay 

Signed-off-by: Katrin Fischer 

Signed-off-by: Hayley Mapley 
Signed-off-by: Bin Wen 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Bin Wen  changed:

   What|Removed |Added

  Attachment #93850|0   |1
is obsolete||

--- Comment #156 from Bin Wen  ---
Created attachment 93851
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93851=edit
Bug 11879: Add the "Main contact method" field in borrower informations.

This patch adds the "Main Contact Method" field in the borrower modification
form.

This field is useful for reporting purposes, or to know which contact method to
use first when trying to contact a borrower.

Following Nicolas' fix, removed a $branch variable from patch, since it has
been suppressed in Bug 17284.

Test case :
* Edit a borrower's informations. The "Main Contact Method" selectbox should
appear in the form and its value should be saved correctly.

Sponsored-by: CCSR 

Signed-off-by: Lucie Gay 

Signed-off-by: Katrin Fischer 

Signed-off-by: Hayley Mapley 
Signed-off-by: Bin Wen 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Bin Wen  changed:

   What|Removed |Added

  Attachment #88396|0   |1
is obsolete||

--- Comment #157 from Bin Wen  ---
Created attachment 93852
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93852=edit
Bug 11879: (follow-up) Streamline markup and make label corrections

This patch makes minor markup corrections to the patron detail page
template:

- Simplify the SWITCH markup
- Add "primary" to primary phone label
- Correct case on label
- Add IF statement to hide label if there is no primary contact
  method

Signed-off-by: Lucie Gay 

Signed-off-by: Katrin Fischer 

Signed-off-by: Hayley Mapley 
Signed-off-by: Bin Wen 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Bin Wen  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
 CC||bin@inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Bin Wen  changed:

   What|Removed |Added

  Attachment #88395|0   |1
is obsolete||

--- Comment #155 from Bin Wen  ---
Created attachment 93850
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93850=edit
Bug 11879: Add the "Main contact method" field in borrower informations.

This patch adds the "Main Contact Method" field in the borrower modification
form.

This field is useful for reporting purposes, or to know which contact method to
use first when trying to contact a borrower.

Following Nicolas' fix, removed a $branch variable from patch, since it has
been suppressed in Bug 17284.

Test case :
* Edit a borrower's informations. The "Main Contact Method" selectbox should
appear in the form and its value should be saved correctly.

Sponsored-by: CCSR 

Signed-off-by: Lucie Gay 

Signed-off-by: Katrin Fischer 

Signed-off-by: Hayley Mapley 
Signed-off-by: Bin Wen 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Bin Wen  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Katrin Fischer  changed:

   What|Removed |Added

 CC||neng...@gmail.com

--- Comment #154 from Katrin Fischer  ---
*** Bug 9082 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Josef Moravec  changed:

   What|Removed |Added

 QA Contact||josef.mora...@gmail.com
 Status|Signed Off  |Failed QA

--- Comment #153 from Josef Moravec  ---
Started QAing:

1) QA test tools have complains about missing filters

 FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember-brief.tt
   FAIL   filters
missing_filter at line 22 ( [% UNLESS ( I ) %][% IF (
othernames ) %][% othernames %][% END %])
missing_filter at line 64 (Card
number: [% cardnumber %])
missing_filter at line 65 (Borrowernumber:  [% borrowernumber %])
missing_filter at line 66 (Category: [% categoryname %] ([% categorycode %]))
missing_filter at line 66 (Category: [% categoryname %] ([% categorycode %]))


2) The database update is not consistent, in atomic file you add columns after
other columns then in kohastructure.sql

Also, you should use .perl atomic update here, to check for column existence
before adding it - see skeleton.perl for example

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Hayley Mapley  changed:

   What|Removed |Added

  Attachment #88363|0   |1
is obsolete||

--- Comment #152 from Hayley Mapley  ---
Created attachment 88400
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88400=edit
Bug 11879: (follow-up) Corrected OPAC and removed unrelated changes

Signed-off-by: Hayley Mapley 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Hayley Mapley  changed:

   What|Removed |Added

  Attachment #88361|0   |1
is obsolete||

--- Comment #150 from Hayley Mapley  ---
Created attachment 88398
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88398=edit
Bug 11879: Schema updates

Signed-off-by: Lucie Gay 

Signed-off-by: Katrin Fischer 

Signed-off-by: Hayley Mapley 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Hayley Mapley  changed:

   What|Removed |Added

  Attachment #88362|0   |1
is obsolete||

--- Comment #151 from Hayley Mapley  ---
Created attachment 88399
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88399=edit
Bug 11879: Remove unecessary code in controller

- adds the field required is defined in BorrowerMandatoryField (staff
only)
- removes code from controller (not needed, we can follow existing
pattern)
- does not send patron's attribute separately (we have the 'patron'
variable already)

Need to be done:
- same changes for the OPAC
- remove extra changes made to moremember-brief.tt (if bugfix it needs
to be moved on a separate bug report)
- deal with PatronSelfModificationBorrowerUnwantedField and
PatronSelfRegistrationBorrowerUnwantedField

I first thought it would have replaced AutoEmailPrimaryAddress, but it
actually only needed for display purpose, how/where can we explain that?
Are release notes enough?

Signed-off-by: Hayley Mapley 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11879] Add a new field to patron record: main contact method

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11879

Hayley Mapley  changed:

   What|Removed |Added

  Attachment #88359|0   |1
is obsolete||

--- Comment #148 from Hayley Mapley  ---
Created attachment 88396
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88396=edit
Bug 11879: (follow-up) Streamline markup and make label corrections

This patch makes minor markup corrections to the patron detail page
template:

- Simplify the SWITCH markup
- Add "primary" to primary phone label
- Correct case on label
- Add IF statement to hide label if there is no primary contact
  method

Signed-off-by: Lucie Gay 

Signed-off-by: Katrin Fischer 

Signed-off-by: Hayley Mapley 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/