[Koha-bugs] [Bug 12022] Independent branches does not isolate pending and approved comments by branch.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12022

Katrin Fischer  changed:

   What|Removed |Added

 Status|In Discussion   |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12022] Independent branches does not isolate pending and approved comments by branch.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12022

Martin Renvoize  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com
   Severity|major   |normal

--- Comment #9 from Martin Renvoize  ---
Is this still valid.. or perhaps it should really be moved to library groups
rather than independent branches at this point?

At this point, it feels like an enhancement to me?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12022] Independent branches does not isolate pending and approved comments by branch.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12022

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |In Discussion

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12022] Independent branches does not isolate pending and approved comments by branch.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12022

--- Comment #8 from Katrin Fischer  ---
Hi Kyle, sorry, but I think this behaviour change will possibly upset some
libraries. Could we tie it to IndyBranches - or a new pref? There is another
example where the latter has been done: IndependentBranchesPatronModifications

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12022] Independent branches does not isolate pending and approved comments by branch.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12022

--- Comment #7 from Kyle M Hall  ---
My new patch just filters based on if the librarian is a superlibrarian or not.
I imagine this would be nice outside of enabling IndependentBranches. If
someone disagrees, please let me know ; )

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12022] Independent branches does not isolate pending and approved comments by branch.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12022

Kyle M Hall  changed:

   What|Removed |Added

 Depends on|10276   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276
[Bug 10276] Extend IndependentBranches to support groups of libraries
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12022] Independent branches does not isolate pending and approved comments by branch.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12022

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12022] Independent branches does not isolate pending and approved comments by branch.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12022

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #26980|0   |1
is obsolete||

--- Comment #6 from Kyle M Hall  ---
Created attachment 54785
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54785=edit
Bug 12022 - Independent branches does not isolate pending and approved comments
by branch.

Test Plan:
1) Create some comments for two libraries
2) Log in as non-superlibrarian
3) Set the logged in library to one of those two libraries
4) View comments, not you only see the comments from patrons
   whose home library matches the logged in library
5) Log in as a superlibrarian
6) Note you see all the comments reguardless of the patron's
   home library

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12022] Independent branches does not isolate pending and approved comments by branch.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12022

Katrin Fischer  changed:

   What|Removed |Added

Version|3.14|master

--- Comment #5 from Katrin Fischer  ---
Commit message mentions a depending bug that was marked as WONTFIX - Kyle,
could you take a look here maybe?

My feeling is that the behaviour might still be desirable, but we'd need a
restart on the patches?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12022] Independent branches does not isolate pending and approved comments by branch.

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12022

Katrin Fischer  changed:

   What|Removed |Added

 Depends on||10276
 CC||katrin.fisc...@bsz-bw.de


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10276
[Bug 10276] Extend IndependentBranches to support groups of libraries
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12022] Independent branches does not isolate pending and approved comments by branch.

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12022

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch

--- Comment #4 from Marc Véron  ---
Is this bug still valid?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12022] Independent branches does not isolate pending and approved comments by branch.

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12022

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #3 from Owen Leonard oleon...@myacpl.org ---
Looks like something has been left out of the patch?

Undefined subroutine C4::Review::GetIndependentGroupModificationRights called
at C4/Review.pm line 141.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12022] Independent branches does not isolate pending and approved comments by branch.

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12022

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12022] Independent branches does not isolate pending and approved comments by branch.

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12022

--- Comment #1 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 26979
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26979action=edit
Bug 12022 - Independent branches does not isolate pending and approved comments
by branch.

Given Branches A and B

Branch A patron logs on to OPAC and leaves a comment for a title.
Branch B staff is then able to see these comments in Home  Tools
 Comments  Approved comments, in both the Approved Comments
and Comments awaiting moderation tabs.

Test Plan:
1) Create some comments for two libraries
2) Enable IndependentBranches
3) View the comments, not you see comments
   from both library's patrons
4) Apply the patch for bug 10276
5) Apply this patch
6) View the comments again, note you only
   see the comments for the patrons of the
   library you are logged in as.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12022] Independent branches does not isolate pending and approved comments by branch.

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12022

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
   Assignee|gmcha...@gmail.com  |k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12022] Independent branches does not isolate pending and approved comments by branch.

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12022

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #26979|0   |1
is obsolete||

--- Comment #2 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 26980
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26980action=edit
Bug 12022 - Independent branches does not isolate pending and approved comments
by branch.

Given Branches A and B

Branch A patron logs on to OPAC and leaves a comment for a title.
Branch B staff is then able to see these comments in Home  Tools
 Comments  Approved comments, in both the Approved Comments
and Comments awaiting moderation tabs.

Test Plan:
1) Create some comments for two libraries
2) Enable IndependentBranches
3) View the comments, not you see comments
   from both library's patrons
4) Apply the patch for bug 10276
5) Apply this patch
6) View the comments again, note you only
   see the comments for the patrons of the
   library you are logged in as.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/