[Koha-bugs] [Bug 12051] add renew tab to top on staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12051 Julian Maurice changed: What|Removed |Added Blocks||16933 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16933 [Bug 16933] Alt-Y not working on "Please confirm checkout" dialogs -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12051] add renew tab to top on staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12051 Brendan Gallagher changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||bren...@bywatersolutions.co ||m --- Comment #17 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 Release. Thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12051] add renew tab to top on staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12051 Aleisha Amohia changed: What|Removed |Added Blocks||15706 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15706 [Bug 15706] Templates require circulate permissions to show circ related tabs when they should only require circulate_remaining_permissions -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12051] add renew tab to top on staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12051 --- Comment #16 from Kyle M Hall --- I have filed bug 15706 for the more systemic issue brought up by Jonathan. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12051] add renew tab to top on staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12051 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12051] add renew tab to top on staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12051 Kyle M Hall changed: What|Removed |Added Attachment #47454|0 |1 is obsolete|| --- Comment #15 from Kyle M Hall --- Created attachment 47476 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47476&action=edit Bug 12051: Adds a Renew tab to the staff client UPDATE: Added to checkin-search.inc to show up on returns.pl To test: 1) Apply patch 2) Confirm that there is now a Renew tab on the pages where there is also a Check-in tab only 3) Attempt to renew a book using this, confirm it works as expected 4) Check if I have missed any pages Signed-off-by: Marc Véron Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12051] add renew tab to top on staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12051 Kyle M Hall changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=15706 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12051] add renew tab to top on staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12051 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com --- Comment #14 from Kyle M Hall --- > I was going to pass QA on this patch, but I am wondering if the permission > should not be CAN_user_circulate_circulate_remaining_permissions instead of > CAN_user_circulate. Indeed the circ/renew.pl script needs only this subperm. I think the issue at hand is that this is really just repeating an existing bug. For instance, in cat-search.inc, the checkin box is wrapped with [% IF ( CAN_user_circulate ) %] yet a librarian with only CAN_user_circulate_circulate_remaining_permissions should be able to see the box, as checkins only require circulate_remaining_permissions. I would suggest we leave it the way it is for now for the sake of consistency and file a new bug to fix the issue globally. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12051] add renew tab to top on staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12051 --- Comment #13 from Jonathan Druart --- Aleisha, I have amended your patch to remove files where only 1 line where added/removed. I have also fixed a 3 vs 2: +++ b/koha-tmpl/intranet-tmpl/prog/en/includes/suggestions-add-search.inc @@ -23,10 +23,11 @@ [% END %] + Search suggestions [% IF ( CAN_user_circulate ) %]Check out[% END %] -[% IF ( CAN_user_catalogue ) %]Search the catalog[% END %] +[% IF ( CAN_user_catalogue ) %]Search the catalog[% END %] I was going to pass QA on this patch, but I am wondering if the permission should not be CAN_user_circulate_circulate_remaining_permissions instead of CAN_user_circulate. Indeed the circ/renew.pl script needs only this subperm. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12051] add renew tab to top on staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12051 Jonathan Druart changed: What|Removed |Added Attachment #47412|0 |1 is obsolete|| --- Comment #12 from Jonathan Druart --- Created attachment 47454 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47454&action=edit Bug 12051: Adds a Renew tab to the staff client UPDATE: Added to checkin-search.inc to show up on returns.pl To test: 1) Apply patch 2) Confirm that there is now a Renew tab on the pages where there is also a Check-in tab only 3) Attempt to renew a book using this, confirm it works as expected 4) Check if I have missed any pages Signed-off-by: Marc Véron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12051] add renew tab to top on staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12051 Marc Véron changed: What|Removed |Added Attachment #47406|0 |1 is obsolete|| --- Comment #11 from Marc Véron --- Created attachment 47412 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47412&action=edit Bug 12051: Adds a Renew tab to the staff client UPDATE: Added to checkin-search.inc to show up on returns.pl To test: 1) Apply patch 2) Confirm that there is now a Renew tab on the pages where there is also a Check-in tab only 3) Attempt to renew a book using this, confirm it works as expected 4) Check if I have missed any pages Signed-off-by: Marc Véron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12051] add renew tab to top on staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12051 Marc Véron changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12051] add renew tab to top on staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12051 Aleisha Amohia changed: What|Removed |Added Attachment #47362|0 |1 is obsolete|| --- Comment #10 from Aleisha Amohia --- Created attachment 47406 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47406&action=edit Bug 12051: Adds a Renew tab to the staff client UPDATE: Added to checkin-search.inc to show up on returns.pl To test: 1) Apply patch 2) Confirm that there is now a Renew tab on the pages where there is also a Check-in tab only 3) Attempt to renew a book using this, confirm it works as expected 4) Check if I have missed any pages -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12051] add renew tab to top on staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12051 Sally Healey changed: What|Removed |Added CC||sally.healey@cheshireshared ||services.gov.uk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12051] add renew tab to top on staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12051 --- Comment #9 from Marc Véron --- I think there is one more place where the renew tab would make sense: /cgi-bin/koha/circ/returns.pl Use case: A patron who wants to return some books and to renew some others at the same time. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12051] add renew tab to top on staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12051 Aleisha Amohia changed: What|Removed |Added Attachment #47361|0 |1 is obsolete|| --- Comment #8 from Aleisha Amohia --- Created attachment 47362 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47362&action=edit Bug 12051: Adds a Renew tab to the staff client To test: 1) Apply patch 2) Confirm that there is now a Renew tab on the pages where there is also a Check-in tab only 3) Attempt to renew a book using this, confirm it works as expected 4) Check if I have missed any pages Had to fix some numbering -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12051] add renew tab to top on staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12051 Aleisha Amohia changed: What|Removed |Added Attachment #47276|0 |1 is obsolete|| --- Comment #7 from Aleisha Amohia --- Created attachment 47361 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47361&action=edit Bug 12051: Adds a Renew tab to the staff client To test: 1) Apply patch 2) Confirm that there is now a Renew tab on the pages where there is also a Check-in tab only 3) Attempt to renew a book using this, confirm it works as expected 4) Check if I have missed any pages -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12051] add renew tab to top on staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12051 Aleisha Amohia changed: What|Removed |Added Status|In Discussion |Needs Signoff Patch complexity|Small patch |Large patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12051] add renew tab to top on staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12051 --- Comment #6 from Katrin Fischer --- +1 :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12051] add renew tab to top on staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12051 --- Comment #5 from Owen Leonard --- (In reply to Aleisha Amohia from comment #4) > I see what you mean. Perhaps only on the pages where there is also a > check-in tab? Since they also need the barcode for that? I agree with this. I think the presence of the check-in tab is a good indicator that the Renew tab fits. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12051] add renew tab to top on staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12051 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org Status|Signed Off |In Discussion -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12051] add renew tab to top on staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12051 --- Comment #4 from Aleisha Amohia --- (In reply to Katrin Fischer from comment #3) > I am not sure about adding the same tabs everywhere - it might get a bit > crowded up there. Renew doesn't seem to be used very often as it requires > you to have the items on hand to scan the barcodes. > > Hm, adding Owen for another opinion. I see what you mean. Perhaps only on the pages where there is also a check-in tab? Since they also need the barcode for that? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12051] add renew tab to top on staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12051 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de, ||oleon...@myacpl.org --- Comment #3 from Katrin Fischer --- I am not sure about adding the same tabs everywhere - it might get a bit crowded up there. Renew doesn't seem to be used very often as it requires you to have the items on hand to scan the barcodes. Hm, adding Owen for another opinion. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12051] add renew tab to top on staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12051 Marc Véron changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||ve...@veron.ch Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12051] add renew tab to top on staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12051 Marc Véron changed: What|Removed |Added Attachment #46847|0 |1 is obsolete|| --- Comment #2 from Marc Véron --- Created attachment 47276 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47276&action=edit Bug 12051: Adds a Renew tab to the staff client To test: 1) Apply patch 2) Confirm that there is now a Renew tab on every page 3) Attempt to renew a book using this, confirm it works as expected 4) Check if I have missed any pages Followed test plan, works as expected. Signed-off-by: Marc Véron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12051] add renew tab to top on staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12051 Marc Véron changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=15661 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12051] add renew tab to top on staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12051 Aleisha Amohia changed: What|Removed |Added CC||aleishaamo...@hotmail.com Assignee|oleon...@myacpl.org |aleishaamo...@hotmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12051] add renew tab to top on staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12051 Aleisha Amohia changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12051] add renew tab to top on staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12051 --- Comment #1 from Aleisha Amohia --- Created attachment 46847 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46847&action=edit Bug 12051: Adds a Renew tab to the staff client To test: 1) Apply patch 2) Confirm that there is now a Renew tab on every page 3) Attempt to renew a book using this, confirm it works as expected 4) Check if I have missed any pages -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12051] add renew tab to top on staff client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12051 Suzanne Fayle changed: What|Removed |Added CC||sfa...@roseman.edu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
