[Koha-bugs] [Bug 12302] OPAC course details not displaying item status correctly for itemtypes that are not for loan
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12302 Patrick Robitaille changed: What|Removed |Added CC||patrick.robitaille@collecto ||.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12302] OPAC course details not displaying item status correctly for itemtypes that are not for loan
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12302 --- Comment #12 from Katrin Fischer --- I've found 2 duplicate bugs for this one... usually a good sign that this is annoying to quite a lot of people - Kyle or Nick, could we get a reworked patch for this? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12302] OPAC course details not displaying item status correctly for itemtypes that are not for loan
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12302 Katrin Fischer changed: What|Removed |Added CC||car...@bywatersolutions.com --- Comment #11 from Katrin Fischer --- *** Bug 13693 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12302] OPAC course details not displaying item status correctly for itemtypes that are not for loan
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12302 Katrin Fischer changed: What|Removed |Added CC||marjorie.barry-vila@collect ||o.ca --- Comment #10 from Katrin Fischer --- *** Bug 11979 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12302] OPAC course details not displaying item status correctly for itemtypes that are not for loan
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12302 Myka Kennedy Stephens changed: What|Removed |Added CC||mkstephens@lancasterseminar ||y.edu --- Comment #9 from Myka Kennedy Stephens --- We're seeing these issues with "Not for loan (Ordered)" statuses not displaying in the course reserves OPAC view. I've added comments to bugs #11979 and #13693. These all seem to be interrelated and trying to address the same problem. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12302] OPAC course details not displaying item status correctly for itemtypes that are not for loan
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12302 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id= -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12302] OPAC course details not displaying item status correctly for itemtypes that are not for loan
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12302 Frédéric Demians frede...@tamil.fr changed: What|Removed |Added Depends on||13155 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12302] OPAC course details not displaying item status correctly for itemtypes that are not for loan
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12302 Frédéric Demians frede...@tamil.fr changed: What|Removed |Added Blocks||13155 Depends on|13155 | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12302] OPAC course details not displaying item status correctly for itemtypes that are not for loan
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12302 Frédéric Demians frede...@tamil.fr changed: What|Removed |Added CC||frede...@tamil.fr --- Comment #4 from Frédéric Demians frede...@tamil.fr --- *** Bug 13155 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12302] OPAC course details not displaying item status correctly for itemtypes that are not for loan
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12302 Frédéric Demians frede...@tamil.fr changed: What|Removed |Added Attachment #28403|0 |1 is obsolete|| --- Comment #5 from Frédéric Demians frede...@tamil.fr --- Created attachment 32851 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32851action=edit Bug 12302 - OPAC course details not displaying item status correctly for itemtypes that are not for loan If an item is not for loan based on it's itemtype, opac-detail.pl will show the item as Not for loan but opac-course-details.pl will show the item as Available. Test Plan: 1) Enable course reserves 2) Create a course, add an item to it 3) Edit that item's itemtype, set it to not for loan 4) View the item from opac-detail.pl, note the status is Not for loan 5) View the item from opac-course-details.pl, note the status is Available 6) Apply this patch 7) Reload opac-course-details.pl, not the status is now Not for loan Signed-off-by: Frederic Demians f.demi...@tamil.fr This is a revised version of the patch, introducing a invalid display on item table (see obsolete bug 13155). It works, and correct the bug described by Kyle. A 2nd sign-off may be necessrary. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12302] OPAC course details not displaying item status correctly for itemtypes that are not for loan
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12302 Frédéric Demians frede...@tamil.fr changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12302] OPAC course details not displaying item status correctly for itemtypes that are not for loan
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12302 --- Comment #6 from Frédéric Demians frede...@tamil.fr --- (In reply to Nick Clemens from comment #3) Hi Kyle, I tried testing, but after applying the patch I lose all info except availability and notes on opac-course-details.pl Item still shows as available as well Test the revised patch to confirm it works for you. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12302] OPAC course details not displaying item status correctly for itemtypes that are not for loan
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12302 Nick Clemens n...@quecheelibrary.org changed: What|Removed |Added Attachment #32851|0 |1 is obsolete|| --- Comment #7 from Nick Clemens n...@quecheelibrary.org --- Created attachment 32852 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32852action=edit [SIGNED OFF] Bug 12302 - OPAC course details not displaying item status correctly for itemtypes that are not for loan If an item is not for loan based on it's itemtype, opac-detail.pl will show the item as Not for loan but opac-course-details.pl will show the item as Available. Test Plan: 1) Enable course reserves 2) Create a course, add an item to it 3) Edit that item's itemtype, set it to not for loan 4) View the item from opac-detail.pl, note the status is Not for loan 5) View the item from opac-course-details.pl, note the status is Available 6) Apply this patch 7) Reload opac-course-details.pl, not the status is now Not for loan Signed-off-by: Frederic Demians f.demi...@tamil.fr This is a revised version of the patch, introducing a invalid display on item table (see obsolete bug 13155). It works, and correct the bug described by Kyle. A 2nd sign-off may be necessrary. Signed-off-by: Nick Clemens n...@quecheelibrary.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12302] OPAC course details not displaying item status correctly for itemtypes that are not for loan
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12302 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Failed QA CC||katrin.fisc...@bsz-bw.de --- Comment #8 from Katrin Fischer katrin.fisc...@bsz-bw.de --- This patch works, but I see 2 problems: - It only checks for the notforloan on the itemtype, but not for the notforloan in the item record itself. We should check both to match the behaviour on the result list and in other places. - The change in GetBiblioFromItemnumber should be backed up by unit tests. Failing for the second, but the first should be fixed here or separately to have a more complete fix. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12302] OPAC course details not displaying item status correctly for itemtypes that are not for loan
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12302 Nick Clemens n...@quecheelibrary.org changed: What|Removed |Added CC||n...@quecheelibrary.org --- Comment #3 from Nick Clemens n...@quecheelibrary.org --- Hi Kyle, I tried testing, but after applying the patch I lose all info except availability and notes on opac-course-details.pl Item still shows as available as well -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12302] OPAC course details not displaying item status correctly for itemtypes that are not for loan
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12302 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12302] OPAC course details not displaying item status correctly for itemtypes that are not for loan
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12302 --- Comment #1 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 28402 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28402action=edit Bug 12302 - OPAC course details not displaying item status correctly for itemtypes that are not for loan If an item is not for loan based on it's itemtype, opac-detail.pl will show the item as Not for loan but opac-course-details.pl will show the item as Available. Test Plan: 1) Enable course reserves 2) Create a course, add an item to it 3) Edit that item's itemtype, set it to not for loan 4) View the item from opac-detail.pl, note the status is Not for loan 5) View the item from opac-course-details.pl, note the status is Available 6) Apply this patch 7) Reload opac-course-details.pl, not the status is now Not for loan -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12302] OPAC course details not displaying item status correctly for itemtypes that are not for loan
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12302 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Assignee|oleon...@myacpl.org |k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12302] OPAC course details not displaying item status correctly for itemtypes that are not for loan
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12302 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #28402|0 |1 is obsolete|| --- Comment #2 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 28403 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28403action=edit Bug 12302 - OPAC course details not displaying item status correctly for itemtypes that are not for loan If an item is not for loan based on it's itemtype, opac-detail.pl will show the item as Not for loan but opac-course-details.pl will show the item as Available. Test Plan: 1) Enable course reserves 2) Create a course, add an item to it 3) Edit that item's itemtype, set it to not for loan 4) View the item from opac-detail.pl, note the status is Not for loan 5) View the item from opac-course-details.pl, note the status is Available 6) Apply this patch 7) Reload opac-course-details.pl, not the status is now Not for loan -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
