[Koha-bugs] [Bug 12307] Catalog details page displaying incorrect status for items with itemtype level notforloan status

2014-07-11 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12307

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||tomasco...@gmail.com

--- Comment #7 from Tomás Cohen Arazi tomasco...@gmail.com ---
Patch pushed to master.

Thanks Brendan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12307] Catalog details page displaying incorrect status for items with itemtype level notforloan status

2014-07-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12307

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

  Attachment #29491|0   |1
is obsolete||

--- Comment #6 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 29527
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29527action=edit
[PASSED QA] Bug 12307 - Catalog details page displaying incorrect status for
items with itemtype level notforloan status

The template markup that controls that status column for
the items table in catalogue/detail.pl does not account
for the itemtypes.notforloan flag.

Test Plan:
1) Find an item that is currently available
2) Go to the itemtype editor and mark that itemtype of that item
   as being not for loan
3) Browse to the catalog details page for that item's record
4) Note the item status is still Available
5) Apply this patch
6) Reload the catalog details page
7) Note the item status is now Not for loan

Signed-off-by: Nick Clemens n...@quecheelibrary.org
Signed-off-by: Katrin Fischer katrin.fischer...@web.de
Good catch! Works as described, no problems found.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12307] Catalog details page displaying incorrect status for items with itemtype level notforloan status

2014-07-06 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12307

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12307] Catalog details page displaying incorrect status for items with itemtype level notforloan status

2014-07-03 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12307

--- Comment #5 from Nick Clemens n...@quecheelibrary.org ---
Created attachment 29491
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29491action=edit
[SIGNED OFF] Bug 12307 - Catalog details page displaying incorrect status for
items with itemtype level notforloan status

The template markup that controls that status column for
the items table in catalogue/detail.pl does not account
for the itemtypes.notforloan flag.

Test Plan:
1) Find an item that is currently available
2) Go to the itemtype editor and mark that itemtype of that item
   as being not for loan
3) Browse to the catalog details page for that item's record
4) Note the item status is still Available
5) Apply this patch
6) Reload the catalog details page
7) Note the item status is now Not for loan

Signed-off-by: Nick Clemens n...@quecheelibrary.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12307] Catalog details page displaying incorrect status for items with itemtype level notforloan status

2014-07-03 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12307

Nick Clemens n...@quecheelibrary.org changed:

   What|Removed |Added

  Attachment #28420|0   |1
is obsolete||
 CC||n...@quecheelibrary.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12307] Catalog details page displaying incorrect status for items with itemtype level notforloan status

2014-07-03 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12307

Nick Clemens n...@quecheelibrary.org changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12307] Catalog details page displaying incorrect status for items with itemtype level notforloan status

2014-06-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12307

Koha Team Lyon 3 k...@univ-lyon3.fr changed:

   What|Removed |Added

 CC||k...@univ-lyon3.fr

--- Comment #3 from Koha Team Lyon 3 k...@univ-lyon3.fr ---
We didn't understand the bug to be fixed, we could not manage to see the bug on
the master version  in english, we give up. The bug should be explained with
more details.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12307] Catalog details page displaying incorrect status for items with itemtype level notforloan status

2014-06-19 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12307

--- Comment #4 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to Koha Team Lyon 3 from comment #3)
 We didn't understand the bug to be fixed, we could not manage to see the bug
 on the master version  in english, we give up. The bug should be explained
 with more details.

See with Lyon 3, the item-level_itypes pref should be set to item specific.
They use biblio record, so they won't test this patch.

But no regression found for biblio level :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12307] Catalog details page displaying incorrect status for items with itemtype level notforloan status

2014-06-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12307

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 CC||jonathan.dru...@biblibre.co
   ||m
   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=12419

--- Comment #2 from Jonathan Druart jonathan.dru...@biblibre.com ---
This looks similar than bug 12419 (but not the same view).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12307] Catalog details page displaying incorrect status for items with itemtype level notforloan status

2014-06-18 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12307

Marjorie Barry-Vila marjorie.barry-v...@ccsr.qc.ca changed:

   What|Removed |Added

 CC||marjorie.barry-v...@ccsr.qc
   ||.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12307] Catalog details page displaying incorrect status for items with itemtype level notforloan status

2014-05-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12307

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12307] Catalog details page displaying incorrect status for items with itemtype level notforloan status

2014-05-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12307

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 12307] Catalog details page displaying incorrect status for items with itemtype level notforloan status

2014-05-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12307

--- Comment #1 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 28420
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28420action=edit
Bug 12307 - Catalog details page displaying incorrect status for items with
itemtype level notforloan status

The template markup that controls that status column for
the items table in catalogue/detail.pl does not account
for the itemtypes.notforloan flag.

Test Plan:
1) Find an item that is currently available
2) Go to the itemtype editor and mark that itemtype of that item
   as being not for loan
3) Browse to the catalog details page for that item's record
4) Note the item status is still Available
5) Apply this patch
6) Reload the catalog details page
7) Note the item status is now Not for loan

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/