[Koha-bugs] [Bug 12395] Save order line's creator

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

Martin Renvoize  changed:

   What|Removed |Added

   Keywords|release-notes-needed|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12395] Save order line's creator

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

Fridolin SOMERS  changed:

   What|Removed |Added

 Blocks||22642


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22642
[Bug 22642] DB upgrade 18.06.00.005 can fail
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12395] Save order line's creator

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

Martin Renvoize  changed:

   What|Removed |Added

  Text to go in the||Allowing finer grained
  release notes||auditing of acquisition
   ||orders.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12395] Save order line's creator

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

Martin Renvoize  changed:

   What|Removed |Added

  Text to go in the|Allowing finer grained  |Allow finer grained
  release notes|auditing of acquisition |auditing of acquisition
   |orders. |orders.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12395] Save order line's creator

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

Martin Renvoize  changed:

   What|Removed |Added

   Keywords||release-notes-needed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12395] Save order line's creator

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||21129


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21129
[Bug 21129] New ALTER IGNORE TABLE entries need correction in updatedatabase.pl
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12395] Save order line's creator

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

Martin Renvoize  changed:

   What|Removed |Added

 Status|Pushed to Master|RESOLVED
 CC||martin.renvoize@ptfs-europe
   ||.com
 Resolution|--- |FIXED

--- Comment #145 from Martin Renvoize  ---
Nice enhancement, not backporting to 18.05.x series.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12395] Save order line's creator

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com
 Status|Passed QA   |Pushed to Master

--- Comment #144 from Nick Clemens  ---
Awesome work all!

Pushed to master for 18.11

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12395] Save order line's creator

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 CC||victor.grous...@biblibre.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12395] Save order line's creator

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

--- Comment #142 from Jonathan Druart  
---
Created attachment 76088
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76088=edit
Bug 12395: (QA follow-up) Change wording for consistency and fix use CGI;

Signed-off-by: Julian Maurice 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12395] Save order line's creator

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

--- Comment #143 from Jonathan Druart  
---
Created attachment 76089
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76089=edit
Bug 12395: Add FK constraint and use patron-title.inc

Signed-off-by: Julian Maurice 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12395] Save order line's creator

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

--- Comment #141 from Jonathan Druart  
---
Created attachment 76087
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76087=edit
Bug 12395: Use standard  +  markup for showorder.tt

Signed-off-by: Séverine QUEUNE 

Signed-off-by: Katrin Fischer 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12395] Save order line's creator

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

--- Comment #139 from Jonathan Druart  
---
Created attachment 76085
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76085=edit
Bug 12395: Make received orders table consistent with pending orders table

(links of More column)

Also change "Created by" with "Ordered by" in receive page.

Signed-off-by: Séverine QUEUNE 

Signed-off-by: Katrin Fischer 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12395] Save order line's creator

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

--- Comment #140 from Jonathan Druart  
---
Created attachment 76086
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76086=edit
Bug 12395: (QA follow-up) Add class/id to body tag

Signed-off-by: Séverine QUEUNE 

Signed-off-by: Katrin Fischer 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12395] Save order line's creator

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

--- Comment #138 from Jonathan Druart  
---
Created attachment 76084
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76084=edit
Bug 12395: Display created_by even if firstname is missing on receiving

On receiving orders, "no name" was displayed if the firstname of creator
was not filled.
The surname should be displayed.

Signed-off-by: Paola Rossi 
Signed-off-by: Séverine QUEUNE 

Signed-off-by: Katrin Fischer 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12395] Save order line's creator

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

--- Comment #137 from Jonathan Druart  
---
Created attachment 76083
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76083=edit
Bug 12395: Add unit test to check created_by is correctly set

Signed-off-by: Paola Rossi 
Signed-off-by: Séverine QUEUNE 

Signed-off-by: Katrin Fischer 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12395] Save order line's creator

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

--- Comment #135 from Jonathan Druart  
---
Forgot the signed-off-by line, reattaching...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12395] Save order line's creator

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #76074|0   |1
is obsolete||
  Attachment #76075|0   |1
is obsolete||
  Attachment #76076|0   |1
is obsolete||
  Attachment #76077|0   |1
is obsolete||
  Attachment #76078|0   |1
is obsolete||
  Attachment #76079|0   |1
is obsolete||
  Attachment #76080|0   |1
is obsolete||
  Attachment #76081|0   |1
is obsolete||

--- Comment #136 from Jonathan Druart  
---
Created attachment 76082
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76082=edit
Bug 12395: Save order line's creator

New MySQL column: aqorders.createdby

Creator's name is displayed on order's receive pages (acqui/orderreceive.pl
and acqui/parcel.pl)

On acqui/orderreceive.pl it replace the name of basket's creator
On acqui/parcel.pl, to avoid adding more data in the table of pending
orders, it is shown in a popup like MARC and Card views

Test plan:
1/ Run updatedatabase.pl
2/ Create a new order and go to the receipt page (acqui/parcel.pl)
3/ Click on "Order" link in column "More" (previously "View record")
4/ A javascript popup should appear with your name in it. Close the
popup.
5/ Click on "Receive" link
6/ Your name should appear in front of "Created by" label, to the right
of the page.

Patch updated with use of atomic update.

Signed-off-by: Séverine QUEUNE 

Signed-off-by: Katrin Fischer 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12395] Save order line's creator

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

--- Comment #134 from Jonathan Druart  
---
(In reply to Julian Maurice from comment #125)
> (In reply to Jonathan Druart from comment #124)
> > (In reply to Jonathan Druart from comment #113)
> > >   Bug 12395: Save order line's creator
> > > reverts bug 20303
> > 
> > This one is still missing I think.
> 
> These changes are intended. orderreceive.pl doesn't use
> aqbaskets.authorisedby anymore (with those patches applied)

Indeed! I have tested to delete the account of the creator and receive an order
and it seems ok.

The screen displays "Ordered by: " and nothing in front. Maybe we could add
something to explain why it's empty.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12395] Save order line's creator

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

--- Comment #133 from Jonathan Druart  
---
Created attachment 76081
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76081=edit
Bug 12395: Add FK constraint and use patron-title.inc

Signed-off-by: Julian Maurice 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12395] Save order line's creator

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

--- Comment #132 from Jonathan Druart  
---
Created attachment 76080
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76080=edit
Bug 12395: (QA follow-up) Change wording for consistency and fix use CGI;

Signed-off-by: Julian Maurice 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12395] Save order line's creator

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

--- Comment #131 from Jonathan Druart  
---
Created attachment 76079
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76079=edit
Bug 12395: Use standard  +  markup for showorder.tt

Signed-off-by: Séverine QUEUNE 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12395] Save order line's creator

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

--- Comment #130 from Jonathan Druart  
---
Created attachment 76078
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76078=edit
Bug 12395: (QA follow-up) Add class/id to body tag

Signed-off-by: Séverine QUEUNE 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12395] Save order line's creator

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

--- Comment #128 from Jonathan Druart  
---
Created attachment 76076
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76076=edit
Bug 12395: Display created_by even if firstname is missing on receiving

On receiving orders, "no name" was displayed if the firstname of creator
was not filled.
The surname should be displayed.

Signed-off-by: Paola Rossi 
Signed-off-by: Séverine QUEUNE 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12395] Save order line's creator

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

--- Comment #129 from Jonathan Druart  
---
Created attachment 76077
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76077=edit
Bug 12395: Make received orders table consistent with pending orders table

(links of More column)

Also change "Created by" with "Ordered by" in receive page.

Signed-off-by: Séverine QUEUNE 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12395] Save order line's creator

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

--- Comment #127 from Jonathan Druart  
---
Created attachment 76075
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76075=edit
Bug 12395: Add unit test to check created_by is correctly set

Signed-off-by: Paola Rossi 
Signed-off-by: Séverine QUEUNE 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12395] Save order line's creator

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #75900|0   |1
is obsolete||
  Attachment #75901|0   |1
is obsolete||
  Attachment #75902|0   |1
is obsolete||
  Attachment #75903|0   |1
is obsolete||
  Attachment #75904|0   |1
is obsolete||
  Attachment #75905|0   |1
is obsolete||
  Attachment #75906|0   |1
is obsolete||
  Attachment #75907|0   |1
is obsolete||

--- Comment #126 from Jonathan Druart  
---
Created attachment 76074
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76074=edit
Bug 12395: Save order line's creator

New MySQL column: aqorders.createdby

Creator's name is displayed on order's receive pages (acqui/orderreceive.pl
and acqui/parcel.pl)

On acqui/orderreceive.pl it replace the name of basket's creator
On acqui/parcel.pl, to avoid adding more data in the table of pending
orders, it is shown in a popup like MARC and Card views

Test plan:
1/ Run updatedatabase.pl
2/ Create a new order and go to the receipt page (acqui/parcel.pl)
3/ Click on "Order" link in column "More" (previously "View record")
4/ A javascript popup should appear with your name in it. Close the
popup.
5/ Click on "Receive" link
6/ Your name should appear in front of "Created by" label, to the right
of the page.

Patch updated with use of atomic update.

Signed-off-by: Séverine QUEUNE 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12395] Save order line's creator

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12395] Save order line's creator

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

--- Comment #125 from Julian Maurice  ---
(In reply to Jonathan Druart from comment #124)
> (In reply to Jonathan Druart from comment #113)
> >   Bug 12395: Save order line's creator
> > reverts bug 20303
> 
> This one is still missing I think.

These changes are intended. orderreceive.pl doesn't use aqbaskets.authorisedby
anymore (with those patches applied)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12395] Save order line's creator

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

--- Comment #124 from Jonathan Druart  
---
(In reply to Jonathan Druart from comment #113)
>   Bug 12395: Save order line's creator
> reverts bug 20303

This one is still missing I think.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12395] Save order line's creator

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

Julian Maurice  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

--- Comment #123 from Julian Maurice  ---
(In reply to Jonathan Druart from comment #114)
> 2. Why not a foreign key on aqorders.created_by (with on delete set null)?
> 
> 3. orderreceive.tt and showorder.tt must use patron-title.inc

Fixed in the last patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12395] Save order line's creator

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

--- Comment #122 from Julian Maurice  ---
Created attachment 75907
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75907=edit
Bug 12395: Add FK constraint and use patron-title.inc

Signed-off-by: Julian Maurice 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12395] Save order line's creator

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

Julian Maurice  changed:

   What|Removed |Added

  Attachment #74281|0   |1
is obsolete||

--- Comment #120 from Julian Maurice  ---
Created attachment 75905
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75905=edit
Bug 12395: Use standard  +  markup for showorder.tt

Signed-off-by: Séverine QUEUNE 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12395] Save order line's creator

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

Julian Maurice  changed:

   What|Removed |Added

  Attachment #74280|0   |1
is obsolete||

--- Comment #119 from Julian Maurice  ---
Created attachment 75904
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75904=edit
Bug 12395: QA follow-up - Add class/id to body tag

Signed-off-by: Séverine QUEUNE 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12395] Save order line's creator

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

Julian Maurice  changed:

   What|Removed |Added

  Attachment #74279|0   |1
is obsolete||

--- Comment #118 from Julian Maurice  ---
Created attachment 75903
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75903=edit
Bug 12395: Make received orders table consistent with pending orders table

(links of More column)

Also change "Created by" with "Ordered by" in receive page.

Signed-off-by: Séverine QUEUNE 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12395] Save order line's creator

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

Julian Maurice  changed:

   What|Removed |Added

  Attachment #74278|0   |1
is obsolete||

--- Comment #117 from Julian Maurice  ---
Created attachment 75902
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75902=edit
Bug 12395: Display created_by even if firstname is missing on receiving

On receiving orders, "no name" was displayed if the firstname of creator
was not filled.
The surname should be displayed.

Signed-off-by: Paola Rossi 
Signed-off-by: Séverine QUEUNE 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12395] Save order line's creator

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

Julian Maurice  changed:

   What|Removed |Added

  Attachment #74282|0   |1
is obsolete||

--- Comment #121 from Julian Maurice  ---
Created attachment 75906
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75906=edit
Bug 12395: (QA follow-up) Change wording for consistency and fix use CGI;

Signed-off-by: Julian Maurice 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12395] Save order line's creator

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

Julian Maurice  changed:

   What|Removed |Added

  Attachment #74277|0   |1
is obsolete||

--- Comment #116 from Julian Maurice  ---
Created attachment 75901
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75901=edit
Bug 12395: Add unit test to check created_by is correctly set

Signed-off-by: Paola Rossi 
Signed-off-by: Séverine QUEUNE 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12395] Save order line's creator

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

Julian Maurice  changed:

   What|Removed |Added

  Attachment #74276|0   |1
is obsolete||

--- Comment #115 from Julian Maurice  ---
Created attachment 75900
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75900=edit
Bug 12395: Save order line's creator

New MySQL column: aqorders.createdby

Creator's name is displayed on order's receive pages (acqui/orderreceive.pl
and acqui/parcel.pl)

On acqui/orderreceive.pl it replace the name of basket's creator
On acqui/parcel.pl, to avoid adding more data in the table of pending
orders, it is shown in a popup like MARC and Card views

Test plan:
1/ Run updatedatabase.pl
2/ Create a new order and go to the receipt page (acqui/parcel.pl)
3/ Click on "Order" link in column "More" (previously "View record")
4/ A javascript popup should appear with your name in it. Close the
popup.
5/ Click on "Receive" link
6/ Your name should appear in front of "Created by" label, to the right
of the page.

Patch updated with use of atomic update.

Signed-off-by: Séverine QUEUNE 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12395] Save order line's creator

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

--- Comment #114 from Jonathan Druart  
---
2. Why not a foreign key on aqorders.created_by (with on delete set null)?

3. orderreceive.tt and showorder.tt must use patron-title.inc

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12395] Save order line's creator

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Failed QA

--- Comment #113 from Jonathan Druart  
---
  Bug 12395: Save order line's creator
reverts bug 20303

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12395] Save order line's creator

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

--- Comment #112 from Katrin Fischer  ---
Created attachment 74282
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74282=edit
Bug 12395: (QA follow-up) Change wording for consistency and fix use CGI;

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12395] Save order line's creator

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #74211|0   |1
is obsolete||

--- Comment #110 from Katrin Fischer  ---
Created attachment 74280
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74280=edit
Bug 12395: QA follow-up - Add class/id to body tag

Signed-off-by: Séverine QUEUNE 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12395] Save order line's creator

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #74212|0   |1
is obsolete||

--- Comment #111 from Katrin Fischer  ---
Created attachment 74281
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74281=edit
Bug 12395: Use standard  +  markup for showorder.tt

Signed-off-by: Séverine QUEUNE 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12395] Save order line's creator

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #74210|0   |1
is obsolete||

--- Comment #109 from Katrin Fischer  ---
Created attachment 74279
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74279=edit
Bug 12395: Make received orders table consistent with pending orders table

(links of More column)

Also change "Created by" with "Ordered by" in receive page.

Signed-off-by: Séverine QUEUNE 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12395] Save order line's creator

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #74207|0   |1
is obsolete||

--- Comment #106 from Katrin Fischer  ---
Created attachment 74276
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74276=edit
Bug 12395: Save order line's creator

New MySQL column: aqorders.createdby

Creator's name is displayed on order's receive pages (acqui/orderreceive.pl
and acqui/parcel.pl)

On acqui/orderreceive.pl it replace the name of basket's creator
On acqui/parcel.pl, to avoid adding more data in the table of pending
orders, it is shown in a popup like MARC and Card views

Test plan:
1/ Run updatedatabase.pl
2/ Create a new order and go to the receipt page (acqui/parcel.pl)
3/ Click on "Order" link in column "More" (previously "View record")
4/ A javascript popup should appear with your name in it. Close the
popup.
5/ Click on "Receive" link
6/ Your name should appear in front of "Created by" label, to the right
of the page.

Patch updated with use of atomic update.

Signed-off-by: Séverine QUEUNE 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12395] Save order line's creator

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #74208|0   |1
is obsolete||

--- Comment #107 from Katrin Fischer  ---
Created attachment 74277
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74277=edit
Bug 12395: Add unit test to check created_by is correctly set

Signed-off-by: Paola Rossi 
Signed-off-by: Séverine QUEUNE 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12395] Save order line's creator

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #74209|0   |1
is obsolete||

--- Comment #108 from Katrin Fischer  ---
Created attachment 74278
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74278=edit
Bug 12395: Display created_by even if firstname is missing on receiving

On receiving orders, "no name" was displayed if the firstname of creator
was not filled.
The surname should be displayed.

Signed-off-by: Paola Rossi 
Signed-off-by: Séverine QUEUNE 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12395] Save order line's creator

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #105 from Katrin Fischer  ---
1) Should showorder.pl, I think it should be:
use CGI qw ( -utf8 );

2) I was wondering why the order lines creator didn't show on
/cgi-bin/koha/acqui/basket.pl?basketno=1. Neither does it when editing an order
line. Maybe a follow-up (separate bug?)

3) Make both 'Order' information and orderreceive.pl use 'Ordered by'.

Nothing else. I'll fix 1) and 3) in a follow-up. Please check!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12395] Save order line's creator

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

Julian Maurice  changed:

   What|Removed |Added

  Attachment #72724|0   |1
is obsolete||

--- Comment #102 from Julian Maurice  ---
Created attachment 74211
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74211=edit
Bug 12395: QA follow-up - Add class/id to body tag

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12395] Save order line's creator

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

Julian Maurice  changed:

   What|Removed |Added

  Attachment #72725|0   |1
is obsolete||

--- Comment #103 from Julian Maurice  ---
Created attachment 74212
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74212=edit
Bug 12395: Use standard  +  markup for showorder.tt

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12395] Save order line's creator

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

Julian Maurice  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

--- Comment #104 from Julian Maurice  ---
Patches rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12395] Save order line's creator

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

Julian Maurice  changed:

   What|Removed |Added

  Attachment #72720|0   |1
is obsolete||

--- Comment #98 from Julian Maurice  ---
Created attachment 74207
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74207=edit
Bug 12395: Save order line's creator

New MySQL column: aqorders.createdby

Creator's name is displayed on order's receive pages (acqui/orderreceive.pl
and acqui/parcel.pl)

On acqui/orderreceive.pl it replace the name of basket's creator
On acqui/parcel.pl, to avoid adding more data in the table of pending
orders, it is shown in a popup like MARC and Card views

Test plan:
1/ Run updatedatabase.pl
2/ Create a new order and go to the receipt page (acqui/parcel.pl)
3/ Click on "Order" link in column "More" (previously "View record")
4/ A javascript popup should appear with your name in it. Close the
popup.
5/ Click on "Receive" link
6/ Your name should appear in front of "Created by" label, to the right
of the page.

Patch updated with use of atomic update.

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12395] Save order line's creator

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

Julian Maurice  changed:

   What|Removed |Added

  Attachment #72723|0   |1
is obsolete||

--- Comment #101 from Julian Maurice  ---
Created attachment 74210
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74210=edit
Bug 12395: Make received orders table consistent with pending orders table

(links of More column)

Also change "Created by" with "Ordered by" in receive page.

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12395] Save order line's creator

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

Julian Maurice  changed:

   What|Removed |Added

  Attachment #72722|0   |1
is obsolete||

--- Comment #100 from Julian Maurice  ---
Created attachment 74209
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74209=edit
Bug 12395: Display created_by even if firstname is missing on receiving

On receiving orders, "no name" was displayed if the firstname of creator
was not filled.
The surname should be displayed.

Signed-off-by: Paola Rossi 
Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12395] Save order line's creator

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

Julian Maurice  changed:

   What|Removed |Added

  Attachment #72721|0   |1
is obsolete||

--- Comment #99 from Julian Maurice  ---
Created attachment 74208
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74208=edit
Bug 12395: Add unit test to check created_by is correctly set

Signed-off-by: Paola Rossi 
Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12395] Save order line's creator

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Patch doesn't apply

--- Comment #97 from Katrin Fischer  ---
Patch doesn't apply, please rebase and check for changes needed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12395] Save order line's creator

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

Séverine Queune  changed:

   What|Removed |Added

  Attachment #71349|0   |1
is obsolete||

--- Comment #96 from Séverine Queune  ---
Created attachment 72725
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72725=edit
Bug 12395: Use standard  +  markup for showorder.tt

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12395] Save order line's creator

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

Séverine Queune  changed:

   What|Removed |Added

  Attachment #71347|0   |1
is obsolete||

--- Comment #94 from Séverine Queune  ---
Created attachment 72723
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72723=edit
Bug 12395: Make received orders table consistent with pending orders table

(links of More column)

Also change "Created by" with "Ordered by" in receive page.

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12395] Save order line's creator

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

Séverine Queune  changed:

   What|Removed |Added

  Attachment #71348|0   |1
is obsolete||

--- Comment #95 from Séverine Queune  ---
Created attachment 72724
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72724=edit
Bug 12395: QA follow-up - Add class/id to body tag

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12395] Save order line's creator

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

Séverine Queune  changed:

   What|Removed |Added

  Attachment #71346|0   |1
is obsolete||

--- Comment #93 from Séverine Queune  ---
Created attachment 72722
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72722=edit
Bug 12395: Display created_by even if firstname is missing on receiving

On receiving orders, "no name" was displayed if the firstname of creator
was not filled.
The surname should be displayed.

Signed-off-by: Paola Rossi 
Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12395] Save order line's creator

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

Séverine Queune  changed:

   What|Removed |Added

  Attachment #71344|0   |1
is obsolete||

--- Comment #91 from Séverine Queune  ---
Created attachment 72720
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72720=edit
Bug 12395: Save order line's creator

New MySQL column: aqorders.createdby

Creator's name is displayed on order's receive pages (acqui/orderreceive.pl
and acqui/parcel.pl)

On acqui/orderreceive.pl it replace the name of basket's creator
On acqui/parcel.pl, to avoid adding more data in the table of pending
orders, it is shown in a popup like MARC and Card views

Test plan:
1/ Run updatedatabase.pl
2/ Create a new order and go to the receipt page (acqui/parcel.pl)
3/ Click on "Order" link in column "More" (previously "View record")
4/ A javascript popup should appear with your name in it. Close the
popup.
5/ Click on "Receive" link
6/ Your name should appear in front of "Created by" label, to the right
of the page.

Patch updated with use of atomic update.

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12395] Save order line's creator

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

Séverine Queune  changed:

   What|Removed |Added

  Attachment #71345|0   |1
is obsolete||

--- Comment #92 from Séverine Queune  ---
Created attachment 72721
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72721=edit
Bug 12395: Add unit test to check created_by is correctly set

Signed-off-by: Paola Rossi 
Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12395] Save order line's creator

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

Séverine Queune  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12395] Save order line's creator

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

Julian Maurice  changed:

   What|Removed |Added

  Attachment #58750|0   |1
is obsolete||

--- Comment #89 from Julian Maurice  ---
Created attachment 71349
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71349=edit
Bug 12395: Use standard  +  markup for showorder.tt

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12395] Save order line's creator

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

Julian Maurice  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #90 from Julian Maurice  ---
Patches rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12395] Save order line's creator

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

Julian Maurice  changed:

   What|Removed |Added

  Attachment #58747|0   |1
is obsolete||

--- Comment #86 from Julian Maurice  ---
Created attachment 71346
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71346=edit
Bug 12395: Display created_by even if firstname is missing on receiving

On receiving orders, "no name" was displayed if the firstname of creator
was not filled.
The surname should be displayed.

Signed-off-by: Paola Rossi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12395] Save order line's creator

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

Julian Maurice  changed:

   What|Removed |Added

  Attachment #58749|0   |1
is obsolete||

--- Comment #88 from Julian Maurice  ---
Created attachment 71348
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71348=edit
Bug 12395: QA follow-up - Add class/id to body tag

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12395] Save order line's creator

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

Julian Maurice  changed:

   What|Removed |Added

  Attachment #58748|0   |1
is obsolete||

--- Comment #87 from Julian Maurice  ---
Created attachment 71347
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71347=edit
Bug 12395: Make received orders table consistent with pending orders table

(links of More column)

Also change "Created by" with "Ordered by" in receive page.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12395] Save order line's creator

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

Julian Maurice  changed:

   What|Removed |Added

  Attachment #58745|0   |1
is obsolete||

--- Comment #84 from Julian Maurice  ---
Created attachment 71344
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71344=edit
Bug 12395: Save order line's creator

New MySQL column: aqorders.createdby

Creator's name is displayed on order's receive pages (acqui/orderreceive.pl
and acqui/parcel.pl)

On acqui/orderreceive.pl it replace the name of basket's creator
On acqui/parcel.pl, to avoid adding more data in the table of pending
orders, it is shown in a popup like MARC and Card views

Test plan:
1/ Run updatedatabase.pl
2/ Create a new order and go to the receipt page (acqui/parcel.pl)
3/ Click on "Order" link in column "More" (previously "View record")
4/ A javascript popup should appear with your name in it. Close the
popup.
5/ Click on "Receive" link
6/ Your name should appear in front of "Created by" label, to the right
of the page.

Patch updated with use of atomic update.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12395] Save order line's creator

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

Julian Maurice  changed:

   What|Removed |Added

  Attachment #58746|0   |1
is obsolete||

--- Comment #85 from Julian Maurice  ---
Created attachment 71345
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71345=edit
Bug 12395: Add unit test to check created_by is correctly set

Signed-off-by: Paola Rossi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12395] Save order line's creator

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

jmbroust  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #83 from jmbroust  ---
Tested on sandbox biblibre 5 : 
The name is never printed at :

http://pro.user05-koha.sandbox.biblibre.eu/cgi-bin/koha/acqui/orderreceive.pl?ordernumber=8=2
(receiving order)

nor at : 
http://pro.user05-koha.sandbox.biblibre.eu/cgi-bin/koha/acqui/parcel.pl?invoiceid=3
(pop up when click on more > order)

Please, see screenshots attached.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12395] Save order line's creator

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

--- Comment #82 from jmbroust  ---
Created attachment 61384
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61384=edit
no name when receving

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12395] Save order line's creator

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

jmbroust  changed:

   What|Removed |Added

 CC||jean-manuel.broust@univ-lyo
   ||n2.fr

--- Comment #81 from jmbroust  ---
Created attachment 61383
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61383=edit
column more > order

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12395] Save order line's creator

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

Julian Maurice  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #80 from Julian Maurice  ---
Rebased on master.

Bug 16592 already added the bootstrap modal to the parcel.pl page so I removed
the related code from this bug's patches.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12395] Save order line's creator

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

Julian Maurice  changed:

   What|Removed |Added

  Attachment #40138|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12395] Save order line's creator

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

Julian Maurice  changed:

   What|Removed |Added

  Attachment #45387|0   |1
is obsolete||

--- Comment #79 from Julian Maurice  ---
Created attachment 58750
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58750=edit
Bug 12395: Use standard  +  markup for showorder.tt

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12395] Save order line's creator

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

Julian Maurice  changed:

   What|Removed |Added

  Attachment #43951|0   |1
is obsolete||

--- Comment #78 from Julian Maurice  ---
Created attachment 58749
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58749=edit
Bug 12395: QA follow-up - Add class/id to body tag

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12395] Save order line's creator

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

Julian Maurice  changed:

   What|Removed |Added

  Attachment #40161|0   |1
is obsolete||

--- Comment #77 from Julian Maurice  ---
Created attachment 58748
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58748=edit
Bug 12395: Make received orders table consistent with pending orders table

(links of More column)

Also change "Created by" with "Ordered by" in receive page.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12395] Save order line's creator

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

Julian Maurice  changed:

   What|Removed |Added

  Attachment #40139|0   |1
is obsolete||

--- Comment #76 from Julian Maurice  ---
Created attachment 58747
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58747=edit
Bug 12395: Display created_by even if firstname is missing on receiving

On receiving orders, "no name" was displayed if the firstname of creator
was not filled.
The surname should be displayed.

Signed-off-by: Paola Rossi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12395] Save order line's creator

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

Julian Maurice  changed:

   What|Removed |Added

  Attachment #40136|0   |1
is obsolete||

--- Comment #74 from Julian Maurice  ---
Created attachment 58745
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58745=edit
Bug 12395: Save order line's creator

New MySQL column: aqorders.createdby

Creator's name is displayed on order's receive pages (acqui/orderreceive.pl
and acqui/parcel.pl)

On acqui/orderreceive.pl it replace the name of basket's creator
On acqui/parcel.pl, to avoid adding more data in the table of pending
orders, it is shown in a popup like MARC and Card views

Test plan:
1/ Run updatedatabase.pl
2/ Create a new order and go to the receipt page (acqui/parcel.pl)
3/ Click on "Order" link in column "More" (previously "View record")
4/ A javascript popup should appear with your name in it. Close the
popup.
5/ Click on "Receive" link
6/ Your name should appear in front of "Created by" label, to the right
of the page.

Patch updated with use of atomic update.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12395] Save order line's creator

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

Julian Maurice  changed:

   What|Removed |Added

  Attachment #40137|0   |1
is obsolete||

--- Comment #75 from Julian Maurice  ---
Created attachment 58746
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58746=edit
Bug 12395: Add unit test to check created_by is correctly set

Signed-off-by: Paola Rossi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12395] Save order line's creator

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

Koha Team Lyon 3  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
 CC||k...@univ-lyon3.fr

--- Comment #73 from Koha Team Lyon 3  ---
on the order receive page
(http://pro.test2.biblibre.com/cgi-bin/koha/acqui/orderreceive.pl?ordernumber=7=3)

there's 
Ordered by: No name ...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12395] Save order line's creator

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12395] Save order line's creator

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

Katrin Fischer  changed:

   What|Removed |Added

 CC||oleon...@myacpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12395] Save order line's creator

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

--- Comment #72 from Owen Leonard  ---
Created attachment 45387
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45387=edit
Bug 12395: QA follow-up - Use Bootstrap modal instead of Greybox

- Using Bootstrap modals reduces unnecessary dependencies and allows
   for more consistent styling (contents of the modal are styled by the
   current page's CSS).
 - Using standard  +  markup for showorder.tt.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12395] Save order line's creator

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

Owen Leonard  changed:

   What|Removed |Added

 Status|Signed Off  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12395] Save order line's creator

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

--- Comment #71 from Katrin Fischer  ---
4) I think using the standard font and font-size would already help - it looked
very different than the page in the background to me.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12395] Save order line's creator

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

Julian Maurice  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

--- Comment #70 from Julian Maurice  ---
3) For the tests to pass you need to run misc/devel/update_dbix_class_files.pl
after updatedatabase.pl

4) I don't really know what to do here... Is there another modal window that we
can take as an example ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12395] Save order line's creator

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

--- Comment #68 from Katrin Fischer  ---
Created attachment 43951
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43951=edit
Bug 12395: QA follow-up - Add class/id to body tag and fix title description

- Fixes title attribute for some of the new links
- Adds a unique id and a class to the new modal (xt/tt_valid.t)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12395] Save order line's creator

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #69 from Katrin Fischer  ---
1) xt/tt_valid.t was failing, I fixed it in my follo-up, please check.
1..3
ok 1 - TT syntax: not using TT directive within HTML tag
not ok 2 -  tag with id and class attributes
#   Failed test ' tag with id and class attributes'
#   at xt/tt_valid.t line 91.
# Files list: 
# intranet-tmpl/prog/en/modules/acqui/showorder.tt: 12
ok 3 - Token received same as original put on stack
# Looks like you failed 1 test of 3.

2) Some of the title="MARC" should be title="Card" - fixed in my follow-up,
please check.

3) t/db_dependent/Acquisition/NewOrder.t fails, please fix (blocker) :(
I think it's not only the test - in my testing the creator is not saved for
newly created orders. Only the 'migrated' orders have created_by set in the
database.
1..8
ok 1 - Inserting an order with no params returns undef and croaks
ok 2 - Inserting an order with no budget_id returns undef and croaks with
expected error message
ok 3 - Inserting an order with no biblionumber returns undef and croaks with
expected error message
ok 4 - Inserting an order with no basketno returns undef and croaks with
expected error message
ok 5 - Inserting an order with no quantity returns undef and croaks with
expected error message
ok 6 - Koha::Acquisition::Order->insert set quantityreceivedto 0 if undef is
given
ok 7 - Koha::Acquisition::Order->insert set entrydate to today
not ok 8 - Koha::Acquisition::Order->insert set created_by to logged in user if
not given
#   Failed test 'Koha::Acquisition::Order->insert set created_by to logged in
user if not given'
#   at t/db_dependent/Acquisition/NewOrder.t line 93.
#  got: undef
# expected: '42'
# Looks like you failed 1 test of 8.

4) The 'look' of the new modal for order information is slightly off,
especially font and font-size are unusual. Would be nice to be 
more consistent with Koha's look and feel here.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12395] Save order line's creator

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #67 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
I think the last new patch is ok as a QA follow-up - shifting back to signed
off.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12395] Save order line's creator

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

Alex Arnaud alex.arn...@biblibre.com changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12395] Save order line's creator

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

--- Comment #66 from Alex Arnaud alex.arn...@biblibre.com ---
Created attachment 40161
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40161action=edit
[Follow-up] Bug 12395

  - Make received orders table consistent with pending orders table
(links of More column),
  - Change Created by with Ordered by in receive page.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12395] Save order line's creator

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

Alex Arnaud alex.arn...@biblibre.com changed:

   What|Removed |Added

  Attachment #36079|0   |1
is obsolete||

--- Comment #57 from Alex Arnaud alex.arn...@biblibre.com ---
Created attachment 40134
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40134action=edit
Bug 12395: Fix call to set_userenv in unit tests

Signed-off-by: Paola Rossi paola.ro...@cineca.it

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12395] Save order line's creator

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

Alex Arnaud alex.arn...@biblibre.com changed:

   What|Removed |Added

  Attachment #36075|0   |1
is obsolete||
  Attachment #36076|0   |1
is obsolete||
  Attachment #36077|0   |1
is obsolete||

--- Comment #55 from Alex Arnaud alex.arn...@biblibre.com ---
Created attachment 40132
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40132action=edit
Bug 12395: Save order line's creator

New MySQL column: aqorders.createdby

Creator's name is displayed on order's receive pages (acqui/orderreceive.pl
and acqui/parcel.pl)

On acqui/orderreceive.pl it replace the name of basket's creator
On acqui/parcel.pl, to avoid adding more data in the table of pending
orders, it is shown in a popup like MARC and Card views

Test plan:
1/ Run updatedatabase.pl
2/ Create a new order and go to the receipt page (acqui/parcel.pl)
3/ Click on Order link in column More (previously View record)
4/ A javascript popup should appear with your name in it. Close the
popup.
5/ Click on Receive link
6/ Your name should appear in front of Created by label, to the right
of the page.

Patch updated with use of atomic update.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12395] Save order line's creator

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

Alex Arnaud alex.arn...@biblibre.com changed:

   What|Removed |Added

  Attachment #36080|0   |1
is obsolete||

--- Comment #58 from Alex Arnaud alex.arn...@biblibre.com ---
Created attachment 40135
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40135action=edit
Bug 12395: Display created_by even if firstname is missing on receiving

On receiving orders, no name was displayed if the firstname of creator
was not filled.
The surname should be displayed.

Signed-off-by: Paola Rossi paola.ro...@cineca.it

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12395] Save order line's creator

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

Alex Arnaud alex.arn...@biblibre.com changed:

   What|Removed |Added

  Attachment #36078|0   |1
is obsolete||

--- Comment #56 from Alex Arnaud alex.arn...@biblibre.com ---
Created attachment 40133
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40133action=edit
Bug 12395: Add unit test to check created_by is correctly set

Signed-off-by: Paola Rossi paola.ro...@cineca.it

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12395] Save order line's creator

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

Alex Arnaud alex.arn...@biblibre.com changed:

   What|Removed |Added

  Attachment #40134|0   |1
is obsolete||

--- Comment #61 from Alex Arnaud alex.arn...@biblibre.com ---
Created attachment 40138
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40138action=edit
Bug 12395: Fix call to set_userenv in unit tests

Signed-off-by: Paola Rossi paola.ro...@cineca.it

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12395] Save order line's creator

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12395

Alex Arnaud alex.arn...@biblibre.com changed:

   What|Removed |Added

  Attachment #40132|0   |1
is obsolete||

--- Comment #59 from Alex Arnaud alex.arn...@biblibre.com ---
Created attachment 40136
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40136action=edit
Bug 12395: Save order line's creator

New MySQL column: aqorders.createdby

Creator's name is displayed on order's receive pages (acqui/orderreceive.pl
and acqui/parcel.pl)

On acqui/orderreceive.pl it replace the name of basket's creator
On acqui/parcel.pl, to avoid adding more data in the table of pending
orders, it is shown in a popup like MARC and Card views

Test plan:
1/ Run updatedatabase.pl
2/ Create a new order and go to the receipt page (acqui/parcel.pl)
3/ Click on Order link in column More (previously View record)
4/ A javascript popup should appear with your name in it. Close the
popup.
5/ Click on Receive link
6/ Your name should appear in front of Created by label, to the right
of the page.

Patch updated with use of atomic update.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/