[Koha-bugs] [Bug 12405] Search links on callnumber fails on intranet results page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12405 --- Comment #9 from Fridolin SOMERS fridolyn.som...@biblibre.com --- Pushed to 3.14.x, will be in 3.14.12. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12405] Search links on callnumber fails on intranet results page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12405 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Keywords||rel_3_16_4_candidate Status|Pushed to Master|Pushed to Stable CC||gmcha...@gmail.com --- Comment #8 from Galen Charlton gmcha...@gmail.com --- Pushed to 3.16.x for inclusion in 3.16.4. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12405] Search links on callnumber fails on intranet results page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12405 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||tomasco...@gmail.com --- Comment #7 from Tomás Cohen Arazi tomasco...@gmail.com --- Patch pushed to master. Thanks Fridolin! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12405] Search links on callnumber fails on intranet results page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12405 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added CC||jonathan.dru...@biblibre.co ||m Assignee|gmcha...@gmail.com |fridolyn.som...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12405] Search links on callnumber fails on intranet results page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12405 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #5 from Katrin Fischer katrin.fisc...@bsz-bw.de --- *** Bug 12894 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12405] Search links on callnumber fails on intranet results page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12405 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12405] Search links on callnumber fails on intranet results page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12405 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #31496|0 |1 is obsolete|| --- Comment #6 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 31516 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31516action=edit [PASSED QA] Bug 12405 - Search links on callnumber fails on intranet results page On intranet results page, the callnumber of items is a search like : /cgi-bin/koha/catalogue/search.pl?idx=callnumamp;q=[% result.itemcallnumber |url %] The callnumber should be URI-escaped to avoid special URI characters like , ? ... If the callnumber contains some CCL words or parenthesis, the search will fail, it should be wrapped with double-quotes. This patch adds this to catalogue/results.pl and catalogue/shelves.pl : - uri TT filter instead of url - adds double-quotes using there URI code %22 since its in a HTML attribute using double-quotes Test plan : - Edit an item callnumber with : ABC 123 - Index zebraqueue - Perform a search returning this item - Click on the callnumber = Without this patch you get no result, because URL parameters are : idx=callnumq= ABC 123 = With this patch you get results - Set syspref QueryWeightFields off (because this is no bug if on) - Edit an item callnumber with : AB(C) AND OR - Index zebraqueue - Perform a search returning this item - Click on the callnumber = Without this patch you get no result, because the search contains CCL words OR and AND = With this patch you get results Signed-off-by: Liz Rea l...@catalyst.net.nz Tested all with and without queryweightfields - all searches from clicked call numbers for given callnumbers fail without the patch, all are successful with the patch. Signed-off-by: Katrin Fischer katrin.fischer...@web.de Works as described - no problems found. Passes tests and QA script. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12405] Search links on callnumber fails on intranet results page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12405 Liz Rea l...@catalyst.net.nz changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12405] Search links on callnumber fails on intranet results page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12405 Liz Rea l...@catalyst.net.nz changed: What|Removed |Added Attachment #28773|0 |1 is obsolete|| --- Comment #4 from Liz Rea l...@catalyst.net.nz --- Created attachment 31496 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31496action=edit Bug 12405 - Search links on callnumber fails on intranet results page On intranet results page, the callnumber of items is a search like : /cgi-bin/koha/catalogue/search.pl?idx=callnumamp;q=[% result.itemcallnumber |url %] The callnumber should be URI-escaped to avoid special URI characters like , ? ... If the callnumber contains some CCL words or parenthesis, the search will fail, it should be wrapped with double-quotes. This patch adds this to catalogue/results.pl and catalogue/shelves.pl : - uri TT filter instead of url - adds double-quotes using there URI code %22 since its in a HTML attribute using double-quotes Test plan : - Edit an item callnumber with : ABC 123 - Index zebraqueue - Perform a search returning this item - Click on the callnumber = Without this patch you get no result, because URL parameters are : idx=callnumq= ABC 123 = With this patch you get results - Set syspref QueryWeightFields off (because this is no bug if on) - Edit an item callnumber with : AB(C) AND OR - Index zebraqueue - Perform a search returning this item - Click on the callnumber = Without this patch you get no result, because the search contains CCL words OR and AND = With this patch you get results Signed-off-by: Liz Rea l...@catalyst.net.nz Tested all with and without queryweightfields - all searches from clicked call numbers for given callnumbers fail without the patch, all are successful with the patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12405] Search links on callnumber fails on intranet results page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12405 David Cook dc...@prosentient.com.au changed: What|Removed |Added CC||dc...@prosentient.com.au --- Comment #3 from David Cook dc...@prosentient.com.au --- I'll take a look at this one later... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12405] Search links on callnumber fails on intranet results page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12405 Nicole C. Engard neng...@gmail.com changed: What|Removed |Added CC||neng...@gmail.com --- Comment #2 from Nicole C. Engard neng...@gmail.com --- I'm not sure I'm following the test plan right, but I have queryweightfields off and when i click the call number that starts with a I get brought to the advanced search page and when i click the one with the parens and AND OR in it I get no results found - both of these after applying the patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12405] Search links on callnumber fails on intranet results page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12405 --- Comment #1 from Fridolin SOMERS fridolyn.som...@biblibre.com --- Created attachment 28773 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28773action=edit Bug 12405 - Search links on callnumber fails on intranet results page On intranet results page, the callnumber of items is a search like : /cgi-bin/koha/catalogue/search.pl?idx=callnumamp;q=[% result.itemcallnumber |url %] The callnumber should be URI-escaped to avoid special URI characters like , ? ... If the callnumber contains some CCL words or parenthesis, the search will fail, it should be wrapped with double-quotes. This patch adds this to catalogue/results.pl and catalogue/shelves.pl : - uri TT filter instead of url - adds double-quotes using there URI code %22 since its in a HTML attribute using double-quotes Test plan : - Edit an item callnumber with : ABC 123 - Index zebraqueue - Perform a search returning this item - Click on the callnumber = Without this patch you get no result, because URL parameters are : idx=callnumq= ABC 123 = With this patch you get results - Set syspref QueryWeightFields off (because this is no bug if on) - Edit an item callnumber with : AB(C) AND OR - Index zebraqueue - Perform a search returning this item - Click on the callnumber = Without this patch you get no result, because the search contains CCL words OR and AND = With this patch you get results -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12405] Search links on callnumber fails on intranet results page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12405 Fridolin SOMERS fridolyn.som...@biblibre.com changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
