[Koha-bugs] [Bug 12430] Truncation disables relevance ranking when not using QueryParser

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430

Katrin Fischer  changed:

   What|Removed |Added

   Severity|normal  |critical
 CC||katrin.fisc...@bsz-bw.de

--- Comment #13 from Katrin Fischer  ---
I am upping severity here since a lot of people use QueryAutoTruncate unaware
of it breaking Relevance and falsely assuming Koha can't do better. If we can't
fix it, we should add a warning to the system preference description of
QueryAutoTruncate.

Old patch doesn't apply any longer.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12430] Truncation disables relevance ranking when not using QueryParser

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430

Shane Sammons  changed:

   What|Removed |Added

 CC||ssamm...@npelem.com

--- Comment #12 from Shane Sammons  ---
I just wanted to note that search result being relevant is an issue. I just
migrated from 3.20.00 to 17.11(Debian Packages on Ubuntu 16.04LTS) and I had to
change Trunction to require *, otherwise expected top results were mixed in the
results.

I don't care if it is a fix switching to other "stack", a patch to this issue,
or whatever, but I wanted to comment that something should be done.

Thankfully you are all a great community and super helpful so IRC chat helped
me learn about this bug and we turned it from auto to require * to get far
better search results.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12430] Truncation disables relevance ranking when not using QueryParser

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430

Mirko Tietgen  changed:

   What|Removed |Added

 CC||mi...@abunchofthings.net

--- Comment #11 from Mirko Tietgen  ---
(In reply to David Cook from comment #8)

> FYI, the issue with st-numeric was fixed in Zebra 2.0.62
> 
> http://www.indexdata.com/zebra/doc/NEWS

Hi David, are there other reasons not to use this patch?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12430] Truncation disables relevance ranking when not using QueryParser

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430

--- Comment #10 from David Cook  ---
Honestly, there's probably no point trying to refactor the C4::Search code for
Zebra anymore. It would probably be better to scrap it and start over rather
than try to make it work the way it does now.

Time would probably be better spent finishing the QueryParser, or converting
Koha to use actual CCL query syntax.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12430] Truncation disables relevance ranking when not using QueryParser

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430

--- Comment #8 from David Cook  ---
(In reply to David Cook from comment #6)
> It appears that this patch could break the "Publication Date ()" search,
> when using "yr,st-numeric" (which might be the case after bug 9368).
> 
> If we were to use "yr,st-year" instead, you might get results for a "2000-"
> query but they would only be for "2000". If you specified a full range
> "2000-2012", it would break.
> 
> It seems that relevance can't be run with date ranges (which is usually
> fine, as we use date ranges as limits which are not affected by relevance
> ranking).

FYI, the issue with st-numeric was fixed in Zebra 2.0.62

http://www.indexdata.com/zebra/doc/NEWS

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12430] Truncation disables relevance ranking when not using QueryParser

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430

--- Comment #9 from David Cook  ---
Also, I'm probably never going to work on this again.

I don't have the time to fix all the things that are wrong with C4::Search.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12430] Truncation disables relevance ranking when not using QueryParser

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Blocks||12742

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12430] Truncation disables relevance ranking when not using QueryParser

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Blocks|12742   |
 Depends on||12742

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12430] Truncation disables relevance ranking when not using QueryParser

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430

David Cook dc...@prosentient.com.au changed:

   What|Removed |Added

Summary|Truncation disables |Truncation disables
   |relevance ranking (and has  |relevance ranking when not
   |issues when using   |using QueryParser
   |QueryParser)|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12430] Truncation disables relevance ranking when not using QueryParser

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430

David Cook dc...@prosentient.com.au changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12430] Truncation disables relevance ranking when not using QueryParser

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430

--- Comment #4 from David Cook dc...@prosentient.com.au ---
Created attachment 28880
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28880action=edit
Bug 12430 - Truncation disables relevance ranking when not using QueryParser

The system preference QueryWeightFields is mutually exclusive with
the system preference QueryAutoTruncate and the * truncation
modifier, when not using QueryParser.

If you use truncation, relevance won't work anymore. (N.B. Relevance
doesn't work probably when using QueryParser, but for a very different
reason beyond the current scope of this bug.)

This patch adds relevance ranking when using truncation (or basically
when QueryWeightFields is disabled).

_TEST PLAN_

1) Turn on QueryWeightFields and QueryAutoTruncate
2) Turn off TryQueryParser
3) Do a keyword search in the OPAC
4) Note that the results are ordered by biblionumber ascending

5) Apply patch

6) Do the same keyword search in the OPAC
7) Note that the results are never ordered differently
(presumably in relevance order :P)

If you're a stickler, throw in some warns so that you can see
what CCL query is being sent to Zebra.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12430] Truncation disables relevance ranking when not using QueryParser

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430

David Cook dc...@prosentient.com.au changed:

   What|Removed |Added

   Severity|major   |normal

--- Comment #5 from David Cook dc...@prosentient.com.au ---
Changing the importance of this one as I suppose its severity is debateable...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12430] Truncation disables relevance ranking when not using QueryParser

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430

David Cook dc...@prosentient.com.au changed:

   What|Removed |Added

 Status|Needs Signoff   |In Discussion

--- Comment #6 from David Cook dc...@prosentient.com.au ---
It appears that this patch could break the Publication Date () search,
when using yr,st-numeric (which might be the case after bug 9368).

If we were to use yr,st-year instead, you might get results for a 2000-
query but they would only be for 2000. If you specified a full range
2000-2012, it would break.

It seems that relevance can't be run with date ranges (which is usually fine,
as we use date ranges as limits which are not affected by relevance ranking).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12430] Truncation disables relevance ranking when not using QueryParser

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430

--- Comment #7 from David Cook dc...@prosentient.com.au ---
Putting this on hold for the moment while I try to get some refactoring done on
buildQuery.

We shouldn't be adding relevance searching to date ranges (it will cause errors
that produce no results or results only matching the first date in the range)
or item-level indexes (as the relevance score will be artificially inflated by
bib records with higher numbers of items).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12430] Truncation disables relevance ranking (when not using QueryParser)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12430

David Cook dc...@prosentient.com.au changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/