[Koha-bugs] [Bug 12460] Search history: Combine to start a new search

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12460

Nick Clemens  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=27546
 CC||n...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12460] Search history: Combine to start a new search

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12460

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Failed QA   |Patch doesn't apply

--- Comment #35 from Aleisha Amohia  ---
Patches need rebasing!

$ git bz apply 12460
Bug 12460 - Search history: Combine to start a new search

78648 - Bug 12460: Allow to start a new search from multiple search history
lines
78649 - Bug 12460: Simplify interface to combine queries
78650 - Bug 12460: Fix query combination for anonymous users

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 12460: Allow to start a new search from multiple search history
lines
Using index info to reconstruct a base tree...
M   koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/search-history.tt
M   koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-search-history.tt
Falling back to patching base and 3-way merge...
Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-search-history.tt
CONFLICT (content): Merge conflict in
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-search-history.tt
Auto-merging
koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/search-history.tt
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/search-history.tt
Failed to merge in the changes.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12460] Search history: Combine to start a new search

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12460

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #34 from Jonathan Druart  
---
Hi Julian,
1. minor:
 FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/search-history.tt
   FAIL   forbidden patterns
forbidden pattern: Do not use line breaks inside template tags
(bug 18675) (line 104)
forbidden pattern: Do not use line breaks inside template tags
(bug 18675) (line 114)

 FAIL   koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-search-history.tt
   FAIL   forbidden patterns
forbidden pattern: Do not use line breaks inside template tags
(bug 18675) (line 133)
forbidden pattern: Do not use line breaks inside template tags
(bug 18675) (line 144)

2. Bad news but... this will not work with Elastic, right?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12460] Search history: Combine to start a new search

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12460

Claes  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #33 from Claes  ---
The test plan starts with:"Login to intranet interface" but this feature is
about combining searches in the OPAC interface. 
Doing that in a ByWater sandbox everything in step 1-9 works fine with the
modification concerning the simplified search box.

Instead of step 10 I logged out and repeated made searches as an anonymous.
Then logged in in OPAC again and correctly found that these new searches were
added to the old ones. 

Authority search works as before and is - as intended - without any possibility
to combie searches.

However, I found two peculiar things, which is more about UX and not about how
the bug works:
1. There are two date columns. "Session date" is set to unknown when you have
left the active session. I can live with this since the column "date" has date
and time for both old and active sessions.
2. Session ID is by default ordered in a descending order. Since you can
rearrange by other columns, e.g. Search and Results, I looked for a way to
resort in the Id column. It took me 10 seconds to find that the best way to
sort in Id order is to use the Date column.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12460] Search history: Combine to start a new search

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12460

Julian Maurice  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #32 from Julian Maurice  ---
(In reply to Hugo Agud from comment #28)
> I think the combination method is not quite intuitive for the end user, it
> is very powerful it gives you the chance  of complex combination but I
> guess, that perhaps user will prefer a more intuitive way of combine
> searches.
> 
> Once you are able to select the old searches, I think they will expect to be
> able just combine and that's all, in the same way.than mering bibliorecords.
What do you mean exactly by "just combine" ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12460] Search history: Combine to start a new search

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12460

Julian Maurice  changed:

   What|Removed |Added

  Attachment #72092|0   |1
is obsolete||

--- Comment #30 from Julian Maurice  ---
Created attachment 78649
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78649=edit
Bug 12460: Simplify interface to combine queries

The complicated interface using 'Match any/Match all', checkboxes and
'NOT' selectors is replaced by a simple textbox which expects queries
like this:

  (#1 or #3) and #6

where 1, 3 and 6 are IDs in search_history table.

A new column in the table show these ids.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12460] Search history: Combine to start a new search

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12460

--- Comment #31 from Julian Maurice  ---
Created attachment 78650
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78650=edit
Bug 12460: Fix query combination for anonymous users

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12460] Search history: Combine to start a new search

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12460

Julian Maurice  changed:

   What|Removed |Added

  Attachment #72091|0   |1
is obsolete||

--- Comment #29 from Julian Maurice  ---
Created attachment 78648
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78648=edit
Bug 12460: Allow to start a new search from multiple search history lines

This patch regroups searches of current and previous sessions to allow
selecting lines from both groups.
It adds a new column (session date) to allow to differentiate searches
of current session from other sessions.
Patch is for Intranet and OPAC

Test plan:
  1. Login to intranet interface
  2. Do some biblio searches
  3. Go to the search history page
  4. See you have a new action available "Start a new search", grayed
 because you haven't selected any line
  5. Select two or more searches
  6. "Start a new search" is now enabled, click it.
  7. A dropdown list appears, asking you to chose between a "Match any"
 search and a "Match all" search. There is also a new column in the
 table ("Not") allowing you to apply a NOT to the corresponding line
  8. Make your choice, and then click on Go button, next to the dropdown
 list. You will be redirected to the catalogue search results.
  9. Confirm that the results are correct.
 10. Set syspref opacthemes to 'bootstrap'
 11. Go to OPAC interface anonymously and repeat steps 2-9
 12. Login to OPAC interface and repeat steps 2-9
 13. Check that authority search history still works as before the patch
 (except that there is only one table instead of two)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12460] Search history: Combine to start a new search

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12460

abernaud  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
 CC||anne-claire.bernaudin@univ-
   ||rennes1.fr

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12460] Search history: Combine to start a new search

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12460

Hugo Agud  changed:

   What|Removed |Added

 CC||ha...@orex.es

--- Comment #28 from Hugo Agud  ---
I think the combination method is not quite intuitive for the end user, it is
very powerful it gives you the chance  of complex combination but I guess, that
perhaps user will prefer a more intuitive way of combine searches.

Once you are able to select the old searches, I think they will expect to be
able just combine and that's all, in the same way.than mering bibliorecords.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12460] Search history: Combine to start a new search

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12460

--- Comment #27 from Lucie Gay  ---
Thank you for the new test plan.
It's ok until step 7.
Anonymous mode : ID in first column looks like #20183139523615. If I combine
two of these ID, it doesn't work
the request generated is 
ccl=allrecords,alwaysmatches='' AND allrecords,alwaysmatches=''

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12460] Search history: Combine to start a new search

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12460

--- Comment #26 from Julian Maurice  ---
(In reply to Lucie Gay from comment #24)
> -> There are still two tabs in the search history : catalog / authority. So
> it's not easy to combine both. In the authority's tab, there is no option
> "combine queries".

That is expected, the feature is only for biblios.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12460] Search history: Combine to start a new search

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12460

--- Comment #25 from Julian Maurice  ---
Hi Lucie,

The feature has changed and the test plan was not updated. Sorry about that.
Here's an updated test plan:

Test plan:
  1. Login to intranet interface
  2. Do some biblio searches
  3. Go to the search history page
  4. See you have a new textbox below the table
  5. Type in the textbox a query using the IDs displayed in the table, like
"(#1 or #2) and #3" and click on "Combine queries". You will be redirected to
the catalogue search results.
  6. Confirm that the results are correct.
  7. Go to OPAC interface anonymously and repeat steps 2-6
  8. Login to OPAC interface and repeat steps 2-6
  9. Check that authority search history still works as before the patch
 (except that there is only one table instead of two)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12460] Search history: Combine to start a new search

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12460

Lucie Gay  changed:

   What|Removed |Added

 CC||lucie.gay@ens-paris-saclay.
   ||fr

--- Comment #24 from Lucie Gay  ---
Some comments about my test :

  6. "Start a new search" is now enabled, click it.

-> "Start a new search" doesn't appear.

  7. A dropdown list appears, asking you to chose between a "Match any"
 search and a "Match all" search. There is also a new column in the
 table ("Not") allowing you to apply a NOT to the corresponding line
  8. Make your choice, and then click on Go button, next to the dropdown
 list. You will be redirected to the catalogue search results.

-> Instead, there is a simple text box and a button "Combine queries".

  9. Confirm that the results are correct.

-> Launch a new search with combination of IDs works well (for example : #1 AND
#2) and generate a new line in the history search.

 10. Set syspref opacthemes to 'bootstrap'

-> During the test, bootstrap was already assigned to syspref opacthemes.

 11. Go to OPAC interface anonymously and repeat steps 2-9

-> When we are logged, the IDs of search are simple (#1), but when we are not
logged the IDs looks like (#2018312170988)

 12. Login to OPAC interface and repeat steps 2-9
 13. Check that authority search history still works as before the patch
 (except that there is only one table instead of two)

-> There are still two tabs in the search history : catalog / authority. So
it's not easy to combine both. In the authority's tab, there is no option
"combine queries".

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12460] Search history: Combine to start a new search

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12460

--- Comment #23 from Andreas Jonsson  ---

The support for non-logged in users by getting the search history from the
session was lost in the simplification patch (attachment 72092).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12460] Search history: Combine to start a new search

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12460

Andreas Jonsson  changed:

   What|Removed |Added

 CC||andreas.jons...@kreablo.se

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12460] Search history: Combine to start a new search

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12460

Julian Maurice  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #22 from Julian Maurice  ---
(In reply to Claes from comment #19) 
> A second suggestion would complicate it for the developer :-) but here it
> comes:
> 1) The search history page should have a number for each search set/search
> querie. And the numbers should be in this format: #1, #2, #3
> 2) An extra column at the end of the line with tick boxes for each line and
> with the heading "Delete searches". As in 2) above.
> 3) A search line above the search history with the text Combine queries and
> a brief example (#1 OR #3) AND #6. As the example show there are no box
> ticking here but you send a querie using old search sets.
> 4) remove the big red button "Remove selected searches"
> 5) remove the first column with tick boxes

I've chosen this 2nd option, as it is much more flexible, and was not that
complicated to write (it even removes code!).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12460] Search history: Combine to start a new search

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12460

--- Comment #21 from Julian Maurice  ---
Created attachment 72092
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72092=edit
Bug 12460: Simplify interface to combine queries

The complicated interface using 'Match any/Match all', checkboxes and
'NOT' selectors is replaced by a simple textbox which expects queries
like this:

  (#1 or #3) and #6

where 1, 3 and 6 are IDs in search_history table.

A new column in the table show these ids.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12460] Search history: Combine to start a new search

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12460

Julian Maurice  changed:

   What|Removed |Added

  Attachment #59384|0   |1
is obsolete||

--- Comment #20 from Julian Maurice  ---
Created attachment 72091
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72091=edit
Bug 12460: Allow to start a new search from multiple search history lines

This patch regroups searches of current and previous sessions to allow
selecting lines from both groups.
It adds a new column (session date) to allow to differentiate searches
of current session from other sessions.
Patch is for Intranet and OPAC

Test plan:
  1. Login to intranet interface
  2. Do some biblio searches
  3. Go to the search history page
  4. See you have a new action available "Start a new search", grayed
 because you haven't selected any line
  5. Select two or more searches
  6. "Start a new search" is now enabled, click it.
  7. A dropdown list appears, asking you to chose between a "Match any"
 search and a "Match all" search. There is also a new column in the
 table ("Not") allowing you to apply a NOT to the corresponding line
  8. Make your choice, and then click on Go button, next to the dropdown
 list. You will be redirected to the catalogue search results.
  9. Confirm that the results are correct.
 10. Set syspref opacthemes to 'bootstrap'
 11. Go to OPAC interface anonymously and repeat steps 2-9
 12. Login to OPAC interface and repeat steps 2-9
 13. Check that authority search history still works as before the patch
 (except that there is only one table instead of two)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12460] Search history: Combine to start a new search

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12460

Claes  changed:

   What|Removed |Added

 CC||claes.eriks...@vti.se

--- Comment #19 from Claes  ---
Since this feature would appeal to more experienced user I think that it would
be better to align with common search interfaces.

The option "Start a new search" is not intuitive at all. What we want to do is:
"Combine sets/queries"

"Match any" and "match all" is not really common language and it is not
intuitive. 

It seems that I must select either match any/ match all even if I just want to
select line 4 NOT line 2. The results indicate that the search works as it
should but it is certainly not clear for a user.

I have 2 suggestions: the first beeing a bit simpler and probably easier to
apply. The second would be the most up to date solution.


My first suggestion for a design remake would be:
1) At the search history page add 2 new columns
2) One column with the heading "Delete Sets". In this column, each line/search
set should have a tick box. Two buttons in the same heading with "select all"
and the second button "X delete" 
3) The second column with the heading "Combine sets or Combine queries". In
this heading two tick boxes: "AND" & "OR". And this column should also have a
tick box for each line.
4) remove the big red button "Remove selected searches"
5) remove the first column with tick boxes

So how about the option "NOT"? My experience as information specialist is that
this operator is not well understood and often misused by normal users. 


A second suggestion would complicate it for the developer :-) but here it
comes:
1) The search history page should have a number for each search set/search
querie. And the numbers should be in this format: #1, #2, #3
2) An extra column at the end of the line with tick boxes for each line and
with the heading "Delete searches". As in 2) above.
3) A search line above the search history with the text Combine queries and a
brief example (#1 OR #3) AND #6. As the example show there are no box ticking
here but you send a querie using old search sets.
4) remove the big red button "Remove selected searches"
5) remove the first column with tick boxes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12460] Search history: Combine to start a new search

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12460

Zeno Tajoli  changed:

   What|Removed |Added

 CC|z.taj...@cineca.it  |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12460] Search history: Combine to start a new search

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12460

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #18 from Aleisha Amohia  ---
I have a few issues with the patch:
1) There is a 'session date' column and a 'date' column. The 'date' column is
filled, but every row in the 'session date' column says Unknown. This column
should be removed.
2) The 'start a new search' line is clickable without selecting any rows, but
will not execute the search until some rows are selected. The line should be
greyed out initially, as stated in your test plan
3) My previous search history in both staff client and OPAC are gone.

Setting as Failed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12460] Search history: Combine to start a new search

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12460

Julian Maurice  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

--- Comment #17 from Julian Maurice  ---
Patch rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12460] Search history: Combine to start a new search

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12460

Julian Maurice  changed:

   What|Removed |Added

  Attachment #42450|0   |1
is obsolete||

--- Comment #16 from Julian Maurice  ---
Created attachment 59384
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59384=edit
Bug 12460: Allow to start a new search from multiple search history lines

This patch regroups searches of current and previous sessions to allow
selecting lines from both groups.
It adds a new column (session date) to allow to differentiate searches
of current session from other sessions.
Patch is for Intranet and OPAC (bootstrap only)

Test plan:
1/ Login to intranet interface
2/ Do some biblio searches
3/ Go to the search history page
4/ See you have a new action available "Start a new search", grayed
beacause you haven't selected any line
5/ Select two or more searches
6/ "Start a new search" is now enabled, click it.
7/ A dropdown list appears, asking you to chose between a "Match any"
search and a "Match all" search. There is also a new column in the table
("Not") allowing you to apply a NOT to the corresponding line.
8/ Make your choice, and then click on Go button, next to the dropdown
list. You will be redirected to the catalogue search results.
9/ Confirm that the results are correct.
10/ Set syspref opacthemes to 'bootstrap'
11/ Go to OPAC interface anonymously and repeat steps 2-9
12/ Login to OPAC interface and repeat steps 2-9
13/ Check that authority search history still works as before the patch
(except that there is only one table instead of two)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12460] Search history: Combine to start a new search

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12460

Marc Véron  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||ve...@veron.ch

--- Comment #15 from Marc Véron  ---
Sorry, could not apply:

fatal: sha1 information is lacking or useless
(koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/search-history.tt).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12460] Search history: Combine to start a new search

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12460

claire.hernan...@biblibre.com  changed:

   What|Removed |Added

 Status|BLOCKED |Needs Signoff

--- Comment #14 from claire.hernan...@biblibre.com 
 ---
I am not a bot ;)
This bug depends on 14699 which is in status Needs Sign off.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12460] Search history: Combine to start a new search

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12460

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |BLOCKED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12460] Search history: Combine to start a new search

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12460

I'm just a bot  changed:

   What|Removed |Added

 CC||git...@bugs.koha-community.
   ||org

--- Comment #13 from I'm just a bot  ---
This bug depends on 14699 which is in status In Discussion

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12460] Search history: Combine to start a new search

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12460

Julian Maurice  changed:

   What|Removed |Added

  Attachment #41782|0   |1
is obsolete||

--- Comment #12 from Julian Maurice  ---
Created attachment 42450
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42450=edit
Bug 12460: Allow to start a new search from multiple search history lines

Rebased on top of bug 14699

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12460] Search history: Combine to start a new search

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12460

Zeno Tajoli  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 CC||z.taj...@cineca.it

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12460] Search history: Combine to start a new search

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12460

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

  Attachment #35699|0   |1
is obsolete||

--- Comment #10 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 41782
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41782action=edit
Bug 12460: Allow to start a new search from multiple search history lines

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12460] Search history: Combine to start a new search

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12460

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

 Depends on||14699
 Status|In Discussion   |Needs Signoff

--- Comment #11 from Julian Maurice julian.maur...@biblibre.com ---
Patch rebased on top of bug 14699

It also includes minor changes to address problem 2 of comment 9:
- Start a new search link is displayed on its own line and doesn't require
that the user selected some searches to be clickable
- Add an alert() popup when user clicks on Go without having selected
searches.

So, the expected user behavior is now:
1/ Click on Start a new search. (The 'Not' column appears)
2/ Select some searches (optionally toggle the NOT option for some of these)
3/ Click on Go


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14699
[Bug 14699] Intranet search history issues due to DataTables pagination
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12460] Search history: Combine to start a new search

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12460

LuceBarbey luce.bar...@cirad.fr changed:

   What|Removed |Added

 Status|Signed Off  |In Discussion

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12460] Search history: Combine to start a new search

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12460

LuceBarbey luce.bar...@cirad.fr changed:

   What|Removed |Added

 CC||luce.bar...@cirad.fr

--- Comment #9 from LuceBarbey luce.bar...@cirad.fr ---
I've tested it and I've some comments.
1.This function (developpement) needs a documentation about the behavior.
2. The first time we come on search history, we must select some lines and
click on start a new search before to see the boolean operator 'NOT'. It's
not intuitive
3. To build a complex search, we must proceed in several steps, because we
could search only with AND (match all) / OR (match any.)
Proposals :
1. Display the not column immediately
2. Modify the form : when nothing is checked display Select searches to run a
combined search. When at least one search is checked, display With selected
searches run a combined search [matching any of selected searches] [ok]

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12460] Search history: Combine to start a new search

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12460

claire.hernan...@biblibre.com claire.hernan...@biblibre.com changed:

   What|Removed |Added

 CC||claire.hernandez@biblibre.c
   ||om

--- Comment #7 from claire.hernan...@biblibre.com 
claire.hernan...@biblibre.com ---
To add in test plan:
Enable syspref EnableSearchHistory before testing.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12460] Search history: Combine to start a new search

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12460

Pierre Angot tredok.pie...@gmail.com changed:

   What|Removed |Added

 CC||tredok.pie...@gmail.com
 Status|Needs Signoff   |Signed Off

--- Comment #8 from Pierre Angot tredok.pie...@gmail.com ---
I've tested it on sandbox.

It Works ! ^^

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12460] Search history: Combine to start a new search

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12460

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

  Attachment #29102|0   |1
is obsolete||

--- Comment #6 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 35699
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35699action=edit
Bug 12460: Allow to start a new search from multiple search history lines

Rebased on master
Still depends on bug 11430

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12460] Search history: Combine to start a new search

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12460

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12460] Search history: Combine to start a new search

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12460

Rochelle Healy rochellehealy.stud...@wegc.school.nz changed:

   What|Removed |Added

 CC||rochellehealy.student@wegc.
   ||school.nz
 Status|Needs Signoff   |Patch doesn't apply

--- Comment #5 from Rochelle Healy rochellehealy.stud...@wegc.school.nz ---
We tried applying bug 11430 first but it still doesn't apply, 

Applying: Bug 12460: Allow to start a new search from multiple search history
lines
fatal: sha1 information is lacking or useless
(koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-search-history.tt).
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.
Patch failed at 0001 Bug 12460: Allow to start a new search from multiple
search history lines
When you have resolved this problem run git bz apply --continue.
If you would prefer to skip this patch, instead run git bz apply --skip.
To restore the original branch and stop patching run git bz apply --abort.
Patch left in
/tmp/Bug-12460-Allow-to-start-a-new-search-from-multipl-UuxtJ9.patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12460] Search history: Combine to start a new search

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12460

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

   Keywords||Academy

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12460] Search history: Combine to start a new search

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12460

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

 CC||ch...@bigballofwax.co.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12460] Search history: Combine to start a new search

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12460

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

--- Comment #4 from Owen Leonard oleon...@myacpl.org ---
(In reply to Aleisha Amohia from comment #3)
 Sent this error message when trying to test:
 fatal: sha1 information is lacking or useless (C4/Search/History.pm).

Did you apply the patch for Bug 11430 first?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12460] Search history: Combine to start a new search

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12460

Aleisha Amohia aleishaamo...@hotmail.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||aleishaamo...@hotmail.com

--- Comment #3 from Aleisha Amohia aleishaamo...@hotmail.com ---
Sent this error message when trying to test:
fatal: sha1 information is lacking or useless (C4/Search/History.pm).

Setting to 'patch does not apply'

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12460] Search history: Combine to start a new search

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12460

Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed:

   What|Removed |Added

 CC||bgkrie...@gmail.com

--- Comment #2 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com ---
Trying to test, but Bug 11430 no longer applies

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12460] Search history: Combine to start a new search

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12460

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12460] Search history: Combine to start a new search

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12460

--- Comment #1 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 29102
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29102action=edit
Bug 12460: Allow to start a new search from multiple search history lines

This patch regroups searches of current and previous sessions to allow
selecting lines from both groups.
It adds a new column (session date) to allow to differentiate searches
of current session from other sessions.
Patch is for Intranet and OPAC (bootstrap only)

Test plan:
1/ Login to intranet interface
2/ Do some biblio searches
3/ Go to the search history page
4/ See you have a new action available Start a new search, grayed
beacause you haven't selected any line
5/ Select two or more searches
6/ Start a new search is now enabled, click it.
7/ A dropdown list appears, asking you to chose between a Match any
search and a Match all search. There is also a new column in the table
(Not) allowing you to apply a NOT to the corresponding line.
8/ Make your choice, and then click on Go button, next to the dropdown
list. You will be redirected to the catalogue search results.
9/ Confirm that the results are correct.
10/ Set syspref opacthemes to 'bootstrap'
11/ Go to OPAC interface anonymously and repeat steps 2-9
12/ Login to OPAC interface and repeat steps 2-9
13/ Check that authority search history still works as before the patch
(except that there is only one table instead of two)

Depends on bug 11430

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/