[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||27586


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27586
[Bug 27586] Import patrons script has a confirm switch that doesn't do anything
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

Fridolin SOMERS  changed:

   What|Removed |Added

 Blocks||22136


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22136
[Bug 22136] Import patrons notes hides a note because the syspref isn't
referenced correctly
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

Martin Renvoize  changed:

   What|Removed |Added

 Status|Pushed to Master|RESOLVED
 Resolution|--- |FIXED
 CC||martin.renvoize@ptfs-europe
   ||.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

Jonathan Druart  changed:

   What|Removed |Added

   Keywords|release-notes-needed|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

Kyle M Hall  changed:

   What|Removed |Added

  Text to go in the||Koha now has a command line
  release notes||tool for importing patron
   ||CSV files of the same
   ||format the web-based tool
   ||uses. This tool allows a
   ||user to specify a
   ||matchpoint, set default
   ||values for non-existing
   ||fields, decide if a match
   ||should be overwritten, and
   ||if extended attributes
   ||should be preserved!
   ||
   ||For
   ||more details, run
   ||"misc/import_patrons.pl -h"

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #182 from Jonathan Druart  
---
Pushed to master for 18.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

Jonathan Druart  changed:

   What|Removed |Added

   Keywords||release-notes-needed

--- Comment #181 from Jonathan Druart  
---
It would have been better to get another QA point of view but I am going push
this patch set anyway, it has been waiting for too long.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

--- Comment #179 from Kyle M Hall  ---
Created attachment 71765
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71765=edit
Bug 12598: Use Pod::Usage and make the help more explicit

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

--- Comment #173 from Kyle M Hall  ---
Created attachment 71759
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71759=edit
Bug 12598: Fix conflict with 17829 - GetMember

Signed-off-by: Colin Campbell 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

--- Comment #180 from Kyle M Hall  ---
Created attachment 71766
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71766=edit
Bug 12598: Fix POD

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

--- Comment #175 from Kyle M Hall  ---
Created attachment 71761
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71761=edit
Bug 12598 Allow matched patron to be updated

When a test was introduced to not add duplicate userids
it overlooked that if you were matching on userid you
do not want the update to be rejected.

Add a test to overcome this logical flaw if updating
by matching userid

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

--- Comment #178 from Kyle M Hall  ---
Created attachment 71764
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71764=edit
Bug 12598: Remove warnings from tests and make them pass

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

--- Comment #176 from Kyle M Hall  ---
Created attachment 71762
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71762=edit
Bug 12598: Re-add bug 18555: Create patron list from patron import

Signed-off-by: Colin Campbell 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

--- Comment #177 from Kyle M Hall  ---
Created attachment 71763
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71763=edit
Bug 12598: Add use Koha::Patron::debarments statement

Signed-off-by: Colin Campbell 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

--- Comment #174 from Kyle M Hall  ---
Created attachment 71760
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71760=edit
Bug 12598: Re-add some missing stuffs

This patch will have to be squashed with previous ones, but for
readability I prefer to let it alone for now.

It reintroduces 2 missing changes:
  commit fd123903651435c56ca14d88897e9ce4d7a38bb5
Bug 15010: Import patron tool creates 'duplicate' restrictions (
debarments )
  commit 011d8e9855ffeb1779f5c1aadc9f4367c298cee7
Bug 12543 - Add userid as matchpoint for "Import patrons" tool

Signed-off-by: Colin Campbell 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #71755|0   |1
is obsolete||

--- Comment #170 from Kyle M Hall  ---
Created attachment 71756
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71756=edit
Bug 12598: New misc/import_borrowers.pl command line tool

Test Plan:
1) Apply this patch
2) Test importing patrons from command line,
   options are availble with --help.

Signed-off-by: Bernardo Gonzalez Kriegel 

Tested with minimal csv
(cardnumber,surname,firstname,categorycode,branchcode,password,userid)

Overwrite does not change category or branch.
Patrons are loaded, userid & password works

Updated license to GPLv3
No other koha-qa errors.

Signed-off-by: Benjamin Rokseth 

Signed-off-by: Kyle M Hall 

Bug 12598 - Tidy import_borrowers.pl

Signed-off-by: Benjamin Rokseth 

Signed-off-by: Kyle M Hall 

Bug 12598 - Move importing code to a subroutine

Signed-off-by: Benjamin Rokseth 

Signed-off-by: Kyle M Hall 

Bug 12598 - Update command line script to use patron import subroutine

Signed-off-by: Benjamin Rokseth 

Signed-off-by: Kyle M Hall 

Bug 12598 [QA Followup]

* Fix copyright on import_borrowers.pl
* Changes -c --csv to -f --file
* Adds -c --confirm option
* Renames misc/import_borrowers.pl to misc/import_patrons.pl
* Restore userid matchpoint option

Signed-off-by: Kyle M Hall 

Bug 12598 - Fix merge to master. Backport 3 updates from latest
import_borrowers.pl

Signed-off-by: Kyle M Hall 

Bug 12598 - Started regression tests. Fix missing C4::Members::Attributes
package

Signed-off-by: Kyle M Hall 

Bug 12598 - More refactoring and regression tests in Koha::Patrons::Import

Signed-off-by: Kyle M Hall 

Bug 12598 - Creating objects in misc/import_patrons.pl and
tools/import_borrowers.pl

Signed-off-by: Kyle M Hall 

Bug 12598 - Refactoring Koha::Patrons::Import includes bug fixed for critical
date types and header column parsing

Signed-off-by: Kyle M Hall 

Bug 12598 - Rebase + backport of 16426 plus fixing 16426

Signed-off-by: Kyle M Hall 

Bug 12598: catch warnings raised by import_patrons in tests

Signed-off-by: Colin Campbell 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

--- Comment #172 from Kyle M Hall  ---
Created attachment 71758
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71758=edit
Bug 12598: Fix conflict with bug 16911

Tests will have to be written for this change

Signed-off-by: Colin Campbell 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

--- Comment #171 from Kyle M Hall  ---
Created attachment 71757
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71757=edit
Bug 12598: Update code to use new modules

Signed-off-by: Colin Campbell 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #66575|0   |1
is obsolete||
  Attachment #66576|0   |1
is obsolete||
  Attachment #66577|0   |1
is obsolete||
  Attachment #66578|0   |1
is obsolete||
  Attachment #66579|0   |1
is obsolete||
  Attachment #66580|0   |1
is obsolete||
  Attachment #67276|0   |1
is obsolete||
  Attachment #67277|0   |1
is obsolete||
  Attachment #70265|0   |1
is obsolete||
  Attachment #70266|0   |1
is obsolete||

--- Comment #169 from Kyle M Hall  ---
Created attachment 71755
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71755=edit
Bug 12598: New misc/import_borrowers.pl command line tool

Test Plan:
1) Apply this patch
2) Test importing patrons from command line,
   options are availble with --help.

Signed-off-by: Bernardo Gonzalez Kriegel 

Tested with minimal csv
(cardnumber,surname,firstname,categorycode,branchcode,password,userid)

Overwrite does not change category or branch.
Patrons are loaded, userid & password works

Updated license to GPLv3
No other koha-qa errors.

Signed-off-by: Benjamin Rokseth 

Signed-off-by: Kyle M Hall 

Bug 12598 - Tidy import_borrowers.pl

Signed-off-by: Benjamin Rokseth 

Signed-off-by: Kyle M Hall 

Bug 12598 - Move importing code to a subroutine

Signed-off-by: Benjamin Rokseth 

Signed-off-by: Kyle M Hall 

Bug 12598 - Update command line script to use patron import subroutine

Signed-off-by: Benjamin Rokseth 

Signed-off-by: Kyle M Hall 

Bug 12598 [QA Followup]

* Fix copyright on import_borrowers.pl
* Changes -c --csv to -f --file
* Adds -c --confirm option
* Renames misc/import_borrowers.pl to misc/import_patrons.pl
* Restore userid matchpoint option

Signed-off-by: Kyle M Hall 

Bug 12598 - Fix merge to master. Backport 3 updates from latest
import_borrowers.pl

Signed-off-by: Kyle M Hall 

Bug 12598 - Started regression tests. Fix missing C4::Members::Attributes
package

Signed-off-by: Kyle M Hall 

Bug 12598 - More refactoring and regression tests in Koha::Patrons::Import

Signed-off-by: Kyle M Hall 

Bug 12598 - Creating objects in misc/import_patrons.pl and
tools/import_borrowers.pl

Signed-off-by: Kyle M Hall 

Bug 12598 - Refactoring Koha::Patrons::Import includes bug fixed for critical
date types and header column parsing

Signed-off-by: Kyle M Hall 

Bug 12598 - Rebase + backport of 16426 plus fixing 16426

Signed-off-by: Kyle M Hall 

Bug 12598: catch warnings raised by import_patrons in tests

Signed-off-by: Colin Campbell 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

Kyle M Hall  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

--- Comment #168 from Jonathan Druart  
---
(In reply to Katrin Fischer from comment #165)
> I've taken a look at the patches for a first QA review. 

1 & 2 have been fixed.

> 3) Might be me, but trying to run the script always gives me the help, no
> error or anything. Used -c and -f with a random file.

I improved the POD for the script, --matchpoint is required.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

--- Comment #167 from Jonathan Druart  
---
Created attachment 70266
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70266=edit
Bug 12598: Use Pod::Usage and make the help more explicit

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

Jonathan Druart  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

--- Comment #166 from Jonathan Druart  
---
Created attachment 70265
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70265=edit
Bug 12598: Remove warnings from tests and make them pass

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #165 from Katrin Fischer  ---
I've taken a look at the patches for a first QA review. 

1) Currently fails QA script:

 FAIL   t/db_dependent/Koha/Patrons/Import.t
   FAIL   critic
"$headerrow_0" is declared but not used at line 320, column 5.
Unused variables clutter code and make it harder to read.

2) Tests fail:

kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ perl
t/db_dependent/Koha/Patrons/Import.t
1..124
ok 1 - use Koha::Patrons::Import;
ok 2 - An object of class 'Koha::Patrons::Import' isa 'Koha::Patrons::Import'
# Subtest: test_methods
1..1
ok 1 - Koha::Patrons::Import->can(...)
ok 3 - test_methods
# Subtest: test_attributes
1..1
ok 1 - Koha::Patrons::Import->can(...)
ok 4 - test_attributes
ok 5 -  Koha::Patrons::Import->import_patrons carps if no file handle is passed
ok 6 - Got the expected undef from import_patrons with nothing much
ok 7 -  Koha::Patrons::Import->import_patrons carps if no file handle is passed
ok 8 - Got the expected undef from import_patrons with no file handle
Use of uninitialized value $matchpoint in string eq at
/home/vagrant/kohaclone/Koha/Patrons/Import.pm line 170, <$handle_1> line 2.
# Looks like your test exited with 255 just after 8.

3) Might be me, but trying to run the script always gives me the help, no error
or anything. Used -c and -f with a random file.

Can you please take a look?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

Colin Campbell  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #164 from Colin Campbell  ---
Signed off Jonathans patches for Patron lists and import of Debarments

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

Colin Campbell  changed:

   What|Removed |Added

  Attachment #66582|0   |1
is obsolete||

--- Comment #163 from Colin Campbell  ---
Created attachment 67277
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67277=edit
Bug 12598: Add use Koha::Patron::Debarments statement

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

Colin Campbell  changed:

   What|Removed |Added

  Attachment #66581|0   |1
is obsolete||

--- Comment #162 from Colin Campbell  ---
Created attachment 67276
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67276=edit
Bug 12598: Re-add bug 18555: Create patron list from patron import

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

--- Comment #161 from Jonathan Druart  
---
(In reply to Colin Campbell from comment #151)
> The recently applied to master patch
> 
>  Bug 17829: (follow-up) Fix import patron
> 
> needs to be reverted inorder for the first of these patch to still apply

First patch has been rebased to fix this conflict.

(In reply to Colin Campbell from comment #152)
> Koha/Patrons/Import.pm
> 
> Should have a 'use Koha::Patron::Debarments;'  to avoid runtime errors with
> undefined subroutine GetDebarments called

Fixed in the last patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

--- Comment #159 from Jonathan Druart  
---
Created attachment 66581
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66581=edit
Bug 12598: Re-add bug 18555: Create patron list from patron import

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

--- Comment #160 from Jonathan Druart  
---
Created attachment 66582
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66582=edit
Bug 12598: Add use Koha::Patron::debarments statement

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

--- Comment #158 from Jonathan Druart  
---
Created attachment 66580
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66580=edit
Bug 12598 Allow matched patron to be updated

When a test was introduced to not add duplicate userids
it overlooked that if you were matching on userid you
do not want the update to be rejected.

Add a test to overcome this logical flaw if updating
by matching userid

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

--- Comment #157 from Jonathan Druart  
---
Created attachment 66579
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66579=edit
Bug 12598: Re-add some missing stuffs

This patch will have to be squashed with previous ones, but for
readability I prefer to let it alone for now.

It reintroduces 2 missing changes:
  commit fd123903651435c56ca14d88897e9ce4d7a38bb5
Bug 15010: Import patron tool creates 'duplicate' restrictions (
debarments )
  commit 011d8e9855ffeb1779f5c1aadc9f4367c298cee7
Bug 12543 - Add userid as matchpoint for "Import patrons" tool

Signed-off-by: Colin Campbell 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

--- Comment #156 from Jonathan Druart  
---
Created attachment 66578
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66578=edit
Bug 12598: Fix conflict with 17829 - GetMember

Signed-off-by: Colin Campbell 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

--- Comment #155 from Jonathan Druart  
---
Created attachment 66577
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66577=edit
Bug 12598: Fix conflict with bug 16911

Tests will have to be written for this change

Signed-off-by: Colin Campbell 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #66353|0   |1
is obsolete||
  Attachment #66354|0   |1
is obsolete||
  Attachment #66355|0   |1
is obsolete||
  Attachment #66356|0   |1
is obsolete||
  Attachment #66357|0   |1
is obsolete||
  Attachment #66358|0   |1
is obsolete||
  Attachment #66359|0   |1
is obsolete||

--- Comment #153 from Jonathan Druart  
---
Created attachment 66575
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66575=edit
Bug 12598: New misc/import_borrowers.pl command line tool

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

--- Comment #154 from Jonathan Druart  
---
Created attachment 66576
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66576=edit
Bug 12598: Update code to use new modules

Signed-off-by: Colin Campbell 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

--- Comment #152 from Colin Campbell  ---
Koha/Patrons/Import.pm

Should have a 'use Koha::Patron::Debarments;'  to avoid runtime errors with
undefined subroutine GetDebarments called

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

--- Comment #151 from Colin Campbell  ---
The recently applied to master patch

 Bug 17829: (follow-up) Fix import patron

needs to be reverted inorder for the first of these patch to still apply

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

--- Comment #150 from Jonathan Druart  
---
Created attachment 66359
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66359=edit
Bug 12598: Re-add bug 18555: Create patron list from patron import

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

--- Comment #149 from Jonathan Druart  
---
Created attachment 66358
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66358=edit
Bug 12598 Allow matched patron to be updated

When a test was introduced to not add duplicate userids
it overlooked that if you were matching on userid you
do not want the update to be rejected.

Add a test to overcome this logical flaw if updating
by matching userid

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

--- Comment #148 from Jonathan Druart  
---
Created attachment 66357
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66357=edit
Bug 12598: Re-add some missing stuffs

This patch will have to be squashed with previous ones, but for
readability I prefer to let it alone for now.

It reintroduces 2 missing changes:
  commit fd123903651435c56ca14d88897e9ce4d7a38bb5
Bug 15010: Import patron tool creates 'duplicate' restrictions (
debarments )
  commit 011d8e9855ffeb1779f5c1aadc9f4367c298cee7
Bug 12543 - Add userid as matchpoint for "Import patrons" tool

Signed-off-by: Colin Campbell 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

--- Comment #147 from Jonathan Druart  
---
Created attachment 66356
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66356=edit
Bug 12598: Fix conflict with 17829 - GetMember

Signed-off-by: Colin Campbell 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

--- Comment #146 from Jonathan Druart  
---
Created attachment 66355
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66355=edit
Bug 12598: Fix conflict with bug 16911

Tests will have to be written for this change

Signed-off-by: Colin Campbell 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

--- Comment #145 from Jonathan Druart  
---
Created attachment 66354
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66354=edit
Bug 12598: Update code to use new modules

Signed-off-by: Colin Campbell 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #65819|0   |1
is obsolete||
  Attachment #65820|0   |1
is obsolete||
  Attachment #65821|0   |1
is obsolete||
  Attachment #65822|0   |1
is obsolete||
  Attachment #65823|0   |1
is obsolete||
  Attachment #65824|0   |1
is obsolete||

--- Comment #144 from Jonathan Druart  
---
Created attachment 66353
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66353=edit
Bug 12598: New misc/import_borrowers.pl command line tool

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

Jonathan Druart  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

--- Comment #143 from Katrin Fischer  ---
Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 12598: New misc/import_borrowers.pl command line tool
Using index info to reconstruct a base tree...
M   koha-tmpl/intranet-tmpl/prog/en/modules/tools/import_borrowers.tt
M   tools/import_borrowers.pl
Falling back to patching base and 3-way merge...
Auto-merging tools/import_borrowers.pl
CONFLICT (content): Merge conflict in tools/import_borrowers.pl
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/tools/import_borrowers.tt
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/en/modules/tools/import_borrowers.tt
error: Failed to merge in the changes.
Patch failed at 0001 Bug 12598: New misc/import_borrowers.pl command line tool
The copy of the patch that failed is found in: .git/rebase-apply/patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in /tmp/New-importborrowerspl-command-tool-MjxqyB.patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

--- Comment #142 from Colin Campbell  ---
Created attachment 65824
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65824=edit
Allow matched patron to be updated

Additional patch to be included - currently if matching is on userid and there
is a match the update is rejected. Historically the addition of the userid
match point and the guard against adding duplicate userids were separate
patches merged around the same time without taking account of each other. This
rectifies the problem. - Will submit a patch for the existing code separately
but will also need including in this enhancement

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

Colin Campbell  changed:

   What|Removed |Added

  Attachment #65218|0   |1
is obsolete||

--- Comment #141 from Colin Campbell  ---
Created attachment 65823
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65823=edit
Re-add some missing stuff

Signed off these patches after testing

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

Colin Campbell  changed:

   What|Removed |Added

  Attachment #65217|0   |1
is obsolete||

--- Comment #140 from Colin Campbell  ---
Created attachment 65822
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65822=edit
Fix conflict with 17829 - GetMember

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

Colin Campbell  changed:

   What|Removed |Added

  Attachment #65215|0   |1
is obsolete||
  Attachment #65216|0   |1
is obsolete||

--- Comment #139 from Colin Campbell  ---
Created attachment 65821
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65821=edit
Fis conflict with bug 16911

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

--- Comment #138 from Colin Campbell  ---
Created attachment 65820
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65820=edit
Update code to use new modules

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

Colin Campbell  changed:

   What|Removed |Added

  Attachment #65214|0   |1
is obsolete||

--- Comment #137 from Colin Campbell  ---
Created attachment 65819
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65819=edit
New import_borrowers.pl command tool

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

--- Comment #136 from Jonathan Druart  
---
(In reply to Colin Campbell from comment #130)
> Code in Koha/Patrons?Import.pm does not reflect latest version of existing
> import. When we tested we fell foul of the fact that it effectively undid
> the changes introduced by bug 12543 - it rejects all records matching on
> userid. As that is probably the most common matchpoint in the sites that do
> regular offline updates its a showstopper. Maybe that other functionality
> present in current load is missing

Hi Colin, thanks for catching that. I have rebased the patches and provide
other follow-ups.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

--- Comment #132 from Jonathan Druart  
---
Created attachment 65215
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65215=edit
Bug 12598: Update code to use new modules

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

--- Comment #135 from Jonathan Druart  
---
Created attachment 65218
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65218=edit
Bug 12598: Re-add some missing stuffs

This patch will have to be squashed with previous ones, but for
readability I prefer to let it alone for now.

It reintroduces 2 missing changes:
  commit fd123903651435c56ca14d88897e9ce4d7a38bb5
Bug 15010: Import patron tool creates 'duplicate' restrictions (
debarments )
  commit 011d8e9855ffeb1779f5c1aadc9f4367c298cee7
Bug 12543 - Add userid as matchpoint for "Import patrons" tool

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

--- Comment #134 from Jonathan Druart  
---
Created attachment 65217
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65217=edit
Bug 12598: Fix conflict with 17829 - GetMember

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

--- Comment #133 from Jonathan Druart  
---
Created attachment 65216
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65216=edit
Bug 12598: Fix conflict with bug 16911

Tests will have to be written for this change

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #64437|0   |1
is obsolete||
  Attachment #64438|0   |1
is obsolete||
  Attachment #64855|0   |1
is obsolete||

--- Comment #131 from Jonathan Druart  
---
Created attachment 65214
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65214=edit
Bug 12598: New misc/import_borrowers.pl command line tool

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

--- Comment #130 from Colin Campbell  ---
Code in Koha/Patrons?Import.pm does not reflect latest version of existing
import. When we tested we fell foul of the fact that it effectively undid the
changes introduced by bug 12543 - it rejects all records matching on userid. As
that is probably the most common matchpoint in the sites that do regular
offline updates its a showstopper. Maybe that other functionality present in
current load is missing

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

--- Comment #129 from Jonathan Druart  
---
Created attachment 64855
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64855=edit
Bug 12598: Fix conflict with bug 16911

Tests will have to be written for this change

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

Alan  changed:

   What|Removed |Added

 CC|aschr...@eunc.edu   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

Colin Campbell  changed:

   What|Removed |Added

 CC||colin.campbell@ptfs-europe.
   ||com

--- Comment #128 from Colin Campbell  ---
Problem occured in testing

Koha/Patrons/Import.pm calls undefined GetExpiryDate method

Undefined subroutine ::Patrons::Import::GetExpiryDate called at
/usr/share/koha/lib/Koha/Patrons/Import.pm line 161

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

Jonathan Druart  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #127 from Jonathan Druart  
---
I tried to revive these patches, I had to squash all patches to rebase them
(authorship lost, sorry!).

I have pushed a branch with all previous patches applied on
https://github.com/joubu/Koha/tree/old/20160701_bug_12598 (so not up-to-date).

I switched the status to Needs Signoff to get feedback and know/estimate what
need to be done to get something ready for push.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

--- Comment #126 from Jonathan Druart  
---
Created attachment 64438
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64438=edit
Bug 12598: Update code to use new modules

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #52323|0   |1
is obsolete||
  Attachment #52324|0   |1
is obsolete||
  Attachment #52325|0   |1
is obsolete||
  Attachment #52326|0   |1
is obsolete||
  Attachment #52327|0   |1
is obsolete||
  Attachment #52328|0   |1
is obsolete||
  Attachment #52329|0   |1
is obsolete||
  Attachment #52330|0   |1
is obsolete||
  Attachment #52331|0   |1
is obsolete||
  Attachment #52332|0   |1
is obsolete||
  Attachment #52333|0   |1
is obsolete||
  Attachment #52540|0   |1
is obsolete||

--- Comment #125 from Jonathan Druart  
---
Created attachment 64437
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64437=edit
Bug 12598: New misc/import_borrowers.pl command line tool

Test Plan:
1) Apply this patch
2) Test importing patrons from command line,
   options are availble with --help.

Signed-off-by: Bernardo Gonzalez Kriegel 

Tested with minimal csv
(cardnumber,surname,firstname,categorycode,branchcode,password,userid)

Overwrite does not change category or branch.
Patrons are loaded, userid & password works

Updated license to GPLv3
No other koha-qa errors.

Signed-off-by: Benjamin Rokseth 

Signed-off-by: Kyle M Hall 

Bug 12598 - Tidy import_borrowers.pl

Signed-off-by: Benjamin Rokseth 

Signed-off-by: Kyle M Hall 

Bug 12598 - Move importing code to a subroutine

Signed-off-by: Benjamin Rokseth 

Signed-off-by: Kyle M Hall 

Bug 12598 - Update command line script to use patron import subroutine

Signed-off-by: Benjamin Rokseth 

Signed-off-by: Kyle M Hall 

Bug 12598 [QA Followup]

* Fix copyright on import_borrowers.pl
* Changes -c --csv to -f --file
* Adds -c --confirm option
* Renames misc/import_borrowers.pl to misc/import_patrons.pl
* Restore userid matchpoint option

Signed-off-by: Kyle M Hall 

Bug 12598 - Fix merge to master. Backport 3 updates from latest
import_borrowers.pl

Signed-off-by: Kyle M Hall 

Bug 12598 - Started regression tests. Fix missing C4::Members::Attributes
package

Signed-off-by: Kyle M Hall 

Bug 12598 - More refactoring and regression tests in Koha::Patrons::Import

Signed-off-by: Kyle M Hall 

Bug 12598 - Creating objects in misc/import_patrons.pl and
tools/import_borrowers.pl

Signed-off-by: Kyle M Hall 

Bug 12598 - Refactoring Koha::Patrons::Import includes bug fixed for critical
date types and header column parsing

Signed-off-by: Kyle M Hall 

Bug 12598 - Rebase + backport of 16426 plus fixing 16426

Signed-off-by: Kyle M Hall 

Bug 12598: catch warnings raised by import_patrons in tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

Nicole C. Engard  changed:

   What|Removed |Added

 CC||a...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

--- Comment #124 from Jonathan Druart  
---
(In reply to Jonathan Druart from comment #123)
> What you are doing is just initializing them, so you can do that in the
> constructor (new).

Florent, let me know if you need more info about how to do it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

--- Comment #123 from Jonathan Druart  
---
(In reply to Florent Mara from comment #122)
> I agree with most of it - also I can't reproduce the failed tests - but I
> can fail other tests so some of these need to be reconsidered. 
> $headerrow_0 shouldn't be there. Namespace uniformity sounds like an
> excellent idea, any suggestion/guidance? 

Actually it was added by bug 14722 which is already pushed.
I have added the topic to the next dev meeting, just in case
(https://wiki.koha-community.org/wiki/Development_IRC_meeting_13_July_2016).
I have already talked about this to someone, but I don't find anything.

> The part that confuses me is around Moo usage and I assume the comment
> refers to Koha::Patrons::Import. The module has 2 attributes ('today_iso'
> and 'text_csv'), can these exist without importing Moo?

Yes of course.
What you are doing is just initializing them, so you can do that in the
constructor (new).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

--- Comment #122 from Florent Mara  ---
I agree with most of it - also I can't reproduce the failed tests - but I can
fail other tests so some of these need to be reconsidered. 
$headerrow_0 shouldn't be there. Namespace uniformity sounds like an excellent
idea, any suggestion/guidance? 

The part that confuses me is around Moo usage and I assume the comment refers
to Koha::Patrons::Import. The module has 2 attributes ('today_iso' and
'text_csv'), can these exist without importing Moo?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #121 from Jonathan Druart  
---
1/ + use namespace::clean;

Why do you need it?

2/ + use Moo;

You are going to start a neverending debate using Moo: it is not marked as
mandatory and is not used from a CGI script. If you persist, you will have to
start the discussion during the next dev meeting.

3/ On bug 15451, I have created a Koha::Exporter::Record file, which will
export records.
Here you created a Koha::Patrons::Import. We will need to uniformise the
namespace.

4/ You should use pod2usage to display the help of the command line script

5/ Doc of the script is wrong:
  import_patrons.pl -c /path/to/patrons.csv -m cardnumber
-f is missing

6/ Data::Dumper is not imported

7/ The pod does not explain that the script supports several levels of
verbosity

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

--- Comment #120 from Jonathan Druart  
---
FAIL   t/db_dependent/Koha/Patrons/Import.t
  FAIL   critic
"$headerrow_0" is declared but not used at line 313, column 5. Unused
variables clutter code and make it harder to read.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

--- Comment #119 from Jonathan Druart  
---
2 Tests are failing
t/db_dependent/Koha/Patrons/Import.t .. 2/124 
#   Failed test 'Got the expected array size from set column keys with
undef extended'
#   at t/db_dependent/Koha/Patrons/Import.t line 398.
#  got: '67'
# expected: '66'

#   Failed test 'Got the expected array size from set column keys with
extended'
#   at t/db_dependent/Koha/Patrons/Import.t line 405.
#  got: '68'
# expected: '67'
# Looks like you failed 2 tests of 2

I guess it's because a new column has been added to the borrowers table.
Maybe it would be better to test that
  @columnkeys_1 = @columnkeys_0 + 1
don't you think?
It would avoid these 2 tests to fail each time a new column is added/removed to
this table.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

--- Comment #118 from Jonathan Druart  
---
Created attachment 52540
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52540=edit
Bug 12598: catch warnings raised by import_patrons in tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

--- Comment #117 from Kyle M Hall  ---
Created attachment 52333
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52333=edit
Bug 12598 - Rebase + backport of 16426 plus fixing 16426

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

--- Comment #116 from Kyle M Hall  ---
Created attachment 52332
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52332=edit
Bug 12598 - Refactoring Koha::Patrons::Import includes bug fixed for critical
date types and header column parsing

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

--- Comment #113 from Kyle M Hall  ---
Created attachment 52329
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52329=edit
Bug 12598 - Started regression tests. Fix missing C4::Members::Attributes
package

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

--- Comment #115 from Kyle M Hall  ---
Created attachment 52331
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52331=edit
Bug 12598 - Creating objects in misc/import_patrons.pl and
tools/import_borrowers.pl

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

--- Comment #114 from Kyle M Hall  ---
Created attachment 52330
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52330=edit
Bug 12598 - More refactoring and regression tests in Koha::Patrons::Import

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

--- Comment #112 from Kyle M Hall  ---
Created attachment 52328
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52328=edit
Bug 12598 - Fix merge to master. Backport 3 updates from latest
import_borrowers.pl

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

--- Comment #111 from Kyle M Hall  ---
Created attachment 52327
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52327=edit
Bug 12598 [QA Followup]

* Fix copyright on import_borrowers.pl
* Changes -c --csv to -f --file
* Adds -c --confirm option
* Renames misc/import_borrowers.pl to misc/import_patrons.pl
* Restore userid matchpoint option

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

--- Comment #109 from Kyle M Hall  ---
Created attachment 52325
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52325=edit
Bug 12598 - Move importing code to a subroutine

Signed-off-by: Benjamin Rokseth 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

--- Comment #110 from Kyle M Hall  ---
Created attachment 52326
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52326=edit
Bug 12598 - Update command line script to use patron import subroutine

Signed-off-by: Benjamin Rokseth 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #51361|0   |1
is obsolete||
  Attachment #51362|0   |1
is obsolete||
  Attachment #51363|0   |1
is obsolete||
  Attachment #51364|0   |1
is obsolete||
  Attachment #51365|0   |1
is obsolete||
  Attachment #51366|0   |1
is obsolete||
  Attachment #51367|0   |1
is obsolete||
  Attachment #51368|0   |1
is obsolete||
  Attachment #51369|0   |1
is obsolete||
  Attachment #51370|0   |1
is obsolete||
  Attachment #51371|0   |1
is obsolete||

--- Comment #107 from Kyle M Hall  ---
Created attachment 52323
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52323=edit
Bug 12598: New misc/import_borrowers.pl command line tool

Test Plan:
1) Apply this patch
2) Test importing patrons from command line,
   options are availble with --help.

Signed-off-by: Bernardo Gonzalez Kriegel 

Tested with minimal csv
(cardnumber,surname,firstname,categorycode,branchcode,password,userid)

Overwrite does not change category or branch.
Patrons are loaded, userid & password works

Updated license to GPLv3
No other koha-qa errors.

Signed-off-by: Benjamin Rokseth 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

Kyle M Hall  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

--- Comment #108 from Kyle M Hall  ---
Created attachment 52324
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52324=edit
Bug 12598 - Tidy import_borrowers.pl

Signed-off-by: Benjamin Rokseth 

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

Mason James  changed:

   What|Removed |Added

 CC||m...@kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

--- Comment #106 from Florent Mara  ---
(Thank you Bernardo for the advice on trying to progress this) 

Here are the changes introduces in each of the 6 patches:
Patch 1 - Replace deprecated C4::Dates with Koha::DateUtils and backport fix
from master for entries with empty userids. This fix is deprecated in my last
commit due to bug 16426.

Patch 2 - Add missing dependency C4::Members::Attributes and some pod. Add the
first regression tests - none were present previously - with basic tests for
empty parameters variables and valid input file. 

Patch 3 - Introduced Moo. Refactored setting of column keys, missing borrower
category code and missing borrower branch code into 3 new methods. Features are
identical as prior. Each method is 100% test covered with subtests. 

Patch 4 - Update misc/import_patrons.pl and tools/import_borrowers.pl to use
Koha::Patrons::Import in an object oriented way.

Patch 5 - Adds missing dependency C4::Members::AttributeTypes. Refactor setting
attributes types, prepare columns and dates formatting into 3 new methods.
Features for attributes type and prepare column are identical. 

Date formatting was changes as follows after discussion with Chris.
* The previous implementation let parsing of dates silently failed then be
overwritten with system default values during import as the error was push to
@missing_criticals after this array was last considered. 
* The new implementation formats dates and uses @missing_criticals before it is
used to bail out of importing the entry. 

Each new method is 100% test covered with subtests. 

Patch 6 - Backport changes from bug 16426 and fixes the defect it introduces.
As per my comment in 16426, the fix was introduced at the wrong place in the
code which caused it to never be reached and prevents checks on duplicate
userid . 

Test plan:
1) Apply this patch. 
2) Set dateformat to mm/dd/. (Koha home->Administration->search for
dateformat -> select and save) 
3) run 'prove t/db_dependent/Koha/Patrons/Import.t'. All 122 tests should pass. 
These regression tests validate (1) Koha::Patrons::Import compiles, (2) all
fields output from the main import() method are identical before and after
refactoring (equivalence of output), (3) all 6 new methods provide the expected
feature, (4) backport duplicate userid fix. 
4) Run the online importer ( Koha home->tools->Import patrons) Load
PatronDataCSV1.csv sample file with default import parameters. It should result
in 165 imported records and 835 not imported because they are not in the
expected format.
This step validates that (1) tools/import_borrowers.pl works as previously and
wrongly formatted dates are now correctly being reported as such. 
5) Set dateformat to dd/mm/.
6) Run the new command line importer 'perl misc/import_patrons.pl -f
PatronDataCSV1.csv -c -m 'cardnumber' -v'
It should load the remaining 835 entries from the sample file.
Import complete:
Imported:835
Overwritten: 0
Skipped: 0
Invalid: 165
Total:   1000
This step validates the new command line tool misc/import_patrons works and
confirm date validation is effective.

While this is a big patch, it contains only one feature change to fix dates
being silently overwritten and is coming with a large number of tests with
extensive test coverage for all changes made. It also contains a regression
tested fix for bug 16426.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

Florent Mara  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

--- Comment #105 from Bernardo Gonzalez Kriegel  ---
(In reply to Florent Mara from comment #104)
> It is good enough for now. :-)

If it's ready, could you please change status to 'Needs Signoff'?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

--- Comment #104 from Florent Mara  ---
It is good enough for now. :-)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

--- Comment #103 from Bernardo Gonzalez Kriegel  ---
Is it ready to be signed?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

--- Comment #102 from Florent Mara  ---
This patch has been rebased today. Bug 16426 was backported and fixed.

Test plan:
1) Apply this patch. 
2) Set dateformat to mm/dd/. (Koha home->Administration->search for
dateformat -> select and save)
3) run 'prove t/db_dependent/Koha/Patrons/Import.t' which should result in 2
file handle warnings and 122 tests passing.
4) Run the online importer ( Koha home->tools->Import patrons) Load
PatronDataCSV1.csv sample file with default import parameters. It should result
in 165 imported records and 835 not imported because they are not in the
expected format.
5) Set dateformat to dd/mm/.
6) Run the new command line importer 'perl misc/import_patrons.pl -f
~/Downloads/PatronDataCSV1.csv -c -m 'cardnumber' -v'
It should load the remaining 835 entries from the sample file.
Import complete:
Imported:835
Overwritten: 0
Skipped: 0
Invalid: 165
Total:   1000
7) Optional. Run 'perl misc/import_patrons.pl --help' because you can.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

--- Comment #101 from Florent Mara  ---
Created attachment 51372
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51372=edit
Patrons sample data

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

--- Comment #100 from Florent Mara  ---
Created attachment 51371
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51371=edit
Bug 12598 - Rebase + backport of 16426 plus fixing 16426

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

Florent Mara  changed:

   What|Removed |Added

  Attachment #51122|0   |1
is obsolete||

--- Comment #99 from Florent Mara  ---
Created attachment 51370
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51370=edit
Bug 12598 - Refactoring Koha::Patrons::Import includes bug fixed for critical
date types and header column parsing

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

Florent Mara  changed:

   What|Removed |Added

  Attachment #50700|0   |1
is obsolete||

--- Comment #97 from Florent Mara  ---
Created attachment 51368
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51368=edit
Bug 12598 - More refactoring and regression tests in Koha::Patrons::Import

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

Florent Mara  changed:

   What|Removed |Added

  Attachment #50704|0   |1
is obsolete||

--- Comment #98 from Florent Mara  ---
Created attachment 51369
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51369=edit
Bug 12598 - Creating objects in misc/import_patrons.pl and
tools/import_borrowers.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12598] New misc/import_borrowers.pl command line tool

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12598

Florent Mara  changed:

   What|Removed |Added

  Attachment #50699|0   |1
is obsolete||

--- Comment #96 from Florent Mara  ---
Created attachment 51367
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51367=edit
Bug 12598 - Started regression tests. Fix missing C4::Members::Attributes
package

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/