[Koha-bugs] [Bug 12605] TestBuilder - Refactoring Acquisition/close_reopen_basket.t

2018-02-08 Thread bugzilla-daemon 
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12605

Victor Grousset/tuxayo  changed:

   What|Removed |Added

   Assignee|yohann.duf...@biblibre.com  |ch...@bigballofwax.co.nz
 CC||victor.grous...@biblibre.co
   ||m

--- Comment #5 from Victor Grousset/tuxayo  ---
Yohann doesn't work anymore at BibLibre.
Unassigning to avoid signaling that this bug is still being supervized. Which
could wrongly discourage someone to continue the work.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12605] TestBuilder - Refactoring Acquisition/close_reopen_basket.t

2015-06-17 Thread bugzilla-daemon 
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12605

--- Comment #4 from M. Tompsett mtomp...@hotmail.com ---
Comment on attachment 30089
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30089
[SIGNED-OFF] Bug 12604: refactoring close_reopen_basket.t with TestBuilder

Review of attachment 30089:
 -- 
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.htmlbug=12605attachment=30089)
-

::: t/db_dependent/Acquisition/close_reopen_basket.t
@@ -46,5 @@
 -my ($ordernumber1, $ordernumber2);
 -( undef, $ordernumber1 ) = C4::Acquisition::NewOrder(
 -{
 -basketno = $basketno,
 -quantity = 24,

How is this quantity reflected in the refactored code?

@@ -55,5 @@
  
 -( undef, $ordernumber2 ) = C4::Acquisition::NewOrder(
 -{
 -basketno = $basketno,
 -quantity = 42,

How is this quantity reflected in the refactored code?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12605] TestBuilder - Refactoring Acquisition/close_reopen_basket.t

2014-10-13 Thread bugzilla-daemon 
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12605

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl
Version|unspecified |master
 QA Contact|gmcha...@gmail.com  |m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12605] TestBuilder - Refactoring Acquisition/close_reopen_basket.t

2014-10-13 Thread bugzilla-daemon 
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12605

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 Status|Signed Off  |Patch doesn't apply

--- Comment #3 from M. de Rooy m.de.r...@rijksmuseum.nl ---
CONFLICT (content): Merge conflict in
t/db_dependent/Acquisition/close_reopen_basket.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12605] TestBuilder - Refactoring Acquisition/close_reopen_basket.t

2014-07-25 Thread bugzilla-daemon 
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12605

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #29851|0   |1
is obsolete||

--- Comment #2 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 30089
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30089action=edit
[SIGNED-OFF] Bug 12604: refactoring close_reopen_basket.t with TestBuilder

The tests have been refactored with the module TestBuilder.

Test plan:
1/ Apply the patch 12603 and the last patch of bug 11518.
2/ The command : prove t/db_dependent/Acquisition/close_reopen_basket.t has to
be a success without error or warning :
t/db_dependent/Acquisition/close_reopen_basket.t .. ok
All tests successful.
Files=1, Tests=7,  1 wallclock secs ( 0.03 usr  0.01 sys +  1.71 cusr  0.09
csys =  1.84 CPU)
Result: PASS

http://bugs.koha-community.org/show_bug.cgi?id=12605

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12605] TestBuilder - Refactoring Acquisition/close_reopen_basket.t

2014-07-25 Thread bugzilla-daemon 
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12605

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12605] TestBuilder - Refactoring Acquisition/close_reopen_basket.t

2014-07-18 Thread bugzilla-daemon 
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12605

Yohann Dufour yohann.duf...@biblibre.com changed:

   What|Removed |Added

 Status|NEW |ASSIGNED
   Assignee|ch...@bigballofwax.co.nz|yohann.duf...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12605] TestBuilder - Refactoring Acquisition/close_reopen_basket.t

2014-07-18 Thread bugzilla-daemon 
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12605

--- Comment #1 from Yohann Dufour yohann.duf...@biblibre.com ---
Created attachment 29851
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29851action=edit
Bug 12604: refactoring close_reopen_basket.t with TestBuilder

The tests have been refactored with the module TestBuilder.

Test plan:
1/ Apply the patch 12603 and the last patch of bug 11518.
2/ The command : prove t/db_dependent/Acquisition/close_reopen_basket.t has to
be a success without error or warning :
t/db_dependent/Acquisition/close_reopen_basket.t .. ok
All tests successful.
Files=1, Tests=7,  1 wallclock secs ( 0.03 usr  0.01 sys +  1.71 cusr  0.09
csys =  1.84 CPU)
Result: PASS

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12605] TestBuilder - Refactoring Acquisition/close_reopen_basket.t

2014-07-18 Thread bugzilla-daemon 
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12605

Yohann Dufour yohann.duf...@biblibre.com changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
   Patch complexity|--- |Medium patch
 Depends on||12603

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/