[Koha-bugs] [Bug 12805] Proposed changes to Koha plugins system (.KPZ) structure

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12805

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12805] Proposed changes to Koha plugins system (.KPZ) structure

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12805

Josef Moravec  changed:

   What|Removed |Added

 CC||josef.mora...@gmail.com

--- Comment #12 from Josef Moravec  ---
This also should be one script with parameters --enable and --disable, as it is
in other Koha debian commands

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12805] Proposed changes to Koha plugins system (.KPZ) structure

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12805

M. Tompsett  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||mtomp...@hotmail.com

--- Comment #11 from M. Tompsett  ---
With plack changes and the like, this no longer applies. :(
Tinkered with getting it up, but not finished, so marking does not apply until
someone rebases or fixes it. :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12805] Proposed changes to Koha plugins system (.KPZ) structure

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12805

--- Comment #10 from Magnus Enger  ---
The new scripts need to be documented in man pages, similar to the existing
scripts.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12805] Proposed changes to Koha plugins system (.KPZ) structure

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12805

Magnus Enger  changed:

   What|Removed |Added

 Status|In Discussion   |Needs Signoff

--- Comment #9 from Magnus Enger  ---
Looks like this has a patch that needs signoff. Changing the status
accordingly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12805] Proposed changes to Koha plugins system (.KPZ) structure

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12805

Magnus Enger mag...@enger.priv.no changed:

   What|Removed |Added

 CC||mag...@enger.priv.no

--- Comment #8 from Magnus Enger mag...@enger.priv.no ---
(In reply to Viktor Sarge from comment #5)
 I can only provide partial feedback here. An optional command line tool
 would be a welcome addition. It's practical when you are afraid to to mess
 the file up, while still making it possible to edit it manually and learn a
 little more about whats going on under the hood.

This got me thinking about the possibilities of adding a general purpose
koha-config script. See bug 12824 for some suggestions/questions.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12805] Proposed changes to Koha plugins system (.KPZ) structure

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12805

Viktor Sarge viktor.sa...@regionhalland.se changed:

   What|Removed |Added

 CC||viktor.sarge@regionhalland.
   ||se

--- Comment #5 from Viktor Sarge viktor.sa...@regionhalland.se ---
I can only provide partial feedback here. An optional command line tool would
be a welcome addition. It's practical when you are afraid to to mess the file
up, while still making it possible to edit it manually and learn a little more
about whats going on under the hood.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12805] Proposed changes to Koha plugins system (.KPZ) structure

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12805

--- Comment #6 from Indranil Das Gupta indr...@gmail.com ---
Created attachment 31112
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31112action=edit
Adds koha-enable-plugins and koha-disable-plugins scripts

Command-line koha-* script to toggle enable_plugins definition in
site specific koha-conf.xml; also to add plugins listing to existing
koha-list command. These files are expected to be used for a .deb
package based installation of Koha

Test plan:

1) Have a koha-common setup installed
2) Apply the patch and build a package for it.
3) Install it.
4) Verify that /yazgfz/config/enable_plugins is being toggled correctly
   when koha-enable-plugins and koha-disable-plugins are being called
   respectively.

-idg

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12805] Proposed changes to Koha plugins system (.KPZ) structure

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12805

--- Comment #7 from Robin Sheat ro...@catalyst.net.nz ---
While I haven't tested it yet, this patch looks like a good approach to me.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12805] Proposed changes to Koha plugins system (.KPZ) structure

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12805

Indranil Das Gupta indr...@gmail.com changed:

   What|Removed |Added

 CC||ch...@bigballofwax.co.nz,
   ||gmcha...@gmail.com,
   ||indr...@gmail.com,
   ||k...@bywatersolutions.com
   Assignee|gmcha...@gmail.com  |indr...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12805] Proposed changes to Koha plugins system (.KPZ) structure

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12805

Robin Sheat ro...@catalyst.net.nz changed:

   What|Removed |Added

 CC||ro...@catalyst.net.nz

--- Comment #1 from Robin Sheat ro...@catalyst.net.nz ---
1) is exactly how the packages do it now,
2) I don't see the need for this. At the moment you edit koha-conf.xml and set
enable_plugins to 1 and that's all that's needed. koha-enable-plugins would
just do that, but I feel it's doing such a small thing that it may as well be
just the edit.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12805] Proposed changes to Koha plugins system (.KPZ) structure

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12805

--- Comment #2 from Robin Sheat ro...@catalyst.net.nz ---
One change I would like is supporting .tar.gz, .zip is such a wrong idea on
linux systems. But that's probably its own bug :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12805] Proposed changes to Koha plugins system (.KPZ) structure

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12805

--- Comment #3 from Indranil Das Gupta indr...@gmail.com ---
(In reply to Robin Sheat from comment #1)
 1) is exactly how the packages do it now,

Mea culpa! Got that one clarified at #koha :-)

 2) I don't see the need for this. At the moment you edit koha-conf.xml and
 set enable_plugins to 1 and that's all that's needed. koha-enable-plugins
 would just do that, but I feel it's doing such a small thing that it may as
 well be just the edit.

Automation and ease-of-use. With newbie users that I'm training up on
Ubuntu/Koha combination, it is easier to have them run a command rather than
fire up an editor, locate the line and change 0 to 1. FWIW, these are not
technically savvy people and I've faced several cases of accidental deletion of
other crucial lines / insertion of extraneous characters while making these
small changes. These are largely train-and-let-go users whose only tech support
is via telephone. The installations typically do not have Internet access.

But yes, this is a niche case, and perhaps do not map into regular Koha users.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12805] Proposed changes to Koha plugins system (.KPZ) structure

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12805

--- Comment #4 from Robin Sheat ro...@catalyst.net.nz ---
I'm OK with having the script created, that's no problem. If someone writes it,
I certainly wouldn't veto it :)

But be aware that installing plugins may require some additional commandline
stuff too, chmod'ing files etc. 

Due to them being in a zip file, they can end up installed with the most unsafe
permissions possible, and that must be fixed from the command line. Also, some
scripts may need to be made executable.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/