[Koha-bugs] [Bug 12905] Deleting parent fund will orphan child funds, leaving them un-editable
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12905 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Summary|Deleting parent fund will |Deleting parent fund will |orphan child funds, leaving |orphan child funds, leaving |them un-editable. |them un-editable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12905] Deleting parent fund will orphan child funds, leaving them un-editable.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12905 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added CC||tomasco...@gmail.com Status|Passed QA |Pushed to Master --- Comment #10 from Tomás Cohen Arazi tomasco...@gmail.com --- Patch pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12905] Deleting parent fund will orphan child funds, leaving them un-editable.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12905
Kyle M Hall k...@bywatersolutions.com changed:
What|Removed |Added
Attachment #34133|0 |1
is obsolete||
--- Comment #9 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 34364
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34364action=edit
[PASSED QA] Bug 12905: funds with children could not be deleted
The interface should prevent to delete funds with children.
Otherwise the relationship is broken and problems occur:
1/ You don't see the orphan fund in the fund list
2/ You cannot edit the orphan fund amount ('Fund amount exceeds parent
allocation').
This patch:
- adds a JS check, template side
- adds a check in the perl script (should never be true)
- adds an updatedatabase check, in order to alert users with inconsistent data.
Test plan:
Verify you are not allow to delete a fund with children.
Signed-off-by: Paola Rossi paola.ro...@cineca.it
Signed-off-by: Kyle M Hall k...@bywatersolutions.com
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12905] Deleting parent fund will orphan child funds, leaving them un-editable.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12905 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12905] Deleting parent fund will orphan child funds, leaving them un-editable.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12905 Paola Rossi paola.ro...@cineca.it changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||paola.ro...@cineca.it -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12905] Deleting parent fund will orphan child funds, leaving them un-editable.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12905 Paola Rossi paola.ro...@cineca.it changed: What|Removed |Added Attachment #33474|0 |1 is obsolete|| --- Comment #8 from Paola Rossi paola.ro...@cineca.it --- Created attachment 34133 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34133action=edit Bug 12905: funds with children could not be deleted On master (head 12123) the problem was still present at my tests. I deleted the parent fund/aqbudget and I still saw the child fund using the MySQL client. In intranet, the child fund was not listed anymore from Funds and it could be seen only by this link [X is the budget_id of the aqbudget]: /koha/admin/aqbudgets.pl?op=add_formbudget_id=X I've applied the patch (head 12123). The patch needed a trivial rebase (on 3.19?). On a parent fund, the Delete action: was present in grey, warned This fund has children. as mouse moved on it; and prevented me from deleting the fund by the message: This fund has children. It cannot be deleted. when selected. On upgrading the database I saw the check alerting me about my inconsistent data, just as required. Everything seemed OK to me, I pass the patch to Signed Off status. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12905] Deleting parent fund will orphan child funds, leaving them un-editable.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12905
Jonathan Druart jonathan.dru...@biblibre.com changed:
What|Removed |Added
Status|In Discussion |Needs Signoff
--- Comment #7 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to Christopher Brannon from comment #6)
Jonathan and Barton,
Can you verify that this problem still exists?
Without the patch on master, I go through steps 1 through 11, and when I
delete the parent, the child fund is deleted as well. There is no longer
any sign of the child.
Christopher
Hi Christopher,
I tested 2 weeks ago and the problems were there.
They are:
1/ You don't see the orphan fund in the fund list
2/ You cannot edit the orphan fund amount ('Fund amount exceeds parent
allocation').
for 1/ you need to use the MySQL CLI.
Please back to In discussion if you confirm that you did not reproduce these
2 problems.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12905] Deleting parent fund will orphan child funds, leaving them un-editable.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12905 Christopher Brannon cbran...@cdalibrary.org changed: What|Removed |Added Status|Needs Signoff |In Discussion CC||cbran...@cdalibrary.org --- Comment #6 from Christopher Brannon cbran...@cdalibrary.org --- Jonathan and Barton, Can you verify that this problem still exists? Without the patch on master, I go through steps 1 through 11, and when I delete the parent, the child fund is deleted as well. There is no longer any sign of the child. Christopher -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12905] Deleting parent fund will orphan child funds, leaving them un-editable.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12905
Jonathan Druart jonathan.dru...@biblibre.com changed:
What|Removed |Added
Attachment #33457|0 |1
is obsolete||
--- Comment #4 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 33474
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33474action=edit
Bug 12905: funds with children could not be deleted
The interface should prevent to delete funds with children.
Otherwise the relationship is broken and problems occur:
1/ You don't see the orphan fund in the fund list
2/ You cannot edit the orphan fund amount ('Fund amount exceeds parent
allocation').
This patch:
- adds a JS check, template side
- adds a check in the perl script (should never be true)
- adds an updatedatabase check, in order to alert users with inconsistent data.
Test plan:
Verify you are not allow to delete a fund with children.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12905] Deleting parent fund will orphan child funds, leaving them un-editable.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12905 --- Comment #5 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to Jeremie from comment #3) Javascript verification is working, but i got an error when i'm 'hacking' the JS : Undefined subroutine main::HasChildren called at /inlibro/git/koha-try4jeremie-dev-inlibro/admin/aqbudgets.pl line 234 Hello Jeremie, Thanks for testing it! Yes, the routine's name is BudgetHasChildren, not HasChildren... Fixed in the last patch, please retest. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12905] Deleting parent fund will orphan child funds, leaving them un-editable.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12905
Jeremie jeremie.benar...@inlibro.com changed:
What|Removed |Added
Attachment #33413|0 |1
is obsolete||
--- Comment #3 from Jeremie jeremie.benar...@inlibro.com ---
Created attachment 33457
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33457action=edit
Bug 12905: funds with children could not be deleted
The interface should prevent to delete funds with children.
Otherwise the relationship is broken and problems occur:
1/ You don't see the orphan fund in the fund list
2/ You cannot edit the orphan fund amount ('Fund amount exceeds parent
allocation').
This patch:
- adds a JS check, template side
- adds a check in the perl script (should never be true)
- adds an updatedatabase check, in order to alert users with inconsistent data.
Test plan:
Verify you are not allow to delete a fund with children.
Signed-off-by: jeremie.benarros jeremie.benar...@inlibro.com
Javascript verification is working, but i got an error when i'm 'hacking' the
JS :
Undefined subroutine main::HasChildren called at
/inlibro/git/koha-try4jeremie-dev-inlibro/admin/aqbudgets.pl line 234
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12905] Deleting parent fund will orphan child funds, leaving them un-editable.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12905
--- Comment #1 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 33413
--
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33413action=edit
Bug 12905: funds with children could not be deleted
The interface should prevent to delete funds with children.
Otherwise the relationship is broken and problems occur:
1/ You don't see the orphan fund in the fund list
2/ You cannot edit the orphan fund amount ('Fund amount exceeds parent
allocation').
This patch:
- adds a JS check, template side
- adds a check in the perl script (should never be true)
- adds an updatedatabase check, in order to alert users with inconsistent data.
Test plan:
Verify you are not allow to delete a fund with children.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12905] Deleting parent fund will orphan child funds, leaving them un-editable.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12905 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|NEW |Needs Signoff CC||jonathan.dru...@biblibre.co ||m Assignee|koha-b...@lists.koha-commun |jonathan.dru...@biblibre.co |ity.org |m Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12905] Deleting parent fund will orphan child funds, leaving them un-editable.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12905 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added CC||neng...@gmail.com --- Comment #2 from Jonathan Druart jonathan.dru...@biblibre.com --- *** Bug 4292 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12905] Deleting parent fund will orphan child funds, leaving them un-editable.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12905 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Version|3.14|master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12905] Deleting parent fund will orphan child funds, leaving them un-editable.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12905 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=4292 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
