[Koha-bugs] [Bug 12911] batch_id for new label batches can be assigned to several batches

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12911

Chris Cormack  changed:

   What|Removed |Added

   Keywords|Academy |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12911] batch_id for new label batches can be assigned to several batches

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12911

Nick Clemens  changed:

   What|Removed |Added

 Blocks|14739   |
   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=14739


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739
[Bug 14739] Add several patrons to a new batch will create a new batch per
patron added
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12911] batch_id for new label batches can be assigned to several batches

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12911

Jonathan Druart jonathan.dru...@bugs.koha-community.org changed:

   What|Removed |Added

 Blocks||14739


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14739
[Bug 14739] Add several patrons to a new batch will create a new batch per
patron added
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12911] batch_id for new label batches can be assigned to several batches

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12911

Jonathan Druart jonathan.dru...@bugs.koha-community.org changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #9 from Jonathan Druart jonathan.dru...@bugs.koha-community.org 
---
 Test plan:
 1 -In one browser window, go to tools-label creator and click the new batch
 button
 2 - Before adding items, open a new browser, and go tools-label creator and
 click the new batch button
 3 - Note that both batches have the same number listed
 4 - Add an item to the first batch - you should now see one item in the batch
 5 - Add an item to the second batch, you should see two items in the batch
 6 - Apply patch and repeat steps 12
 7 - Note that neither batch lists a batch number
 8 - Add an item to the first batch, you should see one item and a batch
 number
 9 - Add an item to the second batch, you should see one item and a new batch
 number

But does not work if you add a second item!

See bug 14739 and please provide a quick fix.
This bug is much more annoying than the one fixed by this patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12911] batch_id for new label batches can be assigned to several batches

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12911

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

 CC||ch...@bigballofwax.co.nz
 Status|Pushed to Master|Pushed to Stable

--- Comment #8 from Chris Cormack ch...@bigballofwax.co.nz ---
Pushed to 3.18.x will be in 3.18.7

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12911] batch_id for new label batches can be assigned to several batches

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12911

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

 Blocks||14204

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12911] batch_id for new label batches can be assigned to several batches

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12911

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||tomasco...@gmail.com

--- Comment #7 from Tomás Cohen Arazi tomasco...@gmail.com ---
Patch pushed to master.

Thanks Nick!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12911] batch_id for new label batches can be assigned to several batches

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12911

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #35807|0   |1
is obsolete||

--- Comment #6 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 35898
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35898action=edit
[PASSED QA] Bug 12911 - batch_id for new labels batches can be asssigned to
several batches

Currently batch_id is assigned upon creation of a new batch object.  This patch
leaves batch_id as 0 at creation and adds a check when adding items.  If batch
is new then batch_id is created then

Test plan:
1 -In one browser window, go to tools-label creator and click the new batch
button
2 - Before adding items, open a new browser, and go tools-label creator and
click the new batch button
3 - Note that both batches have the same number listed
4 - Add an item to the first batch - you should now see one item in the batch
5 - Add an item to the second batch, you should see two items in the batch
6 - Apply patch and repeat steps 12
7 - Note that neither batch lists a batch number
8 - Add an item to the first batch, you should see one item and a batch number
9 - Add an item to the second batch, you should see one item and a new batch
number

Patch behaves as expected.
Signed-off-by: Marc Veron ve...@veron.ch

Signed-off-by: Kyle M Hall k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12911] batch_id for new label batches can be assigned to several batches

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12911

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12911] batch_id for new label batches can be assigned to several batches

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12911

--- Comment #5 from Marc Véron ve...@veron.ch ---
Created attachment 35807
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35807action=edit
[Signed-off] Bug 12911 - batch_id for new labels batches can be asssigned to
several batches

Currently batch_id is assigned upon creation of a new batch object.  This patch
leaves batch_id as 0 at creation and adds a check when adding items.  If batch
is new then batch_id is created then

Test plan:
1 -In one browser window, go to tools-label creator and click the new batch
button
2 - Before adding items, open a new browser, and go tools-label creator and
click the new batch button
3 - Note that both batches have the same number listed
4 - Add an item to the first batch - you should now see one item in the batch
5 - Add an item to the second batch, you should see two items in the batch
6 - Apply patch and repeat steps 12
7 - Note that neither batch lists a batch number
8 - Add an item to the first batch, you should see one item and a batch number
9 - Add an item to the second batch, you should see one item and a new batch
number

Patch behaves as expected.
Signed-off-by: Marc Véron ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12911] batch_id for new label batches can be assigned to several batches

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12911

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

 CC||ve...@veron.ch
  Attachment #35719|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12911] batch_id for new label batches can be assigned to several batches

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12911

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12911] batch_id for new label batches can be assigned to several batches

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12911

Marjorie Barry-Vila marjorie.barry-v...@ccsr.qc.ca changed:

   What|Removed |Added

 CC||marjorie.barry-v...@ccsr.qc
   ||.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12911] batch_id for new label batches can be assigned to several batches

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12911

Nick Clemens n...@quecheelibrary.org changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12911] batch_id for new label batches can be assigned to several batches

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12911

Nick Clemens n...@quecheelibrary.org changed:

   What|Removed |Added

  Attachment #35600|0   |1
is obsolete||

--- Comment #4 from Nick Clemens n...@quecheelibrary.org ---
Created attachment 35719
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35719action=edit
Bug 12911 - batch_id for new labels batches can be asssigned to several batches

Currently batch_id is assigned upon creation of a new batch object.  This patch
leaves batch_id as 0 at creation and adds a check when adding items.  If batch
is new then batch_id is created then

Test plan:
1 -In one browser window, go to tools-label creator and click the new batch
button
2 - Before adding items, open a new browser, and go tools-label creator and
click the new batch button
3 - Note that both batches have the same number listed
4 - Add an item to the first batch - you should now see one item in the batch
5 - Add an item to the second batch, you should see two items in the batch
6 - Apply patch and repeat steps 12
7 - Note that neither batch lists a batch number
8 - Add an item to the first batch, you should see one item and a batch number
9 - Add an item to the second batch, you should see one item and a new batch
number

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12911] batch_id for new label batches can be assigned to several batches

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12911

Nick Clemens n...@quecheelibrary.org changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |n...@quecheelibrary.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12911] batch_id for new label batches can be assigned to several batches

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12911

Nick Clemens n...@quecheelibrary.org changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #3 from Nick Clemens n...@quecheelibrary.org ---
I tried testing and got odd results with one number displaying as batch id, but
the results saving into the DB with a higher batch id, I suspect there is some
double increment due to the placeholder records.

I am wondering if instead of adding a placeholder at object creation the batch
id could be assigned after the first items are added?  Maybe assign batch ID
-1, don't display it in the add screen, and then in the add items function
check for batch id -1 and create the new items then?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12911] batch_id for new label batches can be assigned to several batches

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12911

Thomas Wright tomsst...@gmail.com changed:

   What|Removed |Added

 CC||tomsst...@gmail.com
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12911] batch_id for new label batches can be assigned to several batches

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12911

--- Comment #2 from Thomas Wright tomsst...@gmail.com ---
Created attachment 35600
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35600action=edit
Bug 12911 - batch_id for new label batches can be assigned to several batches
-Added code to make a placeholder and thus reserve the batch number. -Added
code to delete old placeholders everytime a new batch is made. -Modified code
in SELECT query to disc

Testing Plan
-Open two koha staff windows in different browsers/inprivate.
-On both navigate HomeToolsLabel Creator
-Make a new batch in the first window
-Make a new batch in the second window
*The new batches created should have different batch numbers

-Add items to one of the batches
*Only the items added should show in the summary below. No placeholders should
be shown

-Go back to manage batches page on either window
*The batch created which did not have any items added to it should not be
displayed in this window

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12911] batch_id for new label batches can be assigned to several batches

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12911

Nick Clemens n...@quecheelibrary.org changed:

   What|Removed |Added

   Keywords||Academy

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12911] batch_id for new label batches can be assigned to several batches

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12911

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 CC||sh...@pennmanor.net

--- Comment #1 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
*** Bug 8042 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12911] batch_id for new label batches can be assigned to several batches

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12911

Nick Clemens n...@quecheelibrary.org changed:

   What|Removed |Added

 CC||n...@quecheelibrary.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/