[Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933

Cab Vinton  changed:

   What|Removed |Added

 CC||bibli...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||17968


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17968
[Bug 17968] Remove useless variable in C4::Overdues::parse_overdues_letter
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933

Nicole C. Engard  changed:

   What|Removed |Added

 CC|neng...@gmail.com   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933

Nicole C. Engard  changed:

   What|Removed |Added

 CC||a...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933

J Schmidt  changed:

   What|Removed |Added

 CC||jschm...@switchinc.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933

J Schmidt  changed:

   What|Removed |Added

 CC||jschm...@switchinc.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933

Marcel de Rooy  changed:

   What|Removed |Added

 Blocks|15135   |


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15135
[Bug 15135] Remove Warning Subroutine HasOverdues redefined
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933

--- Comment #68 from Jonathan Druart  
---
(In reply to Jonathan Druart from comment #67)
> (In reply to Jonathan Druart from comment #15)
> > QA comment:
> > 3/ Same for C4::Members::GetOverdues, we already have a GetOverdues
> > subroutine in C4::Overdues.
> 
> Was valid for HasOverdues too.
> See bug 15135.

This is still valid, please fix.

returns.pl: Subroutine HasOverdues redefined at
/home/koha/src/Koha/Template/Plugin/Borrowers.pm line 52

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||15242
   See Also|http://bugs.koha-community. |
   |org/bugzilla3/show_bug.cgi? |
   |id=15242|


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15242
[Bug 15242] Missing subroutine in overdue_notices.pl
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933

Nick Clemens  changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=15242

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933

Katrin Fischer  changed:

   What|Removed |Added

  Component|Staff Client|Notices

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||15135


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15135
[Bug 15135] Remove Warning Subroutine HasOverdues redefined
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933

--- Comment #67 from Jonathan Druart  
---
(In reply to Jonathan Druart from comment #15)
> QA comment:
> 3/ Same for C4::Members::GetOverdues, we already have a GetOverdues
> subroutine in C4::Overdues.

Was valid for HasOverdues too.
See bug 15135.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
 Status|Passed QA   |Pushed to Master

--- Comment #66 from Tomás Cohen Arazi  ---
Patches pushed to master.

Thanks Kyle!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #43930|0   |1
is obsolete||

--- Comment #65 from Kyle M Hall  ---
Created attachment 43953
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43953=edit
Bug 12933: QA Followq-up - Add missing notice templates and other small fixes

- Fixes page title of slip print window: Members > Patrons
- Fixes error message if no notice template is found
- Fixes a stray template variable that resulted in the
  borrower number showing in the 'Print' pull down
- Fixes xt/sample_notices.t by adding the sample notice to
  it-IT and es-ES

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933

--- Comment #63 from Katrin Fischer  ---
Created attachment 43929
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43929=edit
[PASSED QA] Bug 12933 [QA Followup] - Rename GetOverdues to
GetOverduesForPatron

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #43904|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933

--- Comment #61 from Katrin Fischer  ---
Created attachment 43927
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43927=edit
[PASSED QA] Bug 12933 [QA Followup] - Rename parse_letter to
parse_overdues_letter

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933

--- Comment #59 from Katrin Fischer  ---
Created attachment 43925
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43925=edit
[PASSED QA] Bug 12933 - Add ability to print overdue slip from staff intranet

Some librarians would like to be able to print an overdues slip from the
staff intranet. This slip would be defined as the print transport
version of the ODUE slip.

Test Plan:
1) Apply this patch
2) Locate a patron with overdues
3) Define a print version of the OVERDUES_SLIP slip
4) Try Print > Print overdues

Signed-off-by: Amy Purvis 
Signed-off-by: Laurie McKee 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933

--- Comment #60 from Katrin Fischer  ---
Created attachment 43926
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43926=edit
[PASSED QA] Bug 12933 - Add new OVERDUES_SLIP letter

Signed-off-by: Amy Purvis 
Signed-off-by: Laurie McKee 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933

--- Comment #62 from Katrin Fischer  ---
Created attachment 43928
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43928=edit
[PASSED QA] Bug 12933 [QA Followup] - Add Unit Tests

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933

--- Comment #64 from Katrin Fischer  ---
Created attachment 43930
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43930=edit
Bug 12933: QA Followq-up - Add missing notice templates and other small fixes

- Fixes page title of slip print window: Members > Patrons
- Fixes error message if no notice template is found
- Fixes a stray template variable that resulted in the
  borrower number showing in the 'Print' pull down
- Fixes xt/sample_notices.t by adding the sample notice to
  it-IT and es-ES

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #43908|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #43905|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #43907|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #43906|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933

--- Comment #56 from Kyle M Hall  ---
Created attachment 43906
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43906=edit
Bug 12933 [QA Followup] - Rename parse_letter to parse_overdues_letter

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933

--- Comment #55 from Kyle M Hall  ---
Created attachment 43905
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43905=edit
Bug 12933 - Add new OVERDUES_SLIP letter

Signed-off-by: Amy Purvis 
Signed-off-by: Laurie McKee 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933

--- Comment #58 from Kyle M Hall  ---
Created attachment 43908
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43908=edit
Bug 12933 [QA Followup] - Rename GetOverdues to GetOverduesForPatron

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933

--- Comment #57 from Kyle M Hall  ---
Created attachment 43907
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43907=edit
Bug 12933 [QA Followup] - Add Unit Tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933

Kyle M Hall  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #43519|0   |1
is obsolete||
  Attachment #43520|0   |1
is obsolete||
  Attachment #43521|0   |1
is obsolete||
  Attachment #43522|0   |1
is obsolete||
  Attachment #43523|0   |1
is obsolete||

--- Comment #54 from Kyle M Hall  ---
Created attachment 43904
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43904=edit
Bug 12933 - Add ability to print overdue slip from staff intranet

Some librarians would like to be able to print an overdues slip from the
staff intranet. This slip would be defined as the print transport
version of the ODUE slip.

Test Plan:
1) Apply this patch
2) Locate a patron with overdues
3) Define a print version of the OVERDUES_SLIP slip
4) Try Print > Print overdues

Signed-off-by: Amy Purvis 
Signed-off-by: Laurie McKee 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Patch doesn't apply

--- Comment #53 from Katrin Fischer  ---
Sorry, patch doesn't apply, please rebase:

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 12933 - Add ability to print overdue slip from staff intranet
Using index info to reconstruct a base tree...
M   C4/Overdues.pm
Falling back to patching base and 3-way merge...
Auto-merging C4/Overdues.pm
CONFLICT (content): Merge conflict in C4/Overdues.pm
Failed to merge in the changes.
Patch failed at 0001 Bug 12933 - Add ability to print overdue slip from staff
intranet
The copy of the patch that failed is found in:
   /home/katrin/kohaclone/.git/rebase-apply/patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in
/tmp/Bug-12933---Add-ability-to-print-overdue-slip-from-IujNUN.patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #41606|0   |1
is obsolete||
  Attachment #41607|0   |1
is obsolete||
  Attachment #41608|0   |1
is obsolete||
  Attachment #41609|0   |1
is obsolete||
  Attachment #41610|0   |1
is obsolete||

--- Comment #42 from Kyle M Hall  ---
Created attachment 43514
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43514=edit
Bug 12933 - Add ability to print overdue slip from staff intranet

Some librarians would like to be able to print an overdues slip from the
staff intranet. This slip would be defined as the print transport
version of the ODUE slip.

Test Plan:
1) Apply this patch
2) Locate a patron with overdues
3) Define a print version of the OVERDUES_SLIP slip
4) Try Print > Print overdues

Signed-off-by: Amy Purvis 
Signed-off-by: Laurie McKee 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933

--- Comment #43 from Kyle M Hall  ---
Created attachment 43515
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43515=edit
Bug 12933 - Add new OVERDUES_SLIP letter

Signed-off-by: Amy Purvis 
Signed-off-by: Laurie McKee 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933

--- Comment #45 from Kyle M Hall  ---
Created attachment 43517
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43517=edit
Bug 12933 [QA Followup] - Add Unit Tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933

--- Comment #44 from Kyle M Hall  ---
Created attachment 43516
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43516=edit
Bug 12933 [QA Followup] - Rename parse_letter to parse_overdues_letter

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933

--- Comment #46 from Kyle M Hall  ---
Created attachment 43518
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43518=edit
Bug 12933 [QA Followup] - Rename GetOverdues to GetOverduesForPatron

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933

--- Comment #52 from Kyle M Hall  ---
(In reply to Jonathan Druart from comment #41)
> There is something wrong in the second patch:
> 
> installer/data/mysql/updatedatabase.pl | 1157
> +---

Fixed!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933

--- Comment #51 from Kyle M Hall  ---
Created attachment 43523
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43523=edit
Bug 12933 [QA Followup] - Rename GetOverdues to GetOverduesForPatron

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933

--- Comment #50 from Kyle M Hall  ---
Created attachment 43522
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43522=edit
Bug 12933 [QA Followup] - Add Unit Tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #43514|0   |1
is obsolete||
  Attachment #43515|0   |1
is obsolete||
  Attachment #43516|0   |1
is obsolete||
  Attachment #43517|0   |1
is obsolete||
  Attachment #43518|0   |1
is obsolete||

--- Comment #47 from Kyle M Hall  ---
Created attachment 43519
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43519=edit
Bug 12933 - Add ability to print overdue slip from staff intranet

Some librarians would like to be able to print an overdues slip from the
staff intranet. This slip would be defined as the print transport
version of the ODUE slip.

Test Plan:
1) Apply this patch
2) Locate a patron with overdues
3) Define a print version of the OVERDUES_SLIP slip
4) Try Print > Print overdues

Signed-off-by: Amy Purvis 
Signed-off-by: Laurie McKee 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933

--- Comment #49 from Kyle M Hall  ---
Created attachment 43521
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43521=edit
Bug 12933 [QA Followup] - Rename parse_letter to parse_overdues_letter

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933

--- Comment #48 from Kyle M Hall  ---
Created attachment 43520
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43520=edit
Bug 12933 - Add new OVERDUES_SLIP letter

Signed-off-by: Amy Purvis 
Signed-off-by: Laurie McKee 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #41 from Jonathan Druart  
---
There is something wrong in the second patch:

installer/data/mysql/updatedatabase.pl | 1157 +---

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933

Nicole Engard (ByWater) nic...@bywatersolutions.com changed:

   What|Removed |Added

 CC||nic...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933

Kyle M Hall kyle.m.h...@gmail.com changed:

   What|Removed |Added

 CC||kyle.m.h...@gmail.com
  Attachment #41611|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #35533|0   |1
is obsolete||
  Attachment #35534|0   |1
is obsolete||
  Attachment #35535|0   |1
is obsolete||
  Attachment #35536|0   |1
is obsolete||
  Attachment #35537|0   |1
is obsolete||
  Attachment #35538|0   |1
is obsolete||
  Attachment #35918|0   |1
is obsolete||

--- Comment #34 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 41606
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41606action=edit
Bug 12933 - Add ability to print overdue slip from staff intranet

Some librarians would like to be able to print an overdues slip from the
staff intranet. This slip would be defined as the print transport
version of the ODUE slip.

Test Plan:
1) Apply this patch
2) Locate a patron with overdues
3) Define a print version of the OVERDUES_SLIP slip
4) Try Print  Print overdues

Signed-off-by: Amy Purvis apur...@galencollege.edu
Signed-off-by: Laurie McKee lmc...@littleelm.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933

--- Comment #36 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 41608
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41608action=edit
Bug 12933 [QA Followup] - Rename parse_letter to parse_overdues_letter

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933

--- Comment #37 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 41609
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41609action=edit
Bug 12933 [QA Followup] - Add Unit Tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933

--- Comment #35 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 41607
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41607action=edit
Bug 12933 - Add new OVERDUES_SLIP letter

Signed-off-by: Amy Purvis apur...@galencollege.edu
Signed-off-by: Laurie McKee lmc...@littleelm.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933

--- Comment #39 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 41611
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41611action=edit
Bug 12933 [QA Followup] - Remove Template plugin and use thereof

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933

--- Comment #38 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 41610
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41610action=edit
Bug 12933 [QA Followup] - Rename GetOverdues to GetOverduesForPatron

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933

Kyle M Hall kyle.m.h...@gmail.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #40 from Kyle M Hall kyle.m.h...@gmail.com ---
  By using a TT plugin, we don't have to modify each and every script that
  uses the members toolbar.
 
 Yes, but it's the way it's done everywhere into Koha.
 I still really don't like to see an other overhead to get this kind of info.

There is no sacrifice or performance using this method. In fact, based on my
followup, using the plugin results in somewhat better performance!

The key here is that just because we've always done something in a particular
way doesn't mean we should keep doing it that way. In fact, we have precedence
for this very pattern.

Once we introduced the plugin for getting system preferences, we began to
remove the template parameters that only passed system preferences. There is no
need to fetch the values in the script and pass them to the template, because
the script has absolutely no need for them. Doing so only added unnecessary
complexity and by using a plugin we greatly reduce that complexity. This is
essentially the exact same issue.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933

Nicole C. Engard neng...@gmail.com changed:

   What|Removed |Added

 CC||neng...@gmail.com
 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933

jdem...@roseville.ca.us jdem...@roseville.ca.us changed:

   What|Removed |Added

 CC||jdem...@roseville.ca.us

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933

--- Comment #33 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 35918
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35918action=edit
Bug 12933 [QA Followup] - Remove Template plugin and use thereof

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #32 from Kyle M Hall k...@bywatersolutions.com ---
I'll write a followup to remove the plugin sub and use of it, replacing it with
something more common. Until then, setting to Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933

--- Comment #30 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to Kyle M Hall from comment #16)
 (In reply to Jonathan Druart from comment #15)
  QA comment:
  I am quite confuse by this patch.
  IMO there are some inconsistencies:
  1/ I don't understand the usefulness to pass by the template plugin to know
  if a borrower has overdues or not.
 
 By using a TT plugin, we don't have to modify each and every script that
 uses the members toolbar.

Yes, but it's the way it's done everywhere into Koha.
I still really don't like to see an other overhead to get this kind of info.

Other QA pov needed here please.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933

--- Comment #31 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to Kyle M Hall from comment #29)
 Created attachment 35538 [details] [review]
 Bug 12933 [QA Followup] - Remove trailing whitespace from Members.pm

There are 26 patches in the queue modifying C4/Members.pm.
IMO this patch does not give enough benefit to be required.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933

--- Comment #27 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 35536
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35536action=edit
Bug 12933 [QA Followup] - Add Unit Tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #34884|0   |1
is obsolete||
  Attachment #34885|0   |1
is obsolete||
  Attachment #34888|0   |1
is obsolete||
  Attachment #34889|0   |1
is obsolete||

--- Comment #24 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 35533
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35533action=edit
Bug 12933 - Add ability to print overdue slip from staff intranet

Some librarians would like to be able to print an overdues slip from the
staff intranet. This slip would be defined as the print transport
version of the ODUE slip.

Test Plan:
1) Apply this patch
2) Locate a patron with overdues
3) Define a print version of the OVERDUES_SLIP slip
4) Try Print  Print overdues

Signed-off-by: Amy Purvis apur...@galencollege.edu
Signed-off-by: Laurie McKee lmc...@littleelm.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933

--- Comment #26 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 35535
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35535action=edit
Bug 12933 [QA Followup] - Rename parse_letter to parse_overdues_letter

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933

--- Comment #29 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 35538
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35538action=edit
Bug 12933 [QA Followup] - Remove trailing whitespace from Members.pm

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|In Discussion   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933

--- Comment #28 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 35537
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35537action=edit
Bug 12933 [QA Followup] - Rename GetOverdues to GetOverduesForPatron

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933

--- Comment #25 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 35534
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35534action=edit
Bug 12933 - Add new OVERDUES_SLIP letter

Signed-off-by: Amy Purvis apur...@galencollege.edu
Signed-off-by: Laurie McKee lmc...@littleelm.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Signed Off  |In Discussion

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933

Martin Renvoize martin.renvo...@ptfs-europe.com changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com

--- Comment #23 from Martin Renvoize martin.renvo...@ptfs-europe.com ---
(In reply to Kyle M Hall from comment #16)
 (In reply to Jonathan Druart from comment #15)


I agree with Joubu that I don't like having a second GetOverdues added to the
code.. it's not DRY.. if you really want to be able to access the function from
C4::Members rather than directly from C4::Overdues, then it should be a sugar
function that refers to C4::Overdues in my mind, else it's confusing to future
people working on the code.  If it does perform a different function.. then
surely that should be made clear by naming it something completely different,
or enahcning the C4::Overdues function with the required extras and a filter
perhaps?

Just my thoughts

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933

--- Comment #16 from Kyle M Hall k...@bywatersolutions.com ---
(In reply to Jonathan Druart from comment #15)
 QA comment:
 I am quite confuse by this patch.
 IMO there are some inconsistencies:
 1/ I don't understand the usefulness to pass by the template plugin to know
 if a borrower has overdues or not.

By using a TT plugin, we don't have to modify each and every script that uses
the members toolbar.

 2/ Why did you move parse_letter to the pm file? A subroutine with the same
 name exists in advance_notices.pl cronjob script (which uses C4::Overdues
 too, so introduces a redefinion of it)?

I moved it so we could use the same subroutine in both the cron script and the
new script. I'll submit a followup to rename it to parse_overdues_letter

 3/ Same for C4::Members::GetOverdues, we already have a GetOverdues
 subroutine in C4::Overdues.

C4::Members::GetOverdues deals with getting a specific borrowers overdues, and
gets more data than C4::Overdues::GetOverdues. They really do two different
jobs.

 4/ Tests are missing for changes in packages.

Will do!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933

--- Comment #18 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 34885
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34885action=edit
Bug 12933 - Add new OVERDUES_SLIP letter

Signed-off-by: Amy Purvis apur...@galencollege.edu
Signed-off-by: Laurie McKee lmc...@littleelm.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933

--- Comment #19 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 34886
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34886action=edit
Bug 12933 [QA Followup] - Rename parse_letter to parse_overdues_letter

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933

--- Comment #20 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 34887
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34887action=edit
Bug 12933 [QA Followup] - Add Unit Tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #34886|0   |1
is obsolete||
  Attachment #34887|0   |1
is obsolete||

--- Comment #21 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 34888
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34888action=edit
Bug 12933 [QA Followup] - Rename parse_letter to parse_overdues_letter

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933

--- Comment #22 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 34889
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34889action=edit
Bug 12933 [QA Followup] - Add Unit Tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #34474|0   |1
is obsolete||
  Attachment #34475|0   |1
is obsolete||

--- Comment #17 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 34884
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34884action=edit
Bug 12933 - Add ability to print overdue slip from staff intranet

Some librarians would like to be able to print an overdues slip from the
staff intranet. This slip would be defined as the print transport
version of the ODUE slip.

Test Plan:
1) Apply this patch
2) Locate a patron with overdues
3) Define a print version of the OVERDUES_SLIP slip
4) Try Print  Print overdues

Signed-off-by: Amy Purvis apur...@galencollege.edu
Signed-off-by: Laurie McKee lmc...@littleelm.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA
 CC||jonathan.dru...@biblibre.co
   ||m

--- Comment #15 from Jonathan Druart jonathan.dru...@biblibre.com ---
QA comment:
I am quite confuse by this patch.
IMO there are some inconsistencies:
1/ I don't understand the usefulness to pass by the template plugin to know if
a borrower has overdues or not.
2/ Why did you move parse_letter to the pm file? A subroutine with the same
name exists in advance_notices.pl cronjob script (which uses C4::Overdues too,
so introduces a redefinion of it)?
3/ Same for C4::Members::GetOverdues, we already have a GetOverdues subroutine
in C4::Overdues.
4/ Tests are missing for changes in packages.

Marked as Failed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #31638|0   |1
is obsolete||

--- Comment #5 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 34456
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34456action=edit
Bug 12933 - Add ability to print overdue slip from staff intranet

Some librarians would like to be able to print an overdues slip from the
staff intranet. This slip would be defined as the print transport
version of the ODUE slip.

Test Plan:
1) Apply this patch
2) Locate a patron with overdues
3) Define a print version of the OVERDUES_SLIP slip
4) Try Print  Print overdues

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933

--- Comment #6 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 34457
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34457action=edit
Bug 12933 - Add new OVERDUES_SLIP letter

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #34456|0   |1
is obsolete||
  Attachment #34457|0   |1
is obsolete||

--- Comment #7 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 34467
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34467action=edit
Bug 12933 - Add ability to print overdue slip from staff intranet

Some librarians would like to be able to print an overdues slip from the
staff intranet. This slip would be defined as the print transport
version of the ODUE slip.

Test Plan:
1) Apply this patch
2) Locate a patron with overdues
3) Define a print version of the OVERDUES_SLIP slip
4) Try Print  Print overdues

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933

--- Comment #8 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 34468
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34468action=edit
Bug 12933 - Add new OVERDUES_SLIP letter

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #34467|0   |1
is obsolete||
  Attachment #34468|0   |1
is obsolete||

--- Comment #9 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 34469
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34469action=edit
Bug 12933 - Add ability to print overdue slip from staff intranet

Some librarians would like to be able to print an overdues slip from the
staff intranet.

Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
2) Locate a patron with overdues
4) Try Print  Print overdues

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #34469|0   |1
is obsolete||

--- Comment #10 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 34470
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34470action=edit
Bug 12933 - Add ability to print overdue slip from staff intranet

Some librarians would like to be able to print an overdues slip from the
staff intranet.

Test Plan:
1) Apply this patch
2) Run updatedatabase.pl
2) Locate a patron with overdues
4) Try Print  Print overdues

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933

--- Comment #11 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 34471
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34471action=edit
Bug 12933 - Add new OVERDUES_SLIP letter

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933

--- Comment #12 from Barton Chittenden bar...@bywatersolutions.com ---
Test Plan:
1) Apply this patch
2) Run ./installer/data/mysql/updatedatabase.pl
3) Locate a patron with overdues
4) Try Print  Print overdues

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933

Barton Chittenden bar...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #34470|0   |1
is obsolete||

--- Comment #13 from Barton Chittenden bar...@bywatersolutions.com ---
Created attachment 34474
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34474action=edit
Bug 12933 - Add ability to print overdue slip from staff intranet

Some librarians would like to be able to print an overdues slip from the
staff intranet. This slip would be defined as the print transport
version of the ODUE slip.

Test Plan:
1) Apply this patch
2) Locate a patron with overdues
3) Define a print version of the OVERDUES_SLIP slip
4) Try Print  Print overdues

Signed-off-by: Amy Purvis apur...@galencollege.edu
Signed-off-by: Laurie McKee lmc...@littleelm.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933

Barton Chittenden bar...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #34471|0   |1
is obsolete||

--- Comment #14 from Barton Chittenden bar...@bywatersolutions.com ---
Created attachment 34475
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34475action=edit
Bug 12933 - Add new OVERDUES_SLIP letter

Signed-off-by: Amy Purvis apur...@galencollege.edu
Signed-off-by: Laurie McKee lmc...@littleelm.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933

Barton Chittenden bar...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933

Barton Chittenden bar...@bywatersolutions.com changed:

   What|Removed |Added

 CC||bar...@bywatersolutions.com

--- Comment #4 from Barton Chittenden bar...@bywatersolutions.com ---
I tried to run the test plan, on step 4, I got a 404:

http:// ... /cgi-bin/koha/members/print_overdues.pl?borrowernumber=220

The file print_overdues.pl does not exist.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933

Nick Clemens n...@quecheelibrary.org changed:

   What|Removed |Added

 CC||n...@quecheelibrary.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933

--- Comment #3 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 31667
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31667action=edit
Bug 12933 [Followup] - Switch from DBI to DBIC

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #31667|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933

--- Comment #1 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 31638
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31638action=edit
Bug 12933 - Add ability to print overdue slip from staff intranet

Some librarians would like to be able to print an overdues slip from the
staff intranet. This slip would be defined as the print transport
version of the ODUE slip.

Test Plan:
1) Apply this patch
2) Locate a patron with overdues
3) Define a print version of the ODUE slip
4) Try Print  Print overdues

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12933] Add ability to print overdue slip from staff intranet

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12933

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #2 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Hm, wouldn't it be better to have a separate template for a slip? I think the
print transport type for ODUEs is thought for printing letters mostly and this
could confuse things a bit.

Also, not all libraries use ODUE - it's not hardcoded as the notice triggers
will let you pick any slip that is in the circulation module.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/