[Koha-bugs] [Bug 13014] Sent an email to budget owner when a suggestion can be treated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13014 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||tomasco...@gmail.com --- Comment #48 from Tomás Cohen Arazi tomasco...@gmail.com --- Enhancement pushed to master. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13014] Sent an email to budget owner when a suggestion can be treated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13014 --- Comment #47 from Tomás Cohen Arazi tomasco...@gmail.com --- Created attachment 40597 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40597action=edit Bug 13014: (QA followup) have new warnings tested Signed-off-by: Tomas Cohen Arazi tomasco...@theke.io -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13014] Sent an email to budget owner when a suggestion can be treated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13014 --- Comment #38 from M. de Rooy m.de.r...@rijksmuseum.nl --- Rebased patch 4. Wondering about patch 5 here.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13014] Sent an email to budget owner when a suggestion can be treated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13014 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #46 from M. de Rooy m.de.r...@rijksmuseum.nl --- QA Comment: Code looks good to me. Some small remarks: GetUnprocessedSuggestions misses pod section. notice_unprocessed_suggestions.pl documentation says: =item B--days This parameter is mandatory. It must contain an integer representing the number of days elapsed since the last modification of suggestions to process. A further explanation that it only selects suggestion that are exactly x days old should be added. The workflow of sending it after one day and reminding after 7 days with the parameters 1 7 could be clarifying. Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13014] Sent an email to budget owner when a suggestion can be treated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13014 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13014] Sent an email to budget owner when a suggestion can be treated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13014 --- Comment #42 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 38014 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38014action=edit Bug 13014: Notify budget owner on new suggestion - cronjob Test plan: 0/ Create a new notice suggestions TO_PROCESS You can use the one defined in the other patch. 1/ Create a suggestion and link it to a fund 2/ Add a owner to this fund and make sure this patron has an email address (the email address used should be the one defined in the AutoEmailPrimaryAddress syspref). 3/ Execute the cronjob script with the -v and without the -c argument 4/ The output should tell you that an email will be sent 5/ Execute the cronjob script with the -v and with the -c argument 6/ Verify the notice is generated in the message_queue table and it is correctly formatted. Signed-off-by: Frederic Demians f.demi...@tamil.fr Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13014] Sent an email to budget owner when a suggestion can be treated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13014 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Attachment #36272|0 |1 is obsolete|| Attachment #36273|0 |1 is obsolete|| Attachment #36275|0 |1 is obsolete|| Attachment #38006|0 |1 is obsolete|| Attachment #38007|0 |1 is obsolete|| Attachment #38009|0 |1 is obsolete|| --- Comment #40 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 38012 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38012action=edit Bug 13014: Notify budget owner on new suggestion - UT When a suggestion is created and linked to a fund, a mail will be generated, using a cronjob, to notify the budget owner. A suggestion is considered as can be treated if its status is ASKED. Signed-off-by: Frederic Demians f.demi...@tamil.fr Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13014] Sent an email to budget owner when a suggestion can be treated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13014 --- Comment #45 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 38017 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38017action=edit Bug 13014: [QA Follow-up] Few typos in cronjob Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13014] Sent an email to budget owner when a suggestion can be treated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13014 --- Comment #44 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 38016 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38016action=edit Bug 13014: (follow-up 2) Notify budget owner on new suggestion - sample notices This patch updates the 2 optional sample_notices.sql files for ru-RU and uk-UA. Not sure if it is relevant but I don't understand why they are not up-to-date. Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl Checked by running them manually. English installs 27, Russian 27 and Ukrainian 26. Last language can be updated somewhere else. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13014] Sent an email to budget owner when a suggestion can be treated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13014 --- Comment #43 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 38015 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38015action=edit Bug 13014: (follow-up) Notify budget owner on new suggestion - sample notices This patch adds the new notice for all other languages. Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13014] Sent an email to budget owner when a suggestion can be treated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13014 --- Comment #41 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 38013 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38013action=edit Bug 13014: Notify budget owner on new suggestion - sample notices This patch add the new notice suggestion TO_PROCESS Others will be added when the patch will be signed off. Signed-off-by: Frederic Demians f.demi...@tamil.fr Followup expected :-) It would be nice also to have an updatabase.pl entry to insert the new TO_PROCESS notification. Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13014] Sent an email to budget owner when a suggestion can be treated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13014 --- Comment #35 from Katrin Fischer katrin.fisc...@bsz-bw.de --- (In reply to Jonathan Druart from comment #34) (In reply to Katrin Fischer from comment #33) Just wondering: Why not send out the email immediately like the other emails, but via a cronjob? Because we would like the ability to sent an email for the suggestions not processed for X days. Ok! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13014] Sent an email to budget owner when a suggestion can be treated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13014 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Attachment #36276|0 |1 is obsolete|| Attachment #36277|0 |1 is obsolete|| --- Comment #36 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 38006 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38006action=edit Bug 13014: (follow-up) Notify budget owner on new suggestion - sample notices This patch adds the new notice for all other languages. Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13014] Sent an email to budget owner when a suggestion can be treated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13014 --- Comment #37 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 38007 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38007action=edit Bug 13014: (follow-up 2) Notify budget owner on new suggestion - sample notices This patch updates the 2 optional sample_notices.sql files for ru-RU and uk-UA. Not sure if it is relevant but I don't understand why they are not up-to-date. Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13014] Sent an email to budget owner when a suggestion can be treated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13014 --- Comment #39 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 38009 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38009action=edit Bug 13014: [QA Follow-up] Few typos in cronjob Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13014] Sent an email to budget owner when a suggestion can be treated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13014 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13014] Sent an email to budget owner when a suggestion can be treated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13014 Matthias Meusburger matthias.meusbur...@biblibre.com changed: What|Removed |Added CC||matthias.meusburger@biblibr ||e.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13014] Sent an email to budget owner when a suggestion can be treated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13014 --- Comment #33 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Hi Jonathan, this looks good so far in code review and the unit tests all pass. Just wondering: Why not send out the email immediately like the other emails, but via a cronjob? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13014] Sent an email to budget owner when a suggestion can be treated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13014 --- Comment #34 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to Katrin Fischer from comment #33) Just wondering: Why not send out the email immediately like the other emails, but via a cronjob? Because we would like the ability to sent an email for the suggestions not processed for X days. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13014] Sent an email to budget owner when a suggestion can be treated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13014 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #35603|0 |1 is obsolete|| --- Comment #28 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 36272 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36272action=edit Bug 13014: Notify budget owner on new suggestion - UT When a suggestion is created and linked to a fund, a mail will be generated, using a cronjob, to notify the budget owner. A suggestion is considered as can be treated if its status is ASKED. Signed-off-by: Frederic Demians f.demi...@tamil.fr -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13014] Sent an email to budget owner when a suggestion can be treated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13014 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #35604|0 |1 is obsolete|| --- Comment #29 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 36273 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36273action=edit Bug 13014: Notify budget owner on new suggestion - sample notices This patch add the new notice suggestion TO_PROCESS Others will be added when the patch will be signed off. Signed-off-by: Frederic Demians f.demi...@tamil.fr Followup expected :-) It would be nice also to have an updatabase.pl entry to insert the new TO_PROCESS notification. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13014] Sent an email to budget owner when a suggestion can be treated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13014 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13014] Sent an email to budget owner when a suggestion can be treated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13014 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #35607|0 |1 is obsolete|| --- Comment #32 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 36277 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36277action=edit Bug 13014: (follow-up 2) Notify budget owner on new suggestion - sample notices This patch updates the 2 optional sample_notices.sql files for ru-RU and uk-UA. Not sure if it is relevant but I don't understand why they are not up-to-date. Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13014] Sent an email to budget owner when a suggestion can be treated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13014 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #35605|0 |1 is obsolete|| --- Comment #30 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 36275 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36275action=edit Bug 13014: Notify budget owner on new suggestion - cronjob Test plan: 0/ Create a new notice suggestions TO_PROCESS You can use the one defined in the other patch. 1/ Create a suggestion and link it to a fund 2/ Add a owner to this fund and make sure this patron has an email address (the email address used should be the one defined in the AutoEmailPrimaryAddress syspref). 3/ Execute the cronjob script with the -v and without the -c argument 4/ The output should tell you that an email will be sent 5/ Execute the cronjob script with the -v and with the -c argument 6/ Verify the notice is generated in the message_queue table and it is correctly formatted. Signed-off-by: Frederic Demians f.demi...@tamil.fr -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13014] Sent an email to budget owner when a suggestion can be treated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13014 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #35606|0 |1 is obsolete|| --- Comment #31 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 36276 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36276action=edit Bug 13014: (follow-up) Notify budget owner on new suggestion - sample notices This patch adds the new notice for all other languages. Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13014] Sent an email to budget owner when a suggestion can be treated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13014 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Patch doesn't apply --- Comment #27 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 13014: Notify budget owner on new suggestion - UT fatal: sha1 information is lacking or useless (C4/Suggestions.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. :( -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13014] Sent an email to budget owner when a suggestion can be treated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13014 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #34792|0 |1 is obsolete|| Attachment #34793|0 |1 is obsolete|| Attachment #34794|0 |1 is obsolete|| Attachment #34795|0 |1 is obsolete|| Attachment #34796|0 |1 is obsolete|| --- Comment #21 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 35603 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35603action=edit Bug 13014: Notify budget owner on new suggestion - UT When a suggestion is created and linked to a fund, a mail will be generated, using a cronjob, to notify the budget owner. A suggestion is considered as can be treated if its status is ASKED. Signed-off-by: Frederic Demians f.demi...@tamil.fr -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13014] Sent an email to budget owner when a suggestion can be treated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13014 --- Comment #22 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 35604 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35604action=edit Bug 13014: Notify budget owner on new suggestion - sample notices This patch add the new notice suggestion TO_PROCESS Others will be added when the patch will be signed off. Signed-off-by: Frederic Demians f.demi...@tamil.fr Followup expected :-) It would be nice also to have an updatabase.pl entry to insert the new TO_PROCESS notification. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13014] Sent an email to budget owner when a suggestion can be treated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13014 --- Comment #25 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 35607 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35607action=edit Bug 13014: (follow-up 2) Notify budget owner on new suggestion - sample notices This patch updates the 2 optional sample_notices.sql files for ru-RU and uk-UA. Not sure if it is relevant but I don't understand why they are not up-to-date. Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13014] Sent an email to budget owner when a suggestion can be treated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13014 --- Comment #24 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 35606 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35606action=edit Bug 13014: (follow-up) Notify budget owner on new suggestion - sample notices This patch adds the new notice for all other languages. Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13014] Sent an email to budget owner when a suggestion can be treated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13014 --- Comment #23 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 35605 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35605action=edit Bug 13014: Notify budget owner on new suggestion - cronjob Test plan: 0/ Create a new notice suggestions TO_PROCESS You can use the one defined in the other patch. 1/ Create a suggestion and link it to a fund 2/ Add a owner to this fund and make sure this patron has an email address (the email address used should be the one defined in the AutoEmailPrimaryAddress syspref). 3/ Execute the cronjob script with the -v and without the -c argument 4/ The output should tell you that an email will be sent 5/ Execute the cronjob script with the -v and with the -c argument 6/ Verify the notice is generated in the message_queue table and it is correctly formatted. Signed-off-by: Frederic Demians f.demi...@tamil.fr -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13014] Sent an email to budget owner when a suggestion can be treated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13014 --- Comment #26 from Jonathan Druart jonathan.dru...@biblibre.com --- I moved the tests into a subtest to avoid conflicts later. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13014] Sent an email to budget owner when a suggestion can be treated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13014 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added CC||k...@bywatersolutions.com Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13014] Sent an email to budget owner when a suggestion can be treated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13014 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Patch doesn't apply |Signed Off --- Comment #20 from Jonathan Druart jonathan.dru...@biblibre.com --- Kyle, the patches apply cleanly here. They depends on bug 13007. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13014] Sent an email to budget owner when a suggestion can be treated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13014 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #33267|0 |1 is obsolete|| --- Comment #16 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 34794 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34794action=edit Bug 13014: Notify budget owner on new suggestion - cronjob Test plan: 0/ Create a new notice suggestions TO_PROCESS You can use the one defined in the other patch. 1/ Create a suggestion and link it to a fund 2/ Add a owner to this fund and make sure this patron has an email address (the email address used should be the one defined in the AutoEmailPrimaryAddress syspref). 3/ Execute the cronjob script with the -v and without the -c argument 4/ The output should tell you that an email will be sent 5/ Execute the cronjob script with the -v and with the -c argument 6/ Verify the notice is generated in the message_queue table and it is correctly formatted. Signed-off-by: Frederic Demians f.demi...@tamil.fr -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13014] Sent an email to budget owner when a suggestion can be treated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13014 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #33293|0 |1 is obsolete|| --- Comment #17 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 34795 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34795action=edit Bug 13014: (follow-up) Notify budget owner on new suggestion - sample notices This patch adds the new notice for all other languages. Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13014] Sent an email to budget owner when a suggestion can be treated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13014 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Patch doesn't apply |Signed Off --- Comment #19 from Jonathan Druart jonathan.dru...@biblibre.com --- Patches rebased. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13014] Sent an email to budget owner when a suggestion can be treated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13014 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #33294|0 |1 is obsolete|| --- Comment #18 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 34796 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34796action=edit Bug 13014: (follow-up 2) Notify budget owner on new suggestion - sample notices This patch updates the 2 optional sample_notices.sql files for ru-RU and uk-UA. Not sure if it is relevant but I don't understand why they are not up-to-date. Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13014] Sent an email to budget owner when a suggestion can be treated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13014 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #33266|0 |1 is obsolete|| --- Comment #15 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 34793 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34793action=edit Bug 13014: Notify budget owner on new suggestion - sample notices This patch add the new notice suggestion TO_PROCESS Others will be added when the patch will be signed off. Signed-off-by: Frederic Demians f.demi...@tamil.fr Followup expected :-) It would be nice also to have an updatabase.pl entry to insert the new TO_PROCESS notification. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13014] Sent an email to budget owner when a suggestion can be treated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13014 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #33265|0 |1 is obsolete|| --- Comment #14 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 34792 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34792action=edit Bug 13014: Notify budget owner on new suggestion - UT When a suggestion is created and linked to a fund, a mail will be generated, using a cronjob, to notify the budget owner. A suggestion is considered as can be treated if its status is ASKED. Signed-off-by: Frederic Demians f.demi...@tamil.fr -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13014] Sent an email to budget owner when a suggestion can be treated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13014 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Patch doesn't apply CC||katrin.fisc...@bsz-bw.de --- Comment #13 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 13014: Notify budget owner on new suggestion - UT Using index info to reconstruct a base tree... MC4/Suggestions.pm Mt/db_dependent/Suggestions.t Falling back to patching base and 3-way merge... Auto-merging t/db_dependent/Suggestions.t CONFLICT (content): Merge conflict in t/db_dependent/Suggestions.t Auto-merging C4/Suggestions.pm Failed to merge in the changes. Patch failed at 0001 Bug 13014: Notify budget owner on new suggestion - UT -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13014] Sent an email to budget owner when a suggestion can be treated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13014 --- Comment #10 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 33293 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33293action=edit Bug 13014: (follow-up) Notify budget owner on new suggestion - sample notices This patch adds the new notice for all other languages. Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13014] Sent an email to budget owner when a suggestion can be treated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13014 --- Comment #11 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 33294 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33294action=edit Bug 13014: (follow-up 2) Notify budget owner on new suggestion - sample notices This patch updates the 2 optional sample_notices.sql files for ru-RU and uk-UA. Not sure if it is relevant but I don't understand why they are not up-to-date. Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13014] Sent an email to budget owner when a suggestion can be treated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13014 --- Comment #12 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to Frédéric Demians from comment #8) Followup expected :-) It would be nice also to have an updatabase.pl entry to insert the new TO_PROCESS notification. Done, thanks Frédéric for your tests! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13014] Sent an email to budget owner when a suggestion can be treated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13014 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #31952|0 |1 is obsolete|| --- Comment #5 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 33247 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33247action=edit Bug 13014: Notify budget owner on new suggestion - cronjob Test plan: 0/ Create a new notice suggestions TO_PROCESS You can use the one defined in the other patch. 1/ Create a suggestion and link it to a fund 2/ Add a owner to this fund and make sure this patron has an email address (the email address used should be the one defined in the AutoEmailPrimaryAddress syspref). 3/ Execute the cronjob script with the -v and without the -c argument 4/ The output should tell you that an email will be sent 5/ Execute the cronjob script with the -v and with the -c argument 6/ Verify the notice is generated in the message_queue table and it is correctly formatted. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13014] Sent an email to budget owner when a suggestion can be treated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13014
--- Comment #6 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to Frédéric Demians from comment #4)
- A patch add a new TO_PROCESS notice to en/mandatory/sample_notices.sql. Why
no notice for other languages?
Others will be added when the patch will be signed off.
I will do :)
- notice_unprocessed_suggestion.pl script has no execution permisions like
other scripts in misc/cronjobs
Done.
- The script help should say that the script uses a notice named TO_PROCESS
Done.
- It would be a plus, if running the script without -c were sending the
result
to STDOUT.
Done.
- Patron name surname are in TO_PROCESS notice, but are not displayed. It
appears that, calling EnqueueLetter, your script doesn't provide borrowers
table info. You should have:
tables = {
suggestions = $suggestion-{suggestionid},
branches= $patron-{branchcode},
borrowers = $patron-{borrowernumber},
},
Done.
Thanks!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13014] Sent an email to budget owner when a suggestion can be treated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13014 Frédéric Demians frede...@tamil.fr changed: What|Removed |Added Attachment #31950|0 |1 is obsolete|| --- Comment #7 from Frédéric Demians frede...@tamil.fr --- Created attachment 33265 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33265action=edit Bug 13014: Notify budget owner on new suggestion - UT When a suggestion is created and linked to a fund, a mail will be generated, using a cronjob, to notify the budget owner. A suggestion is considered as can be treated if its status is ASKED. Signed-off-by: Frederic Demians f.demi...@tamil.fr -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13014] Sent an email to budget owner when a suggestion can be treated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13014 Frédéric Demians frede...@tamil.fr changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13014] Sent an email to budget owner when a suggestion can be treated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13014 Frédéric Demians frede...@tamil.fr changed: What|Removed |Added Attachment #31951|0 |1 is obsolete|| --- Comment #8 from Frédéric Demians frede...@tamil.fr --- Created attachment 33266 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33266action=edit Bug 13014: Notify budget owner on new suggestion - sample notices This patch add the new notice suggestion TO_PROCESS Others will be added when the patch will be signed off. Signed-off-by: Frederic Demians f.demi...@tamil.fr Followup expected :-) It would be nice also to have an updatabase.pl entry to insert the new TO_PROCESS notification. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13014] Sent an email to budget owner when a suggestion can be treated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13014 Frédéric Demians frede...@tamil.fr changed: What|Removed |Added Attachment #33247|0 |1 is obsolete|| --- Comment #9 from Frédéric Demians frede...@tamil.fr --- Created attachment 33267 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33267action=edit Bug 13014: Notify budget owner on new suggestion - cronjob Test plan: 0/ Create a new notice suggestions TO_PROCESS You can use the one defined in the other patch. 1/ Create a suggestion and link it to a fund 2/ Add a owner to this fund and make sure this patron has an email address (the email address used should be the one defined in the AutoEmailPrimaryAddress syspref). 3/ Execute the cronjob script with the -v and without the -c argument 4/ The output should tell you that an email will be sent 5/ Execute the cronjob script with the -v and with the -c argument 6/ Verify the notice is generated in the message_queue table and it is correctly formatted. Signed-off-by: Frederic Demians f.demi...@tamil.fr -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13014] Sent an email to budget owner when a suggestion can be treated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13014
Frédéric Demians frede...@tamil.fr changed:
What|Removed |Added
CC||frede...@tamil.fr
--- Comment #4 from Frédéric Demians frede...@tamil.fr ---
Yes, it could be great to notify the budget owner, as you said.
Some remarks:
- A patch add a new TO_PROCESS notice to en/mandatory/sample_notices.sql. Why
no notice for other languages?
- notice_unprocessed_suggestion.pl script has no execution permisions like
other scripts in misc/cronjobs
- The script help should say that the script uses a notice named TO_PROCESS
- It would be a plus, if running the script without -c were sending the result
to STDOUT.
- Patron name surname are in TO_PROCESS notice, but are not displayed. It
appears that, calling EnqueueLetter, your script doesn't provide borrowers
table info. You should have:
tables = {
suggestions = $suggestion-{suggestionid},
branches= $patron-{branchcode},
borrowers = $patron-{borrowernumber},
},
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13014] Sent an email to budget owner when a suggestion can be treated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13014 Julian Maurice julian.maur...@biblibre.com changed: What|Removed |Added CC||julian.maur...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13014] Sent an email to budget owner when a suggestion can be treated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13014 Koha Team Lyon 3 k...@univ-lyon3.fr changed: What|Removed |Added CC||k...@univ-lyon3.fr -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13014] Sent an email to budget owner when a suggestion can be treated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13014 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|NEW |ASSIGNED Depends on||13007 Assignee|koha-b...@lists.koha-commun |jonathan.dru...@biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13014] Sent an email to budget owner when a suggestion can be treated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13014 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13014] Sent an email to budget owner when a suggestion can be treated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13014 --- Comment #1 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 31950 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31950action=edit Bug 13014: Notify budget owner on new suggestion - UT When a suggestion is created and linked to a fund, a mail will be generated, using a cronjob, to notify the budget owner. A suggestion is considered as can be treated if its status is ASKED. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13014] Sent an email to budget owner when a suggestion can be treated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13014 --- Comment #2 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 31951 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31951action=edit Bug 13014: Notify budget owner on new suggestion - sample notices This patch add the new notice suggestion TO_PROCESS Others will be added when the patch will be signed off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13014] Sent an email to budget owner when a suggestion can be treated
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13014 --- Comment #3 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 31952 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31952action=edit Bug 13014: Notify budget owner on new suggestion - cronjob Test plan: 0/ Create a new notice suggestions TO_PROCESS You can use the one defined in the other patch. 1/ Create a suggestion and link it to a fund 2/ Add a owner to this fund and make sure this patron has an email address (the email address used should be the one defined in the AutoEmailPrimaryAddress syspref). 3/ Execute the cronjob script with the -v and without the -c argument 4/ The output should tell you that an email will be sent 5/ Execute the cronjob script with the -v and with the -c argument 6/ Verify the notice is generated in the message_queue table and it is correctly formatted. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
