[Koha-bugs] [Bug 13049] Merge selfreg cron jobs into cleanup_database
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13049 Fridolin SOMERS changed: What|Removed |Added Blocks||21855 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21855 [Bug 21855] Remove mention of deprecated delete_unverified_opac_registrations.pl cronjob -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13049] Merge selfreg cron jobs into cleanup_database
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13049 --- Comment #21 from Marcel de Rooy --- (In reply to Katrin Fischer from comment #20) > (In reply to Marcel de Rooy from comment #19) > > (In reply to Katrin Fischer from comment #18) > > > It looks like this change introduced a regression. Before the changes it > > > was > > > possible to define the delay for unverified registrations in hours and now > > > it's days. It will also change what actually happens when you switch over? > > > > > > With GDPR being very strict about saving data the initial feature of being > > > able to delete after x hours would be better. > > > > I think you are being even stricter now :) > > Triggered by a request from a library. I will try to submit some patches on bug 20819 this week. It now includes a (pref controlled) checkbox on opac-memberentry to give consent during selfregistration. No consent means no registration. Which makes this request less urgent again, since you will have a consent. (But note that we could already argue that it is not possible to "perform this contract" of self-registration without data. Second ground of GDPR.) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13049] Merge selfreg cron jobs into cleanup_database
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13049 --- Comment #20 from Katrin Fischer --- (In reply to Marcel de Rooy from comment #19) > (In reply to Katrin Fischer from comment #18) > > It looks like this change introduced a regression. Before the changes it was > > possible to define the delay for unverified registrations in hours and now > > it's days. It will also change what actually happens when you switch over? > > > > With GDPR being very strict about saving data the initial feature of being > > able to delete after x hours would be better. > > I think you are being even stricter now :) Triggered by a request from a library. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13049] Merge selfreg cron jobs into cleanup_database
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13049 Katrin Fischer changed: What|Removed |Added Blocks||20856 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20856 [Bug 20856] Restore ability to delete unverified self registrations after x hours -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13049] Merge selfreg cron jobs into cleanup_database
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13049 --- Comment #19 from Marcel de Rooy --- (In reply to Katrin Fischer from comment #18) > It looks like this change introduced a regression. Before the changes it was > possible to define the delay for unverified registrations in hours and now > it's days. It will also change what actually happens when you switch over? > > With GDPR being very strict about saving data the initial feature of being > able to delete after x hours would be better. I think you are being even stricter now :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13049] Merge selfreg cron jobs into cleanup_database
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13049 --- Comment #18 from Katrin Fischer --- It looks like this change introduced a regression. Before the changes it was possible to define the delay for unverified registrations in hours and now it's days. It will also change what actually happens when you switch over? With GDPR being very strict about saving data the initial feature of being able to delete after x hours would be better. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13049] Merge selfreg cron jobs into cleanup_database
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13049 Olli-Antti Kivilahtichanged: What|Removed |Added Blocks||10744 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10744 [Bug 10744] ExpireReservesMaxPickUpDelay works with hold(s) over report -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13049] Merge selfreg cron jobs into cleanup_database
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13049 Olli-Antti Kivilahtichanged: What|Removed |Added Blocks|10744 | Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10744 [Bug 10744] ExpireReservesMaxPickUpDelay works with hold(s) over report -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13049] Merge selfreg cron jobs into cleanup_database
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13049 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #17 from Tomás Cohen Arazi tomasco...@gmail.com --- Patches pushed to master. Nice work Marcel! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13049] Merge selfreg cron jobs into cleanup_database
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13049 --- Comment #16 from Marcel de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 39343 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39343action=edit Bug 13049: [QA Follow-up] Remove unneeded module The call to cronlogaction is done in cleanup_database. So there is no use in keeping the module here. Test plan: Run or compile (perl -c) script delete_expired_opac_registrations.pl. Run or compile (perl -c) script delete_unverified_opac_registrations.pl. Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13049] Merge selfreg cron jobs into cleanup_database
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13049 Marcel de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Attachment #38042|0 |1 is obsolete|| --- Comment #14 from Marcel de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 39276 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39276action=edit Bug 13049: Merge selfreg cron jobs into cleanup_database This patch moves the core code of two selfreg cron jobs into the Members module. The new routines are called from cleanup_database with two new parameters. The old cron jobs are now wrappers to cleanup_database. As a bonus, we can add a unit test now. In time, we can obsolete the selfreg cron jobs. For now, the code is in one place and behavior does not change. A next step (as described on the Bugzilla report) would be: remove the Delay pref for self regs. Test plan: Run the unit test t/db_dependent/Members.t. Test the two new parameters of cleanup_database.pl. Verify if delete_expired_opac_registrations.pl still works. Same for delete_unverified_opac_registrations.pl. Signed-off-by: Frederic Demians f.demi...@tamil.fr . Fixed minor merge confict on UT cleanup_database.pl . UT ok . The two deprecated scripts still work as before, with a warning message. . cleanup_database.pl do the deletion job, calling new C4::Members function rather that doing it directly. Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13049] Merge selfreg cron jobs into cleanup_database
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13049 --- Comment #15 from Marcel de Rooy m.de.r...@rijksmuseum.nl --- Rebased: cronlogaction is called in cleanup_database; so the action is logged. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13049] Merge selfreg cron jobs into cleanup_database
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13049 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Severity|normal |enhancement CC||tomasco...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13049] Merge selfreg cron jobs into cleanup_database
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13049 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #37903|0 |1 is obsolete|| --- Comment #13 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 38042 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38042action=edit [PASSED QA] Bug 13049: Merge selfreg cron jobs into cleanup_database This patch moves the core code of two selfreg cron jobs into the Members module. The new routines are called from cleanup_database with two new parameters. The old cron jobs are now wrappers to cleanup_database. As a bonus, we can add a unit test now. In time, we can obsolete the selfreg cron jobs. For now, the code is in one place and behavior does not change. A next step (as described on the Bugzilla report) would be: remove the Delay pref for self regs. Test plan: Run the unit test t/db_dependent/Members.t. Test the two new parameters of cleanup_database.pl. Verify if delete_expired_opac_registrations.pl still works. Same for delete_unverified_opac_registrations.pl. Signed-off-by: Frederic Demians f.demi...@tamil.fr . Fixed minor merge confict on UT cleanup_database.pl . UT ok . The two deprecated scripts still work as before, with a warning message. . cleanup_database.pl do the deletion job, calling new C4::Members function rather that doing it directly. Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13049] Merge selfreg cron jobs into cleanup_database
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13049 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13049] Merge selfreg cron jobs into cleanup_database
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13049 --- Comment #11 from M. de Rooy m.de.r...@rijksmuseum.nl --- (In reply to Katrin Fischer from comment #10) A next step (as described on the Bugzilla report) would be: remove the Delay pref for self regs. Can we rethink this? There is another 'movement' in the patches recently to create preferences for options in the cronjobs. This is helpful when you are running multiple installations on one server, where maintaining separate cronjobs for each library would be quite a hassle. Ultimately I'd like a separate tool for those things, but as we have a pref already, why not keep it until that arrives? Fine with me. But this could proceed now separate of that. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13049] Merge selfreg cron jobs into cleanup_database
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13049 --- Comment #12 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Yes, this is separate, just thought maybe better to discuss first before code written :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13049] Merge selfreg cron jobs into cleanup_database
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13049 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #10 from Katrin Fischer katrin.fisc...@bsz-bw.de --- A next step (as described on the Bugzilla report) would be: remove the Delay pref for self regs. Can we rethink this? There is another 'movement' in the patches recently to create preferences for options in the cronjobs. This is helpful when you are running multiple installations on one server, where maintaining separate cronjobs for each library would be quite a hassle. Ultimately I'd like a separate tool for those things, but as we have a pref already, why not keep it until that arrives? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13049] Merge selfreg cron jobs into cleanup_database
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13049 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Attachment #37793|0 |1 is obsolete|| --- Comment #9 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 37903 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37903action=edit Bug 13049: Merge selfreg cron jobs into cleanup_database This patch moves the core code of two selfreg cron jobs into the Members module. The new routines are called from cleanup_database with two new parameters. The old cron jobs are now wrappers to cleanup_database. As a bonus, we can add a unit test now. In time, we can obsolete the selfreg cron jobs. For now, the code is in one place and behavior does not change. A next step (as described on the Bugzilla report) would be: remove the Delay pref for self regs. Test plan: Run the unit test t/db_dependent/Members.t. Test the two new parameters of cleanup_database.pl. Verify if delete_expired_opac_registrations.pl still works. Same for delete_unverified_opac_registrations.pl. Signed-off-by: Frederic Demians f.demi...@tamil.fr . Fixed minor merge confict on UT cleanup_database.pl . UT ok . The two deprecated scripts still work as before, with a warning message. . cleanup_database.pl do the deletion job, calling new C4::Members function rather that doing it directly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13049] Merge selfreg cron jobs into cleanup_database
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13049 Frédéric Demians frede...@tamil.fr changed: What|Removed |Added Attachment #37792|0 |1 is obsolete|| --- Comment #7 from Frédéric Demians frede...@tamil.fr --- Created attachment 37793 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37793action=edit Bug 13049: Merge selfreg cron jobs into cleanup_database This patch moves the core code of two selfreg cron jobs into the Members module. The new routines are called from cleanup_database with two new parameters. The old cron jobs are now wrappers to cleanup_database. As a bonus, we can add a unit test now. In time, we can obsolete the selfreg cron jobs. For now, the code is in one place and behavior does not change. A next step (as described on the Bugzilla report) would be: remove the Delay pref for self regs. Test plan: Run the unit test t/db_dependent/Members.t. Test the two new parameters of cleanup_database.pl. Verify if delete_expired_opac_registrations.pl still works. Same for delete_unverified_opac_registrations.pl. Signed-off-by: Frederic Demians f.demi...@tamil.fr . Fixed minor merge confict on UT cleanup_database.pl . UT ok . The two deprecated scripts still work as before, with a warning message. . cleanup_database.pl do the deletion job, calling new C4::Members function rather that doing it directly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13049] Merge selfreg cron jobs into cleanup_database
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13049 Frédéric Demians frede...@tamil.fr changed: What|Removed |Added Attachment #36929|0 |1 is obsolete|| --- Comment #6 from Frédéric Demians frede...@tamil.fr --- Created attachment 37792 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37792action=edit Bug 13049: Merge selfreg cron jobs into cleanup_database This patch moves the core code of two selfreg cron jobs into the Members module. The new routines are called from cleanup_database with two new parameters. The old cron jobs are now wrappers to cleanup_database. As a bonus, we can add a unit test now. In time, we can obsolete the selfreg cron jobs. For now, the code is in one place and behavior does not change. A next step (as described on the Bugzilla report) would be: remove the Delay pref for self regs. Test plan: Run the unit test t/db_dependent/Members.t. Test the two new parameters of cleanup_database.pl. Verify if delete_expired_opac_registrations.pl still works. Same for delete_unverified_opac_registrations.pl. Signed-off-by: Frederic Demians f.demi...@tamil.fr . Fixed minor merge confict on UT cleanup_database.pl . UT ok . The two deprecated scripts still work as before, with a warning message. . cleanup_database.pl do the deletion job, calling new C4::Members function rather that doing it directly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13049] Merge selfreg cron jobs into cleanup_database
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13049 Frédéric Demians frede...@tamil.fr changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13049] Merge selfreg cron jobs into cleanup_database
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13049 --- Comment #8 from M. de Rooy m.de.r...@rijksmuseum.nl --- Thanks, Frederic for your SO. I am not sure however if everything went fine? When applying your patch, I get: fatal: sha1 information is lacking or useless (misc/cronjobs/cleanup_database.pl). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. And the signed-off patch contains this line: + Bug 13049: Merge selfreg cron jobs into cleanup_database It is in the usage statement of cleanup_database.pl If it is easy for you to fix it, go ahead :) Otherwise I will fix it tomorrow or so.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13049] Merge selfreg cron jobs into cleanup_database
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13049 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Summary|Improve self-registration |Merge selfreg cron jobs |cronjobs|into cleanup_database -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/