[Koha-bugs] [Bug 13134] Add patron category to returns confirmation dialogs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13134

Kyle M Hall  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #12 from Kyle M Hall  ---
Pushed to master for 16.11, thanks for the followup Marc!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13134] Add patron category to returns confirmation dialogs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13134

--- Comment #11 from Jonathan Druart  
---
Created attachment 54359
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54359=edit
Bug 13134: Fix template file to make category appear

This is a followup to rescue the bug.

To test: Follow test plan from comment #1

Signed-off-by: Owen Leonard 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13134] Add patron category to returns confirmation dialogs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13134

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #54306|0   |1
is obsolete||
  Attachment #54307|0   |1
is obsolete||

--- Comment #10 from Jonathan Druart  
---
Created attachment 54358
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54358=edit
Bug 13134 - Add patron category to returns confirmation dialogs

Some librarians find it useful to know what category a patron is before
confirming a reserve or transfer from the checkin screen.

This patch adds the patron category to the hold and transfer popups
to the patron information already displayed. The li tags that contain
the patron category have the class "patron-category" to allow this data
to be easily hidden.

Test Plan:
1) Apply this patch
2) Trap a hold for a patron, note the patron category is now displayed
3) Trap a hold for pickup at another loation, note the patron category
   is now displayed

Signed-off-by: Owen Leonard 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13134] Add patron category to returns confirmation dialogs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13134

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13134] Add patron category to returns confirmation dialogs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13134

Owen Leonard  changed:

   What|Removed |Added

  Attachment #32642|0   |1
is obsolete||

--- Comment #8 from Owen Leonard  ---
Created attachment 54306
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54306=edit
[SIGNED-OFF] Bug 13134 - Add patron category to returns confirmation dialogs

Some librarians find it useful to know what category a patron is before
confirming a reserve or transfer from the checkin screen.

This patch adds the patron category to the hold and transfer popups
to the patron information already displayed. The li tags that contain
the patron category have the class "patron-category" to allow this data
to be easily hidden.

Test Plan:
1) Apply this patch
2) Trap a hold for a patron, note the patron category is now displayed
3) Trap a hold for pickup at another loation, note the patron category
   is now displayed

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13134] Add patron category to returns confirmation dialogs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13134

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13134] Add patron category to returns confirmation dialogs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13134

Owen Leonard  changed:

   What|Removed |Added

  Attachment #54282|0   |1
is obsolete||

--- Comment #9 from Owen Leonard  ---
Created attachment 54307
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54307=edit
[SIGNED-OFF] Bug 13134: Fix template file to make category appear

This is a followup to rescue the bug.

To test: Follow test plan from comment #1

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13134] Add patron category to returns confirmation dialogs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13134

Marc Véron  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff
 CC||ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13134] Add patron category to returns confirmation dialogs

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13134

--- Comment #7 from Marc Véron  ---
Created attachment 54282
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54282=edit
Bug 13134: Fix template file to make category appear

This is a followup to rescue the bug.

To test: Follow test plan from comment #1

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13134] Add patron category to returns confirmation dialogs

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13134

Owen Leonard oleon...@myacpl.org changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #6 from Owen Leonard oleon...@myacpl.org ---
(In reply to Kyle M Hall from comment #5)
 2) Trap a hold for a patron, note the patron category is now displayed
 3) Trap a hold for pickup at another loation, note the patron category
is now displayed

I think there's a copy-paste error. I'm not seeing the patron category in this
latest version for either of those cases.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13134] Add patron category to returns confirmation dialogs

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13134

--- Comment #1 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 32617
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32617action=edit
Bug 13134 - Add patron category to returns confirmation dialogs

Some librarians find it useful to know what category a patron is before
confirming a reserve or transfer from the checkin screen.

This patch adds the patron category to the hold and transfer popups
to the patron information already displayed. The li tags that contain
the patron category have the class patron-category to allow this data
to be easily hidden.

Test Plan:
1) Apply this patch
2) Trap a hold for a patron, note the patron category is now displayed
3) Trap a hold for pickup at another loation, note the patron category
   is now displayed

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13134] Add patron category to returns confirmation dialogs

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13134

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13134] Add patron category to returns confirmation dialogs

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13134

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13134] Add patron category to returns confirmation dialogs

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13134

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13134] Add patron category to returns confirmation dialogs

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13134

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #32617|0   |1
is obsolete||

--- Comment #2 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 32618
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32618action=edit
Bug 13134 - Add patron category to returns confirmation dialogs

Some librarians find it useful to know what category a patron is before
confirming a reserve or transfer from the checkin screen.

This patch adds the patron category to the hold and transfer popups
to the patron information already displayed. The li tags that contain
the patron category have the class patron-category to allow this data
to be easily hidden.

Test Plan:
1) Apply this patch
2) Trap a hold for a patron, note the patron category is now displayed
3) Trap a hold for pickup at another loation, note the patron category
   is now displayed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13134] Add patron category to returns confirmation dialogs

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13134

--- Comment #3 from Owen Leonard oleon...@myacpl.org ---
My inclination is to add this to the line with the patron name, similar to the
way we do it on the screen where you submit a partial name for checkout and are
presented with a multi-select. For example:

li
  a href=/cgi-bin/koha/members/moremember.pl?borrowernumber=[% borrowernumber
%][% borsurname %], [% borfirstname %]/a
  ([% borcnum %]span class=patron-category - [% borcategory %]/span)
/li

Which would like something like this:

- Leonard, Owen (012345 - Adult)

Seems more compact and logical to me.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13134] Add patron category to returns confirmation dialogs

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13134

--- Comment #4 from Kyle M Hall k...@bywatersolutions.com ---
(In reply to Owen Leonard from comment #3)
 My inclination is to add this to the line with the patron name, similar to
 the way we do it on the screen where you submit a partial name for checkout
 and are presented with a multi-select. For example:
 
 li
   a href=/cgi-bin/koha/members/moremember.pl?borrowernumber=[%
 borrowernumber %][% borsurname %], [% borfirstname %]/a
   ([% borcnum %]span class=patron-category - [% borcategory %]/span)
 /li
 
 Which would like something like this:
 
 - Leonard, Owen (012345 - Adult)
 
 Seems more compact and logical to me.

I agree. I think that's a much better idea. I'll update the patch as soon as I
can.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13134] Add patron category to returns confirmation dialogs

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13134

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #32618|0   |1
is obsolete||

--- Comment #5 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 32642
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32642action=edit
Bug 13134 - Add patron category to returns confirmation dialogs

Some librarians find it useful to know what category a patron is before
confirming a reserve or transfer from the checkin screen.

This patch adds the patron category to the hold and transfer popups
to the patron information already displayed. The li tags that contain
the patron category have the class patron-category to allow this data
to be easily hidden.

Test Plan:
1) Apply this patch
2) Trap a hold for a patron, note the patron category is now displayed
3) Trap a hold for pickup at another loation, note the patron category
   is now displayed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/