[Koha-bugs] [Bug 13178] cardnumber field length is too short
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13178 Jonathan Druartchanged: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #25 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13178] cardnumber field length is too short
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13178 Nick Clemenschanged: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13178] cardnumber field length is too short
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13178 Katrin Fischerchanged: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #24 from Katrin Fischer --- Checked Nick's follow-up and liked it :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13178] cardnumber field length is too short
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13178 Katrin Fischerchanged: What|Removed |Added Attachment #68475|0 |1 is obsolete|| --- Comment #23 from Katrin Fischer --- Created attachment 68555 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68555=edit Bug 13178: QA Followup - fix kohastructure and update info in fields Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13178] cardnumber field length is too short
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13178 Katrin Fischerchanged: What|Removed |Added Attachment #68474|0 |1 is obsolete|| --- Comment #22 from Katrin Fischer --- Created attachment 68554 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68554=edit Bug 13178: Correct Max cardnumberlength ($max is the value of the max size of a card number) - $max not hardcoded anymore in C4::Memeber - $max now correctly adapts to the field of cardnumber in database Signed-off-by: Marc Véron Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13178] cardnumber field length is too short
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13178 Katrin Fischerchanged: What|Removed |Added Attachment #68473|0 |1 is obsolete|| --- Comment #21 from Katrin Fischer --- Created attachment 68553 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68553=edit Bug 13178: increase max value of CardnumberLength testplan 1 - Apply patch 2 - Run updatedatabase.pl 3 - Update dbix scheme 4 - set the value of CardnumberLength to a value between 16 and 32 5 - Check you can enter a propper cardnumber (modify to 32 instead 20) + max value now depends on the database field value to Signed-off-by: Marc Véron Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13178] cardnumber field length is too short
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13178 Nick Clemenschanged: What|Removed |Added CC||n...@bywatersolutions.com, ||tomasco...@gmail.com --- Comment #20 from Nick Clemens --- Looks good here, added the max length to syspref notes so want an opinion on that -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13178] cardnumber field length is too short
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13178 --- Comment #19 from Nick Clemens--- Created attachment 68475 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68475=edit Bug 13178: QA Followup - fix kohastructure and update info in fields Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13178] cardnumber field length is too short
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13178 --- Comment #18 from Nick Clemens--- Created attachment 68474 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68474=edit Bug 13178: Correct Max cardnumberlength ($max is the value of the max size of a card number) - $max not hardcoded anymore in C4::Memeber - $max now correctly adapts to the field of cardnumber in database Signed-off-by: Marc Véron Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13178] cardnumber field length is too short
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13178 Nick Clemenschanged: What|Removed |Added Attachment #64646|0 |1 is obsolete|| Attachment #64647|0 |1 is obsolete|| --- Comment #17 from Nick Clemens --- Created attachment 68473 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68473=edit Bug 13178: increase max value of CardnumberLength testplan 1 - Apply patch 2 - Run updatedatabase.pl 3 - Update dbix scheme 4 - set the value of CardnumberLength to a value between 16 and 32 5 - Check you can enter a propper cardnumber (modify to 32 instead 20) + max value now depends on the database field value to Signed-off-by: Marc Véron Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13178] cardnumber field length is too short
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13178 Josef Moravecchanged: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com --- Comment #16 from Josef Moravec --- *** Bug 18338 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13178] cardnumber field length is too short
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13178 Jonathan Druartchanged: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #15 from Jonathan Druart --- @QAer, take a look at bug 10267 as well. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13178] cardnumber field length is too short
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13178 Marc Véronchanged: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=10267 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13178] cardnumber field length is too short
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13178 Marc Véronchanged: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13178] cardnumber field length is too short
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13178 Marc Véronchanged: What|Removed |Added Attachment #64645|0 |1 is obsolete|| --- Comment #14 from Marc Véron --- Created attachment 64647 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64647=edit Bug 13178: Correct Max cardnumberlength ($max is the value of the max size of a card number) - $max not hardcoded anymore in C4::Memeber - $max now correctly adapts to the field of cardnumber in database Signed-off-by: Marc Véron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13178] cardnumber field length is too short
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13178 Marc Véronchanged: What|Removed |Added Attachment #64644|0 |1 is obsolete|| --- Comment #13 from Marc Véron --- Created attachment 64646 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64646=edit Bug 13178: increase max value of CardnumberLength testplan 1 - Apply patch 2 - Run updatedatabase.pl 3 - Update dbix scheme 4 - set the value of CardnumberLength to a value between 16 and 32 5 - Check you can enter a propper cardnumber (modify to 32 instead 20) + max value now depends on the database field value to Signed-off-by: Marc Véron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13178] cardnumber field length is too short
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13178 --- Comment #12 from Marc Véron--- Tested both patches together, will sign off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13178] cardnumber field length is too short
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13178 Baptistechanged: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #11 from Baptiste --- @Marc Veron Sorry I didn't write to update the DBix schema, if you do this this should correct your problem However you discovered another bug: max size should be set to 16 in your case, because you had a wrong max value Please apply second patch and try again ;) To test the second patch: -> set your syspref to (100,200) before applying patch => max shouldn't change -> do the same after applying patch => max should change -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13178] cardnumber field length is too short
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13178 --- Comment #10 from Baptiste--- Created attachment 64645 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64645=edit Bug 13178: Correct Max cardnumberlength ($max is the value of the max size of a card number) - $max not hardcoded anymore in C4::Memeber - $max now correctly adapts to the field of cardnumber in database -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13178] cardnumber field length is too short
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13178 Baptistechanged: What|Removed |Added Attachment #64487|0 |1 is obsolete|| --- Comment #9 from Baptiste --- Created attachment 64644 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64644=edit Bug 13178: increase max value of CardnumberLength testplan 1 - Apply patch 2 - Run updatedatabase.pl 3 - Update dbix scheme 4 - set the value of CardnumberLength to a value between 16 and 32 5 - Check you can enter a propper cardnumber (modify to 32 instead 20) + max value now depends on the database field value to -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13178] cardnumber field length is too short
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13178 Marc Véronchanged: What|Removed |Added Status|Needs Signoff |Failed QA CC||ve...@veron.ch --- Comment #8 from Marc Véron --- (In reply to Baptiste from comment #7) > Created attachment 64487 [details] [review] > Bug 13178: increase max value of CardnumberLength > > testplan > 1 - Apply patch > 2 - Run updatedatabase.pl > 3 - set the value of CardnumberLength to a value between 16 and 20 > 4 - Check you can enter a propper cardnumber > (modify to 32 instead 20) I tested by setting CardnumberLength to 20,32 for min 20 and max 32 However in cgi-bin/koha/members/memberentry.pl I get: "Card number must be between 16 and 32 characters." ...and I can enter an card number inside this range, e.g. a length of 18. Expected: Correct validation (card number length between 20 and 32). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13178] cardnumber field length is too short
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13178 Baptistechanged: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13178] cardnumber field length is too short
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13178 Baptistechanged: What|Removed |Added Attachment #64428|0 |1 is obsolete|| --- Comment #7 from Baptiste --- Created attachment 64487 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64487=edit Bug 13178: increase max value of CardnumberLength testplan 1 - Apply patch 2 - Run updatedatabase.pl 3 - set the value of CardnumberLength to a value between 16 and 20 4 - Check you can enter a propper cardnumber (modify to 32 instead 20) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13178] cardnumber field length is too short
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13178 --- Comment #6 from Baptiste--- Created attachment 64428 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64428=edit Bug 13178: increase max value of CardnumberLength testplan 1 - Apply patch 2 - Run updatedatabase.pl 3 - set the value of CardnumberLength to a value between 16 and 20 4 - Check you can enter a propper cardnumber -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13178] cardnumber field length is too short
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13178 --- Comment #5 from Baptiste--- The code specifies that if the cardnumber length from the system preference is to big, it will consider it as the biggest authorized value -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13178] cardnumber field length is too short
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13178 Baptistechanged: What|Removed |Added CC||baptiste.wojtkowski@biblibr ||e.com Status|NEW |ASSIGNED Assignee|koha-b...@lists.koha-commun |baptiste.wojtkowski@biblibr |ity.org |e.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13178] cardnumber field length is too short
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13178 Indranil Das Guptachanged: What|Removed |Added CC||indr...@l2c2.co.in -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13178] cardnumber field length is too short
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13178 Joonas Kylmälä j.kylm...@gmail.com changed: What|Removed |Added CC||j.kylm...@gmail.com --- Comment #4 from Joonas Kylmälä j.kylm...@gmail.com --- There is CardnumberLength system preference but it doesn't change the max length of the cardnumber when trying to edit x patron's cardnumber. Does anyone know what is the purpose of this preference, does it change the cardnumber length somewhere else? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13178] cardnumber field length is too short
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13178 Brendon Ford brendon.f...@manhattan.edu changed: What|Removed |Added CC||brendon.f...@manhattan.edu --- Comment #3 from Brendon Ford brendon.f...@manhattan.edu --- We are also having an issue with the 16 digit character limit. Our card readers output a trailing equals sign and then send a backspace keystroke to remove it when swiping a card. Since our card numbers are 16 digits the equals sign never gets typed into the field and the backspace removes the last digit of the card number. We can't reprogram the card readers because it would leave the equals sign in other fields that we swipe card numbers into. We are currently using a bit of javascript to extend the maxlength, but it would be great to see the character limit extended. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13178] cardnumber field length is too short
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13178 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Version|unspecified |master --- Comment #1 from Owen Leonard oleon...@myacpl.org --- I'm sure there's not any problem with making the field longer (other than finding someone to do the work), but I'm wondering why you don't enter the patron's email address as their username and have Koha auto-generate card numbers? That way Koha handles the card numbers without you having to think about it, and the user can log in to their account using their email address. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13178] cardnumber field length is too short
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13178 --- Comment #2 from Jeremy Evans jeremy.ev...@nibsc.org --- Owen, Thanks for your quick reply. I must admit I hadn't thought of that option. I have just tried it out and I think this would actually work better as it is one less field to worry about when creating a new patron record. We usually look up the user by surname in the staff client when checking something out. So this bug can be closed I think. Also related is this one which would automatically align the username login to the email address field. http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2237 Jeremy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/