subject:"\[Koha\-bugs\] \[Bug 13205\] Last\/First page options for result list paging"

[Koha-bugs] [Bug 13205] Last/First page options for result list paging

2017-10-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13205

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #21 from Jonathan Druart  
---
Pushed to master for 17.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13205] Last/First page options for result list paging

2017-10-06 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13205

--- Comment #20 from Nick Clemens  ---
Created attachment 6
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6=edit
Bug 13205: [FOLLOW-UP] Fixing math and variable names

Have changed
  my $last_page = $pages * ( $results_per_page - 1 );
to
  my $last_page = ( $pages - 1) * $results_per_page;
which seems to fix the 'last' button offset! (Comment 10)

Will add the box to jump to a page in a separate patch.
Adding the pagination to the top on the staff client will be dealt with
in Bug 18916 as it is slightly out of the scope of this bug.

Signed-off-by: Lee Jamison 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13205] Last/First page options for result list paging

2017-10-06 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13205

Nick Clemens  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13205] Last/First page options for result list paging

2017-10-06 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13205

--- Comment #18 from Nick Clemens  ---
Created attachment 67775
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67775=edit
Bug 13205: Last/first page options for result list paging for OPAC

Same fix but on OPAC side. Same test plan

Sponsored-by: Catalyst IT

Signed-off-by: Dilan Johnpulle 
Signed-off-by: Your Full Name 

Signed-off-by: Lee Jamison 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13205] Last/First page options for result list paging

2017-10-06 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13205

--- Comment #19 from Nick Clemens  ---
Created attachment 67776
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67776=edit
Bug 13205: [FOLLOW-UP] Some extra logic

See Comment 8.

Test:
When on first page of results, confirm that the 'First' and 'Previous'
buttons do not show. Confirm they come back on the second page and every
page after.
When on last page of results, confirm that the 'Last' and 'Next' buttons
do not show. Confirm they come back on all previous pages.
Check on both staff side and OPAC.

Sponsored-by: Catalyst IT

Signed-off-by: Lee Jamison 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13205] Last/First page options for result list paging

2017-10-06 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13205

Nick Clemens  changed:

   What|Removed |Added

  Attachment #64981|0   |1
is obsolete||
  Attachment #64982|0   |1
is obsolete||
  Attachment #64983|0   |1
is obsolete||
  Attachment #64984|0   |1
is obsolete||

--- Comment #17 from Nick Clemens  ---
Created attachment 67774
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67774=edit
Bug 13205: Last/first page options for result list paging

This patch adds first and last page buttons to the pagination at the
bottom of a page of catalog search results.

To test:
1) Apply patch
2) Do a number of searches
3) For each search, ensure that the first and last page buttons work as
expected

Sponsored-by: Catalyst IT

Followed test plan, works as expected.
Signed-off-by: Marc Véron 

Signed-off-by: Lee Jamison 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13205] Last/First page options for result list paging

2017-10-06 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13205

Nick Clemens  changed:

   What|Removed |Added

  Attachment #64670|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13205] Last/First page options for result list paging

2017-10-06 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13205

Nick Clemens  changed:

   What|Removed |Added

  Attachment #64938|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13205] Last/First page options for result list paging

2017-10-06 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13205

Nick Clemens  changed:

   What|Removed |Added

  Attachment #61194|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13205] Last/First page options for result list paging

2017-10-06 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13205

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com
  Attachment #60248|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13205] Last/First page options for result list paging

2017-07-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13205

--- Comment #13 from Lee Jamison  ---
Created attachment 64981
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64981=edit
[SIGNED-OFF] Bug 13205: Last/first page options for result list paging

This patch adds first and last page buttons to the pagination at the
bottom of a page of catalog search results.

To test:
1) Apply patch
2) Do a number of searches
3) For each search, ensure that the first and last page buttons work as
expected

Sponsored-by: Catalyst IT

Followed test plan, works as expected.
Signed-off-by: Marc Véron 

Signed-off-by: Lee Jamison 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13205] Last/First page options for result list paging

2017-07-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13205

--- Comment #15 from Lee Jamison  ---
Created attachment 64983
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64983=edit
[SIGNED-OFF] Bug 13205: [FOLLOW-UP] Some extra logic

See Comment 8.

Test:
When on first page of results, confirm that the 'First' and 'Previous'
buttons do not show. Confirm they come back on the second page and every
page after.
When on last page of results, confirm that the 'Last' and 'Next' buttons
do not show. Confirm they come back on all previous pages.
Check on both staff side and OPAC.

Sponsored-by: Catalyst IT

Signed-off-by: Lee Jamison 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13205] Last/First page options for result list paging

2017-07-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13205

--- Comment #16 from Lee Jamison  ---
Created attachment 64984
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64984=edit
[SIGNED-OFF] Bug 13205: [FOLLOW-UP] Fixing math and variable names

Have changed
  my $last_page = $pages * ( $results_per_page - 1 );
to
  my $last_page = ( $pages - 1) * $results_per_page;
which seems to fix the 'last' button offset! (Comment 10)

Will add the box to jump to a page in a separate patch.
Adding the pagination to the top on the staff client will be dealt with
in Bug 18916 as it is slightly out of the scope of this bug.

Signed-off-by: Lee Jamison 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13205] Last/First page options for result list paging

2017-07-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13205

--- Comment #14 from Lee Jamison  ---
Created attachment 64982
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64982=edit
[SIGNED-OFF] Bug 13205: Last/first page options for result list paging for OPAC

Same fix but on OPAC side. Same test plan

Sponsored-by: Catalyst IT

Signed-off-by: Dilan Johnpulle 
Signed-off-by: Your Full Name 

Signed-off-by: Lee Jamison 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13205] Last/First page options for result list paging

2017-07-10 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13205

Lee Jamison  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13205] Last/First page options for result list paging

2017-07-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13205

--- Comment #12 from Aleisha Amohia  ---
(In reply to Aleisha Amohia from comment #11)
> Created attachment 64938 [details] [review]
> Bug 13205: [FOLLOW-UP] Fixing math and variable names
> 
> Have changed
>   my $last_page = $pages * ( $results_per_page - 1 );
> to
>   my $last_page = ( $pages - 1) * $results_per_page;
> which seems to fix the 'last' button offset! (Comment 10)
> 
> Will add the box to jump to a page in a separate patch.

Actually, my apologies - I had written a patch for this in Bug 18128

> Adding the pagination to the top on the staff client will be dealt with
> in Bug 18916 as it is slightly out of the scope of this bug.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13205] Last/First page options for result list paging

2017-07-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13205

--- Comment #11 from Aleisha Amohia  ---
Created attachment 64938
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64938=edit
Bug 13205: [FOLLOW-UP] Fixing math and variable names

Have changed
  my $last_page = $pages * ( $results_per_page - 1 );
to
  my $last_page = ( $pages - 1) * $results_per_page;
which seems to fix the 'last' button offset! (Comment 10)

Will add the box to jump to a page in a separate patch.
Adding the pagination to the top on the staff client will be dealt with
in Bug 18916 as it is slightly out of the scope of this bug.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13205] Last/First page options for result list paging

2017-07-09 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13205

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13205] Last/First page options for result list paging

2017-06-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13205

Séverine Queune  changed:

   What|Removed |Added

 CC||severine.que...@bulac.fr
 Status|Needs Signoff   |Failed QA

--- Comment #10 from Séverine Queune  ---
Tested on the BibLibre's sandbox #2.

Behavior is exactly the same for staff client and OPAC :

  - Display is correct for the button "First" : it not visible when you're on
the first page (neither button "<< Previous"); using it brings you back to the
first page.

  - I had more difficulties with button "Last" (expect explanations will be
clear...):
> Using the button "Last" didn't always bring me to the last page (I arrived 
> page 167 instead of 174 // for only 2 pages result, I arrived on a blank page 
> // it was ok for a result with 18 pages)
> I had problem on the number of the pages : after clicking on "Last", all the 
> pages were named "[page_number].[number]" : I searched different keywords and 
> the number after the dot was always different (.05 ; .25 ; .18). When I went 
> to the last pages without using the button "Last", the numbers appear 
> correctly.
> on the last page, both buttons "Last" and "Next" appear once I used one of 
> them. Display is correct (none of them visible) when I went to the last page 
> not using "Last" but jumping for one page to another until the last one.


I agree with Katrin about a box to enter the page we want to go to.

I also think it would be useful to have on staff client the pagination
appearing both at the top and the bottom of the page result (like it is on the
OPAC).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13205] Last/First page options for result list paging

2017-06-26 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13205

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13205] Last/First page options for result list paging

2017-06-26 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13205

--- Comment #9 from Aleisha Amohia  ---
Created attachment 64670
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64670=edit
Bug 13205: [FOLLOW-UP] Some extra logic

See Comment 8.

Test:
When on first page of results, confirm that the 'First' and 'Previous'
buttons do not show. Confirm they come back on the second page and every
page after.
When on last page of results, confirm that the 'Last' and 'Next' buttons
do not show. Confirm they come back on all previous pages.
Check on both staff side and OPAC.

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13205] Last/First page options for result list paging

2017-03-17 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13205

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA
 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #8 from Jonathan Druart  
---
Hi Aleisha,

It's a bit more complicated, we do not want to see First and Last when they are
not needed (for instance if you are on the first or last page).

I would have written
  my $last_page = ($pages * $results_per_page) - $results_per_page;
that way:
  my $last_page = $pages * ( $results_per_page - 1 );

Sounds more readable.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13205] Last/First page options for result list paging

2017-03-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13205

di...@calyx.net.au changed:

   What|Removed |Added

 CC||di...@calyx.net.au
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13205] Last/First page options for result list paging

2017-03-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13205

--- Comment #7 from di...@calyx.net.au ---
Comment on attachment 61194
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61194
Bug 13205: Last/first page options for result list paging for OPAC

>From bd80eca290f389e8e12d63dd220ec639763adcbb Mon Sep 17 00:00:00 2001
>From: Aleisha Amohia 
>Date: Thu, 16 Feb 2017 02:28:13 +
>Subject: [PATCH] Bug 13205: Last/first page options for result list paging for
> OPAC
>
>Same fix but on OPAC side. Same test plan
>
>Sponsored-by: Catalyst IT
>
>Signed-off-by: Dilan Johnpulle 
>
>---
> .../bootstrap/en/includes/page-numbers.inc | 26 --
> opac/opac-search.pl|  2 ++
> 2 files changed, 16 insertions(+), 12 deletions(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/page-numbers.inc 
>b/koha-tmpl/opac-tmpl/bootstrap/en/includes/page-numbers.inc
>index f18c9ce..63e083e 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/page-numbers.inc
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/page-numbers.inc
>@@ -1,19 +1,21 @@
> [% IF ( PAGE_NUMBERS ) %]
> 
> 
>-[% IF ( previous_page_offset.defined ) %]
>- Previous
>-[% END %]
>-[% FOREACH PAGE_NUMBER IN PAGE_NUMBERS %]
>-[% IF ( PAGE_NUMBER.highlight ) %]
>-[% PAGE_NUMBER.pg %]
>-[% ELSE %]
>-[% PAGE_NUMBER.pg %]
>+First
>+[% IF ( previous_page_offset.defined ) %]
>+ Previous
> [% END %]
>-[% END %]
>-[% IF ( next_page_offset ) %]
>-Next 
>-[% END %]
>+[% FOREACH PAGE_NUMBER IN PAGE_NUMBERS %]
>+[% IF ( PAGE_NUMBER.highlight ) %]
>+[% PAGE_NUMBER.pg 
>%]
>+[% ELSE %]
>+[% PAGE_NUMBER.pg 
>%]
>+[% END %]
>+[% END %]
>+[% IF ( next_page_offset ) %]
>+Next 
>+[% END %]
>+Last
> 
> 
> [% END %]
>diff --git a/opac/opac-search.pl b/opac/opac-search.pl
>index a84e9d3..130aad3 100755
>--- a/opac/opac-search.pl
>+++ b/opac/opac-search.pl
>@@ -837,6 +837,7 @@ for (my $i=0;$i<@servers;$i++) {
> my @page_numbers;
> # total number of pages there will be
> my $pages = ceil($hits / $results_per_page);
>+my $last_page = ($pages * $results_per_page) - $results_per_page;
> # default page number
> my $current_page_number = 1;
> if ($offset) {
>@@ -887,6 +888,7 @@ for (my $i=0;$i<@servers;$i++) {
> 
> }
> $template->param(   PAGE_NUMBERS => \@page_numbers,
>+last_page => $last_page,
> previous_page_offset => 
> $previous_page_offset) unless $pages < 2;
> $template->param(next_page_offset => $next_page_offset) unless 
> $pages eq $current_page_number;
> }
>-- 
>2.1.4

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13205] Last/First page options for result list paging

2017-03-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13205

--- Comment #6 from di...@calyx.net.au ---
Comment on attachment 61194
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61194
Bug 13205: Last/first page options for result list paging for OPAC

>From bd80eca290f389e8e12d63dd220ec639763adcbb Mon Sep 17 00:00:00 2001
>From: Aleisha Amohia 
>Date: Thu, 16 Feb 2017 02:28:13 +
>Subject: [PATCH] Bug 13205: Last/first page options for result list paging for
> OPAC
>
>Same fix but on OPAC side. Same test plan
>
>Sponsored-by: Catalyst IT
>
>Signed-off-by: Dilan Johnpulle 
>
>---
> .../bootstrap/en/includes/page-numbers.inc | 26 --
> opac/opac-search.pl|  2 ++
> 2 files changed, 16 insertions(+), 12 deletions(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/page-numbers.inc 
>b/koha-tmpl/opac-tmpl/bootstrap/en/includes/page-numbers.inc
>index f18c9ce..63e083e 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/page-numbers.inc
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/page-numbers.inc
>@@ -1,19 +1,21 @@
> [% IF ( PAGE_NUMBERS ) %]
> 
> 
>-[% IF ( previous_page_offset.defined ) %]
>- Previous
>-[% END %]
>-[% FOREACH PAGE_NUMBER IN PAGE_NUMBERS %]
>-[% IF ( PAGE_NUMBER.highlight ) %]
>-[% PAGE_NUMBER.pg %]
>-[% ELSE %]
>-[% PAGE_NUMBER.pg %]
>+First
>+[% IF ( previous_page_offset.defined ) %]
>+ Previous
> [% END %]
>-[% END %]
>-[% IF ( next_page_offset ) %]
>-Next 
>-[% END %]
>+[% FOREACH PAGE_NUMBER IN PAGE_NUMBERS %]
>+[% IF ( PAGE_NUMBER.highlight ) %]
>+[% PAGE_NUMBER.pg 
>%]
>+[% ELSE %]
>+[% PAGE_NUMBER.pg 
>%]
>+[% END %]
>+[% END %]
>+[% IF ( next_page_offset ) %]
>+Next 
>+[% END %]
>+Last
> 
> 
> [% END %]
>diff --git a/opac/opac-search.pl b/opac/opac-search.pl
>index a84e9d3..130aad3 100755
>--- a/opac/opac-search.pl
>+++ b/opac/opac-search.pl
>@@ -837,6 +837,7 @@ for (my $i=0;$i<@servers;$i++) {
> my @page_numbers;
> # total number of pages there will be
> my $pages = ceil($hits / $results_per_page);
>+my $last_page = ($pages * $results_per_page) - $results_per_page;
> # default page number
> my $current_page_number = 1;
> if ($offset) {
>@@ -887,6 +888,7 @@ for (my $i=0;$i<@servers;$i++) {
> 
> }
> $template->param(   PAGE_NUMBERS => \@page_numbers,
>+last_page => $last_page,
> previous_page_offset => 
> $previous_page_offset) unless $pages < 2;
> $template->param(next_page_offset => $next_page_offset) unless 
> $pages eq $current_page_number;
> }
>-- 
>2.1.4

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13205] Last/First page options for result list paging

2017-03-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13205

di...@calyx.net.au changed:

   What|Removed |Added

  Attachment #60300|0   |1
is obsolete||

--- Comment #5 from di...@calyx.net.au ---
Created attachment 61194
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61194=edit
Bug 13205: Last/first page options for result list paging for OPAC

Same fix but on OPAC side. Same test plan

Sponsored-by: Catalyst IT

Signed-off-by: Dilan Johnpulle 
Signed-off-by: Your Full Name 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13205] Last/First page options for result list paging

2017-02-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13205

Aleisha Amohia  changed:

   What|Removed |Added

 Blocks||18128


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18128
[Bug 18128] 'Go to page' option for search results in opac and staff
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13205] Last/First page options for result list paging

2017-02-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13205

Aleisha Amohia  changed:

   What|Removed |Added

 Status|Signed Off  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13205] Last/First page options for result list paging

2017-02-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13205

--- Comment #4 from Aleisha Amohia  ---
Created attachment 60300
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60300=edit
Bug 13205: Last/first page options for result list paging for OPAC

Same fix but on OPAC side. Same test plan

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13205] Last/First page options for result list paging

2017-02-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13205

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13205] Last/First page options for result list paging

2017-02-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13205

Marc Véron  changed:

   What|Removed |Added

  Attachment #60229|0   |1
is obsolete||

--- Comment #3 from Marc Véron  ---
Created attachment 60248
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60248=edit
Bug 13205: Last/first page options for result list paging

This patch adds first and last page buttons to the pagination at the
bottom of a page of catalog search results.

To test:
1) Apply patch
2) Do a number of searches
3) For each search, ensure that the first and last page buttons work as
expected

Sponsored-by: Catalyst IT

Followed test plan, works as expected.
Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13205] Last/First page options for result list paging

2017-02-14 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13205

Aleisha Amohia  changed:

   What|Removed |Added

 CC||aleishaamo...@hotmail.com
   Assignee|gmcha...@gmail.com  |aleishaamo...@hotmail.com
  Change sponsored?|--- |Sponsored

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13205] Last/First page options for result list paging

2017-02-14 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13205

Aleisha Amohia  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13205] Last/First page options for result list paging

2017-02-14 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13205

--- Comment #2 from Aleisha Amohia  ---
Created attachment 60229
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60229=edit
Bug 13205: Last/first page options for result list paging

This patch adds first and last page buttons to the pagination at the
bottom of a page of catalog search results.

To test:
1) Apply patch
2) Do a number of searches
3) For each search, ensure that the first and last page buttons work as
expected

Sponsored-by: Catalyst IT

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13205] Last/First page options for result list paging

2014-11-06 Thread bugzilla-daemon

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13205

--- Comment #1 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Something else that would be helpful is a box where you can enter the page that
you want to jump to.

This is also an accessibility problem as our current way of paging makes it
harder to work with long result lists.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13205] Last/First page options for result list paging

[Koha-bugs] [Bug 13205] Last/First page options for result list paging

[Koha-bugs] [Bug 13205] Last/First page options for result list paging

[Koha-bugs] [Bug 13205] Last/First page options for result list paging

[Koha-bugs] [Bug 13205] Last/First page options for result list paging

[Koha-bugs] [Bug 13205] Last/First page options for result list paging

[Koha-bugs] [Bug 13205] Last/First page options for result list paging

[Koha-bugs] [Bug 13205] Last/First page options for result list paging

[Koha-bugs] [Bug 13205] Last/First page options for result list paging

[Koha-bugs] [Bug 13205] Last/First page options for result list paging

[Koha-bugs] [Bug 13205] Last/First page options for result list paging

[Koha-bugs] [Bug 13205] Last/First page options for result list paging

[Koha-bugs] [Bug 13205] Last/First page options for result list paging

[Koha-bugs] [Bug 13205] Last/First page options for result list paging

[Koha-bugs] [Bug 13205] Last/First page options for result list paging

[Koha-bugs] [Bug 13205] Last/First page options for result list paging

[Koha-bugs] [Bug 13205] Last/First page options for result list paging

[Koha-bugs] [Bug 13205] Last/First page options for result list paging

[Koha-bugs] [Bug 13205] Last/First page options for result list paging

[Koha-bugs] [Bug 13205] Last/First page options for result list paging

[Koha-bugs] [Bug 13205] Last/First page options for result list paging

[Koha-bugs] [Bug 13205] Last/First page options for result list paging

[Koha-bugs] [Bug 13205] Last/First page options for result list paging

[Koha-bugs] [Bug 13205] Last/First page options for result list paging

[Koha-bugs] [Bug 13205] Last/First page options for result list paging

[Koha-bugs] [Bug 13205] Last/First page options for result list paging

[Koha-bugs] [Bug 13205] Last/First page options for result list paging

[Koha-bugs] [Bug 13205] Last/First page options for result list paging

[Koha-bugs] [Bug 13205] Last/First page options for result list paging

[Koha-bugs] [Bug 13205] Last/First page options for result list paging

[Koha-bugs] [Bug 13205] Last/First page options for result list paging

[Koha-bugs] [Bug 13205] Last/First page options for result list paging

[Koha-bugs] [Bug 13205] Last/First page options for result list paging

[Koha-bugs] [Bug 13205] Last/First page options for result list paging

[Koha-bugs] [Bug 13205] Last/First page options for result list paging

35 matches

Site Navigation

Mail list logo

Footer information