[Koha-bugs] [Bug 13455] Members/AddEnrolmentFeeIfNeeded.t requires sample data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13455 Jonathan Druart changed: What|Removed |Added Status|In Discussion |RESOLVED Resolution|--- |DUPLICATE --- Comment #7 from Jonathan Druart --- And this is what did this commit commit f9654783e2154bfd95cac92ae9b23615d88538e2 Bug 16912: Koha::Patrons - Move and rewrite tests for AddEnrolmentFeeIfNeeded *** This bug has been marked as a duplicate of bug 16912 *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13455] Members/AddEnrolmentFeeIfNeeded.t requires sample data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13455 --- Comment #6 from Jonathan Druart --- (In reply to Katrin Fischer from comment #5) > (In reply to Jonathan Druart from comment #3) > > I still completely disagree with this kind of patch, see my comments on bug > > 13457. > > Have we settled on assuming the sample data is available? use TestBuilder. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13455] Members/AddEnrolmentFeeIfNeeded.t requires sample data
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13455 --- Comment #5 from Katrin Fischer --- (In reply to Jonathan Druart from comment #3) > I still completely disagree with this kind of patch, see my comments on bug > 13457. Have we settled on assuming the sample data is available? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13455] Members/AddEnrolmentFeeIfNeeded.t requires sample data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13455 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Status|Signed Off |In Discussion --- Comment #4 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Moving this to In Discussion. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13455] Members/AddEnrolmentFeeIfNeeded.t requires sample data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13455 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added CC||jonathan.dru...@biblibre.co ||m --- Comment #3 from Jonathan Druart jonathan.dru...@biblibre.com --- I still completely disagree with this kind of patch, see my comments on bug 13457. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13455] Members/AddEnrolmentFeeIfNeeded.t requires sample data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13455 Magnus Enger mag...@enger.priv.no changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||mag...@enger.priv.no -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13455] Members/AddEnrolmentFeeIfNeeded.t requires sample data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13455 Magnus Enger mag...@enger.priv.no changed: What|Removed |Added Attachment #34370|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13455] Members/AddEnrolmentFeeIfNeeded.t requires sample data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13455 --- Comment #2 from Magnus Enger mag...@enger.priv.no --- Created attachment 36008 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36008action=edit Bug 13455: Members/AddEnrolmentFeeIfNeeded.t requires sample data TEST PLAN - 1) Make sure there are no 'J', 'K', nor 'YA' patron category codes. 2) Make sure there are no 'CPL' nor 'MPL' branch codes. 3) prove t/db_dependent/Members/AddEnrolmentFeeIfNeeded.t -- dies horribly 4) apply patch 5) prove t/db_dependent/Members/AddEnrolmentFeeIfNeeded.t -- passes 6) Run koha qa test tools Signed-off-by: Magnus Enger mag...@enger.priv.no For me, the tests fail because I have a Norweian setup with different categories etc. After applying the patch the tests pass. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13455] Members/AddEnrolmentFeeIfNeeded.t requires sample data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13455 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Assignee|ch...@bigballofwax.co.nz|mtomp...@hotmail.com Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13455] Members/AddEnrolmentFeeIfNeeded.t requires sample data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13455 --- Comment #1 from M. Tompsett mtomp...@hotmail.com --- Created attachment 34370 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34370action=edit Bug 13455: Members/AddEnrolmentFeeIfNeeded.t requires sample data TEST PLAN - 1) Make sure there are no 'J', 'K', nor 'YA' patron category codes. 2) Make sure there are no 'CPL' nor 'MPL' branch codes. 3) prove t/db_dependent/Members/AddEnrolmentFeeIfNeeded.t -- dies horribly 4) apply patch 5) prove t/db_dependent/Members/AddEnrolmentFeeIfNeeded.t -- passes 6) Run koha qa test tools -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13455] Members/AddEnrolmentFeeIfNeeded.t requires sample data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13455 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
