[Koha-bugs] [Bug 13614] Replace usage of YUI on basket groups page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13614 --- Comment #14 from Katrin Fischer --- (In reply to Jonathan Druart from comment #13) > Did we forget to remove koha-tmpl/intranet-tmpl/prog/js/basketgroup.js? We did, but fixed now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13614] Replace usage of YUI on basket groups page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13614 Jonathan Druart changed: What|Removed |Added Blocks||32935 See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32935 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32935 [Bug 32935] Can basketgroup.js be removed? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13614] Replace usage of YUI on basket groups page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13614 Jonathan Druart changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com --- Comment #13 from Jonathan Druart --- Did we forget to remove koha-tmpl/intranet-tmpl/prog/js/basketgroup.js? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13614] Replace usage of YUI on basket groups page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13614 Katrin Fischer changed: What|Removed |Added Blocks||31056 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31056 [Bug 31056] Unable to 'Close and export as PDF' a basket group -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13614] Replace usage of YUI on basket groups page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13614 Katrin Fischer changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=32935 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13614] Replace usage of YUI on basket groups page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13614 Owen Leonard changed: What|Removed |Added Resolution|--- |FIXED Status|Pushed to master|RESOLVED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13614] Replace usage of YUI on basket groups page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13614 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #12 from Lucas Gass --- Doesn't apply clean to 22.05.x, no backport. If needed please rebase. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13614] Replace usage of YUI on basket groups page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13614 --- Comment #11 from Tomás Cohen Arazi --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13614] Replace usage of YUI on basket groups page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13614 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||22.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13614] Replace usage of YUI on basket groups page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13614 David Nind changed: What|Removed |Added Text to go in the||This enhancement: release notes||1. ||Updates the basket groups ||interface so that it ||doesn't rely on YUI to move ||baskets in and out of ||groups. ||2. Removes all YUI ||assets and many ||long-obsolete references to ||YUI-related classes and ||IDs. || ||For basket groups, ||you no longer need to drag ||and drop baskets between ||columns (which could be a ||bit fiddly). || ||The basket ||group form is now in one ||column and ungrouped ||baskets in another. Baskets ||are listed in sortable ||tables, and using 'Add to ||group' and 'Remove' buttons ||lets you add and remove ||baskets from the group. Keywords|release-notes-needed|Manual -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13614] Replace usage of YUI on basket groups page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13614 --- Comment #10 from Katrin Fischer --- Great to see so much code gone :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13614] Replace usage of YUI on basket groups page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13614 Katrin Fischer changed: What|Removed |Added Attachment #135679|0 |1 is obsolete|| --- Comment #9 from Katrin Fischer --- Created attachment 135734 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135734=edit Bug 13614: Replace usage of YUI on basket groups page This patch updates the basket groups interface so that it doesn't rely on YUI to move baskets in and out of groups. The patch also removes all YUI assets and many long-obsolete references to YUI-related classes and IDs. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client) - Go to Acquisitions. - Locate a vendor with multiple closed baskets. - Click "Basket groups" in the sidebar menu. - Create or edit a basket group. - On the basket group page you should see the basket group form in one column and ungrouped baskets in another. - Both grouped and ungrouped baskets should be in a sortable DataTable. - Test that when you click the "Add to group" button on an ungrouped basket the row is removed from the table of ungrouped baskets and added to the table of grouped baskets. - The button text on the row should now read "Remove." - Test the reverse operation: Clicking "Remove" on a grouped basket should move it to the table of ungrouped baskets. - Test that when all baskets are moved out of either of the tables a row is displayed with a message specific to that table, e.g. "There are no ungrouped baskets." - Test that the basket group saves correctly when zero or more baskets are added to the group. Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13614] Replace usage of YUI on basket groups page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13614 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13614] Replace usage of YUI on basket groups page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13614 Katrin Fischer changed: What|Removed |Added Keywords||release-notes-needed --- Comment #8 from Katrin Fischer --- I think it will be good to describe the change in the release notes. I feel like the new GUI here is more intuitive than the old one. It always required explanation that you were supposed to drag and drop the entries and it could be a bit 'fiddly' doing so. I also imagine that the handling using buttons is more accessible. I like it! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13614] Replace usage of YUI on basket groups page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13614 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13614] Replace usage of YUI on basket groups page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13614 David Nind changed: What|Removed |Added Attachment #135675|0 |1 is obsolete|| --- Comment #7 from David Nind --- Created attachment 135679 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135679=edit Bug 13614: Replace usage of YUI on basket groups page This patch updates the basket groups interface so that it doesn't rely on YUI to move baskets in and out of groups. The patch also removes all YUI assets and many long-obsolete references to YUI-related classes and IDs. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client) - Go to Acquisitions. - Locate a vendor with multiple closed baskets. - Click "Basket groups" in the sidebar menu. - Create or edit a basket group. - On the basket group page you should see the basket group form in one column and ungrouped baskets in another. - Both grouped and ungrouped baskets should be in a sortable DataTable. - Test that when you click the "Add to group" button on an ungrouped basket the row is removed from the table of ungrouped baskets and added to the table of grouped baskets. - The button text on the row should now read "Remove." - Test the reverse operation: Clicking "Remove" on a grouped basket should move it to the table of ungrouped baskets. - Test that when all baskets are moved out of either of the tables a row is displayed with a message specific to that table, e.g. "There are no ungrouped baskets." - Test that the basket group saves correctly when zero or more baskets are added to the group. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13614] Replace usage of YUI on basket groups page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13614 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13614] Replace usage of YUI on basket groups page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13614 --- Comment #6 from Owen Leonard --- (In reply to David Nind from comment #4) > Everything is working as expected, except for the second last step: no > messages, such as "There are no ungrouped baskets." I left out a step in the test plan: The CSS has to be rebuilt. This allows for the message to be un-hidden. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13614] Replace usage of YUI on basket groups page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13614 Owen Leonard changed: What|Removed |Added Attachment #135394|0 |1 is obsolete|| --- Comment #5 from Owen Leonard --- Created attachment 135675 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135675=edit Bug 13614: Replace usage of YUI on basket groups page This patch updates the basket groups interface so that it doesn't rely on YUI to move baskets in and out of groups. The patch also removes all YUI assets and many long-obsolete references to YUI-related classes and IDs. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client) - Go to Acquisitions. - Locate a vendor with multiple closed baskets. - Click "Basket groups" in the sidebar menu. - Create or edit a basket group. - On the basket group page you should see the basket group form in one column and ungrouped baskets in another. - Both grouped and ungrouped baskets should be in a sortable DataTable. - Test that when you click the "Add to group" button on an ungrouped basket the row is removed from the table of ungrouped baskets and added to the table of grouped baskets. - The button text on the row should now read "Remove." - Test the reverse operation: Clicking "Remove" on a grouped basket should move it to the table of ungrouped baskets. - Test that when all baskets are moved out of either of the tables a row is displayed with a message specific to that table, e.g. "There are no ungrouped baskets." - Test that the basket group saves correctly when zero or more baskets are added to the group. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13614] Replace usage of YUI on basket groups page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13614 Owen Leonard changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13614] Replace usage of YUI on basket groups page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13614 David Nind changed: What|Removed |Added CC||da...@davidnind.com Status|Needs Signoff |Failed QA --- Comment #4 from David Nind --- Everything is working as expected, except for the second last step: no messages, such as "There are no ungrouped baskets.", are shown on the group edit form if there are no rows. A nice improvement as well, I like the tables and the action buttons (add to group/remove) compared with the drag and drop. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13614] Replace usage of YUI on basket groups page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13614 Owen Leonard changed: What|Removed |Added Depends on|11708 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13614] Replace usage of YUI on basket groups page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13614 --- Comment #3 from Owen Leonard --- Created attachment 135394 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=135394=edit Bug 13614: Replace usage of YUI on basket groups page This patch updates the basket groups interface so that it doesn't rely on YUI to move baskets in and out of groups. The patch also removes all YUI assets and many long-obsolete references to YUI-related classes and IDs. To test, apply the patch and go to Acquisitions. - Locate a vendor with multiple closed baskets. - Click "Basket groups" in the sidebar menu. - Create or edit a basket group. - On the basket group page you should see the basket group form in one column and ungrouped baskets in another. - Both grouped and ungrouped baskets should be in a sortable DataTable. - Test that when you click the "Add to group" button on an ungrouped basket the row is removed from the table of ungrouped baskets and added to the table of grouped baskets. - The button text on the row should now read "Remove." - Test the reverse operation: Clicking "Remove" on a grouped basket should move it to the table of ungrouped baskets. - Test that when all baskets are moved out of either of the tables a row is displayed with a message specific to that table, e.g. "There are no ungrouped baskets." - Test that the basket group saves correctly when zero or more baskets are added to the group. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13614] Replace usage of YUI on basket groups page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13614 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Small patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13614] Replace usage of YUI on basket groups page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13614 Owen Leonard changed: What|Removed |Added Status|BLOCKED |ASSIGNED --- Comment #2 from Owen Leonard --- (In reply to Owen Leonard from comment #1) > I'll wait for Bug 11708 It's been stalled for too long, so I'm going ahead with this. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13614] Replace usage of YUI on basket groups page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13614 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|BLOCKED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13614] Replace usage of YUI on basket groups page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13614 Owen Leonardchanged: What|Removed |Added Assignee|koha-b...@lists.koha-commun |oleon...@myacpl.org |ity.org | Status|NEW |ASSIGNED Depends on||11708 --- Comment #1 from Owen Leonard --- I have an idea for this but I'll wait for Bug 11708 and related bugs to go through before I work any more on it. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11708 [Bug 11708] Display all basketgroups on one page, and new column aqbasketgroups.closeddate -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/