[Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||27718


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27718
[Bug 27718] Holds to Pull list doesn't respect holdallowed circulation rule
anymore
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640

robbi...@middlesex.mass.edu changed:

   What|Removed |Added

 CC||robbi...@middlesex.mass.edu

--- Comment #26 from robbi...@middlesex.mass.edu ---
Does this fix take into account patron type? We have some item types that are
requestable by one type of patron category but not by other patron categories.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640

Fridolin SOMERS  changed:

   What|Removed |Added

 Status|Pushed to master|Pushed to stable
 CC||fridolin.som...@biblibre.co
   ||m
 Version(s)|19.11.00|19.11.00,19.05.02
released in||

--- Comment #25 from Fridolin SOMERS  ---
Pushed to 19.05.x for 19.05.02

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640

Martin Renvoize  changed:

   What|Removed |Added

 Blocks||22431


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22431
[Bug 22431] Incorrect group by in circ/pendingreserves.pl
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640

--- Comment #24 from Martin Renvoize  ---
Nice work!

Pushed to master for 19.11.00

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640

Martin Renvoize  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 Version(s)||19.11.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640

Martin Renvoize  changed:

   What|Removed |Added

 Blocks||23175


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23175
[Bug 23175] circ/pendingreserves.pl SQL fails with SQL strict modes
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640

Marcel de Rooy  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640

--- Comment #23 from Marcel de Rooy  ---
@RM: Passing QA with a follow-up. Note that the current query also fails on
strict SQL mode. So not blocking for that. And yes, it could be moved to a
module on a new report.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640

--- Comment #22 from Marcel de Rooy  ---
Created attachment 90872
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90872=edit
Bug 13640: (QA follow-up) Allow NULL values for
default_branch_item_rules.holdallowed

If a rule has not been defined for an itemtype or you submit a biblio level
hold, you cannot filter on holdallowed<>0.

Test plan:
Test with a biblio level hold. Have two items; one item should be blocked
with a policy.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #90639|0   |1
is obsolete||

--- Comment #21 from Marcel de Rooy  ---
Created attachment 90871
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90871=edit
Bug 13640: Do not display unreserveable items on the Holds to pull screen

We should only display the items that meet the hold policies

Test plan:
It would be good to have a huge list of holds displayed on the "Holds to
pull" and confirm that the display is now correct.

One of the possible test plan has been let in a comment on the bug
report:
Bib Record A has 2 items:

Item Record X (can be placed on hold)
Item Record Y (cannot be placed on hold)

If you place a bib-level hold on Bib Record A, both Item Record X and
Item Record Y show up as available items in the Holds To Pull List.

With this patch applied you must not see Y

Signed-off-by: Martin Renvoize 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640

Marcel de Rooy  changed:

   What|Removed |Added

 Status|BLOCKED |Passed QA
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640

--- Comment #20 from Marcel de Rooy  ---
(In reply to Martin Renvoize from comment #14)
> Signing off as in a testing it appears to work as expected.. 
> 
> I'd love to see this query moved into a module and unit tested really, but
> this fix works for now in my opinion.. good luck QAers.

It does not work, but I agree about the module thing ;)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640

--- Comment #19 from Marcel de Rooy  ---
The where condition is wrong. It should also incorporate the case that
default_branch_item_rules is NULL (for istance, no corresponding record found
for a biblio level hold).
Will add a follow-up.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640

--- Comment #18 from Marcel de Rooy  ---
Fails on strict sql mode:

DBD::mysql::st execute failed: 'koha_master.reserves.reserve_id' isn't in GROUP
BY [for Statement [ ... etc ]

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl
 Status|Signed Off  |BLOCKED

--- Comment #17 from Marcel de Rooy  ---
QA: Looking here

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640

Jonathan Druart  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=22431

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640

--- Comment #16 from Martin Renvoize  ---
(In reply to Jonathan Druart from comment #15)
> (In reply to Martin Renvoize from comment #12)
> > (In reply to Jonathan Druart from comment #10)
> > > Because there are 3 values: From any library, From home library and not
> > > allowed (0)
> > 
> > I'm wondering if we're taking into account the 1, and 2 options correctly
> > then in that case?
> 
> Why not? The patch adds the holdallowed != 0 condition, which matches 1 and
> 2 :)

It was more of a 'note to self' to make sure I improved my understanding of how
the value is used before Signing Off.

It looks sane enough to me, but I'm still not 100%. What I'm trying to work out
is if the clause is in the right place and is indeed correct allowing both 1
and 2 options. I note that with independent branches switched on we limit by
holdingbranch being the local branch.. hence wondering if we aught to be
handling library limitations in this part of the query too...  It's one monster
query.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640

--- Comment #15 from Jonathan Druart  
---
(In reply to Martin Renvoize from comment #12)
> (In reply to Jonathan Druart from comment #10)
> > Because there are 3 values: From any library, From home library and not
> > allowed (0)
> 
> I'm wondering if we're taking into account the 1, and 2 options correctly
> then in that case?

Why not? The patch adds the holdallowed != 0 condition, which matches 1 and 2
:)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640

Martin Renvoize  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #14 from Martin Renvoize  ---
Signing off as in a testing it appears to work as expected.. 

I'd love to see this query moved into a module and unit tested really, but this
fix works for now in my opinion.. good luck QAers.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640

Martin Renvoize  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com

--- Comment #12 from Martin Renvoize  ---
(In reply to Jonathan Druart from comment #10)
> Because there are 3 values: From any library, From home library and not
> allowed (0)

I'm wondering if we're taking into account the 1, and 2 options correctly then
in that case?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #89665|0   |1
is obsolete||

--- Comment #13 from Martin Renvoize  ---
Created attachment 90639
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90639=edit
Bug 13640: Do not display unreserveable items on the Holds to pull screen

We should only display the items that meet the hold policies

Test plan:
It would be good to have a huge list of holds displayed on the "Holds to
pull" and confirm that the display is now correct.

One of the possible test plan has been let in a comment on the bug
report:
Bib Record A has 2 items:

Item Record X (can be placed on hold)
Item Record Y (cannot be placed on hold)

If you place a bib-level hold on Bib Record A, both Item Record X and
Item Record Y show up as available items in the Holds To Pull List.

With this patch applied you must not see Y

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640

Michal Denar  changed:

   What|Removed |Added

 CC||blac...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c
   |ity.org |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640

--- Comment #11 from Jonathan Druart  
---
Created attachment 89665
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89665=edit
Bug 13640: Do not display unreserveable items on the Holds to pull screen

We should only display the items that meet the hold policies

Test plan:
It would be good to have a huge list of holds displayed on the "Holds to
pull" and confirm that the display is now correct.

One of the possible test plan has been let in a comment on the bug
report:
Bib Record A has 2 items:

Item Record X (can be placed on hold)
Item Record Y (cannot be placed on hold)

If you place a bib-level hold on Bib Record A, both Item Record X and
Item Record Y show up as available items in the Holds To Pull List.

With this patch applied you must not see Y

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640

Jonathan Druart  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #10 from Jonathan Druart  
---
(In reply to Magnus Enger from comment #9)
> What is changed compared to the "Holds to pull" SQL are these two lines:
> 
> - LEFT JOIN default_branch_item_rules ON
> items.itype=default_branch_item_rules.itemtype
> - AND default_branch_item_rules.holdallowed != 0

This seems to fix the issue.

> However, default_branch_item_rules.holdallowed is of the "bit" type:
> http://schema.koha-community.org/18_05/tables/default_branch_item_rules.html
> I gotta confess I'm not familiar with that. Any special tricks to consider?
> When I look in the database, the value of that column is 0 or 2. Why not a
> boolean "0 or 1" value?

Because there are 3 values: From any library, From home library and not allowed
(0)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640

Paul Thornton  changed:

   What|Removed |Added

 CC||paul.thorn...@educampus.ie

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640

--- Comment #9 from Magnus Enger  ---
I think I managed to take the 'Default holds policy by item type' into account
in this report:

SELECT min(reservedate) as l_reservedate,
reserves.reserve_id,
reserves.borrowernumber as borrowernumber,

GROUP_CONCAT(DISTINCT items.holdingbranch 
ORDER BY items.itemnumber SEPARATOR '|') l_holdingbranch,
reserves.biblionumber,
reserves.branchcode as l_branch,
reserves.itemnumber,
items.holdingbranch,
items.homebranch,
GROUP_CONCAT(DISTINCT items.itype
ORDER BY items.itemnumber SEPARATOR '|') l_item_type,
GROUP_CONCAT(DISTINCT items.location 
ORDER BY items.itemnumber SEPARATOR '|') l_location,
GROUP_CONCAT(DISTINCT items.itemcallnumber 
ORDER BY items.itemnumber SEPARATOR '') l_itemcallnumber,
GROUP_CONCAT(DISTINCT items.enumchron
ORDER BY items.itemnumber SEPARATOR '') l_enumchron,
GROUP_CONCAT(DISTINCT items.copynumber
ORDER BY items.itemnumber SEPARATOR '') l_copynumber,
biblio.title,
biblio.author,
count(DISTINCT items.itemnumber) as icount,
count(DISTINCT reserves.borrowernumber) as rcount,
borrowers.firstname,
borrowers.surname
FROM  reserves
LEFT JOIN items ON items.biblionumber=reserves.biblionumber 
LEFT JOIN biblio ON reserves.biblionumber=biblio.biblionumber
LEFT JOIN biblioitems ON biblio.biblionumber=biblioitems.biblionumber
LEFT JOIN branchtransfers ON items.itemnumber=branchtransfers.itemnumber
LEFT JOIN issues ON items.itemnumber=issues.itemnumber
LEFT JOIN borrowers ON reserves.borrowernumber=borrowers.borrowernumber
LEFT JOIN default_branch_item_rules ON
items.itype=default_branch_item_rules.itemtype
WHERE
reserves.found IS NULL
AND (reserves.itemnumber IS NULL OR reserves.itemnumber = items.itemnumber)
AND items.itemnumber NOT IN (SELECT itemnumber FROM branchtransfers where
datearrived IS NULL)
AND items.itemnumber NOT IN (select itemnumber FROM reserves where found IS
NOT NULL)
AND issues.itemnumber IS NULL
AND reserves.priority <> 0 
AND reserves.suspend = 0
AND notforloan = 0 AND damaged = 0 AND itemlost = 0 AND withdrawn = 0
AND default_branch_item_rules.holdallowed != 0
GROUP BY reserves.biblionumber ORDER BY biblio.title

What is changed compared to the "Holds to pull" SQL are these two lines:

- LEFT JOIN default_branch_item_rules ON
items.itype=default_branch_item_rules.itemtype
- AND default_branch_item_rules.holdallowed != 0

However, default_branch_item_rules.holdallowed is of the "bit" type:
http://schema.koha-community.org/18_05/tables/default_branch_item_rules.html
I gotta confess I'm not familiar with that. Any special tricks to consider?
When I look in the database, the value of that column is 0 or 2. Why not a
boolean "0 or 1" value?

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640

--- Comment #8 from Magnus Enger  ---
(In reply to Katrin Fischer from comment #6)
> Hm, I don't think we need more configuration options - we need the report to
> use the ones we have correctly.

...but I can't convince myself 100% that it will work. 

For example, inter library loans. When you start an ILL request you want to put
a hold on the item, so there is a connection between the patron and the
record/item. So if you use an itemtype for ILL that itemtype must be
"holdable". At the same time the item will not be on loan, and so it will look
like an "on the shelf hold" to the Holds to pull report, I think? 

Not sure I can see all the consequences, there might be ways to work around
this, but perhaps something to consider when the time comes. 

BTW, this is the SQL that generates the holds to pull report:
http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=circ/pendingreserves.pl;h=7f03d88cc10a3f6af4c14711242201adb41dfb80;hb=HEAD#l174

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640

--- Comment #7 from Magnus Enger  ---
Yeah, probably a good idea!

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640

--- Comment #6 from Katrin Fischer  ---
Hm, I don't think we need more configuration options - we need the report to
use the ones we have correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640

Magnus Enger  changed:

   What|Removed |Added

 CC||mag...@libriotech.no

--- Comment #5 from Magnus Enger  ---
I have a customer expeiencing problems with this too. 

Could an easy solution be to have a checkbox on the itemtypes that says "Do not
include in 'Holds to pull' report"? And then exlude items with that setting
when the "Holds to pull" is generated?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640

Dobrica Pavlinusic  changed:

   What|Removed |Added

 CC||dpav...@rot13.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640

Patrick Robitaille  changed:

   What|Removed |Added

 CC||patrick.robitaille@collecto
   ||.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||marjorie.barry-vila@collect
   ||o.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640

--- Comment #4 from Fiona Borthwick  ---
This has been raised by one of our customers and I can see it being a big
problem for the larger libraries.

In our customer's case, they have marked certain item types - e.g. Reference as
not for loan in the item type policy. This means that the 'not for loan'
subfield in the item record has not been populated.  It appears that the SQL
for the Holds to Pull report is looking at the not for loan item attribute and
therefore not considering the item type at all.

There are 'Default holds policy by item type' set up to mark these item types
with the value of No Holds Allowed.

The customer is therefore confused as to why the Holds to Pull report should
list these items.  Of course the Reference items will not satisfy the hold so
they can be ignored but in larger libraries they could have a large list.

It seems that perhaps a solution would be to modify the SQL to add a JOIN to
look at the item type policies too.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640

Fiona Borthwick  changed:

   What|Removed |Added

 CC||fiona.borthwick@ptfs-europe
   ||.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640

--- Comment #3 from David Cook  ---
Just a note that I have no plans to work on this currently, so I'm happy for
someone else to work on fixing this bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640

--- Comment #2 from Lisette  ---
We have this as well. If 1 item has no holds allowed and the other is checked
out the no holds allowed will show up on the holds list.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640

Lisette  changed:

   What|Removed |Added

 CC||lisettesla...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640

Janet McGowan  changed:

   What|Removed |Added

 CC||janet.mcgowan@ptfs-europe.c
   ||om

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
   Severity|normal  |major

--- Comment #1 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
We are observing this as well. 

For a record with 2 items:
1 item is not for loan (via itemtype) and on the shelf
1 item is checked out

The holds to pull list shows the not for loan item.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/