[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961

Katie Bliss  changed:

   What|Removed |Added

 CC||kebl...@dmpl.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961

Katrin Fischer  changed:

   What|Removed |Added

 QA Contact|katrin.fisc...@bsz-bw.de|testo...@bugs.koha-communit
   ||y.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #41 from Marcel de Rooy  ---
@@ -660,6 +660,12 @@ sub GetPreparedLetter {
 my $OPACBaseURL = C4::Context->preference('OPACBaseURL');
 $letter->{content} =~ s/<>/$OPACBaseURL/go;

+my $borrowernumber = $tables->{borrowers};
+my $lines = Koha::Account::Lines->search({ borrowernumber =>
$borrowernumber  });
+my ($totalfine) = $lines->total_outstanding;
+$totalfine = sprintf("%.2f", $totalfine);
+$letter->{content} =~ s/<>/$totalfine/go;

See earlier comments. We should not be doing that at this code location.

> Added code to check if borrowernumber is defined and it isn't a reference.

I think we should address that problem at the source, not here.

Please adjust. Also look at comment39. Thanks !

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

--- Comment #40 from Marcel de Rooy  ---
* Signed-off-by line 'Signed-off-by: Salman Ali '
seems invalid

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961

--- Comment #39 from Kyle M Hall  ---
I'm wondering if this is really necessary given the solution provided by Josef.
If we implement this, it means adding yet another database query that will only
be used in a few cases.

That solution from Josef was:
---
[% USE Price %]

# your normal issue slip content

[% SET balance = borrower.account.balance %]
[% IF balance > 0 %]
Patron has debit of [% balance | $Price %].
[% END %]
[% IF balance < 0 %]
Patron has credit of [% balance | $Price %].
[% END %]
---

Is there a slip where this doesn't work? This functions on any slip with a
borrower object. If there is a slip where this doesn't work, it seems more
sensible to add the borrower object instead, right?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961

--- Comment #38 from Emmi Takkinen  ---
(In reply to Salman Ali from comment #37)
> Test needs fixing but patch is working

Do mean tests aren't working? At least for me running prove
t/db_dependent/Letters.t returns "All tests successful.".

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961

Salman Ali  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||salman@inlibro.com

--- Comment #37 from Salman Ali  ---
Test needs fixing but patch is working

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961

Salman Ali  changed:

   What|Removed |Added

 Attachment #116635|0   |1
is obsolete||

--- Comment #36 from Salman Ali  ---
Created attachment 121854
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=121854=edit
Bug 13961: Check that borrowernumber isn't a reference

Some SendAlerts() tests in Letters.t failed due SQL::Abstract errors,
caused by HASH sometimes set as borrowernumber.

Added code to check if borrowernumber is defined and it isn't a reference.
To test prove t/db_dependent/Letters.t

Sponsored-by: Koha-Suomi Oy
Signed-off-by: Salman Ali 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961

Joonas Kylmälä  changed:

   What|Removed |Added

 CC||joonas.kylm...@helsinki.fi

--- Comment #35 from Joonas Kylmälä  ---
Bug 24381 might be duplicate of this, I'm not 100% sure because the approach is
different.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961

Emmi Takkinen  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961

Emmi Takkinen  changed:

   What|Removed |Added

 Attachment #106624|0   |1
is obsolete||

--- Comment #34 from Emmi Takkinen  ---
Created attachment 116635
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116635=edit
Bug 13961: Check that borrowernumber isn't a reference

Some SendAlerts() tests in Letters.t failed due SQL::Abstract errors,
caused by HASH sometimes set as borrowernumber.

Added code to check if borrowernumber is defined and it isn't a reference.
To test prove t/db_dependent/Letters.t

Sponsored-by: Koha-Suomi Oy

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961

Emmi Takkinen  changed:

   What|Removed |Added

 Attachment #106623|0   |1
is obsolete||

--- Comment #33 from Emmi Takkinen  ---
Created attachment 116634
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116634=edit
Bug 13961: Fix QA issues

This patch fixes following QA issues:

 FAIL   C4/Letters.pm
   FAIL   critic
# Variables::ProhibitConditionalDeclarations: Got 1
violation(s).

 FAIL   t/db_dependent/Letters.t
   FAIL   critic
# Variables::ProhibitConditionalDeclarations: Got 1
violation(s).

Sponsored-by: Koha-Suomi Oy

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961

Emmi Takkinen  changed:

   What|Removed |Added

 Attachment #106194|0   |1
is obsolete||

--- Comment #32 from Emmi Takkinen  ---
Created attachment 116633
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116633=edit
Bug 13961: Add unit test

Sponsored-by: Koha-Suomi Oy

Signed-off-by: Sally 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961

Emmi Takkinen  changed:

   What|Removed |Added

 Attachment #106193|0   |1
is obsolete||

--- Comment #31 from Emmi Takkinen  ---
Created attachment 116632
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116632=edit
Bug 13961: Add currency format handling

Sponsored-by: Koha-Suomi Oy

Signed-off-by: Sally 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961

Emmi Takkinen  changed:

   What|Removed |Added

 Attachment #106192|0   |1
is obsolete||

--- Comment #30 from Emmi Takkinen  ---
Created attachment 116631
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116631=edit
Bug 13961: Option to include patron's total amount of fines in notices

Possibility to show patrons's total amount of fines in notices.

Test plan:
1. Apply patch
2. Modify some notice in Tools -> notices & slips
3. See that in the left side of where one can edit message's body is now
   also a new attribute that one can include to the text:
   borrowers.totalfine
4. Include that to the text and see it showing the patron's total amount
   of fines.

Sponsored-by: Vaara-kirjastot

Followed test plan, works as expected.
Signed-off-by: Marc Véron 

Signed-off-by: Sally 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961

Mazen Khallaf  changed:

   What|Removed |Added

 CC||mazen.i.khal...@gmail.com
 Status|Needs Signoff   |Patch doesn't apply

--- Comment #29 from Mazen Khallaf  ---
Unable to apply patch (step 1)

$ git bz apply 13961
Bug 13961 - Option to include patron's total amount of fines in notices

106192 - Bug 13961: Option to include patron's total amount of fines in notices
106193 - Bug 13961: Add currency format handling
106194 - Bug 13961: Add unit test
106623 - Bug 13961: Fix QA issues
106624 - Bug 13961: Check that borrowernumber isn't a reference

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 13961: Option to include patron's total amount of fines in
notices
Applying: Bug 13961: Add currency format handling
error: sha1 information is lacking or useless (C4/Letters.pm).
error: could not build fake ancestor
Patch failed at 0001 Bug 13961: Add currency format handling
The copy of the patch that failed is found in: .git/rebase-apply/patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in /tmp/Bug-13961-Add-currency-format-handling-LIVbPh.patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961

Emmi Takkinen  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961

--- Comment #28 from Emmi Takkinen  ---
Created attachment 106624
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106624=edit
Bug 13961: Check that borrowernumber isn't a reference

Some SendAlerts() tests in Letters.t failed due SQL::Abstract errors,
caused by HASH sometimes set as borrowernumber.

Added code to check if borrowernumber is defined and it isn't a reference.
To test prove t/db_dependent/Letters.t

Sponsored-by: Koha-Suomi Oy

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961

--- Comment #27 from Emmi Takkinen  ---
Created attachment 106623
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106623=edit
Bug 13961: Fix QA issues

This patch fixes following QA issues:

 FAIL   C4/Letters.pm
   FAIL   critic
# Variables::ProhibitConditionalDeclarations: Got 1
violation(s).

 FAIL   t/db_dependent/Letters.t
   FAIL   critic
# Variables::ProhibitConditionalDeclarations: Got 1
violation(s).

Sponsored-by: Koha-Suomi Oy

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #26 from Katrin Fischer  ---
Hi Emmi,

1) there are 2 problems hightlighted by QA tools:

 FAIL   C4/Letters.pm
   FAIL   critic
# Variables::ProhibitConditionalDeclarations: Got 1
violation(s).  

 FAIL   t/db_dependent/Letters.t
   FAIL   critic



2) Also, the tests are failing for me:

Test Summary Report
---
t/db_dependent/Letters.t (Wstat: 512 Tests: 74 Failed: 2)
  Failed tests:  63, 67
  Non-zero exit status: 2

Can you please check?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961

Katrin Fischer  changed:

   What|Removed |Added

 QA Contact|k...@bywatersolutions.com   |katrin.fisc...@bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961

Sally  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961

ByWater Sandboxes  changed:

   What|Removed |Added

  Attachment #98821|0   |1
is obsolete||

--- Comment #25 from ByWater Sandboxes  ---
Created attachment 106194
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106194=edit
Bug 13961: Add unit test

Sponsored-by: Koha-Suomi Oy

Signed-off-by: Sally 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961

ByWater Sandboxes  changed:

   What|Removed |Added

  Attachment #98820|0   |1
is obsolete||

--- Comment #24 from ByWater Sandboxes  ---
Created attachment 106193
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106193=edit
Bug 13961: Add currency format handling

Sponsored-by: Koha-Suomi Oy

Signed-off-by: Sally 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961

ByWater Sandboxes  changed:

   What|Removed |Added

  Attachment #98819|0   |1
is obsolete||

--- Comment #23 from ByWater Sandboxes  ---
Created attachment 106192
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106192=edit
Bug 13961: Option to include patron's total amount of fines in notices

Possibility to show patrons's total amount of fines in notices.

Test plan:
1. Apply patch
2. Modify some notice in Tools -> notices & slips
3. See that in the left side of where one can edit message's body is now
   also a new attribute that one can include to the text:
   borrowers.totalfine
4. Include that to the text and see it showing the patron's total amount
   of fines.

Sponsored-by: Vaara-kirjastot

Followed test plan, works as expected.
Signed-off-by: Marc Véron 

Signed-off-by: Sally 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961

Sally  changed:

   What|Removed |Added

 CC||sally.healey@cheshireshared
   ||services.gov.uk

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961

Emmi Takkinen  changed:

   What|Removed |Added

   Assignee|j.kylm...@gmail.com |emmi.takki...@outlook.com
 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961

--- Comment #21 from Emmi Takkinen  ---
Created attachment 98820
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98820=edit
Bug 13961: Add currency format handling

Added currency format handling proposed in comments.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961

--- Comment #22 from Emmi Takkinen  ---
Created attachment 98821
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98821=edit
Bug 13961: Add unit test

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961

Emmi Takkinen  changed:

   What|Removed |Added

  Attachment #50517|0   |1
is obsolete||
 CC||emmi.takki...@outlook.com

--- Comment #20 from Emmi Takkinen  ---
Created attachment 98819
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98819=edit
Bug 13961: Option to include patron's total amount of fines in notices

Fixed patch to apply master version.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961

Josef Moravec  changed:

   What|Removed |Added

 CC||josef.mora...@gmail.com

--- Comment #19 from Josef Moravec  ---
In ISSUESLIP ans ISSUEQSLIP is possible to do this:


[% USE Price %]

# your normal issue slip content

[% SET balance = borrower.account.balance %]
[% IF balance > 0 %]
Patron has debit of [% balance | $Price %].
[% END %]
[% IF balance < 0 %]
Patron has credit of [% balance | $Price %].
[% END %]

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||marjorie.barry-vila@collect
   ||o.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961

--- Comment #18 from Katrin Fischer  ---
Btw: you can use  and leave the <> out too!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961

--- Comment #17 from Katrin Fischer  ---
Hi, this bug is about a different feature, so it would be good to open a
separate bug report, maybe with a 'see also' link to this one if you want to.

We have been using the items.fine variable without any problems for quite some
time now - although not in 3.20, but in 3.18 and 3.22.

One reson for the fine not printing can be the sequence the cronjobs are being
run. fines.pl should be run before overdue_notices.pl (currently not the
default, see bug 11144). Or that you haven't defined a proper ISO code for your
active currency.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961

Ray Delahunty  changed:

   What|Removed |Added

 CC||r.delahu...@arts.ac.uk

--- Comment #16 from Ray Delahunty  ---
Are we sure that <> is working as it should? We are on 3.20.01 and
we recently changed ODUE to use  allowing nice layout rather than
the horridly formatted <> variable. But often (not always) the
fine amount wasn’t pulling through. Also to our horror, after the change
sometimes only the first overdue would be listed, and not the full list. The
consensus here is that the <> tag can cause problems when
generating notices and we have reverted to <>. This has resolved
issues with notices being truncated after the first item. (We can find no
pattern for why some of these fail but we suspect it is related to the
<> variable.)
Ray Delahunty
University of the Arts London

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961

--- Comment #15 from Katrin Fischer  ---
I was also looking into this and have another note: Please take a look in
Overdues.pm at how items.fine is formatted:

$item->{'fine'} = currency_format($currency_format, "$fine",
FMT_SYMBOL);
# if active currency isn't correct ISO code fallback to sprintf
$item->{'fine'} = sprintf('%.2f', $fine) unless $item->{'fine'};

I think we should use the same formatting for all money amounts if possible -
especially as it's very likely that people will want to use those 2 together!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961

Kyle M Hall  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA
 CC||k...@bywatersolutions.com

--- Comment #14 from Kyle M Hall  ---
Please add a unit test for this addition.

Also, could you please change the key needed from borrowers.totalfine to
something like borrowers.account_balance? I think that would be much more
readable and explanatory.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961

Kyle M Hall  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |k...@bywatersolutions.com
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961

--- Comment #13 from Katrin Fischer  ---
Testing this on top of bug 16378

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961

Katrin Fischer  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |j.kylm...@gmail.com
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961

Marc Véron  changed:

   What|Removed |Added

  Attachment #42089|0   |1
is obsolete||

--- Comment #12 from Marc Véron  ---
Comment on attachment 42089
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42089
[Follow-up] Remove whitespace from line 648 in C4/Letters.pm

QA tools no longer complain regarding first patch. Obsoleting this follow-up.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961

Marc Véron  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961

Marc Véron  changed:

   What|Removed |Added

  Attachment #41872|0   |1
is obsolete||

--- Comment #11 from Marc Véron  ---
Created attachment 50517
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50517=edit
Bug 13961: Option to include patron's total amount of fines in notices

Possibility to show patrons's total amount of fines in notices.

Test plan:
1. Apply patch
2. Modify some notice in Tools -> notices & slips
3. See that in the left side of where one can edit message's body is now
   also a new attribute that one can include to the text:
   borrowers.totalfine
4. Include that to the text and see it showing the patron's total amount
   of fines.

Sponsored-by: Vaara-kirjastot

Followed test plan, works as expected.
Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961

jdem...@roseville.ca.us  changed:

   What|Removed |Added

 CC||jdem...@roseville.ca.us

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961

Zeno Tajoli  changed:

   What|Removed |Added

 CC||z.taj...@cineca.it
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961

Zeno Tajoli  changed:

   What|Removed |Added

 CC|z.taj...@cineca.it  |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

 CC||ve...@veron.ch

--- Comment #5 from Marc Véron ve...@veron.ch ---
Works as expected.
However, C4/Letters.pm line 648 has forbidden pattern (trailing space chars).

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961

--- Comment #6 from Joonas Kylmälä j.kylm...@gmail.com ---
(In reply to Marc Véron from comment #5)
 Works as expected.
 However, C4/Letters.pm line 648 has forbidden pattern (trailing space chars).

I don't see any in that line.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961

--- Comment #9 from Joonas Kylmälä j.kylm...@gmail.com ---
(In reply to Joonas Kylmälä from comment #8)
 (In reply to Marc Véron from comment #7)
  Created attachment 42077 [details]
  Screenshot from diff view - white chars in empty line 648 in C4/letters.pm
  
  Hi Joonas,
  
  There are some space chars in an empty line, see screenshot from diff view.
  
  Marc
 
 When I apply the patch and try to edit with Gedit, Atom, Nano none of these
 editors see the whitespace. Can you please make a follow-up where you remove
 it because I'm not able to.

I think the problem is with the bugzilla's diff shower because in my patch I
didn't even modify that line.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961

--- Comment #8 from Joonas Kylmälä j.kylm...@gmail.com ---
(In reply to Marc Véron from comment #7)
 Created attachment 42077 [details]
 Screenshot from diff view - white chars in empty line 648 in C4/letters.pm
 
 Hi Joonas,
 
 There are some space chars in an empty line, see screenshot from diff view.
 
 Marc

When I apply the patch and try to edit with Gedit, Atom, Nano none of these
editors see the whitespace. Can you please make a follow-up where you remove it
because I'm not able to.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961

--- Comment #7 from Marc Véron ve...@veron.ch ---
Created attachment 42077
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42077action=edit
Screenshot from diff view - white chars in empty line 648 in C4/letters.pm

Hi Joonas,

There are some space chars in an empty line, see screenshot from diff view.

Marc

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961

--- Comment #10 from Marc Véron ve...@veron.ch ---
Created attachment 42089
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42089action=edit
[Follow-up] Remove whitespace from line 648 in C4/Letters.pm

White space in 'empty' line removed.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

  Attachment #42077|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961

--- Comment #4 from Joonas Kylmälä j.kylm...@gmail.com ---
Created attachment 41872
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41872action=edit
Bug 13961: Option to include patron's total amount of fines in notices

Possibility to show patrons's total amount of fines in notices.

Test plan:
1. Apply patch
2. Modify some notice in Tools - notices  slips
3. See that in the left side of where one can edit message's body is now
   also a new attribute that one can include to the text:
   borrowers.totalfine
4. Include that to the text and see it showing the patron's total amount
   of fines.

Sponsored-by: Vaara-kirjastot

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961

--- Comment #3 from Joonas Kylmälä j.kylm...@gmail.com ---
(In reply to Katrin Fischer from comment #2)
 Just looking for a new placeholder. We got items.fine to display the
 fine per item. And we have something like today to display today's date.
 The suggestion would be to have something like totalfine or similar to
 print the total amount owed by a patron in the letter. So a single
 placeholder - not one to be repeated in the letter.

Yeah, that would great. Actually we just spoke about that kind of feature in
our library. I think I could add that quickly there. :)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961

--- Comment #2 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Just looking for a new placeholder. We got items.fine to display the fine
per item. And we have something like today to display today's date. The
suggestion would be to have something like totalfine or similar to print
the total amount owed by a patron in the letter. So a single placeholder - not
one to be repeated in the letter.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961

Joonas Kylmälä j.kylm...@gmail.com changed:

   What|Removed |Added

 CC||j.kylm...@gmail.com

--- Comment #1 from Joonas Kylmälä j.kylm...@gmail.com ---
Koha - Tools - Notices, you mean? Would there be one one row per patron and
there would be all the info? I'm not sure if I understood right what you
suggested.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961

Cab Vinton direc...@plaistowlibrary.com changed:

   What|Removed |Added

 CC||direc...@plaistowlibrary.co
   ||m

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/