[Koha-bugs] [Bug 14118] Silence warnings t/DataTables/Members.t
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14118 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #39229|0 |1 is obsolete|| --- Comment #5 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 39386 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39386action=edit Bug 14118: Silence warnings t/DataTables/Members.t After cleaning 'prove t' up. 'prove -r t' was attempted next. A couple uninitialized variable warning were triggered. TEST PLAN -- 1) prove t/DataTables/Members.t -- warnings. 2) apply patch 3) prove t/DataTables/Members.t -- no warnings. 4) koha qa test tools. Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com Cleaned. No errors Signed-off-by: Jonathan Druart jonathan.dru...@koha-community.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14118] Silence warnings t/DataTables/Members.t
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14118
--- Comment #4 from Jonathan Druart jonathan.dru...@biblibre.com ---
Comment on attachment 39229
-- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39229
[SIGNED-OFF] Bug 14118: Silence warnings t/DataTables/Members.t
Review of attachment 39229:
--
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.htmlbug=14118attachment=39229)
-
Not blocker.
::: C4/Utils/DataTables/Members.pm
@@ +103,4 @@
my $limit;
# If iDisplayLength == -1, we want to display all patrons
+if ( !$dt_params-{iDisplayLength} || $dt_params-{iDisplayLength} -1
) {
What about
if ( not $dt_params-{iDisplayLength} or $dt_params-{iDisplayLength} -1
) {
@@ +107,3 @@
# In order to avoid sql injection
+$dt_params-{iDisplayStart} =~ s/\D//g if
defined($dt_params-{iDisplayStart});
+$dt_params-{iDisplayLength} =~ s/\D//g if
defined($dt_params-{iDisplayLength});
useless use of parenthesis.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14118] Silence warnings t/DataTables/Members.t
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14118 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14118] Silence warnings t/DataTables/Members.t
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14118 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added CC||jonathan.dru...@biblibre.co ||m Attachment #39387|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14118] Silence warnings t/DataTables/Members.t
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14118 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14118] Silence warnings t/DataTables/Members.t
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14118 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #7 from Jonathan Druart jonathan.dru...@biblibre.com --- Erk, wrong bug report. Sorry about that. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14118] Silence warnings t/DataTables/Members.t
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14118 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Passed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14118] Silence warnings t/DataTables/Members.t
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14118 --- Comment #6 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 39387 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39387action=edit [COUNTER-PATCH] Bug 14118: Prevent to save a letter if an error occurred On saving a letter, if the title or the content of a template is not defined, a JS alert is raised. But the form is submitted anyway. This patch prevent the form to be submitted. Test plan: - Create or edit a letter - Fill the title for a template, not the content - Save - Confirm you get the alert and that the form is not submitted -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14118] Silence warnings t/DataTables/Members.t
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14118 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||tomasco...@gmail.com --- Comment #8 from Tomás Cohen Arazi tomasco...@gmail.com --- Patch pushed to master. Thanks Mark! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14118] Silence warnings t/DataTables/Members.t
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14118 Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed: What|Removed |Added Attachment #38759|0 |1 is obsolete|| --- Comment #3 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com --- Created attachment 39229 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39229action=edit [SIGNED-OFF] Bug 14118: Silence warnings t/DataTables/Members.t After cleaning 'prove t' up. 'prove -r t' was attempted next. A couple uninitialized variable warning were triggered. TEST PLAN -- 1) prove t/DataTables/Members.t -- warnings. 2) apply patch 3) prove t/DataTables/Members.t -- no warnings. 4) koha qa test tools. Signed-off-by: Bernardo Gonzalez Kriegel bgkrie...@gmail.com Cleaned. No errors -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14118] Silence warnings t/DataTables/Members.t
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14118 Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14118] Silence warnings t/DataTables/Members.t
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14118 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Blocks||8879 Assignee|ch...@bigballofwax.co.nz|mtomp...@hotmail.com Status|NEW |ASSIGNED --- Comment #1 from M. Tompsett mtomp...@hotmail.com --- I know that bug 8879 is just prove ./t, but I think it is reasonable to extend that omnibus to include prove -r ./t. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14118] Silence warnings t/DataTables/Members.t
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14118 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14118] Silence warnings t/DataTables/Members.t
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14118 --- Comment #2 from M. Tompsett mtomp...@hotmail.com --- Created attachment 38759 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38759action=edit Bug 14118: Silence warnings t/DataTables/Members.t After cleaning 'prove t' up. 'prove -r t' was attempted next. A couple uninitialized variable warning were triggered. TEST PLAN -- 1) prove t/DataTables/Members.t -- warnings. 2) apply patch 3) prove t/DataTables/Members.t -- no warnings. 4) koha qa test tools. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
