[Koha-bugs] [Bug 14201] Remove unused code or template from some MARC21 leader plugins

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14201

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||marjorie.barry-v...@ccsr.qc
   ||.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14201] Remove unused code or template from some MARC21 leader plugins

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14201

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||tomasco...@gmail.com

--- Comment #20 from Tomás Cohen Arazi  ---
Patch pushed to master.

Thanks Marcel!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14201] Remove unused code or template from some MARC21 leader plugins

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14201

--- Comment #16 from Marcel de Rooy  ---
btw the leader template refers to pos 20-24 in the text
this should be 20-23 (see loc)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14201] Remove unused code or template from some MARC21 leader plugins

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14201

--- Comment #15 from Marcel de Rooy  ---
(In reply to Jonathan Druart from comment #14)
> Are we sure they are useless?
> Maybe there is a bug (the plugin_name parameter could be wrong) in them.
> 
> The differences are, for marc21_leader_computerfile vs marc21_leader:
>   my $f2023 = substr( $result, 20, 4 );
>   "f2023"   => $f2023,
> These 2 lines exist in marc21_leader, no in marc21_leader_computerfile.
> 
> Could we ask for a functional point of view, to know if we should remove
> them or fix them?

See also my commit messages. I checked it too. The computerfile is out of date.
The difference above is not really interesting. The positions 20-23 are
hardcoded 4500 (see template too) and should not be changed at all.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14201] Remove unused code or template from some MARC21 leader plugins

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14201

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #42359|0   |1
is obsolete||
  Attachment #42360|0   |1
is obsolete||
  Attachment #42361|0   |1
is obsolete||

--- Comment #17 from Jonathan Druart  
---
Created attachment 42675
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42675=edit
Bug 14201: Plugin marc21_leader_book is useless

A closer look at this plugin revealed the following:
[1] The leader_book builder redirects to leader.pl; the launcher code with
leader_book.tt is dead.
[2] A diff of the two templates showed that most changes are minimal and
irrelevant. Some updates to leader have not been incorporated into
the unused leader_book.
[3] Leader_book does not use Focus while leader does.

This patch removes all traces of leader_book :)
It includes a tiny db revision for those brave people using it. The only
behavior change for them is the focus change.
Another small change: we do not need Search.pm in marc21_leader.

Test plan:
[1] Run the db revision. If you had some field attached to leader_book,
it should be gone.
[2] Check if the leader plugin still works as expected.
[3] Run the FrameworkPlugin unit test. Ignore warnings from field_007.
[4] Git grep on marc21_leader_book. You will only find references to
PO files in misc/translator.

Signed-off-by: Hector Castro 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14201] Remove unused code or template from some MARC21 leader plugins

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14201

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14201] Remove unused code or template from some MARC21 leader plugins

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14201

--- Comment #19 from Jonathan Druart  
---
Created attachment 42677
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42677=edit
Bug 14201: Yes, goodbye to the third plugin marc21_leader_video too

A closer look at this plugin revealed the same things as earlier:
[1] Since the click redirects to leader, the launcher is not used.
In this case no template file existed.
[2] Leader_video does not use Focus while leader does.

This patch removes 'all' traces of leader_video.
It includes a tiny db revision for those brave people using it. The only
behavior change for them is the focus change.

Test plan:
[1] Run the db revision.
[2] Check if the leader plugin still works as expected.
[3] Git grep on marc21_leader_video. Ignore atomicupdate. No PO files :)

Signed-off-by: Hector Castro 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14201] Remove unused code or template from some MARC21 leader plugins

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14201

--- Comment #18 from Jonathan Druart  
---
Created attachment 42676
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42676=edit
Bug 14201: We can do without plugin marc21_leader_computerfile

A closer look at this plugin revealed the same things as the previous
patch for leader_book.
[1] Template leader_computerfile is not used.
[2] The unused template is not up-to-date either.
[3] Leader_computerfile does not use Focus while leader does.

This patch removes all traces of leader_computerfile.
It includes a tiny db revision for those brave people using it. The only
behavior change for them is the focus change.

Test plan:
[1] Run the db revision.
[2] Check if the leader plugin still works as expected.
[3] Git grep on marc21_leader_computerfile. Ignore PO files.

Signed-off-by: Hector Castro 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14201] Remove unused code or template from some MARC21 leader plugins

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14201

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #14 from Jonathan Druart  
---
Are we sure they are useless?
Maybe there is a bug (the plugin_name parameter could be wrong) in them.

The differences are, for marc21_leader_computerfile vs marc21_leader:
  my $f2023 = substr( $result, 20, 4 );
  "f2023"   => $f2023,
These 2 lines exist in marc21_leader, no in marc21_leader_computerfile.

Could we ask for a functional point of view, to know if we should remove them
or fix them?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14201] Remove unused code or template from some MARC21 leader plugins

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14201

Marcel de Rooy  changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=14815

--- Comment #13 from Marcel de Rooy  ---
(In reply to Héctor Eduardo Castro Avalos from comment #9)
> Hi Marcel you're right, the three perl scripts/templates do nothing or do
> the same thing, but the magic of having too many plugins perhaps is for
> filling different data in the frameworks. i.e., books only uses "06 - Type
> of record: a - Language material" but computer files uses "m - Computer
> file" and videos uses "g - Projected medium"
> 
> With this you save time for experimented catalogers. The data in the leader
> is predefined and she or he doesn't need to fill at all. Just by the fact to
> choose the proper framework is enough.
> 
> Maybe you can do a trick in your plugin to catch the framework code and
> redefine the leader for the type of resource/material.

Yes, you are right that this would be handy. And it probably was the idea when
these files came up. But it did not work.
Note that this report does not change behavior.
So I am opening a new report to collect some ideas how to improve the default
leader. Since we have the framework code already, we could pass that one to the
plugin. When we add a preference, we could add leaders there per framework
code. I would not favor hardcoding BKS BOOKS etc. in the plugin..

See bug 14815.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14201] Remove unused code or template from some MARC21 leader plugins

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14201

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

 CC||hector.hecax...@gmail.com

--- Comment #9 from Héctor Eduardo Castro Avalos  ---
Hi Marcel you're right, the three perl scripts/templates do nothing or do the
same thing, but the magic of having too many plugins perhaps is for filling
different data in the frameworks. i.e., books only uses "06 - Type of record: a
- Language material" but computer files uses "m - Computer file" and videos
uses "g - Projected medium"

With this you save time for experimented catalogers. The data in the leader is
predefined and she or he doesn't need to fill at all. Just by the fact to
choose the proper framework is enough.

Maybe you can do a trick in your plugin to catch the framework code and
redefine the leader for the type of resource/material.

Regards

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14201] Remove unused code or template from some MARC21 leader plugins

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14201

--- Comment #11 from Héctor Eduardo Castro Avalos  
---
Created attachment 42360
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42360=edit
[SIGNED-OFF]Bug 14201: We can do without plugin marc21_leader_computerfile

A closer look at this plugin revealed the same things as the previous
patch for leader_book.
[1] Template leader_computerfile is not used.
[2] The unused template is not up-to-date either.
[3] Leader_computerfile does not use Focus while leader does.

This patch removes all traces of leader_computerfile.
It includes a tiny db revision for those brave people using it. The only
behavior change for them is the focus change.

Test plan:
[1] Run the db revision.
[2] Check if the leader plugin still works as expected.
[3] Git grep on marc21_leader_computerfile. Ignore PO files.

Signed-off-by: Hector Castro 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14201] Remove unused code or template from some MARC21 leader plugins

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14201

--- Comment #12 from Héctor Eduardo Castro Avalos  
---
Created attachment 42361
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42361=edit
[SIGNED-OFF]Bug 14201: Yes, goodbye to the third plugin marc21_leader_video too

A closer look at this plugin revealed the same things as earlier:
[1] Since the click redirects to leader, the launcher is not used.
In this case no template file existed.
[2] Leader_video does not use Focus while leader does.

This patch removes 'all' traces of leader_video.
It includes a tiny db revision for those brave people using it. The only
behavior change for them is the focus change.

Test plan:
[1] Run the db revision.
[2] Check if the leader plugin still works as expected.
[3] Git grep on marc21_leader_video. Ignore atomicupdate. No PO files :)

Signed-off-by: Hector Castro 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14201] Remove unused code or template from some MARC21 leader plugins

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14201

--- Comment #10 from Héctor Eduardo Castro Avalos  
---
Created attachment 42359
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42359=edit
[SIGNED-OFF]Bug 14201: Plugin marc21_leader_book is useless

A closer look at this plugin revealed the following:
[1] The leader_book builder redirects to leader.pl; the launcher code with
leader_book.tt is dead.
[2] A diff of the two templates showed that most changes are minimal and
irrelevant. Some updates to leader have not been incorporated into
the unused leader_book.
[3] Leader_book does not use Focus while leader does.

This patch removes all traces of leader_book :)
It includes a tiny db revision for those brave people using it. The only
behavior change for them is the focus change.
Another small change: we do not need Search.pm in marc21_leader.

Test plan:
[1] Run the db revision. If you had some field attached to leader_book,
it should be gone.
[2] Check if the leader plugin still works as expected.
[3] Run the FrameworkPlugin unit test. Ignore warnings from field_007.
[4] Git grep on marc21_leader_book. You will only find references to
PO files in misc/translator.

Signed-off-by: Hector Castro 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14201] Remove unused code or template from some MARC21 leader plugins

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14201

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

  Attachment #41002|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14201] Remove unused code or template from some MARC21 leader plugins

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14201

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14201] Remove unused code or template from some MARC21 leader plugins

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14201

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

  Attachment #41000|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14201] Remove unused code or template from some MARC21 leader plugins

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14201

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

  Attachment #41001|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14201] Remove unused code or template from some MARC21 leader plugins

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14201

Marcel de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14201] Remove unused code or template from some MARC21 leader plugins

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14201

--- Comment #2 from Marcel de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 40997
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40997action=edit
Bug 14201: Plugin marc21_leader_book is useless

A closer look at this plugin revealed the following:
[1] The leader_book launcher redirects to template leader.tt; so the
leader_book.tt is not used at all.
[2] A diff of the two templates showed that most changes are minimal and
irrelevant. Some updates to leader have not been incorporated into
the unused leader_book.
[3] Leader_book does not use Focus while leader does.

This patch removes all traces of leader_book :)
It includes a tiny db revision for those brave people using it. The only
behavior change for them is the focus change.
Another small change: we do not need Search.pm in marc21_leader.

Test plan:
[1] Run the db revision. If you had some field attached to leader_book,
it should be gone.
[2] Check if the leader plugin still works as expected.
[3] Run the FrameworkPlugin unit test. Ignore warnings from field_007.
[4] Git grep on marc21_leader_book. You will only find references to
PO files in misc/translator.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14201] Remove unused code or template from some MARC21 leader plugins

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14201

Marcel de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
   Assignee|gmcha...@gmail.com  |m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14201] Remove unused code or template from some MARC21 leader plugins

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14201

--- Comment #8 from Marcel de Rooy m.de.r...@rijksmuseum.nl ---
Just a small change in the first commit message. accuracy++

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14201] Remove unused code or template from some MARC21 leader plugins

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14201

Marcel de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

  Attachment #40999|0   |1
is obsolete||

--- Comment #7 from Marcel de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 41002
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41002action=edit
Bug 14201: Yes, goodbye to the third plugin marc21_leader_video too

A closer look at this plugin revealed the same things as earlier:
[1] Since the click redirects to leader, the launcher is not used.
In this case no template file existed.
[2] Leader_video does not use Focus while leader does.

This patch removes 'all' traces of leader_video.
It includes a tiny db revision for those brave people using it. The only
behavior change for them is the focus change.

Test plan:
[1] Run the db revision.
[2] Check if the leader plugin still works as expected.
[3] Git grep on marc21_leader_video. Ignore atomicupdate. No PO files :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14201] Remove unused code or template from some MARC21 leader plugins

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14201

--- Comment #3 from Marcel de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 40998
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40998action=edit
Bug 14201: We can do without plugin marc21_leader_computerfile

A closer look at this plugin revealed the same things as the previous
patch for leader_book.
[1] Template leader_computerfile is not used.
[2] The unused template is not up-to-date either.
[3] Leader_computerfile does not use Focus while leader does.

This patch removes all traces of leader_computerfile.
It includes a tiny db revision for those brave people using it. The only
behavior change for them is the focus change.

Test plan:
[1] Run the db revision.
[2] Check if the leader plugin still works as expected.
[3] Git grep on marc21_leader_computerfile. Ignore PO files.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14201] Remove unused code or template from some MARC21 leader plugins

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14201

--- Comment #4 from Marcel de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 40999
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40999action=edit
Bug 14201: Yes, goodbye to the third plugin marc21_leader_video too

A closer look at this plugin revealed the same things as earlier:
[1] Since the click redirects to leader, the launcher is not used.
In this case no template file existed.
[2] Leader_video does not use Focus while leader does.

This patch removes 'all' traces of leader_video.
It includes a tiny db revision for those brave people using it. The only
behavior change for them is the focus change.

Test plan:
[1] Run the db revision.
[2] Check if the leader plugin still works as expected.
[3] Git grep on marc21_leader_video. Ignore atomicupdate. No PO files :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14201] Remove unused code or template from some MARC21 leader plugins

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14201

Marcel de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14201] Remove unused code or template from some MARC21 leader plugins

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14201

Marcel de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

  Attachment #40997|0   |1
is obsolete||

--- Comment #5 from Marcel de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 41000
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41000action=edit
Bug 14201: Plugin marc21_leader_book is useless

A closer look at this plugin revealed the following:
[1] The leader_book builder redirects to leader.pl; the launcher code with
leader_book.tt is dead.
[2] A diff of the two templates showed that most changes are minimal and
irrelevant. Some updates to leader have not been incorporated into
the unused leader_book.
[3] Leader_book does not use Focus while leader does.

This patch removes all traces of leader_book :)
It includes a tiny db revision for those brave people using it. The only
behavior change for them is the focus change.
Another small change: we do not need Search.pm in marc21_leader.

Test plan:
[1] Run the db revision. If you had some field attached to leader_book,
it should be gone.
[2] Check if the leader plugin still works as expected.
[3] Run the FrameworkPlugin unit test. Ignore warnings from field_007.
[4] Git grep on marc21_leader_book. You will only find references to
PO files in misc/translator.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14201] Remove unused code or template from some MARC21 leader plugins

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14201

Marcel de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

  Attachment #40998|0   |1
is obsolete||

--- Comment #6 from Marcel de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 41001
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41001action=edit
Bug 14201: We can do without plugin marc21_leader_computerfile

A closer look at this plugin revealed the same things as the previous
patch for leader_book.
[1] Template leader_computerfile is not used.
[2] The unused template is not up-to-date either.
[3] Leader_computerfile does not use Focus while leader does.

This patch removes all traces of leader_computerfile.
It includes a tiny db revision for those brave people using it. The only
behavior change for them is the focus change.

Test plan:
[1] Run the db revision.
[2] Check if the leader plugin still works as expected.
[3] Git grep on marc21_leader_computerfile. Ignore PO files.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14201] Remove unused code or template from some MARC21 leader plugins

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14201

Marcel de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

   Severity|enhancement |minor
Summary|leader plugins  |Remove unused code or
   ||template from some MARC21
   ||leader plugins

--- Comment #1 from Marcel de Rooy m.de.r...@rijksmuseum.nl ---
Some of the marc21 leader plugins refer to leader.pl and include unused code.
Have to check also if attached template is used at all.

Pertains to:
marc21_leader_book.pl
marc21_leader_computerfile.pl
marc21_leader_video.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14201] Remove unused code or template from some MARC21 leader plugins

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14201

Marcel de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=13437

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/