[Koha-bugs] [Bug 14238] C4::Matcher is mangling data to match on

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14238

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Resolution|--- |DUPLICATE
 Status|In Discussion   |RESOLVED

--- Comment #10 from Tomás Cohen Arazi  ---


*** This bug has been marked as a duplicate of bug 17318 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14238] C4::Matcher is mangling data to match on

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14238

--- Comment #9 from Kyle M Hall  ---
(In reply to David Cook from comment #8)
> (In reply to Tomás Cohen Arazi from comment #7)
> > Bug 17318 introduces new normalization routines (including the misterious
> > option 'None') which could be considered a solution to this bug, and
> > probably also 15541.
> > 
> > Kyle, Galen, David: would you agree on closing this one as duplicate of bug
> > 17318?
> 
> Yep, so long as there's no normalization happening during the matching, I'm
> happy :).

Also agreed!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14238] C4::Matcher is mangling data to match on

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14238

--- Comment #8 from David Cook  ---
(In reply to Tomás Cohen Arazi from comment #7)
> Bug 17318 introduces new normalization routines (including the misterious
> option 'None') which could be considered a solution to this bug, and
> probably also 15541.
> 
> Kyle, Galen, David: would you agree on closing this one as duplicate of bug
> 17318?

Yep, so long as there's no normalization happening during the matching, I'm
happy :).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14238] C4::Matcher is mangling data to match on

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14238

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||gmcha...@gmail.com,
   ||tomasco...@gmail.com
 Status|NEW |In Discussion

--- Comment #7 from Tomás Cohen Arazi  ---
Bug 17318 introduces new normalization routines (including the misterious
option 'None') which could be considered a solution to this bug, and probably
also 15541.

Kyle, Galen, David: would you agree on closing this one as duplicate of bug
17318?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14238] C4::Matcher is mangling data to match on

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14238

--- Comment #6 from David Cook  ---
Kyle, what do you need to move forward on this one?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14238] C4::Matcher is mangling data to match on

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14238

--- Comment #5 from David Cook  ---
Oh... I should add a unit test for the URL mangling as well...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14238] C4::Matcher is mangling data to match on

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14238

Kyle M Hall  changed:

   What|Removed |Added

Version|3.18|master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14238] C4::Matcher is mangling data to match on

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14238

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #39352|0   |1
is obsolete||

--- Comment #4 from Kyle M Hall  ---
Created attachment 52897
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52897=edit
Bug 14238 - Unit Test to demonstrate issue

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14238] C4::Matcher is mangling data to match on

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14238

--- Comment #3 from Owen Leonard  ---
Is this report specific to 3.18.x? If it is valid in master, please mark it as
such.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14238] C4::Matcher is mangling data to match on

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14238

Jonathan Druart  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=15541

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14238] C4::Matcher is mangling data to match on

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14238

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #2 from David Cook  ---
Hey Kyle, I've had the same issue when doing matching. 

Since it has no documentation, I've left it in Koha, but I've created a "none"
or "raw" normalizer which skips C4::Matcher::_normalize, as it was butchering
URLs...

You can see the signed off patch at:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15541

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14238] C4::Matcher is mangling data to match on

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14238

Suzanne Fayle  changed:

   What|Removed |Added

 CC||sfa...@roseman.edu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14238] C4::Matcher is mangling data to match on

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14238

Tom Misilo misi...@fit.edu changed:

   What|Removed |Added

 CC||misi...@fit.edu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14238] C4::Matcher is mangling data to match on

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14238

--- Comment #1 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 39352
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39352action=edit
Bug 14238 - Unit Test to demonstrate issue

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/