[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 --- Comment #149 from Katrin Fischer --- Created attachment 134278 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134278=edit Bug 14242: (QA follow-up) Update hint on suggestion form: 2016 > 2022 First patches were written in 2015 - so I think we can safely move the hint closer to the present. Signed-off-by: Katrin Fischer Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 --- Comment #148 from Katrin Fischer --- Created attachment 134277 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134277=edit Bug 14242: (QA follow-up) Fix alphatic order of sysprefs.sql Signed-off-by: Katrin Fischer Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Katrin Fischer changed: What|Removed |Added Attachment #133988|0 |1 is obsolete|| --- Comment #147 from Katrin Fischer --- Created attachment 134276 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134276=edit Bug 14242: (follow-up) Clear all text input fields Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Katrin Fischer changed: What|Removed |Added Attachment #133987|0 |1 is obsolete|| --- Comment #146 from Katrin Fischer --- Created attachment 134275 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134275=edit Bug 14242: (follow-up) Hide autofil when syspref disabled, clear ISBN Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Katrin Fischer changed: What|Removed |Added Attachment #133986|0 |1 is obsolete|| --- Comment #145 from Katrin Fischer --- Created attachment 134274 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134274=edit Bug 14242: (follow-up) Format copyright date before plugged into form This patch formats the copyright date so that only the year shows before plugging the formatted version into the form. Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Katrin Fischer changed: What|Removed |Added Attachment #133985|0 |1 is obsolete|| --- Comment #144 from Katrin Fischer --- Created attachment 134273 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134273=edit Bug 14242: Use ISBN-field to automatically fill out purchase suggestions Add new jQuery plugin "autofill" which transforms selected element(s) into search fields for Google Books API and automatically fills requested fields with search result. Use in OPAC purchase suggestions to automatically fill out fields when entering ISBN-number. Test plan: 1. Run updatedatabase.pl 2. Enable system precference "OPACSuggestionAutoFill" 3. Log into OPAC and go to purchase suggestions page 4. Write a valid ISBN (such as 0-9690745-2-2 or 978-1-78416-110-1) into the ISBN field and click the 'search google books' button, or unfocus the field. 5. Title, Author, Publisher, publication year and Item Type fields should now be filled automatically. 6. Press "clear form" to undo - should restore all fields that the API pull filled to empty Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 --- Comment #143 from Owen Leonard --- Created attachment 133988 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133988=edit Bug 14242: (follow-up) Clear all text input fields Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 --- Comment #142 from Owen Leonard --- Created attachment 133987 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133987=edit Bug 14242: (follow-up) Hide autofil when syspref disabled, clear ISBN Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 --- Comment #141 from Owen Leonard --- Created attachment 133986 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133986=edit Bug 14242: (follow-up) Format copyright date before plugged into form This patch formats the copyright date so that only the year shows before plugging the formatted version into the form. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Owen Leonard changed: What|Removed |Added Attachment #131219|0 |1 is obsolete|| Attachment #131220|0 |1 is obsolete|| Attachment #131221|0 |1 is obsolete|| Attachment #131222|0 |1 is obsolete|| --- Comment #140 from Owen Leonard --- Created attachment 133985 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133985=edit Bug 14242: Use ISBN-field to automatically fill out purchase suggestions Add new jQuery plugin "autofill" which transforms selected element(s) into search fields for Google Books API and automatically fills requested fields with search result. Use in OPAC purchase suggestions to automatically fill out fields when entering ISBN-number. Test plan: 1. Run updatedatabase.pl 2. Enable system precference "OPACSuggestionAutoFill" 3. Log into OPAC and go to purchase suggestions page 4. Write a valid ISBN (such as 0-9690745-2-2 or 978-1-78416-110-1) into the ISBN field and click the 'search google books' button, or unfocus the field. 5. Title, Author, Publisher, publication year and Item Type fields should now be filled automatically. 6. Press "clear form" to undo - should restore all fields that the API pull filled to empty Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Amit Gupta changed: What|Removed |Added CC||amit.gupta@informaticsgloba ||l.com, ||amitddng...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 --- Comment #139 from Aleisha Amohia --- (In reply to Victor Grousset/tuxayo from comment #133) > I can still reproduce easily comment 128 's *f* test on Firefox and Chromium. > > I can reproduce c. using Chromium, going in the network dev tab, network > conditions (wireless icon), network throttling, adding a custom profile with > 2 seconds of latency. > > That 2 second latency allows me to reproduce d. also. Hopefully latest follow-up addresses the remaining issues! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 --- Comment #138 from Aleisha Amohia --- Created attachment 131222 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131222=edit Bug 14242: (follow-up) Clear all text input fields -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Aleisha Amohia changed: What|Removed |Added Attachment #125382|0 |1 is obsolete|| --- Comment #137 from Aleisha Amohia --- Created attachment 131221 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131221=edit Bug 14242: (follow-up) Hide autofil when syspref disabled, clear ISBN -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Aleisha Amohia changed: What|Removed |Added Attachment #125381|0 |1 is obsolete|| --- Comment #136 from Aleisha Amohia --- Created attachment 131220 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131220=edit Bug 14242: (follow-up) Format copyright date before plugged into form This patch formats the copyright date so that only the year shows before plugging the formatted version into the form. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Aleisha Amohia changed: What|Removed |Added Attachment #125380|0 |1 is obsolete|| --- Comment #135 from Aleisha Amohia --- Created attachment 131219 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131219=edit Bug 14242: Use ISBN-field to automatically fill out purchase suggestions Add new jQuery plugin "autofill" which transforms selected element(s) into search fields for Google Books API and automatically fills requested fields with search result. Use in OPAC purchase suggestions to automatically fill out fields when entering ISBN-number. Test plan: 1. Run updatedatabase.pl 2. Enable system precference "OPACSuggestionAutoFill" 3. Log into OPAC and go to purchase suggestions page 4. Write a valid ISBN (such as 0-9690745-2-2 or 978-1-78416-110-1) into the ISBN field and click the 'search google books' button, or unfocus the field. 5. Title, Author, Publisher, publication year and Item Type fields should now be filled automatically. 6. Press "clear form" to undo - should restore all fields that the API pull filled to empty Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Aleisha Amohia changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Jonathan Druart changed: What|Removed |Added Keywords|rel_21_11_candidate |rel_22_05_candidate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 --- Comment #134 from Victor Grousset/tuxayo --- and issue a. is fixed :D thanks for the other fixes -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Victor Grousset/tuxayo changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #133 from Victor Grousset/tuxayo --- I can still reproduce easily comment 128 's *f* test on Firefox and Chromium. I can reproduce c. using Chromium, going in the network dev tab, network conditions (wireless icon), network throttling, adding a custom profile with 2 seconds of latency. That 2 second latency allows me to reproduce d. also. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 --- Comment #132 from Aleisha Amohia --- (In reply to Victor Grousset/tuxayo from comment #128) > a. > That's odd, I'm getting the autofill even with OPACSuggestionAutoFill off. > Fixed in latest follow-up > > b. > > press the edit icon next to the field > > Where is the icon actually? Is that the Search Google Books button? A step from an old test plan - yes it is the search button, I've reworded the test plan. > > c. > Maybe an issue > > > d. > Found something else that should be related and easy to reproduce > > e. > When clearing the form, should the ISBN also be cleared? I've added a follow-up to clear the ISBN. > > > f. > I can still reproduce the issue from comment 117 I was not able to reproduce c, d or f. Can you please re-test? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 --- Comment #131 from Aleisha Amohia --- Created attachment 125382 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125382=edit Bug 14242: (follow-up) Hide autofil when syspref disabled, clear ISBN -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Aleisha Amohia changed: What|Removed |Added Attachment #116989|0 |1 is obsolete|| --- Comment #130 from Aleisha Amohia --- Created attachment 125381 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125381=edit Bug 14242: (follow-up) Format copyright date before plugged into form This patch formats the copyright date so that only the year shows before plugging the formatted version into the form. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Aleisha Amohia changed: What|Removed |Added Attachment #116712|0 |1 is obsolete|| --- Comment #129 from Aleisha Amohia --- Created attachment 125380 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125380=edit Bug 14242: Use ISBN-field to automatically fill out purchase suggestions Add new jQuery plugin "autofill" which transforms selected element(s) into search fields for Google Books API and automatically fills requested fields with search result. Use in OPAC purchase suggestions to automatically fill out fields when entering ISBN-number. Test plan: 1. Run updatedatabase.pl 2. Enable system precference "OPACSuggestionAutoFill" 3. Log into OPAC and go to purchase suggestions page 4. Write a valid ISBN (such as 0-9690745-2-2 or 978-1-78416-110-1) into the ISBN field and click the 'search google books' button, or unfocus the field. 5. Title, Author, Publisher, publication year and Item Type fields should now be filled automatically. 6. Press "clear form" to undo - should restore all fields that the API pull filled to empty Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Aleisha Amohia changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Jonathan Druart changed: What|Removed |Added Keywords|rel_21_05_candidate |rel_21_11_candidate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Victor Grousset/tuxayo changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #128 from Victor Grousset/tuxayo --- a. That's odd, I'm getting the autofill even with OPACSuggestionAutoFill off. b. > press the edit icon next to the field Where is the icon actually? Is that the Search Google Books button? c. Maybe an issue 1. fill "foo" 2. click on search 3. quickly before it loads, fill "bar" and click search 4. wait for the result to load 5. click on clear 6. the result for foo is restored 7. it's now the default value when restoring even after doing other searches d. Found something else that should be related and easy to reproduce 1. Fill a valid ISBN 2. Spam the search button during a few seconds 3. Wait for data to load multiple time 4. clear 5. data still there e. When clearing the form, should the ISBN also be cleared? f. I can still reproduce the issue from comment 117 1. Paste an ISBN, e.g. 978-1451697384 2. Hit tab 3. Paste another ISBN, e.g. 978-1-250-23723-1 4. Hit tab 5. Clear field 6. The data from the first ISBN came back -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 --- Comment #127 from Victor Grousset/tuxayo --- Tried to QA, not at ease enough with the code, have to pass. QA person: comment 118 have some feedback about the personal processing involved here. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Owen Leonard changed: What|Removed |Added Attachment #116968|0 |1 is obsolete|| --- Comment #126 from Owen Leonard --- Created attachment 116989 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116989=edit Bug 14242: (follow-up) Format copyright date before plugged into form This patch formats the copyright date so that only the year shows before plugging the formatted version into the form. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 --- Comment #125 from Aleisha Amohia --- Created attachment 116968 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116968=edit Bug 14242: (follow-up) Format copyright date before plugged into form This patch formats the copyright date so that only the year shows before plugging the formatted version into the form. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Aleisha Amohia changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 --- Comment #124 from Katrin Fischer --- (In reply to Katrin Fischer from comment #123) > Hi Aleisha, > I tested with "lerening perl" and the year got filled with "2011-06-16", but > this won't store. Can we edit it to be 2011 so the form can be saved without > further editing? Learning Perl actually... without all the typos! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #123 from Katrin Fischer --- Hi Aleisha, I tested with "lerening perl" and the year got filled with "2011-06-16", but this won't store. Can we edit it to be 2011 so the form can be saved without further editing? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Owen Leonard changed: What|Removed |Added Attachment #116620|0 |1 is obsolete|| --- Comment #122 from Owen Leonard --- Created attachment 116712 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116712=edit Bug 14242: Use ISBN-field to automatically fill out purchase suggestions Add new jQuery plugin "autofill" which transforms selected element(s) into search fields for Google Books API and automatically fills requested fields with search result. Use in OPAC purchase suggestions to automatically fill out fields when entering ISBN-number. Test plan: 1. Run updatedatabase.pl 2. Enable system precference "OPACSuggestionAutoFill" 3. Log into OPAC and go to purchase suggestions page 4. Write a valid ISBN (such as 0-9690745-2-2 or 978-1-78416-110-1) into the ISBN field and press the edit icon next to the field, or unfocus the field. 5. Title, Author, Publisher and Item Type fields should now be filled automatically. 6. Press "undo" to undo - should restore all fields that the API pull filled to empty Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 --- Comment #121 from Aleisha Amohia --- (In reply to Victor Grousset/tuxayo from comment #119) > > 2. Clear the ISBN from the field (Book data is correctly removed) > > I can't get the data to be removed after just clearing the ISBN and tabbing. > I feel that I might be misunderstanding this. > Okay, hoping I fixed this in the latest patch! I've also squashed all of the follow-ups so this will need another signoff. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Aleisha Amohia changed: What|Removed |Added Attachment #112597|0 |1 is obsolete|| Attachment #112598|0 |1 is obsolete|| Attachment #112599|0 |1 is obsolete|| Attachment #112600|0 |1 is obsolete|| Attachment #112601|0 |1 is obsolete|| Attachment #113162|0 |1 is obsolete|| Attachment #113163|0 |1 is obsolete|| Attachment #113164|0 |1 is obsolete|| Attachment #113165|0 |1 is obsolete|| Attachment #113166|0 |1 is obsolete|| Attachment #113167|0 |1 is obsolete|| --- Comment #120 from Aleisha Amohia --- Created attachment 116620 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=116620=edit Bug 14242: Use ISBN-field to automatically fill out purchase suggestions Add new jQuery plugin "autofill" which transforms selected element(s) into search fields for Google Books API and automatically fills requested fields with search result. Use in OPAC purchase suggestions to automatically fill out fields when entering ISBN-number. Test plan: 1. Run updatedatabase.pl 2. Enable system precference "OPACSuggestionAutoFill" 3. Log into OPAC and go to purchase suggestions page 4. Write a valid ISBN (such as 0-9690745-2-2 or 978-1-78416-110-1) into the ISBN field and press the edit icon next to the field, or unfocus the field. 5. Title, Author, Publisher and Item Type fields should now be filled automatically. 6. Press "undo" to undo - should restore all fields that the API pull filled to empty -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Aleisha Amohia changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Jonathan Druart changed: What|Removed |Added Keywords|rel_20_11_target|rel_21_05_candidate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 --- Comment #119 from Victor Grousset/tuxayo --- > 2. Clear the ISBN from the field (Book data is correctly removed) I can't get the data to be removed after just clearing the ISBN and tabbing. I feel that I might be misunderstanding this. BTW, the Standard number field can search also for titles, that's a neat hidden feature. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 --- Comment #118 from Victor Grousset/tuxayo --- Some findings that will be useful for QA The request to googleapis.com is done from the browser directly. IIUC the fact that it's due to Koha means that Koha (and thus the library) processes personal data by sending it to Google. Which means the library should (someplaces legally or just by best practices) inform the patrons in the list of all personal data processings. Which personal data? - IP address - user agent - Accept-Language - ISBN search Which is enough to identify someone/a device and for example know some of their reading preferences and use that in advertising. That likely means that it should be avoided unless it's absolutely necessary. One solution could be for Koha to be a proxy for the requests. Is there an example of Koha acting as a proxy to an external service? Since it's an old bug, would me creating a followup bug about proxying the query be enough? And meanwhile, should a small warning in the syspref description be added? So the library can update their documents about their personal data processing. Something like «Personal data processing: Google will receive the following data: IP address, OS name, web browser version, prefered languages, and the ISBNs of the books suggested.» A more experienced English speaker might find a better phrasing. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Victor Grousset/tuxayo changed: What|Removed |Added CC||vic...@tuxayo.net Status|Needs Signoff |Failed QA --- Comment #117 from Victor Grousset/tuxayo --- First test plan needs to update the syspref name: OPACAutoFill => OPACSuggestionAutoFill 978-1-250-23723-1 works and 978-2-89596-254-0 doesn't when they seems to both be found in books.google.com Is there something wrong about the ISBN or is it a bug? I finally managed to reproduce the bug that I found yesterday. 1. Paste an ISBN, e.g. 978-1451697384 2. Hit tab 3. Paste another ISBN, e.g. 978-1-250-23723-1 4. Hit tab 5. Clear field 6. The data from the find ISBN came back -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Aleisha Amohia changed: What|Removed |Added Attachment #112607|0 |1 is obsolete|| --- Comment #116 from Aleisha Amohia --- Created attachment 113167 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113167=edit Bug 14242: (follow-up) Remove well class, weird gap, fix clear form -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Aleisha Amohia changed: What|Removed |Added Attachment #112606|0 |1 is obsolete|| --- Comment #115 from Aleisha Amohia --- Created attachment 113166 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113166=edit Bug 14242: Remove TT conditional from HTML tags It brakes the translation script -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Aleisha Amohia changed: What|Removed |Added Attachment #112604|0 |1 is obsolete|| --- Comment #113 from Aleisha Amohia --- Created attachment 113164 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113164=edit Bug 14242: (follow-up) Adding publication year hint and fix js translations -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Aleisha Amohia changed: What|Removed |Added Attachment #112605|0 |1 is obsolete|| --- Comment #114 from Aleisha Amohia --- Created attachment 113165 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113165=edit Bug 14242: (QA follow-up) Fix buttons for new bootstrap version Stole the mark-up from bug 26478. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Aleisha Amohia changed: What|Removed |Added Attachment #112602|0 |1 is obsolete|| --- Comment #111 from Aleisha Amohia --- Created attachment 113162 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113162=edit Bug 14242: (follow-up) Move English strings out of JavaScript In order for English strings to be translatable they must be defined in the template, not in the JS file. Signed-off-by: Maryse Simard Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Aleisha Amohia changed: What|Removed |Added Attachment #112603|0 |1 is obsolete|| --- Comment #112 from Aleisha Amohia --- Created attachment 113163 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113163=edit Bug 14242: Styling of buttons, get copyright date, fixing plugin comment And other code-y bits. Addressing comments in Comment 59. Sponsored-by: Catalyst IT Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Aleisha Amohia changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Séverine Queune changed: What|Removed |Added CC||severine.que...@bulac.fr Status|Needs Signoff |Patch doesn't apply --- Comment #110 from Séverine Queune --- Applying: Bug 14242: (follow-up) Move English strings out of JavaScript fatal: sha1 information is lacking or useless (koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 14242: (follow-up) Move English strings out of JavaScript -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Aleisha Amohia changed: What|Removed |Added Attachment #110990|0 |1 is obsolete|| --- Comment #108 from Aleisha Amohia --- Created attachment 112606 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112606=edit Bug 14242: Remove TT conditional from HTML tags It brakes the translation script -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 --- Comment #109 from Aleisha Amohia --- Created attachment 112607 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112607=edit Bug 14242: (follow-up) Remove well class, weird gap, fix clear form -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Aleisha Amohia changed: What|Removed |Added Attachment #110498|0 |1 is obsolete|| --- Comment #104 from Aleisha Amohia --- Created attachment 112602 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112602=edit Bug 14242: (follow-up) Move English strings out of JavaScript In order for English strings to be translatable they must be defined in the template, not in the JS file. Signed-off-by: Maryse Simard Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Aleisha Amohia changed: What|Removed |Added Attachment #110499|0 |1 is obsolete|| --- Comment #105 from Aleisha Amohia --- Created attachment 112603 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112603=edit Bug 14242: Styling of buttons, get copyright date, fixing plugin comment And other code-y bits. Addressing comments in Comment 59. Sponsored-by: Catalyst IT Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Aleisha Amohia changed: What|Removed |Added Attachment #110501|0 |1 is obsolete|| --- Comment #107 from Aleisha Amohia --- Created attachment 112605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112605=edit Bug 14242: (QA follow-up) Fix buttons for new bootstrap version Stole the mark-up from bug 26478. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Aleisha Amohia changed: What|Removed |Added Attachment #110497|0 |1 is obsolete|| --- Comment #103 from Aleisha Amohia --- Created attachment 112601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112601=edit Bug 14242: (follow-up) Translateable js strings, $raw filter Sponsored-by: Region Halland Signed-off-by: Maryse Simard Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Aleisha Amohia changed: What|Removed |Added Attachment #110500|0 |1 is obsolete|| --- Comment #106 from Aleisha Amohia --- Created attachment 112604 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112604=edit Bug 14242: (follow-up) Adding publication year hint and fix js translations -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Aleisha Amohia changed: What|Removed |Added Attachment #110496|0 |1 is obsolete|| --- Comment #102 from Aleisha Amohia --- Created attachment 112600 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112600=edit Bug 14242: (follow-up) Strip hyphen from ISBN for search purposes To test, enter a valid ISBN complete with - eg 978-1-78416-110-1 The search should still work Signed-off-by: Marc Signed-off-by: Maryse Simard Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Aleisha Amohia changed: What|Removed |Added Attachment #110493|0 |1 is obsolete|| --- Comment #99 from Aleisha Amohia --- Created attachment 112597 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112597=edit Bug 14242: Use ISBN-field to automatically fill out purchase suggestions Add new jQuery plugin "autofill" which transforms selected element(s) into search fields for Google Books API and automatically fills requested fields with search result. Use in OPAC purchase suggestions to automatically fill out fields when entering ISBN-number. Test plan: 1. Run updatedatabase.pl 2. Enable system precference "OPACAutoFill" 3. Log into OPAC and go to purchase suggetions page 4. Write a valid ISBN into the ISBN field and press the edit icon next to the field, or unfocus the field. 5. Title, Author, Publisher and Item Type fields should now be filled automaticly. 6. Press "undo" to undo - should restore all changed fields to original values Tested all patches together, works as expected. Signed-off-by: Marc Signed-off-by: Maryse Simard Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Aleisha Amohia changed: What|Removed |Added Attachment #110494|0 |1 is obsolete|| --- Comment #100 from Aleisha Amohia --- Created attachment 112598 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112598=edit Bug 14242: (follow up) renaming syspref OPACAutoFill -> OPACSuggestionAutoFill Signed-off-by: Marc Signed-off-by: Maryse Simard Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Aleisha Amohia changed: What|Removed |Added Attachment #110495|0 |1 is obsolete|| --- Comment #101 from Aleisha Amohia --- Created attachment 112599 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112599=edit Bug 14242: (follow-up) Change the icon to words Fix a bug that meant it would search on empty ISBN To test 1. Fill in a valid ISBN (Book data is correctly loaded) 2. Clear the ISBN from the field (Book data is correctly removed) 3. Tab away from the empty ISBN field: Data is loaded for a title "ISBN 0-9690745-2-2" 4. Apply patch 5. Repeat 1,2 and 3 notice a search is no longer done Signed-off-by: Marc Signed-off-by: Maryse Simard Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Aleisha Amohia changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Failed QA Keywords||rel_20_11_target -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 --- Comment #98 from Jonathan Druart --- 3. Search for "foo", then search for "bar" Clear form => It restores values from "foo" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 --- Comment #97 from Jonathan Druart --- 2 minor ergonomic questions: 1. What is the purpose of the "well" class? 2. Is the extra space between the 2 first inputs expected? https://snipboard.io/7kYfJW.jpg -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 --- Comment #96 from Jonathan Druart --- Created attachment 110990 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110990=edit Bug 14242: Remove TT conditional from HTML tags It brakes the translation script -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 --- Comment #95 from Katrin Fischer --- Created attachment 110501 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110501=edit Bug 14242: (QA follow-up) Fix buttons for new bootstrap version Stole the mark-up from bug 26478. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Katrin Fischer changed: What|Removed |Added Attachment #110145|0 |1 is obsolete|| --- Comment #91 from Katrin Fischer --- Created attachment 110497 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110497=edit Bug 14242: (follow-up) Translateable js strings, $raw filter Sponsored-by: Region Halland Signed-off-by: Maryse Simard Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Katrin Fischer changed: What|Removed |Added Attachment #110148|0 |1 is obsolete|| --- Comment #94 from Katrin Fischer --- Created attachment 110500 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110500=edit Bug 14242: (follow-up) Adding publication year hint and fix js translations -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Katrin Fischer changed: What|Removed |Added Attachment #110144|0 |1 is obsolete|| --- Comment #90 from Katrin Fischer --- Created attachment 110496 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110496=edit Bug 14242: (follow-up) Strip hyphen from ISBN for search purposes To test, enter a valid ISBN complete with - eg 978-1-78416-110-1 The search should still work Signed-off-by: Marc Signed-off-by: Maryse Simard Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Katrin Fischer changed: What|Removed |Added Attachment #110143|0 |1 is obsolete|| --- Comment #89 from Katrin Fischer --- Created attachment 110495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110495=edit Bug 14242: (follow-up) Change the icon to words Fix a bug that meant it would search on empty ISBN To test 1. Fill in a valid ISBN (Book data is correctly loaded) 2. Clear the ISBN from the field (Book data is correctly removed) 3. Tab away from the empty ISBN field: Data is loaded for a title "ISBN 0-9690745-2-2" 4. Apply patch 5. Repeat 1,2 and 3 notice a search is no longer done Signed-off-by: Marc Signed-off-by: Maryse Simard Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Katrin Fischer changed: What|Removed |Added Attachment #110146|0 |1 is obsolete|| --- Comment #92 from Katrin Fischer --- Created attachment 110498 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110498=edit Bug 14242: (follow-up) Move English strings out of JavaScript In order for English strings to be translatable they must be defined in the template, not in the JS file. Signed-off-by: Maryse Simard Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Katrin Fischer changed: What|Removed |Added Attachment #110147|0 |1 is obsolete|| --- Comment #93 from Katrin Fischer --- Created attachment 110499 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110499=edit Bug 14242: Styling of buttons, get copyright date, fixing plugin comment And other code-y bits. Addressing comments in Comment 59. Sponsored-by: Catalyst IT Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Katrin Fischer changed: What|Removed |Added Attachment #110142|0 |1 is obsolete|| --- Comment #88 from Katrin Fischer --- Created attachment 110494 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110494=edit Bug 14242: (follow up) renaming syspref OPACAutoFill -> OPACSuggestionAutoFill Signed-off-by: Marc Signed-off-by: Maryse Simard Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Katrin Fischer changed: What|Removed |Added Attachment #110141|0 |1 is obsolete|| --- Comment #87 from Katrin Fischer --- Created attachment 110493 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110493=edit Bug 14242: Use ISBN-field to automatically fill out purchase suggestions Add new jQuery plugin "autofill" which transforms selected element(s) into search fields for Google Books API and automatically fills requested fields with search result. Use in OPAC purchase suggestions to automatically fill out fields when entering ISBN-number. Test plan: 1. Run updatedatabase.pl 2. Enable system precference "OPACAutoFill" 3. Log into OPAC and go to purchase suggetions page 4. Write a valid ISBN into the ISBN field and press the edit icon next to the field, or unfocus the field. 5. Title, Author, Publisher and Item Type fields should now be filled automaticly. 6. Press "undo" to undo - should restore all changed fields to original values Tested all patches together, works as expected. Signed-off-by: Marc Signed-off-by: Maryse Simard Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #86 from Katrin Fischer --- The follow-up is not dramatic, keeping signed off status here. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Aleisha Amohia changed: What|Removed |Added Attachment #108695|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Aleisha Amohia changed: What|Removed |Added Attachment #108701|0 |1 is obsolete|| --- Comment #84 from Aleisha Amohia --- Created attachment 110147 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110147=edit Bug 14242: Styling of buttons, get copyright date, fixing plugin comment And other code-y bits. Addressing comments in Comment 59. Sponsored-by: Catalyst IT Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 --- Comment #85 from Aleisha Amohia --- Created attachment 110148 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110148=edit Bug 14242: (follow-up) Adding publication year hint and fix js translations -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Aleisha Amohia changed: What|Removed |Added Attachment #108699|0 |1 is obsolete|| --- Comment #82 from Aleisha Amohia --- Created attachment 110145 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110145=edit Bug 14242: (follow-up) Translateable js strings, $raw filter Sponsored-by: Region Halland Signed-off-by: Maryse Simard Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Aleisha Amohia changed: What|Removed |Added Attachment #108700|0 |1 is obsolete|| --- Comment #83 from Aleisha Amohia --- Created attachment 110146 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110146=edit Bug 14242: (follow-up) Move English strings out of JavaScript In order for English strings to be translatable they must be defined in the template, not in the JS file. Signed-off-by: Maryse Simard Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Aleisha Amohia changed: What|Removed |Added Attachment #108697|0 |1 is obsolete|| --- Comment #80 from Aleisha Amohia --- Created attachment 110143 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110143=edit Bug 14242: (follow-up) Change the icon to words Fix a bug that meant it would search on empty ISBN To test 1. Fill in a valid ISBN (Book data is correctly loaded) 2. Clear the ISBN from the field (Book data is correctly removed) 3. Tab away from the empty ISBN field: Data is loaded for a title "ISBN 0-9690745-2-2" 4. Apply patch 5. Repeat 1,2 and 3 notice a search is no longer done Signed-off-by: Marc Signed-off-by: Maryse Simard Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 --- Comment #78 from Aleisha Amohia --- Created attachment 110141 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110141=edit Bug 14242: Use ISBN-field to automatically fill out purchase suggestions Add new jQuery plugin "autofill" which transforms selected element(s) into search fields for Google Books API and automatically fills requested fields with search result. Use in OPAC purchase suggestions to automatically fill out fields when entering ISBN-number. Test plan: 1. Run updatedatabase.pl 2. Enable system precference "OPACAutoFill" 3. Log into OPAC and go to purchase suggetions page 4. Write a valid ISBN into the ISBN field and press the edit icon next to the field, or unfocus the field. 5. Title, Author, Publisher and Item Type fields should now be filled automaticly. 6. Press "undo" to undo - should restore all changed fields to original values Tested all patches together, works as expected. Signed-off-by: Marc Signed-off-by: Maryse Simard Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Aleisha Amohia changed: What|Removed |Added Attachment #108696|0 |1 is obsolete|| --- Comment #79 from Aleisha Amohia --- Created attachment 110142 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110142=edit Bug 14242: (follow up) renaming syspref OPACAutoFill -> OPACSuggestionAutoFill Signed-off-by: Marc Signed-off-by: Maryse Simard Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Aleisha Amohia changed: What|Removed |Added Attachment #108698|0 |1 is obsolete|| --- Comment #81 from Aleisha Amohia --- Created attachment 110144 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110144=edit Bug 14242: (follow-up) Strip hyphen from ISBN for search purposes To test, enter a valid ISBN complete with - eg 978-1-78416-110-1 The search should still work Signed-off-by: Marc Signed-off-by: Maryse Simard Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Aleisha Amohia changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242
--- Comment #77 from Katrin Fischer ---
Spotted something else:
self.$error.html(_('Sorry, nothing found.'));
Is not translatable (in .js). Just needs another _
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #76 from Katrin Fischer ---
1) Copyright date changed
The patch set changes the size on coyprightdate and add a pattern check:
-
+
I am not sure about this one, especially since it causes issues as Lisette
noted on comment#75. The message is just: Please match the requested format.
The label and the check also don't match and add a bit to the confusion - we
ask for "date" but expect "year".
I think adding a hint on the field with the expected format or improving the
validation feedback, would be a worthwhile addition here to complement the new
check.
I am not sure if we can agree on this, but maybe we can discuss renaming
Copyright date to publication year? I think this is the only context we use
this specific term. (not blocker, asking for opinion and can file separately)
2) Translations in .js files
This trick is no longer necessary, you can now wrap translations in js files in
__( ) to make them translatable. As Owen is just working hard on switching all
the old constructs to the new one, we should avoid adding more work for him.
Can you please change that?
+var MSG_UNDO_AUTOFILL_SUGGESTION = _("Undo");
+var MSG_SEARCH_GOOGLE_BOOKS = _("Search Google Books");
3) Undo
Not blocker, but wondering if "Clear form" or similar would work a bit better
in this case and be more specific for translations.
Failing for 2) and a missing hint on 1). Really close and works nicely already,
hope to see this come back soon!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Katrin Fischer changed: What|Removed |Added Attachment #103527|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 Lisette Scheer changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #75 from Lisette Scheer --- Worked as intended. ISBN 978-1-78416-110-1 did import the date as 2016-09-22 and the box only allows you to type in 4 characters. It would not let me submit the form with the date that it autofilled, which might cause some patron confusion. It only said "Please match the requested format" but doesn't tell you what the requested format is. Functionally it worked great, that was the only odd thing I noticed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 ByWater Sandboxes changed: What|Removed |Added Attachment #103532|0 |1 is obsolete|| --- Comment #73 from ByWater Sandboxes --- Created attachment 108700 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108700=edit Bug 14242: (follow-up) Move English strings out of JavaScript In order for English strings to be translatable they must be defined in the template, not in the JS file. Signed-off-by: Maryse Simard Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 ByWater Sandboxes changed: What|Removed |Added Attachment #103529|0 |1 is obsolete|| --- Comment #70 from ByWater Sandboxes --- Created attachment 108697 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108697=edit Bug 14242: (follow-up) Change the icon to words Fix a bug that meant it would search on empty ISBN To test 1. Fill in a valid ISBN (Book data is correctly loaded) 2. Clear the ISBN from the field (Book data is correctly removed) 3. Tab away from the empty ISBN field: Data is loaded for a title "ISBN 0-9690745-2-2" 4. Apply patch 5. Repeat 1,2 and 3 notice a search is no longer done Signed-off-by: Marc Signed-off-by: Maryse Simard Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 ByWater Sandboxes changed: What|Removed |Added Attachment #103533|0 |1 is obsolete|| --- Comment #74 from ByWater Sandboxes --- Created attachment 108701 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108701=edit Bug 14242: Styling of buttons, get copyright date, fixing plugin comment And other code-y bits. Addressing comments in Comment 59. Sponsored-by: Catalyst IT Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 ByWater Sandboxes changed: What|Removed |Added Attachment #103531|0 |1 is obsolete|| --- Comment #72 from ByWater Sandboxes --- Created attachment 108699 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108699=edit Bug 14242: (follow-up) Translateable js strings, $raw filter Sponsored-by: Region Halland Signed-off-by: Maryse Simard Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 ByWater Sandboxes changed: What|Removed |Added Attachment #103530|0 |1 is obsolete|| --- Comment #71 from ByWater Sandboxes --- Created attachment 108698 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108698=edit Bug 14242: (follow-up) Strip hyphen from ISBN for search purposes To test, enter a valid ISBN complete with - eg 978-1-78416-110-1 The search should still work Signed-off-by: Marc Signed-off-by: Maryse Simard Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14242] Use ISBN-field to fill out purchase suggestions (using an Ajax-request)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14242 --- Comment #68 from ByWater Sandboxes --- Created attachment 108695 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108695=edit Bug 14242: Use ISBN-field to automaticly fill out purchase suggestions Add new jQuery plugin "autofill" which transforms selected element(s) into search fields for Google Books API and automaticly fills requested fields with search result. Use in OPAC purchase suggestions to automaticly fill out fields when entering ISBN-number. Test plan: 1. Run updatedatabase.pl 2. Enable system precference "OPACAutoFill" 3. Log into OPAC and go to purchase suggetions page 4. Write a valid ISBN into the ISBN field and press the edit icon next to the field, or unfocus the field. 5. Title, Author, Publisher and Item Type fields should now be filled automaticly. 6. Press "undo" to undo - should restore all changed fields to original values Tested all patches together, works as expected. Signed-off-by: Marc Signed-off-by: Maryse Simard Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
