[Koha-bugs] [Bug 14257] Add show_extended_attributes to ILS-DI call GetPatronInfo
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14257 Jonathan Druart changed: What|Removed |Added Blocks||21199 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14257] Add show_extended_attributes to ILS-DI call GetPatronInfo
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14257 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #15 from Jonathan Druart --- I am currently working on moving this code the Koha namespace and I do not understand what is needed exactly here. So far we have: xxx 1 Damaged pouet peout 0 Maybe we just need a couple variable=value, right? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14257] Add show_extended_attributes to ILS-DI call GetPatronInfo
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14257 Brendan Gallagherchanged: What|Removed |Added CC||bren...@bywatersolutions.co ||m Status|Passed QA |Pushed to Master --- Comment #14 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 release. Thanks! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14257] Add show_extended_attributes to ILS-DI call GetPatronInfo
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14257 Katrin Fischerchanged: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14257] Add show_extended_attributes to ILS-DI call GetPatronInfo
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14257 Katrin Fischerchanged: What|Removed |Added Attachment #49581|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14257] Add show_extended_attributes to ILS-DI call GetPatronInfo
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14257 Katrin Fischerchanged: What|Removed |Added Attachment #49580|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14257] Add show_extended_attributes to ILS-DI call GetPatronInfo
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14257 Katrin Fischerchanged: What|Removed |Added Attachment #49669|0 |1 is obsolete|| --- Comment #13 from Katrin Fischer --- Created attachment 49698 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49698=edit Bug 14257: Follow-up - Add documentation, fix typo, fix test - t/db_dependent/ILSDI_Services.t was failing for me as I had issues in my database, fixed with another delete line - QA tools found a typo - comparision - Added documentation of the new parameter to the ilsdi.pl page -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14257] Add show_extended_attributes to ILS-DI call GetPatronInfo
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14257 --- Comment #12 from Katrin Fischer--- Created attachment 49697 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49697=edit [PASSED QA] Bug 14257 - Add show_attributes to GetPatronInfo This patch adds the ability to query the extended patron attributes via the ILSDI web service's GetPatronInfo service. Example: ilsdi.pl?service=GetPatronInfo_id=3_attributes=1 A new element will be added if there are any attributes available from the database. We need to discuss the security implications of showing the attributes. At present it will allow querying of non-public (OPAC-visible) information. We might want to change this. Sponsored-By: Halland County Library Test plan: * Configure Koha to make use of extended attributes: Under 'Administration' -> 'Global system preferences' -> 'Patrons' tab -> Set 'ExtendedPatronAttributes' to 'Enable', press save and switch to 'Web services' tab. * Enable the ILS-DI service: Under 'Administration' -> 'Global system preferences' -> 'Web services' tab -> 'ILS-DI' section: Set 'ILS-DI' to 'Enable' and save. * Create an attribute to query: Under 'Administration' -> 'Patrons and circulation' -> 'Patron attribute types' press 'New patron attribute type': Enter a type code, like 'DOORCODE', description and assign a category that your test patron is a member of, then save. * Set value for test user: Locate the test patron, the new attribute should be listed under 'Additional attributes and identifiers'. Click 'Edit' and assign a value, like '1337' and save. * Query the ILS-DI service: http://127.0.1.1/cgi-bin/koha/ilsdi.pl?service=GetPatronInfo_id=1_attributes=1 The output XML should have an element named 'attributes' containing the data you entered. Signed-off-by: Mirko Tietgen Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14257] Add show_extended_attributes to ILS-DI call GetPatronInfo
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14257 --- Comment #11 from Katrin Fischer--- Created attachment 49696 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49696=edit [PASSED QA] Bug 14257 - Add show_attributes to GetPatronInfo Added unit tests to for GetBorrowerAttributes and GetPatronInfo. Sponsored-By: Halland County Library Signed-off-by: Mirko Tietgen Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14257] Add show_extended_attributes to ILS-DI call GetPatronInfo
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14257 --- Comment #10 from Katrin Fischer--- Still working on this! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14257] Add show_extended_attributes to ILS-DI call GetPatronInfo
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14257 --- Comment #9 from Katrin Fischer--- Created attachment 49669 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49669=edit Bug 14257: Follow-up - Add documentation, fix typo, fix test - t/db_dependent/ILSDI_Services.t was failing for me as I had issues in my database, fixed with another delete line - QA tools found a typo - comparision - Added documentation of the new parameter to the ilsdi.pl page -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14257] Add show_extended_attributes to ILS-DI call GetPatronInfo
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14257 Katrin Fischerchanged: What|Removed |Added CC||katrin.fisc...@bsz-bw.de QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | --- Comment #8 from Katrin Fischer --- Just 2 notes for now: - we need to update the documentation - there is a typo hiding somewhere: FAILspelling comparision ==> comparison -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14257] Add show_extended_attributes to ILS-DI call GetPatronInfo
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14257 Mirko Tietgenchanged: What|Removed |Added CC||mi...@abunchofthings.net Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14257] Add show_extended_attributes to ILS-DI call GetPatronInfo
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14257 --- Comment #7 from Mirko Tietgen--- Created attachment 49581 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49581=edit Bug 14257 - Add show_attributes to GetPatronInfo This patch adds the ability to query the extended patron attributes via the ILSDI web service's GetPatronInfo service. Example: ilsdi.pl?service=GetPatronInfo_id=3_attributes=1 A new element will be added if there are any attributes available from the database. We need to discuss the security implications of showing the attributes. At present it will allow querying of non-public (OPAC-visible) information. We might want to change this. Sponsored-By: Halland County Library Test plan: * Configure Koha to make use of extended attributes: Under 'Administration' -> 'Global system preferences' -> 'Patrons' tab -> Set 'ExtendedPatronAttributes' to 'Enable', press save and switch to 'Web services' tab. * Enable the ILS-DI service: Under 'Administration' -> 'Global system preferences' -> 'Web services' tab -> 'ILS-DI' section: Set 'ILS-DI' to 'Enable' and save. * Create an attribute to query: Under 'Administration' -> 'Patrons and circulation' -> 'Patron attribute types' press 'New patron attribute type': Enter a type code, like 'DOORCODE', description and assign a category that your test patron is a member of, then save. * Set value for test user: Locate the test patron, the new attribute should be listed under 'Additional attributes and identifiers'. Click 'Edit' and assign a value, like '1337' and save. * Query the ILS-DI service: http://127.0.1.1/cgi-bin/koha/ilsdi.pl?service=GetPatronInfo_id=1_attributes=1 The output XML should have an element named 'attributes' containing the data you entered. Signed-off-by: Mirko Tietgen -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14257] Add show_extended_attributes to ILS-DI call GetPatronInfo
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14257 Mirko Tietgenchanged: What|Removed |Added Attachment #49579|0 |1 is obsolete|| --- Comment #6 from Mirko Tietgen --- Created attachment 49580 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49580=edit Bug 14257 - Add show_attributes to GetPatronInfo Added unit tests to for GetBorrowerAttributes and GetPatronInfo. Sponsored-By: Halland County Library Signed-off-by: Mirko Tietgen -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14257] Add show_extended_attributes to ILS-DI call GetPatronInfo
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14257 Mirko Tietgenchanged: What|Removed |Added Attachment #44864|0 |1 is obsolete|| Attachment #44865|0 |1 is obsolete|| --- Comment #5 from Mirko Tietgen --- Created attachment 49579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49579=edit Bug 14257 - Add show_attributes to GetPatronInfo This patch adds the ability to query the extended patron attributes via the ILSDI web service's GetPatronInfo service. Example: ilsdi.pl?service=GetPatronInfo_id=3_attributes=1 A new element will be added if there are any attributes available from the database. We need to discuss the security implications of showing the attributes. At present it will allow querying of non-public (OPAC-visible) information. We might want to change this. Sponsored-By: Halland County Library Test plan: * Configure Koha to make use of extended attributes: Under 'Administration' -> 'Global system preferences' -> 'Patrons' tab -> Set 'ExtendedPatronAttributes' to 'Enable', press save and switch to 'Web services' tab. * Enable the ILS-DI service: Under 'Administration' -> 'Global system preferences' -> 'Web services' tab -> 'ILS-DI' section: Set 'ILS-DI' to 'Enable' and save. * Create an attribute to query: Under 'Administration' -> 'Patrons and circulation' -> 'Patron attribute types' press 'New patron attribute type': Enter a type code, like 'DOORCODE', description and assign a category that your test patron is a member of, then save. * Set value for test user: Locate the test patron, the new attribute should be listed under 'Additional attributes and identifiers'. Click 'Edit' and assign a value, like '1337' and save. * Query the ILS-DI service: http://127.0.1.1/cgi-bin/koha/ilsdi.pl?service=GetPatronInfo_id=1_attributes=1 The output XML should have an element named 'attributes' containing the data you entered. Signed-off-by: Mirko Tietgen -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14257] Add show_extended_attributes to ILS-DI call GetPatronInfo
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14257 Martin Perssonchanged: What|Removed |Added Attachment #44707|0 |1 is obsolete|| --- Comment #3 from Martin Persson --- Created attachment 44864 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44864=edit Bug 14257 - Add show_attributes to GetPatronInfo Added unit tests to for GetBorrowerAttributes and GetPatronInfo. Sponsored-By: Halland County Library -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14257] Add show_extended_attributes to ILS-DI call GetPatronInfo
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14257 --- Comment #4 from Martin Persson--- Created attachment 44865 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44865=edit Bug 14257 - Add show_attributes to GetPatronInfo This patch adds the ability to query the extended patron attributes via the ILSDI web service's GetPatronInfo service. Example: ilsdi.pl?service=GetPatronInfo_id=3_attributes=1 A new element will be added if there are any attributes available from the database. We need to discuss the security implications of showing the attributes. At present it will allow querying of non-public (OPAC-visible) information. We might want to change this. Sponsored-By: Halland County Library Test plan: * Configure Koha to make use of extended attributes: Under 'Administration' -> 'Global system preferences' -> 'Patrons' tab -> Set 'ExtendedPatronAttributes' to 'Enable', press save and switch to 'Web services' tab. * Enable the ILS-DI service: Under 'Administration' -> 'Global system preferences' -> 'Web services' tab -> 'ILS-DI' section: Set 'ILS-DI' to 'Enable' and save. * Create an attribute to query: Under 'Administration' -> 'Patrons and circulation' -> 'Patron attribute types' press 'New patron attribute type': Enter a type code, like 'DOORCODE', description and assign a category that your test patron is a member of, then save. * Set value for test user: Locate the test patron, the new attribute should be listed under 'Additional attributes and identifiers'. Click 'Edit' and assign a value, like '1337' and save. * Query the ILS-DI service: http://127.0.1.1/cgi-bin/koha/ilsdi.pl?service=GetPatronInfo_id=1_attributes=1 The output XML should have an element named 'attributes' containing the data you entered. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14257] Add show_extended_attributes to ILS-DI call GetPatronInfo
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14257 Martin Perssonchanged: What|Removed |Added Attachment #44656|0 |1 is obsolete|| --- Comment #2 from Martin Persson --- Created attachment 44707 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44707=edit Bug 14257 - Add show_attributes to GetPatronInfo This patch adds the ability to query the extended patron attributes via the ILSDI web service's GetPatronInfo service. Example: ilsdi.pl?service=GetPatronInfo_id=3_attributes=1 A new element will be added if there are any attributes available from the database. We need to discuss the security implications of showing the attributes. At present it will allow querying of non-public (OPAC-visible) information. We might want to change this. Sponsored-By: Halland County Library Test plan: * Configure Koha to make use of extended attributes: Under 'Administration' -> 'Global system preferences' -> 'Patrons' tab -> Set 'ExtendedPatronAttributes' to 'Enable', press save and switch to 'Web services' tab. * Enable the ILS-DI service: Under 'Administration' -> 'Global system preferences' -> 'Web services' tab -> 'ILS-DI' section: Set 'ILS-DI' to 'Enable' and save. * Create an attribute to query: Under 'Administration' -> 'Patrons and circulation' -> 'Patron attribute types' press 'New patron attribute type': Enter a type code, like 'DOORCODE', description and assign a category that your test patron is a member of, then save. * Set value for test user: Locate the test patron, the new attribute should be listed under 'Additional attributes and identifiers'. Click 'Edit' and assign a value, like '1337' and save. * Query the ILS-DI service: http://127.0.1.1/cgi-bin/koha/ilsdi.pl?service=GetPatronInfo_id=1_attributes=1 The output XML should have an element named 'attributes' containing the data you entered. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14257] Add show_extended_attributes to ILS-DI call GetPatronInfo
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14257 Martin Perssonchanged: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14257] Add show_extended_attributes to ILS-DI call GetPatronInfo
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14257 --- Comment #1 from Martin Persson--- Created attachment 44656 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44656=edit Bug 14257 - Add show_attributes to GetPatronInfo This patch adds the ability to query the extended patron attributes via the ILSDI web service's GetPatronInfo service. Example: ilsdi.pl?service=GetPatronInfo_id=3_attributes=1 A new element will be added if there are any attributes available from the database. We need to discuss the security implications of showing the attributes. At present it will allow querying of non-public (OPAC-visible) information. We might want to change this. Sponsored-By: Halland County Library -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/