[Koha-bugs] [Bug 14306] Show URL from MARC21 field 555$u in basket and detail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14306 Marcel de Rooy changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=18198 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14306] Show URL from MARC21 field 555$u in basket and detail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14306 Brendan Gallagher changed: What|Removed |Added CC||bren...@bywatersolutions.co ||m Status|Passed QA |Pushed to Master --- Comment #32 from Brendan Gallagher --- Pushed to Master - Should be in the May 2016 - release. Thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14306] Show URL from MARC21 field 555$u in basket and detail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14306 --- Comment #31 from Marcel de Rooy --- (In reply to Katrin Fischer from comment #30) > Signed-off-by: Katrin Fischer Great. Thx -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14306] Show URL from MARC21 field 555$u in basket and detail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14306 Katrin Fischer changed: What|Removed |Added Attachment #46251|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14306] Show URL from MARC21 field 555$u in basket and detail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14306 Katrin Fischer changed: What|Removed |Added Attachment #46254|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14306] Show URL from MARC21 field 555$u in basket and detail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14306 Katrin Fischer changed: What|Removed |Added Attachment #46252|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14306] Show URL from MARC21 field 555$u in basket and detail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14306 Katrin Fischer changed: What|Removed |Added Attachment #46253|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14306] Show URL from MARC21 field 555$u in basket and detail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14306 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14306] Show URL from MARC21 field 555$u in basket and detail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14306 --- Comment #27 from Katrin Fischer --- Created attachment 48681 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48681&action=edit [PASSED QA] Bug 14306: Show URL from MARC21 field 555$u under Title Notes/Descriptions This patch includes: [1] Add some logic to GetMarcNotes to embed the contents of MARC21 field 555$u in a html anchor tag. [2] Add a unit test for GetMarcNotes in Biblio.t [3] Remove calls to GetMarcNotes from sendbasket.pl (opac and staff). A closer look revealed that the data was not used; the notes in the mail of sendbasket are taken from GetBiblioData. Test plan: [1] Edit a record. Add one or two URLS in 555$u. Add something in 500$a too. [2] Check if you can click the URLs in opac and staff detail tab Notes or Descriptions. [3] Run the unit test t/db../Biblio.t [4] Add something in the cart. Click More Details and send the cart. Verify that you have something in Notes (from 500$a). Signed-off-by: Marc Veron Followed test plan. Works as expected. QA tools OK. Tested with all patches together, works as expected Signed-off-by: Marc Véron Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14306] Show URL from MARC21 field 555$u in basket and detail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14306 --- Comment #28 from Katrin Fischer --- Created attachment 48682 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48682&action=edit [PASSED QA] Bug 14306: Follow-up for URLs in 555$u This patch removes the code for inserting the anchor tags around URLs in GetMarcNotes (as added originally). The URLs are placed in separate array elements; the template should take care of further handling. The unit test has been adjusted accordingly. Test plan: Run the unit test. Signed-off-by: Marc Véron Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14306] Show URL from MARC21 field 555$u in basket and detail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14306 --- Comment #30 from Katrin Fischer --- Created attachment 48684 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48684&action=edit [PASSED QA] Bug 14306: Remove call to GetMarcNotes from sendshelf Just as mentioned in the first patch for sendbasket, I discovered that the call of GetMarcNotes is not really used in sendshelf. The array is passed to the template, but the template does not use it. (It uses the information from GetBiblioData.) Test plan: [1] Send a list that includes a record with some notes (opac and staff). Signed-off-by: Marc Véron Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14306] Show URL from MARC21 field 555$u in basket and detail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14306 --- Comment #29 from Katrin Fischer --- Created attachment 48683 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48683&action=edit [PASSED QA] Bug 14306: Changes for basket and detail templates A simple regex is added to the basket and detail templates to select the URLs passed separately from MARC21 555$u by GetMarcNotes. Note that the regex tests if a note starts with http:// or https:// and does not contain any whitespace in order to be considered as a url. These URLs are put in an anchor tag. This touches four places: [1] opac detail, tab title notes [2] catalogue detail, tab Descriptions [3] opac basket, more details, notes [4] staff basket, more details, notes Test plan: [1] Edit a record. Add a 500$a, 555$a and a URL in 555$u. Put "http://this is not a url" in the 500$a (whitespace!). [2] Check opac-detail, tab Title Notes. Check the URL. [3] Do the same for catalogue/detail. [4] Add record to cart in OPAC. Open basket. Check More details. [5] Repeat previous step in staff. Signed-off-by: Marc Véron Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14306] Show URL from MARC21 field 555$u in basket and detail
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14306 --- Comment #26 from Marcel de Rooy --- (In reply to Marc Véron from comment #25) > Signed-off-by: Marc Véron Thanks, Marc -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14306] Show URL from MARC21 field 555$u in basket and detail
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14306 Marc Véron changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14306] Show URL from MARC21 field 555$u in basket and detail
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14306 Marc Véron changed: What|Removed |Added Attachment #46221|0 |1 is obsolete|| --- Comment #25 from Marc Véron --- Created attachment 46254 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46254&action=edit Bug 14306: Remove call to GetMarcNotes from sendshelf Just as mentioned in the first patch for sendbasket, I discovered that the call of GetMarcNotes is not really used in sendshelf. The array is passed to the template, but the template does not use it. (It uses the information from GetBiblioData.) Test plan: [1] Send a list that includes a record with some notes (opac and staff). Signed-off-by: Marc Véron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14306] Show URL from MARC21 field 555$u in basket and detail
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14306 Marc Véron changed: What|Removed |Added Attachment #42012|0 |1 is obsolete|| --- Comment #24 from Marc Véron --- Created attachment 46253 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46253&action=edit Bug 14306: Changes for basket and detail templates A simple regex is added to the basket and detail templates to select the URLs passed separately from MARC21 555$u by GetMarcNotes. Note that the regex tests if a note starts with http:// or https:// and does not contain any whitespace in order to be considered as a url. These URLs are put in an anchor tag. This touches four places: [1] opac detail, tab title notes [2] catalogue detail, tab Descriptions [3] opac basket, more details, notes [4] staff basket, more details, notes Test plan: [1] Edit a record. Add a 500$a, 555$a and a URL in 555$u. Put "http://this is not a url" in the 500$a (whitespace!). [2] Check opac-detail, tab Title Notes. Check the URL. [3] Do the same for catalogue/detail. [4] Add record to cart in OPAC. Open basket. Check More details. [5] Repeat previous step in staff. Signed-off-by: Marc Véron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14306] Show URL from MARC21 field 555$u in basket and detail
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14306 Marc Véron changed: What|Removed |Added Attachment #42011|0 |1 is obsolete|| --- Comment #23 from Marc Véron --- Created attachment 46252 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46252&action=edit Bug 14306: Follow-up for URLs in 555$u This patch removes the code for inserting the anchor tags around URLs in GetMarcNotes (as added originally). The URLs are placed in separate array elements; the template should take care of further handling. The unit test has been adjusted accordingly. Test plan: Run the unit test. Signed-off-by: Marc Véron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14306] Show URL from MARC21 field 555$u in basket and detail
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14306 Marc Véron changed: What|Removed |Added Attachment #42010|0 |1 is obsolete|| --- Comment #22 from Marc Véron --- Created attachment 46251 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46251&action=edit Bug 14306: Show URL from MARC21 field 555$u under Title Notes/Descriptions This patch includes: [1] Add some logic to GetMarcNotes to embed the contents of MARC21 field 555$u in a html anchor tag. [2] Add a unit test for GetMarcNotes in Biblio.t [3] Remove calls to GetMarcNotes from sendbasket.pl (opac and staff). A closer look revealed that the data was not used; the notes in the mail of sendbasket are taken from GetBiblioData. Test plan: [1] Edit a record. Add one or two URLS in 555$u. Add something in 500$a too. [2] Check if you can click the URLs in opac and staff detail tab Notes or Descriptions. [3] Run the unit test t/db../Biblio.t [4] Add something in the cart. Click More Details and send the cart. Verify that you have something in Notes (from 500$a). Signed-off-by: Marc Veron Followed test plan. Works as expected. QA tools OK. Tested with all patches together, works as expected Signed-off-by: Marc Véron -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14306] Show URL from MARC21 field 555$u in basket and detail
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14306 --- Comment #21 from Marcel de Rooy --- (In reply to Marc Véron from comment #20) > Hi Marcel, a question about the test plan: > Do you expect the values (500$a, 555$a and a URL in 555$u) to be inserted > into the mails? Or should we test only that the mails still work? Hi Marc, You may check the mails for unexpected side-effects or so. The main changes in this patch are template changes. Please check the tabs mentioned. The 555 field is not passed in the mail IIRC (the code there did not use GetMarcNotes at all). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14306] Show URL from MARC21 field 555$u in basket and detail
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14306 --- Comment #20 from Marc Véron --- Hi Marcel, a question about the test plan: Do you expect the values (500$a, 555$a and a URL in 555$u) to be inserted into the mails? Or should we test only that the mails still work? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14306] Show URL from MARC21 field 555$u in basket and detail
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14306 Marcel de Rooy changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff --- Comment #19 from Marcel de Rooy --- Rebased. Who adds a signoff? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14306] Show URL from MARC21 field 555$u in basket and detail
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14306 Marcel de Rooy changed: What|Removed |Added Attachment #42013|0 |1 is obsolete|| --- Comment #18 from Marcel de Rooy --- Created attachment 46221 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46221&action=edit Bug 14306: Remove call to GetMarcNotes from sendshelf Just as mentioned in the first patch for sendbasket, I discovered that the call of GetMarcNotes is not really used in sendshelf. The array is passed to the template, but the template does not use it. (It uses the information from GetBiblioData.) Test plan: [1] Send a list that includes a record with some notes (opac and staff). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14306] Show URL from MARC21 field 555$u in basket and detail
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14306 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply --- Comment #17 from Jonathan Druart --- CONFLICT (content): Merge conflict in virtualshelves/sendshelf.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14306] Show URL from MARC21 field 555$u in basket and detail
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14306 Marcel de Rooy changed: What|Removed |Added Summary|Show URL from MARC21 field |Show URL from MARC21 field |555$u under Title Notes |555$u in basket and detail |(OPAC) or Descriptions | |(Staff) | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
