[Koha-bugs] [Bug 14334] DBI fighting DBIx over Autocommit in tests

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14334

Mason James  changed:

   What|Removed |Added

 CC||m...@kohaaloha.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14334] DBI fighting DBIx over Autocommit in tests

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14334

--- Comment #40 from Jonathan Druart  
---
Follow-ups on bug 22001 are waiting for signoff for more that a year now.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14334] DBI fighting DBIx over Autocommit in tests

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14334

Fridolin SOMERS  changed:

   What|Removed |Added

 Status|Pushed to Stable|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14334] DBI fighting DBIx over Autocommit in tests

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14334

Fridolin SOMERS  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #39 from Fridolin SOMERS  ---
Pushed to 17.11.x for 17.11.14

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14334] DBI fighting DBIx over Autocommit in tests

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14334

Lucas Gass  changed:

   What|Removed |Added

 CC||lu...@bywatersolutions.com

--- Comment #38 from Lucas Gass  ---
backported to 18.05 for 18.05.08

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14334] DBI fighting DBIx over Autocommit in tests

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14334

Martin Renvoize  changed:

   What|Removed |Added

 Status|Pushed to Master|Pushed to Stable
 CC||martin.renvoize@ptfs-europe
   ||.com

--- Comment #37 from Martin Renvoize  ---
Pushed to 18.11.x for 18.11.01

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14334] DBI fighting DBIx over Autocommit in tests

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14334

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||22001


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22001
[Bug 22001] RaiseError and PrintError flags must be set for tests
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14334] DBI fighting DBIx over Autocommit in tests

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14334

--- Comment #36 from Jonathan Druart  
---
(In reply to Marcel de Rooy from comment #35)
> (In reply to Jonathan Druart from comment #33)
> > Indeed :)
> > I do not have a strong opinion about them, I can re-add them if you think we
> > must keep them.
> 
> Not so sure if we need them at all.
> From DBIx::Class::Storage::DBI:
> This Storage driver normally installs its own HandleError, sets RaiseError
> and ShowErrorStatement on, and sets PrintError off on all database handles..

Koha::Database:
 95 RaiseError => $ENV{DEBUG} ? 1 : 0,

We disable it :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14334] DBI fighting DBIx over Autocommit in tests

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14334

--- Comment #35 from Marcel de Rooy  ---
(In reply to Jonathan Druart from comment #33)
> Indeed :)
> I do not have a strong opinion about them, I can re-add them if you think we
> must keep them.

Not so sure if we need them at all.
>From DBIx::Class::Storage::DBI:
This Storage driver normally installs its own HandleError, sets RaiseError and
ShowErrorStatement on, and sets PrintError off on all database handles..

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14334] DBI fighting DBIx over Autocommit in tests

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14334

Nick Clemens  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||n...@bywatersolutions.com

--- Comment #34 from Nick Clemens  ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14334] DBI fighting DBIx over Autocommit in tests

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14334

--- Comment #33 from Jonathan Druart  
---
Indeed :)
I do not have a strong opinion about them, I can re-add them if you think we
must keep them.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14334] DBI fighting DBIx over Autocommit in tests

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14334

--- Comment #32 from Marcel de Rooy  ---
(In reply to Jonathan Druart from comment #31)
> (In reply to Marcel de Rooy from comment #29)
> > git grep -l RaiseError|wc -l
> > 29
> > What about these DBI remainders ?
> 
> That should not hurt, I'd even say it should be set for all tests.

You removed 34 :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14334] DBI fighting DBIx over Autocommit in tests

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14334

--- Comment #31 from Jonathan Druart  
---
(In reply to Marcel de Rooy from comment #29)
> git grep -l RaiseError|wc -l
> 29
> What about these DBI remainders ?

That should not hurt, I'd even say it should be set for all tests.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14334] DBI fighting DBIx over Autocommit in tests

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14334

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #83129|0   |1
is obsolete||

--- Comment #30 from Marcel de Rooy  ---
Created attachment 83201
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83201=edit
Bug 14334: Remove AutoCommit from tests

And use a DBIx transaction instead.

Test plan:
prove that the test files modified by this patch are passing

Signed-off-by: Josef Moravec 

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14334] DBI fighting DBIx over Autocommit in tests

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14334

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14334] DBI fighting DBIx over Autocommit in tests

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14334

Marcel de Rooy  changed:

   What|Removed |Added

 QA Contact|gmcha...@gmail.com  |m.de.r...@rijksmuseum.nl
 CC||m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14334] DBI fighting DBIx over Autocommit in tests

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14334

--- Comment #29 from Marcel de Rooy  ---
git grep -l RaiseError|wc -l
29
What about these DBI remainders ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14334] DBI fighting DBIx over Autocommit in tests

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14334

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|mtomp...@hotmail.com|jonathan.dru...@bugs.koha-c
   ||ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14334] DBI fighting DBIx over Autocommit in tests

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14334

Josef Moravec  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14334] DBI fighting DBIx over Autocommit in tests

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14334

Josef Moravec  changed:

   What|Removed |Added

  Attachment #82989|0   |1
is obsolete||

--- Comment #28 from Josef Moravec  ---
Created attachment 83129
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83129=edit
Bug 14334: Remove AutoCommit from tests

And use a DBIx transaction instead.

Test plan:
prove that the test files modified by this patch are passing

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14334] DBI fighting DBIx over Autocommit in tests

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14334

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14334] DBI fighting DBIx over Autocommit in tests

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14334

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14334] DBI fighting DBIx over Autocommit in tests

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14334

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #27 from Jonathan Druart  
---
(In reply to Jonathan Druart from comment #23)
> Created attachment 40184 [details] [review]
> [ FOR DISCUSSION ] Bug 14334: Add a Database module for db dependent tests
> 
> What about something like that to avoid c/p?

That was wrong, sorry. Sometimes we need to rollback before END.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14334] DBI fighting DBIx over Autocommit in tests

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14334

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #39874|0   |1
is obsolete||
  Attachment #39875|0   |1
is obsolete||
  Attachment #39876|0   |1
is obsolete||
  Attachment #39877|0   |1
is obsolete||
  Attachment #39879|0   |1
is obsolete||
  Attachment #39880|0   |1
is obsolete||
  Attachment #39881|0   |1
is obsolete||
  Attachment #39882|0   |1
is obsolete||
  Attachment #39883|0   |1
is obsolete||
  Attachment #39884|0   |1
is obsolete||
  Attachment #39885|0   |1
is obsolete||
  Attachment #40080|0   |1
is obsolete||
  Attachment #40086|0   |1
is obsolete||
  Attachment #40184|0   |1
is obsolete||

--- Comment #26 from Jonathan Druart  
---
Created attachment 82989
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82989=edit
Bug 14334: Remove AutoCommit from tests

And use a DBIx transaction instead.

Test plan:
prove that the test files modified by this patch are passing

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14334] DBI fighting DBIx over Autocommit in tests

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14334

--- Comment #25 from M. Tompsett  ---
(In reply to Jonathan Druart from comment #23)
> Created attachment 40184 [details] [review]
> [ FOR DISCUSSION ] Bug 14334: Add a Database module for db dependent tests
> 
> What about something like that to avoid c/p?

+1 I like this. If I get back to this bug, I'll use that.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14334] DBI fighting DBIx over Autocommit in tests

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14334

--- Comment #23 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 40184
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40184action=edit
[ FOR DISCUSSION ] Bug 14334: Add a Database module for db dependent tests

What about something like that to avoid c/p?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14334] DBI fighting DBIx over Autocommit in tests

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14334

--- Comment #24 from M. Tompsett mtomp...@hotmail.com ---
(In reply to Jonathan Druart from comment #23)
 Created attachment 40184 [details] [review]
 [ FOR DISCUSSION ] Bug 14334: Add a Database module for db dependent tests
 
 What about something like that to avoid c/p?

So, what are you thinking exactly, because I still see all the files needing
modification if we make some db_dependent test module(s)?

Plus, this isn't completely CP. There was a correction or two as well.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14334] DBI fighting DBIx over Autocommit in tests

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14334

--- Comment #21 from M. Tompsett mtomp...@hotmail.com ---
Created attachment 40080
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40080action=edit
Bug 14334: t/db_dependent/Charset.t AutoCommit fix

There is no easy way to trigger an obvious problem.

TEST PLAN
-
1) apply patch
2) git diff origin/master
   -- Are the additions/subtractions similar to
  http://paste.lisp.org/display/149194?
3) run koha qa test tools

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14334] DBI fighting DBIx over Autocommit in tests

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14334

--- Comment #22 from M. Tompsett mtomp...@hotmail.com ---
Created attachment 40086
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40086action=edit
Bug 14334: t/db_dependent/Circulation.t AutoCommit fix

There is no easy way to trigger an obvious problem.
Confirmed with khall that tweaking those two other lines to
ensure the autocommit fix will be correct.
(http://irc.koha-community.org/koha/2015-06-10#i_1686796)

TEST PLAN
-
1) apply patch
2) git diff origin/master
   -- Are the additions/subtractions similar to
  http://paste.lisp.org/display/149194?
3) run koha qa test tools

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14334] DBI fighting DBIx over Autocommit in tests

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14334

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

  Attachment #39871|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14334] DBI fighting DBIx over Autocommit in tests

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14334

--- Comment #19 from Tomás Cohen Arazi tomasco...@gmail.com ---
Borrowed some of this patches so we can rely on jenkins.
Will be back to this once finished.

Thanks Mark!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14334] DBI fighting DBIx over Autocommit in tests

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14334

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

  Attachment #39873|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14334] DBI fighting DBIx over Autocommit in tests

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14334

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

  Attachment #39872|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14334] DBI fighting DBIx over Autocommit in tests

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14334

--- Comment #20 from M. Tompsett mtomp...@hotmail.com ---
Okay. Sorry it may take longer. Just was in a car accident. If anyone wishes to
continue. What you see is what you get. I haven't made it further yet.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14334] DBI fighting DBIx over Autocommit in tests

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14334

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

 Status|Needs Signoff   |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14334] DBI fighting DBIx over Autocommit in tests

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14334

--- Comment #15 from M. Tompsett mtomp...@hotmail.com ---
Created attachment 39882
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39882action=edit
Bug 14334: t/db_dependent/Borrower_Discharge.t AutoCommit fix

There is no easy way to trigger an obvious problem.

TEST PLAN
-
1) apply patch
2) git diff origin/master
   -- Are the additions/subtractions similar to
  http://paste.lisp.org/display/149194?
3) run koha qa test tools

NOTE: I am uncertain of what yohann.duf...@biblibre.com
  means in his FIXME comments. No problems experienced
  under Debian Jessie.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14334] DBI fighting DBIx over Autocommit in tests

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14334

--- Comment #11 from M. Tompsett mtomp...@hotmail.com ---
I was not expecting to see: $dbh-{AutoCommit} = 1;
in t/db_dependent/BackgroundJob.t at all.
Is this correct? Why even include it then?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14334] DBI fighting DBIx over Autocommit in tests

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14334

--- Comment #12 from M. Tompsett mtomp...@hotmail.com ---
Created attachment 39879
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39879action=edit
Bug 14334: t/db_dependent/Biblio.t AutoCommit fix

There is no easy way to trigger an obvious problem.

TEST PLAN
-
1) apply patch
2) git diff origin/master
   -- Are the additions/subtractions similar to
  http://paste.lisp.org/display/149194?
   -- this is a special case, in that the transaction
  rollbacks seem to terminate the transaction in DBIx.
  So there needs to be a transaction for each subtest.
3) run koha qa test tools

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14334] DBI fighting DBIx over Autocommit in tests

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14334

--- Comment #14 from M. Tompsett mtomp...@hotmail.com ---
Created attachment 39881
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39881action=edit
Bug 14334: t/db_dependent/Borrower_Debarments.t AutoCommit fix

There is no easy way to trigger an obvious problem.

TEST PLAN
-
1) apply patch
2) git diff origin/master
   -- Are the additions/subtractions similar to
  http://paste.lisp.org/display/149194?
3) run koha qa test tools

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14334] DBI fighting DBIx over Autocommit in tests

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14334

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

 CC||yohann.duf...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14334] DBI fighting DBIx over Autocommit in tests

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14334

--- Comment #18 from M. Tompsett mtomp...@hotmail.com ---
Created attachment 39885
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39885action=edit
Bug 14334: t/db_dependent/Branch.t AutoCommit fix

There is no easy way to trigger an obvious problem.

TEST PLAN
-
1) apply patch
2) git diff origin/master
   -- Are the additions/subtractions similar to
  http://paste.lisp.org/display/149194?
3) run koha qa test tools

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14334] DBI fighting DBIx over Autocommit in tests

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14334

--- Comment #17 from M. Tompsett mtomp...@hotmail.com ---
Created attachment 39884
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39884action=edit
Bug 14334: t/db_dependent/Borrowers.t AutoCommit fix

There is no easy way to trigger an obvious problem.

TEST PLAN
-
1) apply patch
2) git diff origin/master
   -- Are the additions/subtractions similar to
  http://paste.lisp.org/display/149194?
3) run koha qa test tools

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14334] DBI fighting DBIx over Autocommit in tests

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14334

--- Comment #16 from M. Tompsett mtomp...@hotmail.com ---
Created attachment 39883
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39883action=edit
Bug 14334: t/db_dependent/Borrower_Files.t AutoCommit fix

There is no easy way to trigger an obvious problem.

TEST PLAN
-
1) apply patch
2) git diff origin/master
   -- Are the additions/subtractions similar to
  http://paste.lisp.org/display/149194?
3) run koha qa test tools

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14334] DBI fighting DBIx over Autocommit in tests

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14334

--- Comment #13 from M. Tompsett mtomp...@hotmail.com ---
Created attachment 39880
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39880action=edit
Bug 14334: t/db_dependent/Borrower.t AutoCommit fix

There is no easy way to trigger an obvious problem.

TEST PLAN
-
1) apply patch
2) git diff origin/master
   -- Are the additions/subtractions similar to
  http://paste.lisp.org/display/149194?
   -- I added explicit rollback, since I do not know the
  default behaviour of DBIx.
3) run koha qa test tools

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14334] DBI fighting DBIx over Autocommit in tests

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14334

--- Comment #6 from M. Tompsett mtomp...@hotmail.com ---
t/db_dependent/Acquisition/FillWithDefaultValues.t seems to only read from the
DB. I think the removal of the dbh code in the test file is the correct
solution, and add a comment about how to do AutoCommit = 0 stuff if a test
needs to write. Thoughts?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14334] DBI fighting DBIx over Autocommit in tests

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14334

--- Comment #8 from M. Tompsett mtomp...@hotmail.com ---
Created attachment 39875
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39875action=edit
Bug 14334: t/db_dependent/Auth_with_cas.t AutoCommit fix

There is no easy way to trigger an obvious problem.

TEST PLAN
-
1) apply patch
2) git diff origin/master
   -- Are the additions/subtractions similar to
  http://paste.lisp.org/display/149194?
3) run koha qa test tools

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14334] DBI fighting DBIx over Autocommit in tests

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14334

--- Comment #9 from M. Tompsett mtomp...@hotmail.com ---
Created attachment 39876
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39876action=edit
Bug 14334: t/db_dependent/Auth_with_ldap.t AutoCommit fix

There is no easy way to trigger an obvious problem.

TEST PLAN
-
1) apply patch
2) git diff origin/master
   -- Are the additions/subtractions similar to
  http://paste.lisp.org/display/149194?
3) run koha qa test tools

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14334] DBI fighting DBIx over Autocommit in tests

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14334

--- Comment #10 from M. Tompsett mtomp...@hotmail.com ---
Created attachment 39877
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39877action=edit
Bug 14334: t/db_dependent/AuthoritiesMarc.t AutoCommit fix

There is no easy way to trigger an obvious problem.

TEST PLAN
-
1) apply patch
2) git diff origin/master
   -- Are the additions/subtractions similar to
  http://paste.lisp.org/display/149194?
3) run koha qa test tools

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14334] DBI fighting DBIx over Autocommit in tests

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14334

--- Comment #7 from M. Tompsett mtomp...@hotmail.com ---
t/db_dependent/Auth.t seems to only read from the DB. I think the removal of
the dbh code in the test file is the correct solution, and add a comment about
how to do AutoCommit = 0 stuff if a test needs to write. Thoughts?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14334] DBI fighting DBIx over Autocommit in tests

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14334

Indranil Das Gupta indr...@gmail.com changed:

   What|Removed |Added

 CC||indr...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14334] DBI fighting DBIx over Autocommit in tests

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14334

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

 CC||tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14334] DBI fighting DBIx over Autocommit in tests

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14334

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14334] DBI fighting DBIx over Autocommit in tests

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14334

--- Comment #3 from M. Tompsett mtomp...@hotmail.com ---
Created attachment 39872
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39872action=edit
Bug 14334: t/db_dependent/Budgets.t AutoCommit fix

TEST PLAN
--
1) git reset --hard origin/master
2) prove t/db_dependent/Budgets.t
   -- horrible failure about transaction
3) apply this patch
4) prove t/db_dependent/Budgets.t
   -- no issues
5) koha qa test tools.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14334] DBI fighting DBIx over Autocommit in tests

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14334

--- Comment #4 from M. Tompsett mtomp...@hotmail.com ---
Created attachment 39873
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39873action=edit
Bug 14334: t/db_dependent/Letters.t AutoCommit fix

TEST PLAN
--
1) git reset --hard origin/master
2) prove t/db_dependent/Letters.t
   -- horrible failure about transaction
3) apply this patch
4) prove t/db_dependent/Letters.t
   -- no issues
5) koha qa test tools.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14334] DBI fighting DBIx over Autocommit in tests

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14334

M. Tompsett mtomp...@hotmail.com changed:

   What|Removed |Added

   Patch complexity|--- |Medium patch
 Status|NEW |ASSIGNED
   Assignee|ch...@bigballofwax.co.nz|mtomp...@hotmail.com

--- Comment #1 from M. Tompsett mtomp...@hotmail.com ---
Shoot! Those things which are NOT tests scare me, particularly rebuild_zebra.pl
-- going to investigate further.

$ git grep -i -l autocommit
installer/data/mysql/updatedatabase.pl
misc/batchRebuildItemsTables.pl
misc/commit_file.pl
misc/cronjobs/create_koc_db.pl
misc/cronjobs/delete_patrons.pl
misc/cronjobs/update_totalissues.pl
misc/link_bibs_to_authorities.pl
misc/maintenance/borrowers-force-messaging-defaults
misc/maintenance/fix_accountlines_date.pl
misc/migration_tools/bulkmarcimport.pl
misc/migration_tools/create_analytical_rel.pl
misc/migration_tools/rebuild_zebra.pl
misc/stage_file.pl
test/progressbar.pl
tools/batch_delete_records.pl
tools/manage-marc-import.pl
tools/stage-marc-import.pl
t/db_dependent/Accounts.t
t/db_dependent/Acquisition/FillWithDefaultValues.t
t/db_dependent/Auth.t
t/db_dependent/Auth_with_cas.t
t/db_dependent/Auth_with_ldap.t
t/db_dependent/AuthoritiesMarc.t
t/db_dependent/BackgroundJob.t
t/db_dependent/Biblio.t
t/db_dependent/Bookseller.t
t/db_dependent/Borrower.t
t/db_dependent/Borrower_Debarments.t
t/db_dependent/Borrower_Discharge.t
t/db_dependent/Borrower_Files.t
t/db_dependent/Borrowers.t
t/db_dependent/Branch.t
t/db_dependent/Budgets.t
t/db_dependent/Charset.t
t/db_dependent/Circulation.t
t/db_dependent/Circulation/CheckIfIssuedToPatron.t
t/db_dependent/Circulation/CheckValidBarcode.t
t/db_dependent/Circulation/GetIssues.t
t/db_dependent/Circulation/IsItemIssued.t
t/db_dependent/Circulation/IssuingRules/maxsuspensiondays.t
t/db_dependent/Circulation/Returns.t
t/db_dependent/Circulation_Branch.t
t/db_dependent/Circulation_Issuingrule.t
t/db_dependent/Circulation_OfflineOperation.t
t/db_dependent/Circulation_issue.t
t/db_dependent/Circulation_transfers.t
t/db_dependent/ClassSource.t
t/db_dependent/ColumnsSettings.t
t/db_dependent/Contract.t
t/db_dependent/CourseReserves.t
t/db_dependent/Creators/Lib.t
t/db_dependent/Csv.t
t/db_dependent/FrameworkPlugin.t
t/db_dependent/Holds.t
t/db_dependent/Holds/LocalHoldsPriority.t
t/db_dependent/Holds/RevertWaitingStatus.t
t/db_dependent/HoldsQueue.t
t/db_dependent/Holidays.t
t/db_dependent/ILSDI_Services.t
t/db_dependent/ImportBatch.t
t/db_dependent/Items.t
t/db_dependent/Items/GetItemsForInventory.t
t/db_dependent/Items_DelItem.t
t/db_dependent/Koha.t
t/db_dependent/Koha/GetDailyQuote.t
t/db_dependent/Koha/IsKohaFieldLinked.t
t/db_dependent/Koha/Item/Search/Field.t
t/db_dependent/Koha_Misc_Files.t
t/db_dependent/Koha_borrower_modifications.t
t/db_dependent/Labels/t_Batch.t
t/db_dependent/Languages.t
t/db_dependent/Letters.t
t/db_dependent/Letters/GetLetterTemplates.t
t/db_dependent/Letters/GetLettersAvailableForALibrary.t
t/db_dependent/Log.t
t/db_dependent/MarcModificationTemplates.t
t/db_dependent/Members.t
t/db_dependent/Members/AddEnrolmentFeeIfNeeded.t
t/db_dependent/Members/GetAllIssues.t
t/db_dependent/Members/GetPendingIssues.t
t/db_dependent/Members/IssueSlip.t
t/db_dependent/Members_Attributes.t
t/db_dependent/MungeMarcPrice.t
t/db_dependent/NewsChannels.t
t/db_dependent/OAI/Sets.t
t/db_dependent/Overdues.t
t/db_dependent/Ratings.t
t/db_dependent/Record/marcrecord2csv.t
t/db_dependent/Reports_Guided.t
t/db_dependent/Reserves.t
t/db_dependent/Review.t
t/db_dependent/RotatingCollections.t
t/db_dependent/Search/History.t
t/db_dependent/Search_SearchHistory.t
t/db_dependent/Serials.t
t/db_dependent/Serials/Claims.t
t/db_dependent/Serials/Frequency.t
t/db_dependent/Serials/GetNextDate.t
t/db_dependent/Serials/GetNextSeq.t
t/db_dependent/Serials/Numberpattern.t
t/db_dependent/Serials_2.t
t/db_dependent/ShelfBrowser.t
t/db_dependent/Stats.t
t/db_dependent/Suggestions.t
t/db_dependent/Template/Plugin/Branches.t
t/db_dependent/Template/Plugin/Categories.t
t/db_dependent/Utils/Datatables_Members.t
t/db_dependent/Utils/Datatables_Virtualshelves.t
t/db_dependent/VirtualShelves.t
t/db_dependent/XISBN.t
t/db_dependent/sysprefs.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14334] DBI fighting DBIx over Autocommit in tests

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14334

--- Comment #2 from M. Tompsett mtomp...@hotmail.com ---
Created attachment 39871
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39871action=edit
Bug 14334: t/db_dependent/Bookseller.t AutoCommit fix

TEST PLAN
--
1) git reset --hard origin/master
2) prove t/db_dependent/Bookseller.t
   -- horrible failure about transaction
3) apply this patch
4) prove t/db_dependent/Bookseller.t
   -- no issues
5) koha qa test tools.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14334] DBI fighting DBIx over Autocommit in tests

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14334

--- Comment #5 from M. Tompsett mtomp...@hotmail.com ---
Created attachment 39874
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39874action=edit
Bug 14334: t/db_dependent/Accounts.t AutoCommit fix

There is no easy way to trigger an obvious problem, as this test
uses Koha::Borrowers and other DBIx things, which may or may not
be causing it to not blow up.

TEST PLAN
-
1) apply patch
2) git diff origin/master
   -- Are the additions/subtractions similar to
  http://paste.lisp.org/display/149194?
3) run koha qa test tools

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/