[Koha-bugs] [Bug 14393] Add collection code filter to inventory

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14393

Kyle M Hall  changed:

   What|Removed |Added

 Status|Pushed to master|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14393] Add collection code filter to inventory

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14393

--- Comment #33 from Fridolin Somers  ---
Pushed to master for 22.05, thanks to everybody involved 濾

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14393] Add collection code filter to inventory

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14393

Fridolin Somers  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||22.05.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14393] Add collection code filter to inventory

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14393

Fridolin Somers  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #32 from Fridolin Somers  ---
There is actually no unit test for other filters so its OK.

We should work on more tests for inventory, and move code from pl to a module.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14393] Add collection code filter to inventory

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14393

--- Comment #31 from Kyle M Hall  ---
Created attachment 132792
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132792=edit
Bug 14393: (QA follow-up) Add template filters

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14393] Add collection code filter to inventory

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14393

Kyle M Hall  changed:

   What|Removed |Added

 Attachment #131628|0   |1
is obsolete||

--- Comment #30 from Kyle M Hall  ---
Created attachment 132791
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132791=edit
Bug 14393: Add collection code filter to inventory

This patch adds the ability to do inventory by collection.

_TEST PLAN_

Before applying:
1) Go to "Tools > Inventory/stocktaking"
2) Note that there is no "Collection code:" option

Optionally:
2b) You can create a Barcode file with a single barcode
2c) Don't select anything from "Select items you want to check" (or filter if
you know
how to filter to make it faster... doesn't matter)
2d) Click "Submit" at the bottom of the screen
2e) Note that there is no "Collection code" column in the screen output or CSV
output
(ie with/without the "Export to CSV file" box ticked before submitting)

Apply the patch.

After applying:
3) Note that there is a "Collection code" filter on the main inventory screen
4) Create a Barcode file with a single barcode for an item with a collection
and upload it using the "Choose file" button.
5) Select that item's collection code from the "Collection code" filter
6) Click "Submit"
7) Note that the screen output and the CSV output contains a "Collection code"
column
(ie with/without the "Export to CSV file" box ticked before submitting)

Signed-off-by: kelly mcelligott 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14393] Add collection code filter to inventory

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14393

Kyle M Hall  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14393] Add collection code filter to inventory

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14393

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
 QA Contact|testo...@bugs.koha-communit |k...@bywatersolutions.com
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14393] Add collection code filter to inventory

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14393

ByWater Sandboxes  changed:

   What|Removed |Added

 Attachment #131627|0   |1
is obsolete||

--- Comment #29 from ByWater Sandboxes  ---
Created attachment 131628
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131628=edit
Bug 14393 - Add collection code filter to inventory

This patch adds the ability to do inventory by collection.

_TEST PLAN_

Before applying:
1) Go to "Tools > Inventory/stocktaking"
2) Note that there is no "Collection code:" option

Optionally:
2b) You can create a Barcode file with a single barcode
2c) Don't select anything from "Select items you want to check" (or filter if
you know
how to filter to make it faster... doesn't matter)
2d) Click "Submit" at the bottom of the screen
2e) Note that there is no "Collection code" column in the screen output or CSV
output
(ie with/without the "Export to CSV file" box ticked before submitting)

Apply the patch.

After applying:
3) Note that there is a "Collection code" filter on the main inventory screen
4) Create a Barcode file with a single barcode for an item with a collection
and upload it using the "Choose file" button.
5) Select that item's collection code from the "Collection code" filter
6) Click "Submit"
7) Note that the screen output and the CSV output contains a "Collection code"
column
(ie with/without the "Export to CSV file" box ticked before submitting)

Signed-off-by: kelly mcelligott 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14393] Add collection code filter to inventory

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14393

Jessie Zairo  changed:

   What|Removed |Added

 CC||jza...@bywatersolutions.com
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14393] Add collection code filter to inventory

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14393

ByWater Sandboxes  changed:

   What|Removed |Added

 Attachment #131025|0   |1
is obsolete||

--- Comment #28 from ByWater Sandboxes  ---
Created attachment 131627
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131627=edit
Bug 14393 - Add collection code filter to inventory

This patch adds the ability to do inventory by collection.

_TEST PLAN_

Before applying:
1) Go to "Tools > Inventory/stocktaking"
2) Note that there is no "Collection code:" option

Optionally:
2b) You can create a Barcode file with a single barcode
2c) Don't select anything from "Select items you want to check" (or filter if
you know
how to filter to make it faster... doesn't matter)
2d) Click "Submit" at the bottom of the screen
2e) Note that there is no "Collection code" column in the screen output or CSV
output
(ie with/without the "Export to CSV file" box ticked before submitting)

Apply the patch.

After applying:
3) Note that there is a "Collection code" filter on the main inventory screen
4) Create a Barcode file with a single barcode for an item with a collection
and upload it using the "Choose file" button.
5) Select that item's collection code from the "Collection code" filter
6) Click "Submit"
7) Note that the screen output and the CSV output contains a "Collection code"
column
(ie with/without the "Export to CSV file" box ticked before submitting)

Signed-off-by: Jessica 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14393] Add collection code filter to inventory

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14393

Nick Clemens  changed:

   What|Removed |Added

  Attachment #44772|0   |1
is obsolete||

--- Comment #27 from Nick Clemens  ---
Created attachment 131025
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131025=edit
Bug 14393 - Add collection code filter to inventory

This patch adds the ability to do inventory by collection.

_TEST PLAN_

Before applying:
1) Go to "Tools > Inventory/stocktaking"
2) Note that there is no "Collection code:" option

Optionally:
2b) You can create a Barcode file with a single barcode
2c) Don't select anything from "Select items you want to check" (or filter if
you know
how to filter to make it faster... doesn't matter)
2d) Click "Submit" at the bottom of the screen
2e) Note that there is no "Collection code" column in the screen output or CSV
output
(ie with/without the "Export to CSV file" box ticked before submitting)

Apply the patch.

After applying:
3) Note that there is a "Collection code" filter on the main inventory screen
4) Create a Barcode file with a single barcode for an item with a collection
and upload it using the "Choose file" button.
5) Select that item's collection code from the "Collection code" filter
6) Click "Submit"
7) Note that the screen output and the CSV output contains a "Collection code"
column
(ie with/without the "Export to CSV file" box ticked before submitting)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14393] Add collection code filter to inventory

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14393

Nick Clemens  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14393] Add collection code filter to inventory

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14393

--- Comment #26 from Shanna  ---
Hello, what a beautiful idea for a patch! As a librarian, it would make my
inventory experience a thousand times better.  I am willing to learn whatever
coding and conventions necessary, and make friends with every developer on this
site, in order to learn how to implement this.  It's my first post and first
bug and I am cheering you all on.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14393] Add collection code filter to inventory

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14393

Shanna  changed:

   What|Removed |Added

 CC||sallen@coastlinelibrarynetw
   ||ork.org

--- Comment #25 from Shanna  ---
Hello, what a beautiful idea for a patch! As a librarian, it would make my
inventory experience a thousand times better.  I am willing to learn whatever
coding and conventions necessary, and make friends with every developer on this
site, in order to learn how to implement this.  It's my first post and first
bug and I am cheering you all on.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14393] Add collection code filter to inventory

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14393

Joy Nelson  changed:

   What|Removed |Added

 CC||j...@bywatersolutions.com

--- Comment #24 from Joy Nelson  ---
David-
Glad to hear this is still moving forward!  We have a library interested in
this feature.  Let us know how we can help with testing/signoffs/QA etc!

Thanks
joy


(In reply to David Cook from comment #23)
> I think I've recently ported this to 19.11, so I'll have another look at
> this soon.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14393] Add collection code filter to inventory

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14393

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14393] Add collection code filter to inventory

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14393

--- Comment #23 from David Cook  ---
I think I've recently ported this to 19.11, so I'll have another look at this
soon.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14393] Add collection code filter to inventory

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14393

hannah...@northwestu.edu changed:

   What|Removed |Added

 CC||hannah...@northwestu.edu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14393] Add collection code filter to inventory

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14393

--- Comment #22 from David Cook  ---
(In reply to Charles Farmer from comment #21)
> Merging seems to fail because of HTML filters and whatnot, pretty expected
> from a 2015 patch.

Thanks for checking, Charles. 

Looks like the patch is 9474 commits behind master. Let me try rebasing it.

Not a trivial rebase at a glance. Will have to look at this more some other
time.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14393] Add collection code filter to inventory

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14393

Charles Farmer  changed:

   What|Removed |Added

 CC||charles.far...@inlibro.com
 Status|Needs Signoff   |Patch doesn't apply

--- Comment #21 from Charles Farmer  ---
Merging seems to fail because of HTML filters and whatnot, pretty expected from
a 2015 patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14393] Add collection code filter to inventory

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14393

David Cook  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14393] Add collection code filter to inventory

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14393

--- Comment #19 from Jonathan Druart  
---
(In reply to David Cook from comment #18)
> (In reply to Katrin Fischer from comment #17)
> > You are right, it's theoretically possible... but in my opinoin not
> > recommendable. Think about features like item batch editing or any search
> > form/report that offers you a list of collections. It will cause lots of
> > inconvenience if someone does that. I think we don't need to cover this
> > possibility.
> 
> Ok. I'm fine with that. I was mostly just following the pattern that already
> existed in the script. Other things than collection code do this same check.
> Should a follow-up remove this "all framework checking" for all criteria?

I would prefer to keep it, to avoid undesired side-effects.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14393] Add collection code filter to inventory

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14393

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14393] Add collection code filter to inventory

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14393

--- Comment #20 from David Cook  ---
(In reply to Jonathan Druart from comment #19)
> I would prefer to keep it, to avoid undesired side-effects.

That also seems reasonable.

I'm happy to go with whatever QA decides in the end.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14393] Add collection code filter to inventory

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14393

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #17 from Katrin Fischer  ---
You are right, it's theoretically possible... but in my opinoin not
recommendable. Think about features like item batch editing or any search
form/report that offers you a list of collections. It will cause lots of
inconvenience if someone does that. I think we don't need to cover this
possibility.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14393] Add collection code filter to inventory

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14393

--- Comment #18 from David Cook  ---
(In reply to Katrin Fischer from comment #17)
> You are right, it's theoretically possible... but in my opinoin not
> recommendable. Think about features like item batch editing or any search
> form/report that offers you a list of collections. It will cause lots of
> inconvenience if someone does that. I think we don't need to cover this
> possibility.

Ok. I'm fine with that. I was mostly just following the pattern that already
existed in the script. Other things than collection code do this same check.
Should a follow-up remove this "all framework checking" for all criteria?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14393] Add collection code filter to inventory

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14393

--- Comment #13 from Jonathan Druart  
---
Comment on attachment 44772
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44772
Bug 14393 - Add collection code filter to inventory

Review of attachment 44772:
 --> 
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=14393=44772)
-

::: tools/inventory.pl
@@ +95,5 @@
>}
>push @authorised_value_list,@$data;
>  }
> +
> +my $collection_authorised_value = 
> C4::Koha::GetAuthValCode("items.ccode", $fwkcode);

Does it really necessary to check all frameworks?
Isn't be enough to get the default one?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14393] Add collection code filter to inventory

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14393

--- Comment #14 from David Cook  ---
(In reply to Frédéric Demians from comment #12)
> Forget this. I've added a [% IF %] in your patch that I've signed off in
> order to not display this column when unnecessary.

Cheers, Frédéric :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14393] Add collection code filter to inventory

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14393

--- Comment #16 from David Cook  ---
^ that last comment was for Jonathan. Perhaps I should've just replied to the
comment rather than on the splinter review...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14393] Add collection code filter to inventory

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14393

--- Comment #15 from David Cook  ---
Comment on attachment 44772
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44772
Bug 14393 - Add collection code filter to inventory

Review of attachment 44772:
 --> 
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=14393=44772)
-

::: tools/inventory.pl
@@ +95,5 @@
>}
>push @authorised_value_list,@$data;
>  }
> +
> +my $collection_authorised_value = 
> C4::Koha::GetAuthValCode("items.ccode", $fwkcode);

In practice, it might be enough to get the default one, but in theory you could
use different authorized value categories than "CCODE" for "item.ccode"
depending on the framework of the biblio to which an item is attached.

Originally, I just used the default framework, but then realized that it wasn't
necessarily comprehensive enough. In practice, I don't know if anyone would map
multiple categories to "item.ccode", but it is theoretically possible. You
might only allow certain collections for a certain framework. Framework A might
use "CCODE" which refers to textual collections while Framework B might use
"CCODE2"which refers to audiovisual collections. That would probably be
madness, but it's possible madness.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14393] Add collection code filter to inventory

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14393

--- Comment #12 from Frédéric Demians  ---
(In reply to Frédéric Demians from comment #10)

> I see that in the inventory result table, there is a new columun 'Collection
> code' which is displayed even when there isn't CCODE AV. Do you think there
> is a way to display or not this column?

Forget this. I've added a [% IF %] in your patch that I've signed off in order
to not display this column when unnecessary.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14393] Add collection code filter to inventory

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14393

Frédéric Demians  changed:

   What|Removed |Added

 CC||frede...@tamil.fr

--- Comment #10 from Frédéric Demians  ---
> Could you give that a look? That should be a lot better now... thanks for
> looking at this bug!

Comment 6 is solved. When items.ccode isn't linked to a populated AV list, the
collection code selection list isn't displayed in Inventory.

I see that in the inventory result table, there is a new columun 'Collection
code' which is displayed even when there isn't CCODE AV. Do you think there is
a way to display or not this column?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14393] Add collection code filter to inventory

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14393

Frédéric Demians  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14393] Add collection code filter to inventory

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14393

Frédéric Demians  changed:

   What|Removed |Added

  Attachment #40958|0   |1
is obsolete||

--- Comment #11 from Frédéric Demians  ---
Created attachment 44772
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44772=edit
Bug 14393 - Add collection code filter to inventory

This patch adds the ability to do inventory by collection.

_TEST PLAN_

Before applying:
1) Go to "Tools > Inventory/stocktaking"
2) Note that there is no "Collection code:" option

Optionally:
2b) You can create a Barcode file with a single barcode
2c) Don't select anything from "Select items you want to check" (or filter if
you know
how to filter to make it faster... doesn't matter)
2d) Click "Submit" at the bottom of the screen
2e) Note that there is no "Collection code" column in the screen output or CSV
output
(ie with/without the "Export to CSV file" box ticked before submitting)

Apply the patch.

After applying:
3) Note that there is a "Collection code" filter on the main inventory screen
4) Create a Barcode file with a single barcode for an item with a collection
and upload it using the "Choose file" button.
5) Select that item's collection code from the "Collection code" filter
6) Click "Submit"
7) Note that the screen output and the CSV output contains a "Collection code"
column
(ie with/without the "Export to CSV file" box ticked before submitting)

Note: Collection code isn't displayed on Inventory filter & result if ccode
isn't used in items.

Signed-off-by: Frederic Demians 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14393] Add collection code filter to inventory

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14393

David Cook dc...@prosentient.com.au changed:

   What|Removed |Added

  Attachment #40255|0   |1
is obsolete||

--- Comment #8 from David Cook dc...@prosentient.com.au ---
Created attachment 40958
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40958action=edit
Bug 14393 - Add collection code filter to inventory

This patch adds the ability to do inventory by collection.

_TEST PLAN_

Before applying:
1) Go to Tools  Inventory/stocktaking
2) Note that there is no Collection code: option

Optionally:
2b) You can create a Barcode file with a single barcode
2c) Don't select anything from Select items you want to check (or filter if
you know
how to filter to make it faster... doesn't matter)
2d) Click Submit at the bottom of the screen
2e) Note that there is no Collection code column in the screen output or CSV
output
(ie with/without the Export to CSV file box ticked before submitting)

Apply the patch.

After applying:
3) Note that there is a Collection code filter on the main inventory screen
4) Create a Barcode file with a single barcode for an item with a collection
and upload it using the Choose file button.
5) Select that item's collection code from the Collection code filter
6) Click Submit
7) Note that the screen output and the CSV output contains a Collection code
column
(ie with/without the Export to CSV file box ticked before submitting)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14393] Add collection code filter to inventory

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14393

David Cook dc...@prosentient.com.au changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14393] Add collection code filter to inventory

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14393

--- Comment #9 from David Cook dc...@prosentient.com.au ---
(In reply to Jonathan Druart from comment #6)
 Some libraries don't use this ccode value, it's the case in my installation.
 I this case, the dropdown list is wrongly populated with all authorized
 values!

Could you give that a look? That should be a lot better now... thanks for
looking at this bug!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14393] Add collection code filter to inventory

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14393

--- Comment #6 from Jonathan Druart jonathan.dru...@biblibre.com ---
(In reply to David Cook from comment #5)
 (In reply to Jonathan Druart from comment #4)
  David,
  
  In my dev installation, items.ccode is not mapped.
  Which makes the dropdown list populated with all my authorized values :)
  You certainly need to care about the value of AdvancedSearchTypes, you will
  have to propose item type too.
  
  Marked as Failed QA.
 
 I'm not sure what you mean by You certainly need to care about the value of
 AdvancedSearchTypes, you will have to propose item type too. Could you
 clarify?

Some libraries don't use this ccode value, it's the case in my installation.
I this case, the dropdown list is wrongly populated with all authorized values!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14393] Add collection code filter to inventory

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14393

--- Comment #7 from David Cook dc...@prosentient.com.au ---
(In reply to Jonathan Druart from comment #6)
 Some libraries don't use this ccode value, it's the case in my installation.
 I this case, the dropdown list is wrongly populated with all authorized
 values!

Cool beans. I'll look into it :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14393] Add collection code filter to inventory

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14393

--- Comment #5 from David Cook dc...@prosentient.com.au ---
(In reply to Jonathan Druart from comment #4)
 David,
 
 In my dev installation, items.ccode is not mapped.
 Which makes the dropdown list populated with all my authorized values :)
 You certainly need to care about the value of AdvancedSearchTypes, you will
 have to propose item type too.
 
 Marked as Failed QA.

I'm not sure what you mean by You certainly need to care about the value of
AdvancedSearchTypes, you will have to propose item type too. Could you
clarify?

I'll look into the problem with the mapping in the meantime though :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14393] Add collection code filter to inventory

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14393

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 CC||jonathan.dru...@biblibre.co
   ||m
 Status|Signed Off  |Failed QA

--- Comment #4 from Jonathan Druart jonathan.dru...@biblibre.com ---
David,

In my dev installation, items.ccode is not mapped.
Which makes the dropdown list populated with all my authorized values :)
You certainly need to care about the value of AdvancedSearchTypes, you will
have to propose item type too.

Marked as Failed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14393] Add collection code filter to inventory

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14393

--- Comment #3 from Marc Véron ve...@veron.ch ---
Created attachment 40255
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40255action=edit
[Signed-off] Bug 14393 - Add collection code filter to inventory

This patch adds the ability to do inventory by collection.

_TEST PLAN_

Before applying:
1) Go to Tools  Inventory/stocktaking
2) Note that there is no Collection code: option

Optionally:
2b) You can create a Barcode file with a single barcode
2c) Don't select anything from Select items you want to check (or filter if
you know
how to filter to make it faster... doesn't matter)
2d) Click Submit at the bottom of the screen
2e) Note that there is no Collection code column in the screen output or CSV
output
(ie with/without the Export to CSV file box ticked before submitting)

Apply the patch.

After applying:
3) Note that there is a Collection code filter on the main inventory screen
4) Create a Barcode file with a single barcode for an item with a collection
and upload it using the Choose file button.
5) Select that item's collection code from the Collection code filter
6) Click Submit
7) Note that the screen output and the CSV output contains a Collection code
column
(ie with/without the Export to CSV file box ticked before submitting)

Followed test plan. Works as expected.
Signed-off-by: Marc Véron ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14393] Add collection code filter to inventory

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14393

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14393] Add collection code filter to inventory

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14393

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

 CC||ve...@veron.ch
  Attachment #40209|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14393] Add collection code filter to inventory

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14393

--- Comment #2 from David Cook dc...@prosentient.com.au ---
Created attachment 40209
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40209action=edit
Bug 14393 - Add collection code filter to inventory

This patch adds the ability to do inventory by collection.

_TEST PLAN_

Before applying:
1) Go to Tools  Inventory/stocktaking
2) Note that there is no Collection code: option

Optionally:
2b) You can create a Barcode file with a single barcode
2c) Don't select anything from Select items you want to check (or filter if
you know
how to filter to make it faster... doesn't matter)
2d) Click Submit at the bottom of the screen
2e) Note that there is no Collection code column in the screen output or CSV
output
(ie with/without the Export to CSV file box ticked before submitting)

Apply the patch.

After applying:
3) Note that there is a Collection code filter on the main inventory screen
4) Create a Barcode file with a single barcode for an item with a collection
and upload it using the Choose file button.
5) Select that item's collection code from the Collection code filter
6) Click Submit
7) Note that the screen output and the CSV output contains a Collection code
column
(ie with/without the Export to CSV file box ticked before submitting)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14393] Add collection code filter to inventory

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14393

David Cook dc...@prosentient.com.au changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14393] Add collection code filter to inventory

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14393

Indranil Das Gupta indr...@gmail.com changed:

   What|Removed |Added

 CC||indr...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14393] Add collection code filter to inventory

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14393

David Cook dc...@prosentient.com.au changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |dc...@prosentient.com.au

--- Comment #1 from David Cook dc...@prosentient.com.au ---
I think that this should actually be fairly straightforward.

I should have a patch for this tomorrow...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/