[Koha-bugs] [Bug 14523] Google jackets being blocked when OPAC using HTTPS

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14523

--- Comment #15 from Amit  ---
How google-jackets.js can be used to fetch images in php

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14523] Google jackets being blocked when OPAC using HTTPS

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14523

Amit  changed:

   What|Removed |Added

 CC||amitdangwal@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14523] Google jackets being blocked when OPAC using HTTPS

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14523

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||17137


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17137
[Bug 17137] Omnibus: Always use SSL when referencing external sources
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14523] Google jackets being blocked when OPAC using HTTPS

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14523

Nicholas van Oudtshoorn  changed:

   What|Removed |Added

 CC||vano...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14523] Google jackets being blocked when OPAC using HTTPS

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14523

Kyle M Hall  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||k...@bywatersolutions.com

--- Comment #14 from Kyle M Hall  ---
Pushed to master! Should be in Koha 3.24, thanks Barry!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14523] Google jackets being blocked when OPAC using HTTPS

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14523

Owen Leonard  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com

--- Comment #13 from Owen Leonard  ---
*** Bug 13527 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14523] Google jackets being blocked when OPAC using HTTPS

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14523

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #47511|0   |1
is obsolete||

--- Comment #12 from Jonathan Druart  
---
Created attachment 47544
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47544=edit
Bug 14523 - Google jackets being blocked when OPAC using HTTPS

This patch changes the Google jackets URL to use HTTPS instead of HTTP.

Test Plan:
1) Enable Google Jackets
2) Ensure the Koha OPAC instance is configued to use HTTPS
3) Confirm Google jackets display correctly.

Signed-off-by: Frédéric Demians 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14523] Google jackets being blocked when OPAC using HTTPS

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14523

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14523] Google jackets being blocked when OPAC using HTTPS

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14523

Frédéric Demians  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14523] Google jackets being blocked when OPAC using HTTPS

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14523

--- Comment #6 from Frédéric Demians  ---
Created attachment 47501
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47501=edit
Bug 14523 - Google jackets being blocked when OPAC using HTTPS

Get the protocol of the current URL. This results is the correct prefix
being used to serve the google jackets regarless of koha apache server
setup.

Signed-off-by: Frédéric Demians 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14523] Google jackets being blocked when OPAC using HTTPS

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14523

Frédéric Demians  changed:

   What|Removed |Added

  Attachment #47500|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14523] Google jackets being blocked when OPAC using HTTPS

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14523

Barry Cannon  changed:

   What|Removed |Added

  Attachment #47385|0   |1
is obsolete||

--- Comment #5 from Barry Cannon  ---
Created attachment 47500
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47500=edit
Corrects problem with https sites accessing google jackets

This patch adds prefix variable to the google-jackets.js file. This detects the
current URL prefix and uses that to connect to google to retrieve images.

Test Plan:
1) Enable Google Jackets
2) Ensure the Koha OPAC instance is configued to use HTTPS
3) Confirm Google jackets display correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14523] Google jackets being blocked when OPAC using HTTPS

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14523

--- Comment #9 from Barry Cannon  ---
My very first patch on this thread, 40988, did exactly that! Can that be
re-used?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14523] Google jackets being blocked when OPAC using HTTPS

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14523

Frédéric Demians  changed:

   What|Removed |Added

 Status|Signed Off  |In Discussion

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14523] Google jackets being blocked when OPAC using HTTPS

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14523

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #7 from Jonathan Druart  
---
On bug 14571, we always use https for the amazon images, it would make sense to
do the same here.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14523] Google jackets being blocked when OPAC using HTTPS

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14523

Jonathan Druart  changed:

   What|Removed |Added

Version|3.20|master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14523] Google jackets being blocked when OPAC using HTTPS

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14523

Jonathan Druart  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=14571

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14523] Google jackets being blocked when OPAC using HTTPS

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14523

--- Comment #8 from Frédéric Demians  ---
(In reply to Jonathan Druart from comment #7)
> On bug 14571, we always use https for the amazon images, it would make sense
> to do the same here.

You're correct. If Google Books is requested exclusively in https, it works. If
the OPAC is HTTP, there isn't 'mixed content' error. And if the OPAC is HTTPS,
there isn't anymore 'mixed content' error since OPAC and Google Books are
requested with https.

Barry: would you mind modifying your patch to request Google Books in https,
whatever the OPAC protocol? I can do it if you prefer.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14523] Google jackets being blocked when OPAC using HTTPS

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14523

--- Comment #11 from Frédéric Demians  ---
(In reply to Barry Cannon from comment #9)
> My very first patch on this thread, 40988, did exactly that! Can that be
> re-used?

Yes! Done.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14523] Google jackets being blocked when OPAC using HTTPS

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14523

Frédéric Demians  changed:

   What|Removed |Added

 Status|In Discussion   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14523] Google jackets being blocked when OPAC using HTTPS

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14523

Frédéric Demians  changed:

   What|Removed |Added

  Attachment #47501|0   |1
is obsolete||

--- Comment #10 from Frédéric Demians  ---
Created attachment 47511
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47511=edit
Bug 14523 - Google jackets being blocked when OPAC using HTTPS

This patch changes the Google jackets URL to use HTTPS instead of HTTP.

Signed-off-by: Frédéric Demians 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14523] Google jackets being blocked when OPAC using HTTPS

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14523

Barry Cannon  changed:

   What|Removed |Added

  Attachment #40988|0   |1
is obsolete||
 CC||b...@interleaf.ie

--- Comment #3 from Barry Cannon  ---
Created attachment 47385
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47385=edit
Checks current URL and connects to appropriate google resource

This patch adds prefix variable to the google-jackets.js file. This detects the
current URL prefix and uses that to connect to google to retrieve images.

Test Plan:
1) Enable Google Jackets
2) Ensure the Koha OPAC instance is configued to use HTTPS
3) Confirm Google jackets display correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14523] Google jackets being blocked when OPAC using HTTPS

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14523

--- Comment #4 from Frédéric Demians  ---
Seems OK to me, except that you're creating a 'prefix' variable which pollutes
the Javascript global namespace. Your variable name could potentially be used
elsewhere by another JS portion of code. You should rather use directly
location.protocol.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14523] Google jackets being blocked when OPAC using HTTPS

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14523

Frédéric Demians  changed:

   What|Removed |Added

 CC||frede...@tamil.fr

--- Comment #2 from Frédéric Demians  ---
Wouldn't it better to detect in JavaScript the protocol used to serve the page?
using window.location.protocol.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14523] Google jackets being blocked when OPAC using HTTPS

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14523

Zeno Tajoli  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14523] Google jackets being blocked when OPAC using HTTPS

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14523

Barry Cannon b...@interleaf.ie changed:

   What|Removed |Added

   Assignee|oleon...@myacpl.org |b...@interleaf.ie
 Status|NEW |Needs Signoff

--- Comment #1 from Barry Cannon b...@interleaf.ie ---
Created attachment 40988
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40988action=edit
Change Google books URL from HTTP to HTTPS

When Koha is using HTTPS the Google books (jackets) content isn't served up.
The simplest solution is to change the URL to HTTPS as almost all clients will
have access to the HTTPS resource. This bug changes the google-jacket.js file
to use HTTPS.

Test Plan:
1) Enable Google Jackets
2) Ensure the Koha OPAC instance is configued to use HTTPS
3) Confirm Google jackets display correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/