[Koha-bugs] [Bug 14670] add 'cite' option to detail page in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670 Magnus Enger changed: What|Removed |Added CC||mag...@libriotech.no -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14670] add 'cite' option to detail page in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670 Koha collecto changed: What|Removed |Added CC||k...@collecto.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14670] add 'cite' option to detail page in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670 ByWater Sandboxes changed: What|Removed |Added Attachment #166474|0 |1 is obsolete|| --- Comment #47 from ByWater Sandboxes --- Created attachment 167535 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167535&action=edit Bug 14670: Fix tests and import Sponsored-by: Orex Digital Signed-off-by: alexandre Signed-off-by: hugo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14670] add 'cite' option to detail page in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670 ByWater Sandboxes changed: What|Removed |Added Attachment #161606|0 |1 is obsolete|| --- Comment #46 from ByWater Sandboxes --- Created attachment 167534 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167534&action=edit Bug 14670: Use 260 if 264 is empty Sponsored-by: Orex Digital Signed-off-by: hugo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14670] add 'cite' option to detail page in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670 ByWater Sandboxes changed: What|Removed |Added Attachment #161605|0 |1 is obsolete|| --- Comment #45 from ByWater Sandboxes --- Created attachment 167533 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167533&action=edit Bug 14670: Deal with empty publicatoin date Sponsored-by: Orex Digital Signed-off-by: hugo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14670] add 'cite' option to detail page in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670 ByWater Sandboxes changed: What|Removed |Added Attachment #161604|0 |1 is obsolete|| --- Comment #44 from ByWater Sandboxes --- Created attachment 167532 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167532&action=edit Bug 14670: Move modal code to an include file Also add an icon for the "Cite" entry. Sponsored-by: Orex Digital Signed-off-by: hugo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14670] add 'cite' option to detail page in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670 ByWater Sandboxes changed: What|Removed |Added Attachment #161603|0 |1 is obsolete|| --- Comment #43 from ByWater Sandboxes --- Created attachment 167531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167531&action=edit Bug 14670: fix ControlStructures::ProhibitMutatingListFunctions Signed-off-by: hugo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14670] add 'cite' option to detail page in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670 ByWater Sandboxes changed: What|Removed |Added Attachment #161602|0 |1 is obsolete|| --- Comment #42 from ByWater Sandboxes --- Created attachment 167530 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167530&action=edit Bug 14670: Fix earlier declaration in same scope Signed-off-by: hugo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14670] add 'cite' option to detail page in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670 ByWater Sandboxes changed: What|Removed |Added Attachment #161601|0 |1 is obsolete|| --- Comment #41 from ByWater Sandboxes --- Created attachment 167529 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167529&action=edit Bug 14670: add test for C4::Record::marc2cites Signed-off-by: hugo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14670] add 'cite' option to detail page in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670 ByWater Sandboxes changed: What|Removed |Added Attachment #161600|0 |1 is obsolete|| --- Comment #40 from ByWater Sandboxes --- Created attachment 167528 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=167528&action=edit Bug 14670: Add Cite-option to detail page in OPAC Adds a "cite" option in the tools menu in OPAC detail page for easy citations. Test plan: 1. Apply this patch 2. Got to OPAC detail page 3. In the tools menu to the right, click the new "Cite" link 4. A modal should appear with four different citation styles (APA, Chicago, Harvard, MLA) Sponsored-by: Regionbibliotek Halland / County library of Halland Signed-off-by: Nicole Engard Signed-off-by: hugo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14670] add 'cite' option to detail page in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670 Alexandre changed: What|Removed |Added Attachment #161607|0 |1 is obsolete|| --- Comment #39 from Alexandre --- Created attachment 166474 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166474&action=edit Bug 14670: Fix tests and import Sponsored-by: Orex Digital Signed-off-by: alexandre -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14670] add 'cite' option to detail page in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670 Alexandre changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14670] add 'cite' option to detail page in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670 --- Comment #38 from Jonathan Druart --- Thanks, David. I am actually expecting a signoff from the sponsor to make sure they are happy with the behaviour. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14670] add 'cite' option to detail page in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14670] add 'cite' option to detail page in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #37 from David Nind --- The patches still applied and everything looks OK to me. Would people want a copy button next to each citation? Although easy enough to select and copy. Wasn't sure whether this should be signed off, or whether you would like more extensive feedback. As I'm not an academic, or familiar with the citation requirements, I'm probably not the best person to provide it! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14670] add 'cite' option to detail page in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670 Jonathan Druart changed: What|Removed |Added CC||ha...@orex.es -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14670] add 'cite' option to detail page in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670 Jonathan Druart changed: What|Removed |Added Assignee|mar...@bugs.koha-community. |jonathan.druart+koha@gmail. |org.xinxidi.net |com --- Comment #36 from Jonathan Druart --- Patches rebased and added some follow-ups. I think this is not ready yet. The code in C4::Record needs to be beautify a bit and more tests. Also I am wondering if we should not have a syspref. Patches for discussion, get feedback and revive this bug. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14670] add 'cite' option to detail page in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670 --- Comment #35 from Jonathan Druart --- Created attachment 161607 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161607&action=edit Bug 14670: Fix tests and import Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14670] add 'cite' option to detail page in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670 --- Comment #34 from Jonathan Druart --- Created attachment 161606 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161606&action=edit Bug 14670: Use 260 if 264 is empty Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14670] add 'cite' option to detail page in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670 --- Comment #33 from Jonathan Druart --- Created attachment 161605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161605&action=edit Bug 14670: Deal with empty publicatoin date Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14670] add 'cite' option to detail page in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670 --- Comment #32 from Jonathan Druart --- Created attachment 161604 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161604&action=edit Bug 14670: Move modal code to an include file Also add an icon for the "Cite" entry. Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14670] add 'cite' option to detail page in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670 --- Comment #31 from Jonathan Druart --- Created attachment 161603 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161603&action=edit Bug 14670: fix ControlStructures::ProhibitMutatingListFunctions -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14670] add 'cite' option to detail page in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670 --- Comment #30 from Jonathan Druart --- Created attachment 161602 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161602&action=edit Bug 14670: Fix earlier declaration in same scope -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14670] add 'cite' option to detail page in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670 --- Comment #29 from Jonathan Druart --- Created attachment 161601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161601&action=edit Bug 14670: add test for C4::Record::marc2cites -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14670] add 'cite' option to detail page in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670 Jonathan Druart changed: What|Removed |Added Attachment #75679|0 |1 is obsolete|| Attachment #75680|0 |1 is obsolete|| Attachment #75681|0 |1 is obsolete|| Attachment #75682|0 |1 is obsolete|| Attachment #75683|0 |1 is obsolete|| --- Comment #28 from Jonathan Druart --- Created attachment 161600 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161600&action=edit Bug 14670: Add Cite-option to detail page in OPAC Adds a "cite" option in the tools menu in OPAC detail page for easy citations. Test plan: 1. Apply this patch 2. Got to OPAC detail page 3. In the tools menu to the right, click the new "Cite" link 4. A modal should appear with four different citation styles (APA, Chicago, Harvard, MLA) Sponsored-by: Regionbibliotek Halland / County library of Halland Signed-off-by: Nicole Engard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14670] add 'cite' option to detail page in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14670] add 'cite' option to detail page in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670 Father Vlasie changed: What|Removed |Added CC||fv@spots.school -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14670] add 'cite' option to detail page in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670 Carl changed: What|Removed |Added CC||ct...@hcc.edu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14670] add 'cite' option to detail page in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670 --- Comment #27 from Owen Leonard --- I rebased(In reply to Viktor Sarge from comment #21) > We´re not currently working on this. I have attached rebased patches in case someone wants to pick this up. It certainly looks like it's close. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14670] add 'cite' option to detail page in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670 --- Comment #26 from Owen Leonard --- Created attachment 75683 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75683&action=edit Bug 14670: fix ControlStructures::ProhibitMutatingListFunctions -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14670] add 'cite' option to detail page in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670 --- Comment #24 from Owen Leonard --- Created attachment 75681 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75681&action=edit Bug 14670: add test for C4::Record::marc2cites -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14670] add 'cite' option to detail page in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670 --- Comment #25 from Owen Leonard --- Created attachment 75682 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75682&action=edit Bug 14670: Fix earlier declaration in same scope -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14670] add 'cite' option to detail page in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670 --- Comment #23 from Owen Leonard --- Created attachment 75680 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75680&action=edit Bug 14670: add related css changes to opac.less -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14670] add 'cite' option to detail page in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670 Owen Leonard changed: What|Removed |Added Attachment #43919|0 |1 is obsolete|| Attachment #43920|0 |1 is obsolete|| Attachment #43921|0 |1 is obsolete|| Attachment #43922|0 |1 is obsolete|| Attachment #43923|0 |1 is obsolete|| Attachment #43924|0 |1 is obsolete|| --- Comment #22 from Owen Leonard --- Created attachment 75679 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75679&action=edit Bug 14670: Add Cite-option to detail page in OPAC Adds a "cite" option in the tools menu in OPAC detail page for easy citations. Test plan: 1. Apply this patch 2. Got to OPAC detail page 3. In the tools menu to the right, click the new "Cite" link 4. A modal should appear with four different citation styles (APA, Chicago, Harvard, MLA) Sponsored-by: Regionbibliotek Halland / County library of Halland Signed-off-by: Nicole Engard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14670] add 'cite' option to detail page in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670 Owen Leonard changed: What|Removed |Added Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14670] add 'cite' option to detail page in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670 Marc Véron changed: What|Removed |Added CC||ve...@veron.ch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14670] add 'cite' option to detail page in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670 --- Comment #21 from Viktor Sarge --- (In reply to Aleisha Amohia from comment #19) > I'm not sure why this has been marked Failed QA - just tested and works > well. I think the only thing it needs is an icon in the menu like the other > menu options have! Anyone still working on this? We´re not currently working on this. There´s still a few hundred developer hours left in our project, but for now we'll have to focus on things that have higher priority. Anyone is welcome to take it further, but I'll keep following the thread and at least keep it in mind if we should have developer hours left once we get to lower priority development. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14670] add 'cite' option to detail page in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670 --- Comment #20 from Katrin Fischer --- Hi Aleisha, have you seen my comment#11 with the examples? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14670] add 'cite' option to detail page in OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670 Aleisha Amohia changed: What|Removed |Added CC||aleishaamo...@hotmail.com --- Comment #19 from Aleisha Amohia --- I'm not sure why this has been marked Failed QA - just tested and works well. I think the only thing it needs is an icon in the menu like the other menu options have! Anyone still working on this? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14670] add 'cite' option to detail page in OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670 Viktor Sarge changed: What|Removed |Added CC||viktor.sarge@regionhalland. ||se --- Comment #18 from Viktor Sarge --- Thanks for all the feedback and help! We sort of hoped that this would be more of a good "warm up" patch and with time running out for Martin in our project I have to point him in other directions so we're abandoning this one. We may be able to pick it up later, but I don't dare to make any such promises. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14670] add 'cite' option to detail page in OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670 Katrin Fischer changed: What|Removed |Added Attachment #43829|0 |1 is obsolete|| --- Comment #16 from Katrin Fischer --- Created attachment 43923 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43923&action=edit Bug 14670: fix ControlStructures::ProhibitMutatingListFunctions -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14670] add 'cite' option to detail page in OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670 --- Comment #17 from Katrin Fischer --- Created attachment 43924 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43924&action=edit Bug 14670: QA follow-up: Regenerated opac.css The first patch originally contained the changes opac.css. I removed the file to fix the conflict. This patch readds the opac.css changes generated from the changes to the .less file. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14670] add 'cite' option to detail page in OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670 Katrin Fischer changed: What|Removed |Added Attachment #43771|0 |1 is obsolete|| --- Comment #14 from Katrin Fischer --- Created attachment 43921 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43921&action=edit Bug 14670: add test for C4::Record::marc2cites -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14670] add 'cite' option to detail page in OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670 Katrin Fischer changed: What|Removed |Added Attachment #43770|0 |1 is obsolete|| --- Comment #13 from Katrin Fischer --- Created attachment 43920 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43920&action=edit Bug 14670: add related css changes to opac.less -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14670] add 'cite' option to detail page in OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670 Katrin Fischer changed: What|Removed |Added Attachment #43828|0 |1 is obsolete|| --- Comment #15 from Katrin Fischer --- Created attachment 43922 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43922&action=edit Bug 14670: Fix earlier declaration in same scope -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14670] add 'cite' option to detail page in OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670 Katrin Fischer changed: What|Removed |Added Attachment #43508|0 |1 is obsolete|| --- Comment #12 from Katrin Fischer --- Created attachment 43919 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43919&action=edit Bug 14670: Add Cite-option to detail page in OPAC Adds a "cite" option in the tools menu in OPAC detail page for easy citations. Test plan: 1. Apply this patch 2. Got to OPAC detail page 3. In the tools menu to the right, click the new "Cite" link 4. A modal should appear with four different citation styles (APA, Chicago, Harvard, MLA) Sponsored-by: Regionbibliotek Halland / County library of Halland Signed-off-by: Nicole Engard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14670] add 'cite' option to detail page in OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #11 from Katrin Fischer ---
I don't feel like this is ready to be pushed quite yet. I will give some
examples:
1) If a record (serials?) don't have a publication year, the styles will look
like this:
APA
(). Handelsblatt. Düsseldorf: Verl.-Gruppe Handelsblatt.
Chicago
. Handelsblatt. Düsseldorf: Verl.-Gruppe Handelsblatt.
Harvard
(). Handelsblatt. Düsseldorf: Verl.-Gruppe Handelsblatt.
MLA
Handelsblatt. Düsseldorf: Verl.-Gruppe Handelsblatt. .
So it doesn't cover for the case the publication year doesn't exist in the
record.
Another case are articles - the citation will miss the host item information,
which is very vital for those:
APA
Schweizer K., . (2010). 100 Jahre Internationaler Frauentag. : .
Chicago
Schweizer Karl, . 2010. 100 Jahre Internationaler Frauentag. : .
Harvard
Schweizer K., . (2010). 100 Jahre Internationaler Frauentag. : .
MLA
Schweizer Karl, . 100 Jahre Internationaler Frauentag. : . 2010.
I think this needs more testing with different type of media.
Also one small thing, that I had fixed for a follow-up, but will put here as a
comment now:
-place => $record->subfield("260", "a") || "",
+place => $record->subfield("264", "a") ||
$record->subfield("260", "a") || "",
publisher => $record->subfield("264", "b") ||
$record->subfield("260", "b") || "",
Last but not least: I am reattaching the patches with a follow up taking care
of a conflict in the opac.css. I have removed it from the first patch and put
the fixed file into a separate patch.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14670] add 'cite' option to detail page in OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670 Martin Stenberg changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14670] add 'cite' option to detail page in OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670 --- Comment #10 from Martin Stenberg --- Created attachment 43829 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43829&action=edit Bug 14670: fix ControlStructures::ProhibitMutatingListFunctions -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14670] add 'cite' option to detail page in OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670 --- Comment #9 from Martin Stenberg --- Created attachment 43828 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43828&action=edit Bug 14670: Fix earlier declaration in same scope -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14670] add 'cite' option to detail page in OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670 --- Comment #8 from Martin Stenberg --- Sorry about that, didn't know about the QA test tool. Issues are fixed, attaching two patches below. What is wrong with the css/less? Is it something introduced with any of the 14670 patches? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14670] add 'cite' option to detail page in OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #7 from Jonathan Druart --- Please launch the QA script before submitting patches: FAIL C4/Record.pm FAIL critic # ControlStructures::ProhibitMutatingListFunctions: Got 1 violation(s). FAIL valid "my" variable @authors masks earlier declaration in same scope use perl -wc and perlcritic to get more info. There is something wrong with the css/less files, but it already exists on master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14670] add 'cite' option to detail page in OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Status|Failed QA |Signed Off --- Comment #6 from Katrin Fischer --- Hi Martin, it's usually ok to switch back to signed off once you have provided patches fixing the QA issues - this way it will get reviewed again. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14670] add 'cite' option to detail page in OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670 --- Comment #5 from Martin Stenberg --- Created attachment 43771 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43771&action=edit Bug 14670: add test for C4::Record::marc2cites -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14670] add 'cite' option to detail page in OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670 --- Comment #4 from Martin Stenberg --- Created attachment 43770 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43770&action=edit Bug 14670: add related css changes to opac.less -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14670] add 'cite' option to detail page in OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Failed QA CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #3 from Jonathan Druart --- QA comments: 1/ New subroutines have to be covered by tests 2/ You should provide the related change for opac.less Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14670] add 'cite' option to detail page in OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670 Nicole C. Engard changed: What|Removed |Added Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14670] add 'cite' option to detail page in OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670 Nicole C. Engard changed: What|Removed |Added Attachment #42971|0 |1 is obsolete|| --- Comment #2 from Nicole C. Engard --- Created attachment 43508 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43508&action=edit Bug 14670: Add Cite-option to detail page in OPAC Adds a "cite" option in the tools menu in OPAC detail page for easy citations. Test plan: 1. Apply this patch 2. Got to OPAC detail page 3. In the tools menu to the right, click the new "Cite" link 4. A modal should appear with four different citation styles (APA, Chicago, Harvard, MLA) Sponsored-by: Regionbibliotek Halland / County library of Halland Signed-off-by: Nicole Engard I love it, I'd recommend adding an icon to the menu next to it, but this patch works as described so I'm signing off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14670] add 'cite' option to detail page in OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670 Nicole C. Engard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14670] add 'cite' option to detail page in OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670 Martin Stenberg changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14670] add 'cite' option to detail page in OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670 --- Comment #1 from Martin Stenberg --- Created attachment 42971 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42971&action=edit Bug 14670: Add Cite-option to detail page in OPAC Adds a "cite" option in the tools menu in OPAC detail page for easy citations. Test plan: 1. Apply this patch 2. Got to OPAC detail page 3. In the tools menu to the right, click the new "Cite" link 4. A modal should appear with four different citation styles (APA, Chicago, Harvard, MLA) Sponsored-by: Regionbibliotek Halland / County library of Halland -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14670] add 'cite' option to detail page in OPAC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14670 Martin Stenberg changed: What|Removed |Added Status|NEW |ASSIGNED CC||mar...@bugs.koha-community. ||org.xinxidi.net Assignee|oleon...@myacpl.org |mar...@bugs.koha-community. ||org.xinxidi.net -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
