[Koha-bugs] [Bug 14699] Intranet search history issues due to DataTables pagination

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14699

Claes  changed:

   What|Removed |Added

 CC||claes.eriks...@vti.se

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14699] Intranet search history issues due to DataTables pagination

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14699

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de
 Status|Pushed to Master|Pushed to Stable

--- Comment #17 from Katrin Fischer  ---
This patch has been pushed to 16.11.x, will be in 16.11.01!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14699] Intranet search history issues due to DataTables pagination

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14699

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
 Status|Passed QA   |Pushed to Master

--- Comment #16 from Kyle M Hall  ---
Pushed to master for 17.05, thanks Julian!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14699] Intranet search history issues due to DataTables pagination

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14699

--- Comment #15 from Jonathan Druart  
---
Created attachment 57766
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57766=edit
Bug 14699: Reword "Select all/Clear all" and change their behaviour

"Select all" -> "Select all visible rows"
"Clear all" -> "Clear selection on visible rows"

+ fix the bug where the Delete link was visually enabled only if you
checked a box in the first page (now every checkbox enable the link)

Signed-off-by: Owen Leonard 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14699] Intranet search history issues due to DataTables pagination

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14699

--- Comment #14 from Jonathan Druart  
---
Created attachment 57765
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57765=edit
Bug 14699: Show number of selected searches in search history

With the number displayed, it should remove the ambiguity about what
"Select all" and "Clear all" do.
The number is repeated in the "Delete" confirmation dialog.

Signed-off-by: Owen Leonard 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14699] Intranet search history issues due to DataTables pagination

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14699

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14699] Intranet search history issues due to DataTables pagination

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14699

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #42330|0   |1
is obsolete||
  Attachment #57684|0   |1
is obsolete||
  Attachment #57685|0   |1
is obsolete||

--- Comment #13 from Jonathan Druart  
---
Created attachment 57764
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57764=edit
Bug 14699: Fix intranet search history issues due to pagination

DataTables removes hidden rows from the DOM. Because of that, "Select
all", "Clear all" and the form submission don't work correctly
(basically they act only on the currently displayed page).

This patch fixes just that.

Test plan:
1/ Go to your search history page
2/ Make you sure you have at least 21 entries in your search history. If
not, do some searches and come back here.
3/ Click "Select all" and change page. The checkboxes on the new page
should be checked.
4/ Check some checkboxes on this new page and click "Clear all". Go back
to the previous page, checkboxes shouldn't be checked.
5/ Check some checkboxes on at least 2 different pages and click
"Delete". All selected search history entries should be deleted.

Followed test plan. Works as expected.
Signed-off-by: Marc Véron 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14699] Intranet search history issues due to DataTables pagination

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14699

Owen Leonard  changed:

   What|Removed |Added

  Attachment #42449|0   |1
is obsolete||

--- Comment #11 from Owen Leonard  ---
Created attachment 57684
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57684=edit
[SIGNED-OFF] Bug 14699: Show number of selected searches in search history

With the number displayed, it should remove the ambiguity about what
"Select all" and "Clear all" do.
The number is repeated in the "Delete" confirmation dialog.

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14699] Intranet search history issues due to DataTables pagination

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14699

Owen Leonard  changed:

   What|Removed |Added

  Attachment #56313|0   |1
is obsolete||

--- Comment #12 from Owen Leonard  ---
Created attachment 57685
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57685=edit
[SIGNED-OFF] Bug 14699: Reword "Select all/Clear all" and change their
behaviour

"Select all" -> "Select all visible rows"
"Clear all" -> "Clear selection on visible rows"

+ fix the bug where the Delete link was visually enabled only if you
checked a box in the first page (now every checkbox enable the link)

Signed-off-by: Owen Leonard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14699] Intranet search history issues due to DataTables pagination

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14699

Owen Leonard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14699] Intranet search history issues due to DataTables pagination

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14699

Julian Maurice  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14699] Intranet search history issues due to DataTables pagination

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14699

--- Comment #10 from Julian Maurice  ---
Created attachment 56313
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56313=edit
Bug 14699: Reword "Select all/Clear all" and change their behaviour

"Select all" -> "Select all visible rows"
"Clear all" -> "Clear selection on visible rows"

+ fix the bug where the Delete link was visually enabled only if you
checked a box in the first page (now every checkbox enable the link)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14699] Intranet search history issues due to DataTables pagination

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14699

Nick Clemens  changed:

   What|Removed |Added

 Status|In Discussion   |Failed QA

--- Comment #9 from Nick Clemens  ---
(In reply to Julian Maurice from comment #8)
> (In reply to Owen Leonard from comment #7)
> > (In reply to Nick Clemens from comment #6)
>I suggest to keep the current behaviour,
> change only the labels to "Select all visible rows" or something similar,
> and maybe add an action "Clear all history" ?

That sounds fine to me

The problem in comment 6 with the delete button should also be addressed:
with these patches the delete link still isn't visibly enabled but will delete
all selected regardless of visibility

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14699] Intranet search history issues due to DataTables pagination

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14699

--- Comment #8 from Julian Maurice  ---
(In reply to Owen Leonard from comment #7)
> (In reply to Nick Clemens from comment #6)
> 
> > 2 - Select all searches but respect filters.  If I filter down to 8 searches
> > it should select only those.  If my filter finds 21 searches (default 20
> > visible) it should select all 21, but not searches limited by filter. 
> > Labels would say "With ## selected searches: delete"
> 
> I think this is the correct goal. With a filtered result clicking "select
> all" shouldn't select lines which are not visible because of the filter.
> However, with a filtered or unfiltered result clicking "select all" should
> select records across all pages.

I think there is a problem with this solution: we can't do that with
AJAX-paginated tables. It's not the case of this particular table, but if we
want to have a consistent behaviour for all the "Select all/Clear all" buttons
we must do something that is possible on every table.
So, for this particular table I suggest to keep the current behaviour, change
only the labels to "Select all visible rows" or something similar, and maybe
add an action "Clear all history" ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14699] Intranet search history issues due to DataTables pagination

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14699

--- Comment #7 from Owen Leonard  ---
(In reply to Nick Clemens from comment #6)

> 2 - Select all searches but respect filters.  If I filter down to 8 searches
> it should select only those.  If my filter finds 21 searches (default 20
> visible) it should select all 21, but not searches limited by filter. 
> Labels would say "With ## selected searches: delete"

I think this is the correct goal. With a filtered result clicking "select all"
shouldn't select lines which are not visible because of the filter. However,
with a filtered or unfiltered result clicking "select all" should select
records across all pages.

> 1 - On master selecting any search past 20 doesn't change the look of the
> delete button, though it is enabled.  It does only function on the visible
> searches either way

Confirmed. Checking a box on any but the first page does not change the
appearance of the delete button or show the number of selected lines even
though the delete button will work.

> 2 - The phrasing "With selected searches: Delete" is awkward.

This is a pattern used elsewhere, although it's not quite as useful when there
is only one "action" available. See the OPAC list interface where we have 

"Select titles to: Place hold | Remove from list"

...which changes to:

"With selected titles: Place hold | Remove from list"

I think the advantage to doing it this way is that the interface is explicit
about *why* an option is disabled.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14699] Intranet search history issues due to DataTables pagination

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14699

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@quecheelibrary.org
 Status|Needs Signoff   |In Discussion

--- Comment #6 from Nick Clemens  ---
Moving this to in discussion.

I think the expected behavior is somewhere between the original and that with
the patches applied.  I would expect either:

1 - Preserve current behavior and change just the labels to "Select all visible
/ clear all visible"

2 - Select all searches but respect filters.  If I filter down to 8 searches it
should select only those.  If my filter finds 21 searches (default 20 visible)
it should select all 21, but not searches limited by filter.  Labels would say
"With ## selected searches: delete"

A couple other things from testing:

1 - On master selecting any search past 20 doesn't change the look of the
delete button, though it is enabled.  It does only function on the visible
searches either way 
i.e. select search 21, button no visibly enabled, but clickable. Select #1 and
#21 (with 20 visible) button is enabled, only #1 is deleted.
With the patches the link still isn't visibly enabled but will delete all
selected regardless of visibility

2 - The phrasing "With selected searches: Delete" is awkward.  I think it
should be "Delete selected searches" and button can simply be grayed out when
none are selected With these patches phrasing would then be "Delete ## selected
searches"

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14699] Intranet search history issues due to DataTables pagination

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14699

Julian Maurice  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14699] Intranet search history issues due to DataTables pagination

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14699

--- Comment #5 from Julian Maurice  ---
Created attachment 42449
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42449=edit
Bug 14699: Show number of selected searches in search history

With the number displayed, it should remove the ambiguity about what
"Select all" and "Clear all" do.
The number is repeated in the "Delete" confirmation dialog.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14699] Intranet search history issues due to DataTables pagination

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14699

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14699] Intranet search history issues due to DataTables pagination

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14699

--- Comment #4 from Julian Maurice  ---
(In reply to Jonathan Druart from comment #3)
> What you describe is the expected behavior, I think.
> With your patch if you filter the table and click "select all", it will
> select all row, even the filtered ones.

Then maybe "select/clear all" should be reworded to something like
"select/clear all visible rows" to remove ambuiguity. Or maybe we should make a
difference between invisible rows due to pagination and invisible rows due to
filtering ?
But I believe "Delete" should work on all checked checkboxes, not only the
visible ones (and even the filtered ones).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14699] Intranet search history issues due to DataTables pagination

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14699

Zeno Tajoli  changed:

   What|Removed |Added

 CC|z.taj...@cineca.it  |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14699] Intranet search history issues due to DataTables pagination

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14699

Marc Véron  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14699] Intranet search history issues due to DataTables pagination

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14699

--- Comment #2 from Marc Véron  ---
Created attachment 42330
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42330=edit
[Signed-off] Bug 14699: Fix intranet search history issues due to pagination

DataTables removes hidden rows from the DOM. Because of that, "Select
all", "Clear all" and the form submission don't work correctly
(basically they act only on the currently displayed page).

This patch fixes just that.

Test plan:
1/ Go to your search history page
2/ Make you sure you have at least 21 entries in your search history. If
not, do some searches and come back here.
3/ Click "Select all" and change page. The checkboxes on the new page
should be checked.
4/ Check some checkboxes on this new page and click "Clear all". Go back
to the previous page, checkboxes shouldn't be checked.
5/ Check some checkboxes on at least 2 different pages and click
"Delete". All selected search history entries should be deleted.

Followed test plan. Works as expected.
Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14699] Intranet search history issues due to DataTables pagination

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14699

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch
  Attachment #41734|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14699] Intranet search history issues due to DataTables pagination

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14699

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #3 from Jonathan Druart  
---
What you describe is the expected behavior, I think.
With your patch if you filter the table and click "select all", it will select
all row, even the filtered ones.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14699] Intranet search history issues due to DataTables pagination

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14699

Zeno Tajoli  changed:

   What|Removed |Added

 CC||z.taj...@cineca.it
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14699] Intranet search history issues due to DataTables pagination

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14699

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

 Blocks||12460


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12460
[Bug 12460] Search history: Combine to start a new search
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14699] Intranet search history issues due to DataTables pagination

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14699

--- Comment #1 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 41734
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41734action=edit
Bug 14699: Fix intranet search history issues due to pagination

DataTables removes hidden rows from the DOM. Because of that, Select
all, Clear all and the form submission don't work correctly
(basically they act only on the currently displayed page).

This patch fixes just that.

Test plan:
1/ Go to your search history page
2/ Make you sure you have at least 21 entries in your search history. If
not, do some searches and come back here.
3/ Click Select all and change page. The checkboxes on the new page
should be checked.
4/ Check some checkboxes on this new page and click Clear all. Go back
to the previous page, checkboxes shouldn't be checked.
5/ Check some checkboxes on at least 2 different pages and click
Delete. All selected search history entries should be deleted.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14699] Intranet search history issues due to DataTables pagination

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14699

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |julian.maur...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14699] Intranet search history issues due to DataTables pagination

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14699

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/