[Koha-bugs] [Bug 14711] Make C4::Reserves::AddReserves take a hashref in parameters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14711 Katrin Fischer changed: What|Removed |Added Component|Hold requests |Architecture, internals, ||and plumbing -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14711] Make C4::Reserves::AddReserves take a hashref in parameters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14711 Jonathan Druart changed: What|Removed |Added Blocks||24769 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24769 [Bug 24769] DataTable error on patron hold page when hold placed (ILS-DI and other bugs) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14711] Make C4::Reserves::AddReserves take a hashref in parameters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14711 Joy Nelson changed: What|Removed |Added Resolution|--- |FIXED Status|Pushed to master|RESOLVED CC||j...@bywatersolutions.com --- Comment #12 from Joy Nelson --- Enhancement not pushed to 19.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14711] Make C4::Reserves::AddReserves take a hashref in parameters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14711 --- Comment #11 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14711] Make C4::Reserves::AddReserves take a hashref in parameters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14711 Martin Renvoize changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||20.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14711] Make C4::Reserves::AddReserves take a hashref in parameters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14711 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14711] Make C4::Reserves::AddReserves take a hashref in parameters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14711 Martin Renvoize changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14711] Make C4::Reserves::AddReserves take a hashref in parameters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14711 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||martin.renvoize@ptfs-europe ||.com --- Comment #10 from Martin Renvoize --- Works as expected.. a look through the code doesn't highlight any issues regressions.. I'm tempted to PQA and push and let Jenkins do it's thing here rather than let it languish and require another rebase. As for the note.. I think we're safe with the signature.. the db column name mismatch isn't the first and should likely get cleaned up as a distinct issue upon more to Koha:: PQA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14711] Make C4::Reserves::AddReserves take a hashref in parameters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14711 Martin Renvoize changed: What|Removed |Added Attachment #98708|0 |1 is obsolete|| --- Comment #9 from Martin Renvoize --- Created attachment 98710 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98710&action=edit Bug 14711: Change prototype for AddReserve - pass a hashref The number of parameters of AddReserve makes it hard to read and maintain. This patch replace it with a hashref, which will make the calls more readable. Moreover the bibitems has been removed as it was not used by the subroutine. Test plan: - Make sure the tests pass - Read the diff and search for typos - Place a hold on few items Note for QA: reservation_date and expiration_date do not match the DB column's names, should we? Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14711] Make C4::Reserves::AddReserves take a hashref in parameters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14711 Jonathan Druart changed: What|Removed |Added Attachment #77940|0 |1 is obsolete|| --- Comment #8 from Jonathan Druart --- Created attachment 98708 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98708&action=edit Bug 14711: Change prototype for AddReserve - pass a hashref The number of parameters of AddReserve makes it hard to read and maintain. This patch replace it with a hashref, which will make the calls more readable. Moreover the bibitems has been removed as it was not used by the subroutine. Test plan: - Make sure the tests pass - Read the diff and search for typos - Place a hold on few items Note for QA: reservation_date and expiration_date do not match the DB column's names, should we? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14711] Make C4::Reserves::AddReserves take a hashref in parameters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14711 Jonathan Druart changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14711] Make C4::Reserves::AddReserves take a hashref in parameters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14711 David Nind changed: What|Removed |Added CC||da...@davidnind.com Status|Needs Signoff |Patch doesn't apply --- Comment #7 from David Nind --- Path no longer applies 8-( -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14711] Make C4::Reserves::AddReserves take a hashref in parameters
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14711 Jonathan Druart changed: What|Removed |Added Summary|We do no longer need|Make |bibitems in AddReserve |C4::Reserves::AddReserves ||take a hashref in ||parameters Severity|minor |enhancement -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
