[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Fridolin Somers changed: What|Removed |Added Blocks||32443 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32443 [Bug 32443] Sort order is lost when changing results per page -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Fridolin Somers changed: What|Removed |Added Blocks||31379 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31379 [Bug 31379] Change results per page text for default -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 --- Comment #118 from Katrin Fischer --- Wanted to add: it's not related to this bug or feature. And a tip: When the bug you think is related has already been closed/released, it's always better to open a new one with any findings and link them using depends or see also. Any patches/fixes will need a new bug number. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 --- Comment #117 from Katrin Fischer --- Hi Holly, when using OpacHiddenItems the results are filtered "after" paging, is what I was told, so it leaves holes in the result lists like you see. That cannot be changed easily it seems, which is why it was chosen to remove the numbering of results when OpacHiddenItems is used to hide this a bit. See also: bug 23923 and bug 18989 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Holly changed: What|Removed |Added CC||h...@interleaf.ie --- Comment #116 from Holly --- I'm noticing something in situations where the OPAC is suppressing records that I would appreciate some feedback on. I walk through what I'm seeing below using a general example from a site I'm testing on. In the below example, the system preferences have been set so that the results per page dropdown appears and a search will show 10 results per page for both the OPAC and the staff side. 1. I use the advanced search on the OPAC to search for all items with a specific item type called "General items". 3. The results per page display shows that there should be 10 results on the first and all other pages. 4. There are actually 9 results on the first results page. 5. There are 10 results on all other pages. 6. Doing the same search on the staff side, the results per page display shows that there should be 10 results on the first and all other pages. 7. There are 10 results on the first page and all other pages. 8. The first result on the first page of the staff side does not appear on the OPAC. Looking at it, this seems to be because all items on the bibliographic record are marked as lost. 9. It is fine that the OPAC is not showing the suppressed record, but I would assume in cases like this, instead of showing nine results on the first page, it should show 10, moving the first result from the second page up one, and so on for all the other pages. To summarise, my understanding is that there should be 10 results on the first page of results, assuming that all subsequent pages have 10 or more results on them, even if one of the results for the first page is suppressed. Is anyone else seeing this? Would this require a new bug to be opened? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Martin Renvoize changed: What|Removed |Added Text to go in the|This enhancement adds a |This enhancement adds a release notes|results per page dropdown |'results per page' dropdown |list to catalog search |list to catalog search |results pages in the OPAC |results pages in the OPAC |and staff interface. This |and staff interface. This |lets you set the number of |lets you set the number of |results to show (20, 40,|results to show (20, 40, |60, 80, and so on). |60, 80, and so on). | | |This|This |is enabled by two new |is enabled by two new |system preferences: |system preferences: |OPACnumSearchResultsDropdow |`OPACnumSearchResultsDropdo |n for the OPAC, and |wn` for the OPAC, and |numSearchResultsDropdown|`numSearchResultsDropdown` |for the staff interface. |for the staff interface. || |The default number of |The default number of |search results is set using |search results is set using |existing system |existing system |preferences:|preferences: |OPACnumSearchResults for|`OPACnumSearchResults` for |the OPAC, and |the OPAC, and |numSearchResults for the|`numSearchResults` for the |staff interface. |staff interface. | | |This|This |enhancement works for both |enhancement works for both |Zebra and Elasticsearch |Zebra and Elasticsearch |search engines. |search engines. || ||**New ||system preferences**: ||`OPACnumSearchResultsDropdo ||wn` and ||`numSearchResultsDropdown` ||both default to disabled. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Katrin Fischer changed: What|Removed |Added Component|Staff Client|OPAC -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 --- Comment #115 from Katrin Fischer --- Verified with Joubu - there is no cookie :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 --- Comment #114 from Katrin Fischer --- Hm, was looking to add information on the use of the cookie mentioned to https://wiki.koha-community.org/wiki/Use_of_Cookies, but didn't spot the code for it. Can you help? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Martin Renvoize changed: What|Removed |Added Keywords|Academy,| |rel_20_05_candidate | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Joy Nelson changed: What|Removed |Added CC||j...@bywatersolutions.com --- Comment #113 from Joy Nelson --- enhancement not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 David Nind changed: What|Removed |Added Text to go in the||This enhancement adds a release notes||results per page dropdown ||list to catalog search ||results pages in the OPAC ||and staff interface. This ||lets you set the number of ||results to show (20, 40, ||60, 80, and so on). || ||This ||is enabled by two new ||system preferences: ||OPACnumSearchResultsDropdow ||n for the OPAC, and ||numSearchResultsDropdown ||for the staff interface. || ||The default number of ||search results is set using ||existing system ||preferences: ||OPACnumSearchResults for ||the OPAC, and ||numSearchResults for the ||staff interface. || ||This ||enhancement works for both ||Zebra and Elasticsearch ||search engines. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Fridolin SOMERS changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 --- Comment #112 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 --- Comment #111 from Martin Renvoize --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Martin Renvoize changed: What|Removed |Added Version(s)||20.05.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 --- Comment #110 from Katrin Fischer --- Created attachment 101778 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101778=edit Bug 14715: (QA follow-up) Remove limit on Zebra Found in testing that this appears to work well for Elasticsearch - so removing everything that made this Zebra only. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 --- Comment #109 from Katrin Fischer --- Created attachment 101777 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101777=edit Bug 14715: (QA follow-up) Add missing filters Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Katrin Fischer changed: What|Removed |Added Attachment #99684|0 |1 is obsolete|| --- Comment #107 from Katrin Fischer --- Created attachment 101775 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101775=edit Bug 14715: Results per page dropdown for catalogue search This patch utilises an unused search facet to handle results shown per page. Sponsored-by: Region Halland Signed-off-by: Gabriel DeCarufel Signed-off-by: David Nind Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Katrin Fischer changed: What|Removed |Added Attachment #99685|0 |1 is obsolete|| --- Comment #108 from Katrin Fischer --- Created attachment 101776 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101776=edit Bug 14715: (follow-up) Keep results per page setting when selecting facets and sorting results Also adding missing filters ALSO ensuring you can switch back to library default on staff side Signed-off-by: David Nind Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 --- Comment #106 from Katrin Fischer --- >3) It appears to break when Elasticsearch is activated in a non-good way. >>Switching the number of results made the OPAC load forever for me showing a >>white page. Then it started to work, but the number of pages doesn't change. >Can you please check? If we can't make this work, we should at least add a >note >to the pref and keep it from showing up with Elasticsearch active. I have retested and can't find any issues with Elasticsearch - I think the problems I found earlier were probably an issue in my installation. I am proposing a PQA with a follow-up removing the code that makes this Zebra only. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 --- Comment #105 from Jonathan Druart --- What is the problem with elasticsearch? I have tried (removing the condition in the template), and it works as expected. I do not think we should continue to push Zebra-only features nowadays, especially if it works with elastic :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 David Nind changed: What|Removed |Added Attachment #99677|0 |1 is obsolete|| --- Comment #104 from David Nind --- Created attachment 99685 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99685=edit Bug 14715: (follow-up) Keep results per page setting when selecting facets and sorting results Also adding missing filters ALSO ensuring you can switch back to library default on staff side Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 David Nind changed: What|Removed |Added Attachment #98365|0 |1 is obsolete|| --- Comment #103 from David Nind --- Created attachment 99684 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99684=edit Bug 14715: Results per page dropdown for catalogue search This patch utilises an unused search facet to handle results shown per page. Sponsored-by: Region Halland Signed-off-by: Gabriel DeCarufel Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Aleisha Amohia changed: What|Removed |Added Attachment #99607|0 |1 is obsolete|| --- Comment #102 from Aleisha Amohia --- Created attachment 99677 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99677=edit Bug 14715: (follow-up) Keep results per page setting when selecting facets and sorting results Also adding missing filters ALSO ensuring you can switch back to library default on staff side -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Aleisha Amohia changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 David Nind changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #101 from David Nind --- Thanks for all the changes Aleisha! When changing facets it now remembers the setting. However, the only thing thing that isn't working is on the staff interface. When you try to go back to the default (Library default: 10) nothing happens, example URL - the number doesn't change, the page doesn't automatically refredh and a # is added at the end of the URL: http://127.0.0.1:8081/cgi-bin/koha/catalogue/search.pl?count=20=kw=cat# -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 --- Comment #100 from Jonathan Druart --- Aleisha, what about David's comment? can you please take a look at David'd comment#95?(In reply to Jonathan Druart from comment #99) > Aleisha, what about David's comment? Scratch that! I thought you only added the filters! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 --- Comment #99 from Jonathan Druart --- Aleisha, what about David's comment? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 --- Comment #98 from Aleisha Amohia --- Created attachment 99607 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99607=edit Bug 14715: (follow-up) Keep results per page setting when selecting facets and sorting results Also adding missing filters -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Aleisha Amohia changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 --- Comment #97 from Jonathan Druart --- Missing filters can be added easily with misc/devel/add_missing_filters.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Aleisha Amohia changed: What|Removed |Added Status|Failed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #96 from Katrin Fischer ---
Hi Aleisha,
can you please take a look at David'd comment#95?
I also got a lot of fails with the QA tools for missing filters :(
FAIL koha-tmpl/intranet-tmpl/prog/en/includes/page-numbers.inc
FAIL filters
missing_filter at line 4 ( First)
missing_filter at line 6 ( Previous)
missing_filter at line 12 ([% PAGE_NUMBER.pg | html
%])
missing_filter at line 16 (Next )
missing_filter at line 17 (Last )
OK forbidden patterns
OK git manipulation
OK js_in_body
OK spelling
OK tt_valid
OK valid_template
FAIL koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt
FAIL filters
missing_filter at line 274 (
Results per page: [% results_per_page %] )
missing_filter at line 281 (
[% END %] Library default: [% Koha.Preference('numSearchResults')
%])
OK forbidden patterns
OK git manipulation
OK js_in_body
OK spelling
OK tt_valid
OK valid_template
FAIL koha-tmpl/opac-tmpl/bootstrap/en/includes/page-numbers.inc
FAIL filters
wrong_html_filter at line 6 ( First)
missing_filter at line 6 ( First)
wrong_html_filter at line 7 ( Previous)
missing_filter at line 7 ( Previous)
wrong_html_filter at line 13 ([% PAGE_NUMBER.pg | html
%])
missing_filter at line 13 ([% PAGE_NUMBER.pg | html
%])
wrong_html_filter at line 17 (Next )
missing_filter at line 17 (Next )
wrong_html_filter at line 18 (Last )
missing_filter at line 18 (Last )
OK forbidden patterns
OK git manipulation
OK js_in_body
OK spelling
OK tt_valid
OK valid_template
FAIL koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt
FAIL filters
missing_filter at line 172 (
Library
default: [% Koha.Preference('OPACnumSearchResults') %])
missing_filter at line 172 (
Library
default: [% Koha.Preference('OPACnumSearchResults') %])
missing_filter at line 174 (
Library default: [%
Koha.Preference('OPACnumSearchResults') %])
missing_filter at line 174 (
Library default: [%
Koha.Preference('OPACnumSearchResults') %])
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #95 from David Nind --- A couple of things I noticed during testing, not sure whether they are show stoppers or not: - OPAC and staff interface: the number of results resets to the default if you select any of the refine search options/facets - Staff interface: if you choose any option from the sort drop down this also resets the number of search results to the default Otherwise, it works very nicely! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 David Nind changed: What|Removed |Added Attachment #97004|0 |1 is obsolete|| --- Comment #94 from David Nind --- Created attachment 98365 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98365=edit Bug 14715: Results per page dropdown for catalogue search This patch utilises an unused search facet to handle results shown per page. To test: 1) Enable patch and update database to apply atomic updates 2) Go to system preferences and set both 'numSearchResultsDropdown' and 'OPACnumSearchResultsDropdown' to 'Show' 3) Set both 'numSearchResults' and 'OPACnumSearchResults' system preferences to 10 so that it will be clear to see how the patch works 4) Do a catalogue search in the intranet using a search term that will bring lots of results 5) The results per page dropdown should show with the selected option as the library default, the value of numSearchResults. The number of results shown on the page should match numSearchResults. 6) Choose a different number of results per page in the dropdown. The search results will automatically refresh 7) Confirm that the correct number of results per page shows 8) Confirm that changing pages does not revert the number of results shown per page to the default value 9) Confirm that you are still able to use other search facets as expected 10) Repeat steps 4-9 on the OPAC (note OPAC uses OPACnumSearchResults as the default value) Sponsored-by: Region Halland Signed-off-by: Gabriel DeCarufel Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Gabriel DeCarufel changed: What|Removed |Added Attachment #95038|0 |1 is obsolete|| --- Comment #93 from Gabriel DeCarufel --- Created attachment 97004 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97004=edit Bug 14715: Results per page dropdown for catalogue search This patch utilises an unused search facet to handle results shown per page. Sponsored-by: Region Halland Signed-off-by: Gabriel DeCarufel -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Martin Renvoize changed: What|Removed |Added Keywords||rel_20_05_target CC||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Aleisha Amohia changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Aleisha Amohia changed: What|Removed |Added Attachment #88831|0 |1 is obsolete|| Attachment #88832|0 |1 is obsolete|| Attachment #88833|0 |1 is obsolete|| Attachment #88834|0 |1 is obsolete|| Attachment #88835|0 |1 is obsolete|| Attachment #88836|0 |1 is obsolete|| Attachment #88837|0 |1 is obsolete|| Attachment #88838|0 |1 is obsolete|| Attachment #88839|0 |1 is obsolete|| --- Comment #92 from Aleisha Amohia --- Created attachment 95038 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95038=edit Bug 14715: Results per page dropdown for catalogue search This patch utilises an unused search facet to handle results shown per page. To test: 1) Enable patch and update database to apply atomic updates 2) Go to system preferences and set both 'numSearchResultsDropdown' and 'OPACnumSearchResultsDropdown' to 'Show' 3) Set both 'numSearchResults' and 'OPACnumSearchResults' system preferences to 10 so that it will be clear to see how the patch works 4) Do a catalogue search in the intranet using a search term that will bring lots of results 5) The results per page dropdown should show with the selected option as the library default, the value of numSearchResults. The number of results shown on the page should match numSearchResults. 6) Choose a different number of results per page in the dropdown. The search results will automatically refresh 7) Confirm that the correct number of results per page shows 8) Confirm that changing pages does not revert the number of results shown per page to the default value 9) Confirm that you are still able to use other search facets as expected 10) Repeat steps 4-9 on the OPAC (note OPAC uses OPACnumSearchResults as the default value) Sponsored-by: Region Halland -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Aleisha Amohia changed: What|Removed |Added Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Séverine Queune changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply --- Comment #91 from Séverine Queune --- The sandbox you've requested is not ready. Some problems occurred applying patches from bug 14715: Something went wrong !Applying: Bug 14715: results per page setting for catalog search Using index info to reconstruct a base tree... M C4/Search.pm M catalogue/search.pl M koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt M koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt M opac/opac-search.pl Falling back to patching base and 3-way merge... Auto-merging opac/opac-search.pl CONFLICT (content): Merge conflict in opac/opac-search.pl Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt Auto-merging catalogue/search.pl CONFLICT (content): Merge conflict in catalogue/search.pl Auto-merging C4/Search.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 14715: results per page setting for catalog search -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Owen Leonard changed: What|Removed |Added Assignee|mar...@bugs.koha-community. |alei...@catalyst.net.nz |org.xinxidi.net | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 --- Comment #90 from Katrin Fischer --- *** Bug 7260 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Aleisha Amohia changed: What|Removed |Added Attachment #88106|0 |1 is obsolete|| --- Comment #85 from Aleisha Amohia --- Created attachment 88835 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88835=edit Bug 14715: (QA Follow up) Fix results not showing This fixes the display issue for me. Can someone please test? Signed-off-by: Cab Vinton Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Aleisha Amohia changed: What|Removed |Added Attachment #88107|0 |1 is obsolete|| --- Comment #86 from Aleisha Amohia --- Created attachment 88836 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88836=edit Bug 14715: (QA follow-up) some code changes 1) adds sysprefs to sysprefs.sql 2) removes a merge conflict error that should not have been added Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Aleisha Amohia changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Aleisha Amohia changed: What|Removed |Added Attachment #88195|0 |1 is obsolete|| --- Comment #89 from Aleisha Amohia --- Created attachment 88839 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88839=edit Bug 14715: (follow-up) Fixing database updates This patch removes the atomic update that adds the 'perPage' system preferences and keeps the 'dropdown' system preferences. Also sql file is moved into perl file. Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Aleisha Amohia changed: What|Removed |Added Attachment #88108|0 |1 is obsolete|| --- Comment #87 from Aleisha Amohia --- Created attachment 88837 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88837=edit Bug 14715: (QA follow-up) Edits for ElasticSearch Note added to preferences that the dropdown should not be used with ElasticSearch activated. Dropdowns do not show on search results on staff side or OPAC side if Elasticsearch enabled. Ready to test Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Aleisha Amohia changed: What|Removed |Added Attachment #88104|0 |1 is obsolete|| --- Comment #83 from Aleisha Amohia --- Created attachment 88833 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88833=edit Bug 14715: [QA Follow up] Removing 'all' option, fixing QA tools issues Signed-off-by: Simon Pouchol Signed-off-by: Cab Vinton Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Aleisha Amohia changed: What|Removed |Added Attachment #88109|0 |1 is obsolete|| --- Comment #88 from Aleisha Amohia --- Created attachment 88838 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88838=edit Bug 14715: (QA Follow up) More QA tool cleanup Tools are picking up more stuff now, so a few more things to fix! Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Aleisha Amohia changed: What|Removed |Added Attachment #88105|0 |1 is obsolete|| --- Comment #84 from Aleisha Amohia --- Created attachment 88834 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88834=edit Bug 14715: [QA Follow up] Rebase and fix up I noticed that the two sysprefs initially created with this patch weren't really being used, so I removed them. Instead I've added two new sysprefs: numSearchResultsDropdown OPACnumSearchResultsDropdown that control whether the dropdown shows or not. Otherwise the defaults in numSearchResults and OPACnumSearchResults are used to decide number of search results per page. When testing: Run updatedatabase.pl Test with values in numSearchResults and OPACnumSearchResults. Use original test plan in Comment 12 but test with the dropdown sysprefs off and on. Sponsored-by: Region Halland Signed-off-by: Cab Vinton Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Aleisha Amohia changed: What|Removed |Added Attachment #88102|0 |1 is obsolete|| --- Comment #81 from Aleisha Amohia --- Created attachment 88831 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88831=edit Bug 14715: results per page setting for catalog search Add new select field to catalog search results pages which allows user to set number of results to be shown per page. Setting saved in cookie "results_per_page". To test: 1) Do a catalog search in the intranet and OPAC 2) Confirm that results automatically update upon selection of results per page to show 3) Test for all options (20, 40, 60, 80, 100, all) Bug 14715: syspref for results per page options Remove the "all" option. Add syspref [OPAC]numSearchResultsPerPage for specifying options for numbers of results per page including [OPAC]numSearchResults. Bug 14715: database updates Bug 14715: Fixing pagination problems Signed-off-by: Owen Leonard Signed-off-by: Cab Vinton Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Aleisha Amohia changed: What|Removed |Added Attachment #88103|0 |1 is obsolete|| --- Comment #82 from Aleisha Amohia --- Created attachment 88832 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88832=edit Bug 14715: [QA Follow up] Fixing qa-tools issues and merge conflicts Signed-off-by: Owen Leonard Signed-off-by: Cab Vinton Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Patch doesn't apply --- Comment #80 from Katrin Fischer --- Hi Aleisha, I am sorry, can you please rebase? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 --- Comment #79 from Liz Rea --- we might want to rebase out the old .sql files, but I don't want to mess it up so I will leave that bit. That's the only QA fail I can see, the newest patch resolves Katrin's concerns, near as I can tell. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Liz Rea changed: What|Removed |Added Attachment #88126|0 |1 is obsolete|| --- Comment #78 from Liz Rea --- Created attachment 88195 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88195=edit Bug 14715: (follow-up) Fixing database updates This patch removes the atomic update that adds the 'perPage' system preferences and keeps the 'dropdown' system preferences. Also sql file is moved into perl file. Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Aleisha Amohia changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 --- Comment #77 from Aleisha Amohia --- Created attachment 88126 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88126=edit Bug 14715: (follow-up) Fixing database updates This patch removes the atomic update that adds the 'perPage' system preferences and keeps the 'dropdown' system preferences. Also sql file is moved into perl file. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #76 from Katrin Fischer --- System preference names don't match up: Database updates add 4 different prefs: OPACnumSearchResultsPerPage numSearchResultsPerPage OPACnumSearchResultsDropdown numSearchResultsDropdown syspref.sql adds only 2: numSearchResultsPerPage OPACnumSearchResultsPerPage yaml file has: OPACnumSearchResultsDropdown numSearchResultsDropdown Code appears to use the Dropdown version. Please, when cleaning this up: Database update SQL files should be merged and moved into a .perl file - this will make the RM much happier. For later: New cookie results_per_page needs documentation on the wiki. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 --- Comment #75 from Liz Rea --- Created attachment 88109 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88109=edit Bug 14715: (QA Follow up) More QA tool cleanup Tools are picking up more stuff now, so a few more things to fix! Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 --- Comment #74 from Liz Rea --- Created attachment 88108 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88108=edit Bug 14715: (QA follow-up) Edits for ElasticSearch Note added to preferences that the dropdown should not be used with ElasticSearch activated. Dropdowns do not show on search results on staff side or OPAC side if Elasticsearch enabled. Ready to test Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 --- Comment #71 from Liz Rea --- Created attachment 88105 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88105=edit Bug 14715: [QA Follow up] Rebase and fix up I noticed that the two sysprefs initially created with this patch weren't really being used, so I removed them. Instead I've added two new sysprefs: numSearchResultsDropdown OPACnumSearchResultsDropdown that control whether the dropdown shows or not. Otherwise the defaults in numSearchResults and OPACnumSearchResults are used to decide number of search results per page. When testing: Run updatedatabase.pl Test with values in numSearchResults and OPACnumSearchResults. Use original test plan in Comment 12 but test with the dropdown sysprefs off and on. Sponsored-by: Region Halland Signed-off-by: Cab Vinton Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 --- Comment #72 from Liz Rea --- Created attachment 88106 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88106=edit Bug 14715: (QA Follow up) Fix results not showing This fixes the display issue for me. Can someone please test? Signed-off-by: Cab Vinton Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 --- Comment #70 from Liz Rea --- Created attachment 88104 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88104=edit Bug 14715: [QA Follow up] Removing 'all' option, fixing QA tools issues Signed-off-by: Simon Pouchol Signed-off-by: Cab Vinton Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 --- Comment #73 from Liz Rea --- Created attachment 88107 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88107=edit Bug 14715: (QA follow-up) some code changes 1) adds sysprefs to sysprefs.sql 2) removes a merge conflict error that should not have been added Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 --- Comment #69 from Liz Rea --- Created attachment 88103 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88103=edit Bug 14715: [QA Follow up] Fixing qa-tools issues and merge conflicts Signed-off-by: Owen Leonard Signed-off-by: Cab Vinton Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Liz Rea changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Liz Rea changed: What|Removed |Added Attachment #78299|0 |1 is obsolete|| Attachment #78300|0 |1 is obsolete|| Attachment #78301|0 |1 is obsolete|| Attachment #78302|0 |1 is obsolete|| Attachment #79797|0 |1 is obsolete|| Attachment #81203|0 |1 is obsolete|| Attachment #88097|0 |1 is obsolete|| --- Comment #68 from Liz Rea --- Created attachment 88102 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88102=edit Bug 14715: results per page setting for catalog search Add new select field to catalog search results pages which allows user to set number of results to be shown per page. Setting saved in cookie "results_per_page". To test: 1) Do a catalog search in the intranet and OPAC 2) Confirm that results automatically update upon selection of results per page to show 3) Test for all options (20, 40, 60, 80, 100, all) Bug 14715: syspref for results per page options Remove the "all" option. Add syspref [OPAC]numSearchResultsPerPage for specifying options for numbers of results per page including [OPAC]numSearchResults. Bug 14715: database updates Bug 14715: Fixing pagination problems Signed-off-by: Owen Leonard Signed-off-by: Cab Vinton Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Liz Rea changed: What|Removed |Added Attachment #78298|0 |1 is obsolete|| --- Comment #67 from Liz Rea --- Created attachment 88097 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88097=edit Bug 14715: results per page setting for catalog search Add new select field to catalog search results pages which allows user to set number of results to be shown per page. Setting saved in cookie "results_per_page". To test: 1) Do a catalog search in the intranet and OPAC 2) Confirm that results automatically update upon selection of results per page to show 3) Test for all options (20, 40, 60, 80, 100, all) Bug 14715: syspref for results per page options Remove the "all" option. Add syspref [OPAC]numSearchResultsPerPage for specifying options for numbers of results per page including [OPAC]numSearchResults. Bug 14715: database updates Bug 14715: Fixing pagination problems Signed-off-by: Owen Leonard Signed-off-by: Cab Vinton Signed-off-by: Liz Rea -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Liz Rea changed: What|Removed |Added CC||wizzy...@gmail.com --- Comment #66 from Liz Rea --- I'm going to sign off on this despite these two things: FAIL installer/data/mysql/atomicupdate/bug_14715-searchresults_syspref.sql FAIL git manipulation The file has been added and deleted in the same patchset ^^ I couldn't figure out how to resolve that, someone share plz. FAIL installer/data/mysql/atomicupdate/bug_14715_-_results_per_page_dropdown_sysprefs.sql OK git manipulation OK semicolon FAIL sysprefs_order Not blocker: Sysprefs numSearchResultsDropdown is bad placed (see bug 10610) ^^ isn't a blocker so I'm not letting it block me. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 --- Comment #65 from Aleisha Amohia --- (In reply to Séverine Queune from comment #63) > Tested with Zebra : works fine ! > > Tested with Elasticsearch : works fine except for "60 results per page" (UI > + OPAC) : each time there is more than 1 results, using "Last" button > failed : "Error: Unable to perform your search. Please try again." > > As it's not supposed to work with ES, I don't know if I should change the > status to "Failed" or sign the patch... Hi there! Can you please test again - i have hidden the dropdown if Elasticsearch is enabled to avoid this error. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Aleisha Amohia changed: What|Removed |Added Attachment #79988|0 |1 is obsolete|| --- Comment #64 from Aleisha Amohia --- Created attachment 81203 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81203=edit Bug 14715: (follow-up) Edits for ElasticSearch Note added to preferences that the dropdown should not be used with ElasticSearch activated. Dropdowns do not show on search results on staff side or OPAC side if Elasticsearch enabled. Ready to test -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Séverine Queune changed: What|Removed |Added CC||severine.que...@bulac.fr --- Comment #63 from Séverine Queune --- Tested with Zebra : works fine ! Tested with Elasticsearch : works fine except for "60 results per page" (UI + OPAC) : each time there is more than 1 results, using "Last" button failed : "Error: Unable to perform your search. Please try again." As it's not supposed to work with ES, I don't know if I should change the status to "Failed" or sign the patch... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Katrin Fischer changed: What|Removed |Added Keywords||Academy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Katrin Fischer changed: What|Removed |Added QA Contact|katrin.fisc...@bsz-bw.de| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Aleisha Amohia changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 --- Comment #62 from Aleisha Amohia --- Created attachment 79988 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79988=edit Bug 14715: (follow-up) Note about elasticsearch I'm not sure how to hide the sysprefs if ElasticSearch is active so I've added some comments to the preferences. Ready to test -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Aleisha Amohia changed: What|Removed |Added Attachment #79796|0 |1 is obsolete|| --- Comment #61 from Aleisha Amohia --- Created attachment 79797 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79797=edit Bug 14715: (follow-up) some code changes 1) adds sysprefs to sysprefs.sql 2) removes a merge conflict error that should not have been added -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 --- Comment #60 from Aleisha Amohia --- Created attachment 79796 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79796=edit Bug 14715: (follow-up) some code changes 1) adds sysprefs to sysprefs.sql 2) removes a merge conflict error that should not have been added -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #59 from Katrin Fischer --- Hi Aleisha, 1) some complaints from the QA script: FAIL installer/data/mysql/atomicupdate/bug_14715-searchresults_syspref.sql FAIL git manipulation The file has been added and deleted in the same patchset FAIL installer/data/mysql/atomicupdate/bug_14715_-_results_per_page_dropdown_sysprefs.sql OK git manipulation FAIL semicolon simicolon found instead of comma at line 3 FAIL sysprefs_order Not blocker: Sysprefs numSearchResultsDropdown is bad placed (see bug 10610) It appears the change to sysprefs.sql is missing? 2) I think I would just remove the display of 'library default' in the OPAC and staff. I think we don't need the extra entry in the pull down and it's more confusing as the difference between Library default:20 and 20 is not clear. 3) It appears to break when Elasticsearch is activated in a non-good way. Switching the number of results made the OPAC load forever for me showing a white page. Then it started to work, but the number of pages doesn't change. Can you please check? If we can't make this work, we should at least add a note to the pref and keep it from showing up with Elasticsearch active. Note for later: New cookie needs to be documented in the wiki, once this has been pushed: https://wiki.koha-community.org/wiki/Use_of_Cookies -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 --- Comment #58 from Cab Vinton --- Signed off in PTFS Sandbox 0. But note that the dropdown setting appears to control. In other words, once the dropdown is displayed, that setting sticks, even if the preference setting is changed or if the user logs out of the staff client or OPAC. This is also true if the dropdown is subsequently hidden. So, once the dropdown has been displayed, that is where the Results per page must be set & the system preference does not control. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 --- Comment #56 from PTFS Europe Sandboxes --- Created attachment 78301 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78301=edit Bug 14715: [FOLLOW-UP] Rebase and fix up I noticed that the two sysprefs initially created with this patch weren't really being used, so I removed them. Instead I've added two new sysprefs: numSearchResultsDropdown OPACnumSearchResultsDropdown that control whether the dropdown shows or not. Otherwise the defaults in numSearchResults and OPACnumSearchResults are used to decide number of search results per page. When testing: Run updatedatabase.pl Test with values in numSearchResults and OPACnumSearchResults. Use original test plan in Comment 12 but test with the dropdown sysprefs off and on. Sponsored-by: Region Halland Signed-off-by: Cab Vinton -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 --- Comment #55 from PTFS Europe Sandboxes --- Created attachment 78300 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78300=edit Bug 14715: [FOLLOW-UP] Removing 'all' option, fixing QA tools issues Signed-off-by: Simon Pouchol Signed-off-by: Cab Vinton -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 --- Comment #57 from PTFS Europe Sandboxes --- Created attachment 78302 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78302=edit Bug 14715: [FOLLOW-UP] Fix results not showing This fixes the display issue for me. Can someone please test? Signed-off-by: Cab Vinton -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 PTFS Europe Sandboxes changed: What|Removed |Added Attachment #75941|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 --- Comment #54 from PTFS Europe Sandboxes --- Created attachment 78299 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78299=edit Bug 14715: [FOLLOW-UP] Fixing qa-tools issues and merge conflicts Signed-off-by: Owen Leonard Signed-off-by: Cab Vinton -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 --- Comment #53 from PTFS Europe Sandboxes --- Created attachment 78298 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78298=edit Bug 14715: results per page setting for catalog search Add new select field to catalog search results pages which allows user to set number of results to be shown per page. Setting saved in cookie "results_per_page". To test: 1) Do a catalog search in the intranet and OPAC 2) Confirm that results automatically update upon selection of results per page to show 3) Test for all options (20, 40, 60, 80, 100, all) Bug 14715: syspref for results per page options Remove the "all" option. Add syspref [OPAC]numSearchResultsPerPage for specifying options for numbers of results per page including [OPAC]numSearchResults. Bug 14715: database updates Bug 14715: Fixing pagination problems Signed-off-by: Owen Leonard Signed-off-by: Cab Vinton -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 PTFS Europe Sandboxes changed: What|Removed |Added Attachment #75939|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 PTFS Europe Sandboxes changed: What|Removed |Added Attachment #78230|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 PTFS Europe Sandboxes changed: What|Removed |Added Attachment #75940|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 PTFS Europe Sandboxes changed: What|Removed |Added Attachment #75938|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 PTFS Europe Sandboxes changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||sandbo...@ptfs-europe.com --- Comment #52 from PTFS Europe Sandboxes --- Patch tested with a sandbox, by Cab Vinton -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Aleisha Amohia changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 --- Comment #51 from Aleisha Amohia --- Created attachment 78230 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78230=edit Bug 14715: [FOLLOW-UP] Fix results not showing This fixes the display issue for me. Can someone please test? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
