[Koha-bugs] [Bug 14906] Koha::Logger does not correctly handle instantiation errors

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14906

--- Comment #9 from Marcel de Rooy  ---
(In reply to Jesse Weaver from comment #8)
> May I ask why this was resolved invalid? It's a rather surprising silent
> failure that I had to find with a debugger, and anything besides silence
> would be preferable. Yes, this is unlikely in production, but it would still
> be nice to fix.

Please check the earlier comments. The solution proposed was not adequate. On
itself no reason to close the report, I agree.
If you have a better solution, please reopen.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14906] Koha::Logger does not correctly handle instantiation errors

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14906

Jesse Weaver  changed:

   What|Removed |Added

 CC||jwea...@bywatersolutions.co
   ||m

--- Comment #8 from Jesse Weaver  ---
May I ask why this was resolved invalid? It's a rather surprising silent
failure that I had to find with a debugger, and anything besides silence would
be preferable. Yes, this is unlikely in production, but it would still be nice
to fix.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14906] Koha::Logger does not correctly handle instantiation errors

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14906

Jonathan Druart  changed:

   What|Removed |Added

 Resolution|--- |INVALID
 Status|Failed QA   |RESOLVED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14906] Koha::Logger does not correctly handle instantiation errors

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14906

--- Comment #7 from Marcel de Rooy  ---
(In reply to Jonathan Druart from comment #6)
> Forget last comment.
> 
> Marcel, what do you suggest?

If one of those two logfiles (opac, intranet) is not writable, log4perl will
crash nicely. The goal was to prevent such a crash.
So I would suggest to add the warnings about the unwritable logfile and still
return undef. So do not call log4perl and no additional log message. Note that
this situation should be quite unusual. Probably both files are writable or
both are not.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14906] Koha::Logger does not correctly handle instantiation errors

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14906

--- Comment #4 from Marcel de Rooy  ---
(In reply to Jonathan Druart from comment #0)
> Also, the _check_conf subroutine will fail (return undef) if at least 1 path
> is not correctly defined, which is not necessary:

Yes it is.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14906] Koha::Logger does not correctly handle instantiation errors

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14906

Marcel de Rooy  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |
 CC||m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14906] Koha::Logger does not correctly handle instantiation errors

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14906

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #3 from Marcel de Rooy  ---
First chmod your opac logfile to 400.
Second, try this test please:

use Koha::Logger;
my $logger = Koha::Logger->get({ interface => 'opac' });
$logger->warn('L4');

Without this patch, you will have no warning since the log is not writable.
With your patch, the program will crash (on the following call on line 132
after calling _check_conf):
Log::Log4perl->init_once($conf);
The intention of the code in Logger.pm was just to prevent such a crash.
This patch reintroduces it.

Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14906] Koha::Logger does not correctly handle instantiation errors

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14906

--- Comment #6 from Jonathan Druart  
---
Forget last comment.

Marcel, what do you suggest?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14906] Koha::Logger does not correctly handle instantiation errors

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14906

--- Comment #5 from Jonathan Druart  
---
I get
Logger configuration error - Wrong permission for file
/home/koha/var/log/opac-error.log at t.pl line 289.
Can't open /home/koha/var/log/opac-error.log (Permission denied) at
/usr/share/perl5/Log/Log4perl/Appender/File.pm line 124.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14906] Koha::Logger does not correctly handle instantiation errors

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14906

--- Comment #1 from Jonathan Druart  
---
Created attachment 42904
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42904=edit
Bug 14906: Koha::Logger - handle permission issues

Koha::Logger should log in the regular log files if the paths are not
correctly set (does not exist, no permission to write, etc.).

Test plan:
Set a path without write permission for the intranet in the log4perl
configuration file. The one for opac should be correct.
Try to write 1 line in the OPAC file.
Without this patch, nothing is logged, and nothing is warned in the
regular Koha log file.
With this patch, the line in the OPAC log file will be appened and the
Koha log file will have a line with a permission issue.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14906] Koha::Logger does not correctly handle instantiation errors

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14906

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |jonathan.dru...@bugs.koha-c
   ||ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14906] Koha::Logger does not correctly handle instantiation errors

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14906

Jonathan Druart  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14906] Koha::Logger does not correctly handle instantiation errors

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14906

Jonathan Druart  changed:

   What|Removed |Added

 Depends on||14167
   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=14597


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14167
[Bug 14167] Add Koha::Logger based on Log4perl
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14906] Koha::Logger does not correctly handle instantiation errors

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14906

Kyle M Hall  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14906] Koha::Logger does not correctly handle instantiation errors

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14906

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #42904|0   |1
is obsolete||

--- Comment #2 from Kyle M Hall  ---
Created attachment 42918
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42918=edit
[SIGNED-OFF] Bug 14906: Koha::Logger - handle permission issues

Koha::Logger should log in the regular log files if the paths are not
correctly set (does not exist, no permission to write, etc.).

Test plan:
Set a path without write permission for the intranet in the log4perl
configuration file. The one for opac should be correct.
Try to write 1 line in the OPAC file.
Without this patch, nothing is logged, and nothing is warned in the
regular Koha log file.
With this patch, the line in the OPAC log file will be appened and the
Koha log file will have a line with a permission issue.

Signed-off-by: Kyle M Hall 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/