[Koha-bugs] [Bug 14974] Use the REST API for cities

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14974

Andrew Isherwood  changed:

   What|Removed |Added

 CC|bugzi...@warmlight.co.uk|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14974] Use the REST API for cities

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14974

--- Comment #20 from Jonathan Druart  ---
Bug 30160 is going to provide an alternative using React.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14974] Use the REST API for cities

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14974

Jonathan Druart  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=30160

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14974] Use the REST API for cities

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14974

--- Comment #19 from Jonathan Druart  ---
(In reply to Fridolin Somers from comment #18)
> Dream became true in Bug 25279

Well, not really.
The idea here was to use the different REST API routes for all CRUD operations,
not only list.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14974] Use the REST API for cities

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14974

Fridolin Somers  changed:

   What|Removed |Added

 Status|Patch doesn't apply |RESOLVED
 CC||fridolin.som...@biblibre.co
   ||m
 Resolution|--- |DUPLICATE

--- Comment #18 from Fridolin Somers  ---
Dream became true in Bug 25279

*** This bug has been marked as a duplicate of bug 25279 ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14974] Use the REST API for cities

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14974

Jonathan Druart  changed:

   What|Removed |Added

  Component|Architecture, internals,|REST api
   |and plumbing|
 QA Contact|testo...@bugs.koha-communit |
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14974] Use the REST API for cities

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14974

--- Comment #17 from Andrew Isherwood  ---
In addition to Martin's previous comment, have any reference libraries /
functions been created in order to actually make the API calls and work with
the response?

As part of our in-progress stock rotation feature we're intending using AJAX &
the REST API to simplify one particular function. Martin is working on the
endpoint, I'm doing the front-end, but don't want to roll my own calling
functions if there is an intention to have a standardised way of doing it.

Cheers!
Andrew

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14974] Use the REST API for cities

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14974

--- Comment #16 from Martin Renvoize  ---
Is Kyle planning to submit his ReactJS alternative to here or is that going
elsewhere?

I'm looking forward to seeing the alternative in code :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14974] Use the REST API for cities

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14974

Josef Moravec  changed:

   What|Removed |Added

 Depends on||17428
 CC||josef.mora...@gmail.com


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17428
[Bug 17428] REST API: CRUD endpoint for cities
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14974] Use the REST API for cities

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14974

--- Comment #15 from Jonathan Druart  
---
(In reply to Tomás Cohen Arazi from comment #14)
> (In reply to Jonathan Druart from comment #12)
> > Resetting assignee to default as I have already submitted my try.
> 
> Jonathan, do u allow me to split this into
> * REST API endpoint for handling cities
> * Use cities endpoint for CRUD
> 
> Maybe that's the way to do it so it is simpler to achieve.

Yes of course.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14974] Use the REST API for cities

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14974

--- Comment #14 from Tomás Cohen Arazi  ---
(In reply to Jonathan Druart from comment #12)
> Resetting assignee to default as I have already submitted my try.

Jonathan, do u allow me to split this into
* REST API endpoint for handling cities
* Use cities endpoint for CRUD

Maybe that's the way to do it so it is simpler to achieve.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14974] Use the REST API for cities

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14974

Tomás Cohen Arazi  changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |jonathan.dru...@bugs.koha-c
   ||ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14974] Use the REST API for cities

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14974
Bug 14974 depends on bug 13799, which changed state.

Bug 13799 Summary: Add base for building RESTful API
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799

   What|Removed |Added

 Status|Pushed to Master|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14974] Use the REST API for cities

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14974

--- Comment #13 from Olli-Antti Kivilahti  ---
(In reply to Jonathan Druart from comment #12)
> Resetting assignee to default as I have already submitted my try.

Good :)
Don't burnout yourself with incessant rebasing.

patch applier should be able to do basic merging

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14974] Use the REST API for cities

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14974

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|jonathan.dru...@bugs.koha-c |gmcha...@gmail.com
   |ommunity.org|

--- Comment #12 from Jonathan Druart  
---
Resetting assignee to default as I have already submitted my try.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14974] Use the REST API for cities

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14974

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

 CC||bgkrie...@gmail.com
 Status|Needs Signoff   |Patch doesn't apply

--- Comment #11 from Bernardo Gonzalez Kriegel  ---
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/cities.tt
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/en/modules/admin/cities.tt
Auto-merging api/v1/swagger.json
Failed to merge in the changes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14974] Use the REST API for cities

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14974

--- Comment #10 from Olli-Antti Kivilahti  ---
Facebook uses Flux. That is interesting and very lightweight.
AngularJS is big and needs non-standard html element attributes.
I would prefer to not have non-standard html attributes or even data-*
attributes unless necessary.
Also worried about AngularJS being too one-minded in how to do things.
That can be a good thing as well. Especially for a project like Koha where we
have a lot of developers from around the world doing things their way. Having a
good formal development pattern helps a lot.

I am 40% for AngularJS, maybe even 50% if I look really hard :)
I think most of the guys feeling for REST API and javascript frameworks are
here, so I think it s safe to ask how do you feel about AngularJS?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14974] Use the REST API for cities

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14974

Julian Maurice  changed:

   What|Removed |Added

 Status|In Discussion   |Needs Signoff

--- Comment #9 from Julian Maurice  ---
No AngularJS/SomethingElseJS proposal so far, so I suggest we move forward with
this. Changing status to Needs signoff to have more opinions

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14974] Use the REST API for cities

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14974

--- Comment #8 from Julian Maurice  ---
Created attachment 50022
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50022=edit
Bug 14974: Try to make benefit from using the API

Previous patch immediately redirect after each action (add/edit/delete)
so there is no real benefit from using the API.
This patch move the add/edit form into a modal window, and redraw the
table after each action, so the page is never reloaded.
It also adds a messages area to put messages in (after success/error)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14974] Use the REST API for cities

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14974

--- Comment #7 from Kyle M Hall  ---
Thanks for your input Andrew! I'm sure any guidance and guidelines you may
suggest would be greatly appreciated!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14974] Use the REST API for cities

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14974

--- Comment #5 from Martin Renvoize  ---
I've posted a followup to the main api bug to showcase using $ref's to split up
the specification file, that 'should' help with that side of things a bit.

UI wise, I agree we need a good example implementation an I think AngularJS
would be a great one to showcase here too.

I'm not entirely sure that $resource is still the way to go with angular now,
I've asked a colleague (whose spent the best part of the last year shoulder
deep in angular) to come in and comment on angular best practice to help guide
us.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14974] Use the REST API for cities

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14974

Andrew Isherwood  changed:

   What|Removed |Added

 CC||andrew.isherwood@ptfs-europ
   ||e.com

--- Comment #6 from Andrew Isherwood  ---
Hi all

My first posting to the Koha community, exciting stuff! :)

As Martin mentioned, I've been working with Angular for about a year, so I'm by
no means an expert (Angular is a big beastie), I've got a good feel for ways to
do things and how Angular "works".

The $resource service is a nice wrapper around the $http service and enables
you to create API resource objects that can be interacted with in the
traditional CRUD methods. If you're starting from scratch and looking for a
consistent way of accessing API resources then it's a good way to go.

Although I'm up to my eyeballs at the moment (aren't we all), I'd be happy to
offer any guidance if it's all needed.

Cheers
Andrew
--
Andrew Isherwood
Software Developer
PTFS Europe Limited
Content Management and Library Solutions
+44 (0) 20 8123 4257
email: andrew.isherw...@ptfs-europe.com
skype: andrewisherwood.ptfseurope
web: http://www.ptfs-europe.com/

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14974] Use the REST API for cities

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14974

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|In Discussion

--- Comment #2 from Jonathan Druart  
---
I would be happy to see a try using AngularJS.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14974] Use the REST API for cities

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14974

--- Comment #1 from Jonathan Druart  
---
Created attachment 43194
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43194=edit
Bug 14974: Joubu's try to use the REST API for cities

Here's my try.
The naive way is to do AJAX calls and redirect to the list after
delete/update/add.

The main issue is that it does not simplify the code so far...

Question:
How to display notif to the user after actions (delete/update/add)?
How to simplify the swagger file?
How to present a search interface?

See other comments in the code.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14974] Use the REST API for cities

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14974

Jonathan Druart  changed:

   What|Removed |Added

 CC||ch...@bigballofwax.co.nz,
   ||julian.maur...@biblibre.com
   ||,
   ||jwea...@bywatersolutions.co
   ||m,
   ||k...@bywatersolutions.com,
   ||martin.renvoize@ptfs-europe
   ||.com,
   ||olli-antti.kivila...@jns.fi
   ||, tomasco...@gmail.com

--- Comment #3 from Jonathan Druart  
---
Hi everyone (ccing some people who could be interested in this discussion),
Bug 13799 is going to pass the QA step.
I think we need to know where we are going and what is the next step.
Beside the authentication problem, how could we use the REST API from Koha
scripts?

I have submitted my naive implementation (see above), but it's not so nice and
would like to see what you have in mind.

We need to have good basis, write guidelines and impose them, before pushing
any patches, IMO. What is suggested on bug 13799 is too light and need a
framework to be used efficiently.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14974] Use the REST API for cities

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14974

Kyle M Hall  changed:

   What|Removed |Added

 CC||kyle.m.h...@gmail.com

--- Comment #4 from Kyle M Hall  ---
(In reply to Jonathan Druart from comment #2)
> I would be happy to see a try using AngularJS.

Looks good! I've *love* to see an Angular implementation!

I think as a best practice we should build our interfaces so they can interact
with Angular's $resource service factory with no customization wherever
possible ( see
http://www.sitepoint.com/creating-crud-app-minutes-angulars-resource/ for
example ).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/