[Koha-bugs] [Bug 15083] acqui/currency.pl is unused

2015-11-05 Thread bugzilla-daemon 
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15083

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||tomasco...@gmail.com

--- Comment #4 from Tomás Cohen Arazi  ---
Patch pushed to master.

Thanks Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15083] acqui/currency.pl is unused

2015-11-04 Thread bugzilla-daemon 
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15083

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15083] acqui/currency.pl is unused

2015-11-04 Thread bugzilla-daemon 
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15083

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #44158|0   |1
is obsolete||

--- Comment #3 from Katrin Fischer  ---
Created attachment 44458
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44458=edit
[PASSED QA] Bug 15083: Remove acqui/currency.pl

This script has scary FIXMEs and can be removed.
It is never called from Koha code.
On the way, this patch remove the C4::Budgets::ModCurrencies subroutine,
which was only called from this script.

Test plan:
  git grep 'acqui/currency.pl
and
  git grep ModCurrencies
should not return anything.

Signed-off-by: Bernardo Gonzalez Kriegel 
No more ModeCurrencies, no call to acqui/currency.pl
No errors

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15083] acqui/currency.pl is unused

2015-10-29 Thread bugzilla-daemon 
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15083

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

  Attachment #44155|0   |1
is obsolete||

--- Comment #2 from Bernardo Gonzalez Kriegel  ---
Created attachment 44158
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44158=edit
[SIGNED-OFF] Bug 15083: Remove acqui/currency.pl

This script has scary FIXMEs and can be removed.
It is never called from Koha code.
On the way, this patch remove the C4::Budgets::ModCurrencies subroutine,
which was only called from this script.

Test plan:
  git grep 'acqui/currency.pl
and
  git grep ModCurrencies
should not return anything.

Signed-off-by: Bernardo Gonzalez Kriegel 
No more ModeCurrencies, no call to acqui/currency.pl
No errors

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15083] acqui/currency.pl is unused

2015-10-29 Thread bugzilla-daemon 
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15083

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15083] acqui/currency.pl is unused

2015-10-29 Thread bugzilla-daemon 
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15083

--- Comment #1 from Jonathan Druart  
---
Created attachment 44155
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44155=edit
Bug 15083: Remove acqui/currency.pl

This script has scary FIXMEs and can be removed.
It is never called from Koha code.
On the way, this patch remove the C4::Budgets::ModCurrencies subroutine,
which was only called from this script.

Test plan:
  git grep 'acqui/currency.pl
and
  git grep ModCurrencies
should not return anything.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15083] acqui/currency.pl is unused

2015-10-29 Thread bugzilla-daemon 
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15083

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||15084


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15084
[Bug 15084] Move the currency related code to Koha::Cities
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15083] acqui/currency.pl is unused

2015-10-29 Thread bugzilla-daemon 
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15083

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/