[Koha-bugs] [Bug 15190] Bad utf8 decode to unapi and fixing blank screen error status

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15190

--- Comment #11 from Marcel de Rooy  ---
http://code4lib.org/files/unapi_revision_1-14.html

https://www.google.nl/url?sa=t=j==s=web=4=0ahUKEwjFvafUzPbJAhWCDhoKHarGDJUQFgg4MAM=https%3A%2F%2Fir.library.oregonstate.edu%2Fxmlui%2Fbitstream%2Fhandle%2F1957%2F2359%2Fintro-unapi-draftV15.doc%3Fsequence%3D8=AFQjCNEGxssbXiRQmzUPElGJkGQd1hjx5w=bv.110151844,d.bGQ

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15190] Bad utf8 decode to unapi and fixing blank screen error status

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15190

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl
 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15190] Bad utf8 decode to unapi and fixing blank screen error status

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15190

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #10 from Marcel de Rooy  ---
Hector:
Thanks for your patch.
I think we still need some changes before moving this to PQA:

[1] The encoding problem is imo concentrated in these lines:

Around line 155 we should do:
print $cgi->header( -type =>'application/xml', -charset => 'UTF-8' );
Add the character set ! (Maybe this is needed a few times more..)

Around line 147 we should use chars instead of toString:
# $content = $record_dom->toString();
$content = $transformer->output_as_chars( $record_dom );

According to my testing that should resolve the encoding problem. Note that I
would prefer to stick to the binmode statement and not add the decodes.

[2] The change from 406 to 400 is arguable. Why change it now?

[3] Do not redirect to other Koha scripts. This is a separate unAPI
implementation. What does unAPI exactly say about such statuses? (I could not
reach its site for now..) Note that the browser may affect the results
displayed too. I saw differences here between FF and IE.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15190] Bad utf8 decode to unapi and fixing blank screen error status

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15190

Jonathan Druart  changed:

   What|Removed |Added

 CC||gmcha...@gmail.com,
   ||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #9 from Jonathan Druart  
---
Looks good to me, but I don't have enough expertise in this script to be 100%
confident with the changes.
Galen, could we get your opinion on this patch please?
I am not sure about 2 points:
- replace printing header with a redirect
- move error 406 to 400

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15190] Bad utf8 decode to unapi and fixing blank screen error status

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15190

Marc Véron  changed:

   What|Removed |Added

  Attachment #45428|0   |1
is obsolete||

--- Comment #8 from Marc Véron  ---
Created attachment 45432
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45432=edit
Bug 15190: Bad utf8 decode to unapi and fixing blank screen error status

Fix bad utf8 decoding, also fix cgi->header(-status) to
redirect to one of the posible error pages in /cgi-bin/koha/errors/

To reproduce the issue in OPAC
1) Copy from LOC (Z39.50) ISBN 8467020113 or test it with whichever record with
   special characters
2) Open URL in OPAC cgi-bin/koha/unapi?id=koha:biblionumber:4=oai_dc
   play with oai_dc, srw_dc, mods, mods-full, mods3, mods3-full, rdfdc.
   Note: marcxml does not fail
3) Enter the new biblionumber for ISBN 8467020113 or the record of your choise
4) An oai_dc record will display, notice about the bad utf8
   decoding characters
5) Search the record in OPAC
6) To reproduce blank screen (error status) play with:
cgi-bin/koha/unapi?id=koha:biblionumber:4=
cgi-bin/koha/unapi?id=koha:biblionumber:4=none
cgi-bin/koha/unapi?id=koha:biblionumber:=oai_dc
cgi-bin/koha/unapi?=oai_dc
7) If possible test in NORMARC (UNIMARC will launch an error because bug 15162)

Test plan
-Apply patch
-Follow steps 2 to 6
-You will see no errors in utf8 and redirection to one of the
 error pages in /cgi-bin/koha/errors/

--
Bad formatting reproduced e.g. with format=srw_dc, blank page reproduced with
oai_dc,
after applying patch formatting and redirect to error page OK
Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15190] Bad utf8 decode to unapi and fixing blank screen error status

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15190

Marc Véron  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15190] Bad utf8 decode to unapi and fixing blank screen error status

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15190

--- Comment #4 from Héctor Eduardo Castro Avalos  ---
(In reply to Marc Véron from comment #3)
> Hi Hector, I could reproduce the blank screen issue and it is resolved with
> your patch.
> 
> Regarding the bad utf8 encoding (#4 in test plan), can you give a hint on
> what is wrong?

Hi Marc, for me the patch works well, maybe I need to reword message of commit.
Let me improve.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15190] Bad utf8 decode to unapi and fixing blank screen error status

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15190

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

  Attachment #44887|0   |1
is obsolete||

--- Comment #5 from Héctor Eduardo Castro Avalos  ---
Created attachment 45427
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45427=edit
Bug 15190: Bad utf8 decode to unapi and fixing blank screen error status

Fix bad utf8 decoding, also fix cgi->header(-status) to
redirect to one of the posible error pages in /cgi-bin/koha/errors/

To reproduce the issue in OPAC
1) Copy from LOC (Z39.50) ISBN 8467020113 or test it with whichever record with
   special characters
2) Open URL in OPAC cgi-bin/koha/unapi?id=koha:biblionumber:4=marcxml
3) Enter the new biblionumber for ISBN 8467020113 or the record of your choise
4) A marcxml record will display, notice about the bad utf8
   decoding characters
5) Search the record in opac and try to save in Zotero (see bad decoding)
6) To reproduce blank screen (error status) play with:
cgi-bin/koha/unapi?id=koha:biblionumber:4=
cgi-bin/koha/unapi?id=koha:biblionumber:4=none
cgi-bin/koha/unapi?id=koha:biblionumber:=marcxml
cgi-bin/koha/unapi?=oai_dc
7) If possible test in NORMARC (UNIMARC will launch an error because bug 15162)

Test plan
-Apply patch
-Follow steps 2 to 6
-You will see no errors in utf8 and redirection to one of the
 error pages in /cgi-bin/koha/errors/

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15190] Bad utf8 decode to unapi and fixing blank screen error status

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15190

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

  Attachment #45427|0   |1
is obsolete||

--- Comment #7 from Héctor Eduardo Castro Avalos  ---
Created attachment 45428
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45428=edit
Bug 15190: Bad utf8 decode to unapi and fixing blank screen error status

Fix bad utf8 decoding, also fix cgi->header(-status) to
redirect to one of the posible error pages in /cgi-bin/koha/errors/

To reproduce the issue in OPAC
1) Copy from LOC (Z39.50) ISBN 8467020113 or test it with whichever record with
   special characters
2) Open URL in OPAC cgi-bin/koha/unapi?id=koha:biblionumber:4=oai_dc
   play with oai_dc, srw_dc, mods, mods-full, mods3, mods3-full, rdfdc.
   Note: marcxml does not fail
3) Enter the new biblionumber for ISBN 8467020113 or the record of your choise
4) An oai_dc record will display, notice about the bad utf8
   decoding characters
5) Search the record in OPAC
6) To reproduce blank screen (error status) play with:
cgi-bin/koha/unapi?id=koha:biblionumber:4=
cgi-bin/koha/unapi?id=koha:biblionumber:4=none
cgi-bin/koha/unapi?id=koha:biblionumber:=oai_dc
cgi-bin/koha/unapi?=oai_dc
7) If possible test in NORMARC (UNIMARC will launch an error because bug 15162)

Test plan
-Apply patch
-Follow steps 2 to 6
-You will see no errors in utf8 and redirection to one of the
 error pages in /cgi-bin/koha/errors/

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15190] Bad utf8 decode to unapi and fixing blank screen error status

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15190

--- Comment #6 from Héctor Eduardo Castro Avalos  ---
(In reply to Marc Véron from comment #3)

> Regarding the bad utf8 encoding (#4 in test plan), can you give a hint on
> what is wrong?

Ahh.. Ok I understand the deconding problem only happend with oai_dc, srw_dc,
mods, mods-full, mods3, mods3-full, rdfdc

The format marcxml works well doesn't have utf8 decoding problem.

Antología de entremeses del Siglo de Oro /
Arellano, Ignacio.
  
García Valdés, Celsa Carmen,
ed.
  

If you apply the patch
Antología de entremeses del Siglo de Oro /
Arellano, Ignacio.
  
García Valdés, Celsa Carmen,
ed.
  

I saw the problem in 3.14 or 3.16 but I think in some way someone corrected the
problem, Zotero take metadata from marcxml.

Whe i was testing this bug I only tested with oai_dc, srw_dc and rdfdc.

That's my mistake

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15190] Bad utf8 decode to unapi and fixing blank screen error status

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15190

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch

--- Comment #3 from Marc Véron  ---
Hi Hector, I could reproduce the blank screen issue and it is resolved with
your patch.

Regarding the bad utf8 encoding (#4 in test plan), can you give a hint on what
is wrong?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15190] Bad utf8 decode to unapi and fixing blank screen error status

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15190

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |hector.hecax...@gmail.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15190] Bad utf8 decode to unapi and fixing blank screen error status

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15190

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

  Attachment #44861|0   |1
is obsolete||

--- Comment #2 from Héctor Eduardo Castro Avalos  ---
Created attachment 44887
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44887=edit
Bug 15190: Bad utf8 decode to unapi and fixing blank screen error status

Fix bad utf8 decoding, also fix cgi->header(-status) to
redirect to one of the posible error pages in /cgi-bin/koha/errors/

To test
1) Copy from LOC (Z39.50) ISBN 8467020113
2) Open URL cgi-bin/koha/unapi?id=koha:biblionumber:4=marcxml
3) (enter the new biblionumber for ISBN 8467020113)
4) A marcxml record will display, notice about the bad utf8
   decoding characters
5) Search the record in opac and try to save in Zotero (see bad decoding)
6) To reproduce blank screen (error status) play with:
cgi-bin/koha/unapi?id=koha:biblionumber:4
cgi-bin/koha/unapi?id=koha:biblionumber:4=
cgi-bin/koha/unapi?id=koha:biblionumber:4=none
cgi-bin/koha/unapi?id=koha:biblionumber:=marcxml
cgi-bin/koha/unapi?=oai_dc
cgi-bin/koha/unapi?
7) If possible test in NORMARC (UNIMARC will launch an error because bug 15162)
-Apply patch
-Follow steps 2 to 6
-You will see no errors in utf8 and redirection to one of the
 error pages in /cgi-bin/koha/errors/

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15190] Bad utf8 decode to unapi and fixing blank screen error status

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15190

Héctor Eduardo Castro Avalos  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15190] Bad utf8 decode to unapi and fixing blank screen error status

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15190

--- Comment #1 from Héctor Eduardo Castro Avalos  ---
Created attachment 44861
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44861=edit
15190 - Bad utf8 decode to unapi and fixing blank screen error status

Fix bad utf8 decoding, also fix cgi->header(-status) to
redirect to one of the posible error pages in /cgi-bin/koha/errors/

To test
1) Copy from LOC (Z39.50) ISBN 8467020113
2) Open URL cgi-bin/koha/unapi?id=koha:biblionumber:4=marcxml
3) (enter the new biblionumber for ISBN 8467020113)
4) A marcxml record will display, notice about the bad utf8
   decoding characters
5) Search the record in opac and try to save in Zotero (see bad decoding)
   delete record from Zotero.
6) To reproduce blank screen (error status) play with:
cgi-bin/koha/unapi?id=koha:biblionumber:4
cgi-bin/koha/unapi?id=koha:biblionumber:4=
cgi-bin/koha/unapi?id=koha:biblionumber:4=none
cgi-bin/koha/unapi?id=koha:biblionumber:=marcxml
cgi-bin/koha/unapi?=oai_dc
cgi-bin/koha/unapi?
7) If possible test in NORMARC (UNIMARC will launch an error because bug 15162)
-Apply patch
-Follow steps 2 to 6
-You will see no errors in utf8 and redirection to one of the
 error pages in /cgi-bin/koha/errors/

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/