[Koha-bugs] [Bug 15225] Make HTML5Media work with file upload feature

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15225

Kyle M Hall  changed:

   What|Removed |Added

 CC||k...@bywatersolutions.com
 Status|Passed QA   |Pushed to Master

--- Comment #13 from Kyle M Hall  ---
Pushed to master, thanks Mirko and Marcel!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15225] Make HTML5Media work with file upload feature

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15225

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #45976|0   |1
is obsolete||

--- Comment #11 from Marcel de Rooy  ---
Created attachment 45977
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45977=edit
Bug 15225: [QA Follow-up] Improve changes to gethtml5media

[1] Improve readability, add some checks.
[2] Add the public flag for OPAC use. (If a file has not been marked as
public, we should not return it in OPAC.)

Test plan:
See original commit. No changes in behavior.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15225] Make HTML5Media work with file upload feature

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15225

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #12 from Marcel de Rooy  ---
QA Comment:
Added some extra checks in the follow-up. Note that the regex for the extension
would return the whole file name if there was no extension.
The surrounding code may need some further attention for things like:
Use of uninitialized value $HTML5MediaParent in string ne at C4/HTML5Media.pm
line 205.

Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15225] Make HTML5Media work with file upload feature

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15225

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #45724|0   |1
is obsolete||

--- Comment #8 from Marcel de Rooy  ---
Created attachment 45975
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45975=edit
Bug 15225: Make HTML5Media work with file upload feature.

Koha::Upload allows files to be attached to bibliographic records.
HTML5Media streaming in Koha does not work with these files.

Test plan:
- apply patch
- make sure OPACBaseURL is set correctly
- enable HTML5MediaEnabled in OPAC and staff client
- connect upload.pl to 856$u in your framework
- upload a file with an extension set in HTML5MediaExtensions,
  make sure to set the codec correctly if you use WEBM (subfield c,
  eg. 'vp8, vorbis')
- save record, view in staff client and browser, check if 'Play
  media' option is available and works

Signed-off-by: Hugo Agud 
Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15225] Make HTML5Media work with file upload feature

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15225

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #45725|0   |1
is obsolete||

--- Comment #9 from Marcel de Rooy  ---
Created attachment 45976
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45976=edit
Bug 15225: [QA Follow-up] Improve changes to gethtml5media

[1] Improve readability, add some checks.
[2] Add the public flag for OPAC use. (If a file has not been marked as
public, we should not return it in OPAC.)

Test plan:
See original commit. No changes in behavior.

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15225] Make HTML5Media work with file upload feature

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15225

--- Comment #10 from Marcel de Rooy  ---
(In reply to Hugo Agud from comment #7)
> This is how we have tested, just step 7 is diffente
> 
> 7. Configure 856$q (video/webm or video/mp4)

Thanks, Hugo. That works.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15225] Make HTML5Media work with file upload feature

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15225

--- Comment #5 from Marcel de Rooy  ---
Created attachment 45725
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45725=edit
Bug 15225: [QA Follow-up] Improve changes to gethtml5media

[1] Improve readability, add some checks.
[2] Add the public flag for OPAC use. (If a file has not been marked as
public, we should not return it in OPAC.)

Test plan:
See original commit. No changes in behavior.

Signed-off-by: Marcel de Rooy 
Verified results with some additional debug lines.
Somehow, showing the results in the browser was harder. This is not related
to the changes on this report, but probably to the surrounding code.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15225] Make HTML5Media work with file upload feature

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15225

Marcel de Rooy  changed:

   What|Removed |Added

  Attachment #45205|0   |1
is obsolete||

--- Comment #4 from Marcel de Rooy  ---
Created attachment 45724
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45724=edit
Bug 15225: Make HTML5Media work with file upload feature.

Koha::Upload allows files to be attached to bibliographic records.
HTML5Media streaming in Koha does not work with these files.

Test plan:
- apply patch
- make sure OPACBaseURL is set correctly
- enable HTML5MediaEnabled in OPAC and staff client
- connect upload.pl to 856$u in your framework
- upload a file with an extension set in HTML5MediaExtensions,
  make sure to set the codec correctly if you use WEBM (subfield c,
  eg. 'vp8, vorbis')
- save record, view in staff client and browser, check if 'Play
  media' option is available and works

Signed-off-by: Marcel de Rooy 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15225] Make HTML5Media work with file upload feature

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15225

--- Comment #6 from Marcel de Rooy  ---
Before passing QA:

Mirko or Hugo: Could you please confirm if the follow-up works for you.

Secondly,
I tried adding a mp3 and a webm file in the 856. And added a $c. (Enabled both
prefs.)
But I did not get results.
I suspect that the surrounding code in gethtml5media is not complete.
I saw some warnings on some of the keys in $HTML5Media (mime, parent, .. )
Could you elaborate some more on the steps needed to have actual results in the
browser?

Thanks.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15225] Make HTML5Media work with file upload feature

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15225

--- Comment #7 from Hugo Agud  ---

This is how we have tested, just step 7 is diffente

In order to test the patch
0. Make sure that you have propertly added the video format in
HTML5MediaExtensions
1 apply patch
2 make sure OPACBaseURL is set correctly
3 enable HTML5MediaEnabled in OPAC and staff client
4 connect upload.pl to 856$u in your framework
5. connect upload.pl to 856$u in your framework
6. upload a file with an extension set in HTML5MediaExtensions
7. Configure 856$q (video/webm or video/mp4)
8. SAve record, view in staff client and browser, check if 'PLay media' option
is available and works

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15225] Make HTML5Media work with file upload feature

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15225

Marcel de Rooy  changed:

   What|Removed |Added

Version|unspecified |master
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15225] Make HTML5Media work with file upload feature

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15225

Marcel de Rooy  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |

--- Comment #3 from Marcel de Rooy  ---
QA: Will be looking at this one very soon.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15225] Make HTML5Media work with file upload feature

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15225

Hugo Agud  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 Who signed the||Hugo Agud
  patch off||
 CC||ha...@orex.es

--- Comment #2 from Hugo Agud  ---
We have applied the patch and works fine at least with the files type webm and
mp4

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15225] Make HTML5Media work with file upload feature

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15225

--- Comment #1 from Mirko Tietgen  ---
Created attachment 45205
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45205=edit
Bug 15225: Make HTML5Media work with file upload feature.

Koha::Upload allows files to be attached to bibliographic records.
HTML5Media streaming in Koha does not work with these files.

Test plan:
- apply patch
- make sure OPACBaseURL is set correctly
- enable HTML5MediaEnabled in OPAC and staff client
- connect upload.pl to 856$u in your framework
- upload a file with an extension set in HTML5MediaExtensions,
  make sure to set the codec correctly if you use WEBM (subfield c,
  eg. 'vp8, vorbis')
- save record, view in staff client and browser, check if 'Play
  media' option is available and works

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15225] Make HTML5Media work with file upload feature

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15225

Mirko Tietgen  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15225] Make HTML5Media work with file upload feature

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15225

Mirko Tietgen  changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |mi...@abunchofthings.net

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15225] Make HTML5Media work with file upload feature

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15225

Mirko Tietgen  changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=15226

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/