[Koha-bugs] [Bug 15244] t/db_dependent/Reserves.t depends on external data/configuration

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15244

Frédéric Demians  changed:

   What|Removed |Added

 CC||frede...@tamil.fr

--- Comment #16 from Frédéric Demians  ---
This patch has been pushed to 3.20.x, will be in 3.20.7.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15244] t/db_dependent/Reserves.t depends on external data/configuration

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15244

Julian Maurice  changed:

   What|Removed |Added

 CC||julian.maur...@biblibre.com
 Status|Pushed to Master|Pushed to Stable

--- Comment #15 from Julian Maurice  ---
Patch pushed to 3.22.x, will be in 3.22.1

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15244] t/db_dependent/Reserves.t depends on external data/configuration

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15244

Kyle M Hall  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||k...@bywatersolutions.com

--- Comment #14 from Kyle M Hall  ---
Pushed to master!

Thanks Marc!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15244] t/db_dependent/Reserves.t depends on external data/configuration

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15244

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15244] t/db_dependent/Reserves.t depends on external data/configuration

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15244

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #45431|0   |1
is obsolete||

--- Comment #13 from Katrin Fischer  ---
Created attachment 45437
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45437=edit
[PASSED QA] Bug 15244: t/db_dependent/Reserves.t depends on external
data/configuration

Test 14 in t/db_dependent/Reserves.t fails if syspref LocalHoldsPriority is
set to "[Give] priority for filling holds to patrons whose...

To verify:
- Set syspref as above and run test. Test 14 fails.
- Set syspref to [Don't give] and run test agein, it passes OK.

To test:
- Apply patch
- Run test again with syspref set / not set
Expected result: In both cases test should pass

(AMended to change bug title)

Signed-off-by: Galen Charlton 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15244] t/db_dependent/Reserves.t depends on external data/configuration

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15244

Galen Charlton  changed:

   What|Removed |Added

  Attachment #45287|0   |1
is obsolete||

--- Comment #12 from Galen Charlton  ---
Created attachment 45431
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45431=edit
Bug 15244: t/db_dependent/Reserves.t depends on external data/configuration

Test 14 in t/db_dependent/Reserves.t fails if syspref LocalHoldsPriority is
set to "[Give] priority for filling holds to patrons whose...

To verify:
- Set syspref as above and run test. Test 14 fails.
- Set syspref to [Don't give] and run test agein, it passes OK.

To test:
- Apply patch
- Run test again with syspref set / not set
Expected result: In both cases test should pass

(AMended to change bug title)

Signed-off-by: Galen Charlton 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15244] t/db_dependent/Reserves.t depends on external data/configuration

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15244

Galen Charlton  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15244] t/db_dependent/Reserves.t depends on external data/configuration

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15244

--- Comment #10 from Marc Véron  ---
Created attachment 45291
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45291=edit
Bug 15243 - Place a hold on... Fix display issue and improve translatability

This patch fixes strings in request.tt that are untranslatable because of
splitting by html tags inside the strings.

Additionally, the value of maxreserves was used in one string, but not
filled in every case.

That's why the patch introduces a new function GetAllowedReserves in
C4/Reserves.pm to retrieve the maximum count of allowed reserves (depending
on syspref maxreserves and on issuingrules).

To test:
- If not yet done, apply patch from Bug 15244
- Run t/db_dependent/Reserves.t, verify that it passes OK
- Apply this patch
- Run t/db_dependent/Reserves.t again, should pass OK
- Set syspref 'maxreserves' to 1
- Try to place a hold for a patron who already has holds
- Verify that the warning message displays the value above
- Set the syspref to a high value
- Try to place a hold for a patron who has reached the maximum
  allowed holds defined by issuing rules
- Verify that the warning message with the maximum number of
  holds allowed by issuing rules
- Try to trigger other warning messages and/or carefully review
  code in request.tt line 307 and following.
  Additonal messages to trigger are:
  - Already in possession
  - Hold already placed
  - Age restricted
  - No items available
  - Too many holds

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15244] t/db_dependent/Reserves.t depends on external data/configuration

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15244

Marc Véron  changed:

   What|Removed |Added

  Attachment #45291|0   |1
is obsolete||

--- Comment #11 from Marc Véron  ---
Comment on attachment 45291
  --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45291
Bug 15243 - Place a hold on... Fix display issue and improve translatability

Sorry, mistaked with bug number...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15244] t/db_dependent/Reserves.t depends on external data/configuration

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15244

Marc Véron  changed:

   What|Removed |Added

  Attachment #45286|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15244] t/db_dependent/Reserves.t depends on external data/configuration

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15244

Marc Véron  changed:

   What|Removed |Added

Summary|Fix failing test 14 in  |t/db_dependent/Reserves.t
   |t/db_dependent/Reserves.t   |depends on external
   ||data/configuration

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15244] t/db_dependent/Reserves.t depends on external data/configuration

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15244

--- Comment #9 from Marc Véron  ---
Created attachment 45287
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45287=edit
Bug 15244: t/db_dependent/Reserves.t depends on external data/configuration

Test 14 in t/db_dependent/Reserves.t fails if syspref LocalHoldsPriority is
set to "[Give] priority for filling holds to patrons whose...

To verify:
- Set syspref as above and run test. Test 14 fails.
- Set syspref to [Don't give] and run test agein, it passes OK.

To test:
- Apply patch
- Run test again with syspref set / not set
Expected result: In both cases test should pass

(AMended to change bug title)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15244] t/db_dependent/Reserves.t depends on external data/configuration

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15244

Marc Véron  changed:

   What|Removed |Added

   Patch complexity|--- |Trivial patch
 Status|NEW |Needs Signoff
   Assignee|koha-b...@lists.koha-commun |ve...@veron.ch
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/