[Koha-bugs] [Bug 15261] Verify if checkout or hold request periods overlap with existing holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 --- Comment #114 from Katrin Fischer --- Is this something that could be replaced by the new bookings development? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15261] Verify if checkout or hold request periods overlap with existing holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 --- Comment #113 from Fridolin Somers --- Pref template must be fixed : choices yes/no must be 1/0 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15261] Verify if checkout or hold request periods overlap with existing holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 --- Comment #112 from Katrin Fischer --- I think the idea was about 'booking' things in advance. Could we maybe replace this bug with: Bug 29002 - Add ability to book items ahead of time ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15261] Verify if checkout or hold request periods overlap with existing holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15261] Verify if checkout or hold request periods overlap with existing holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261
--- Comment #111 from Fridolin Somers ---
(In reply to Henri-Damien LAURENT from comment #108)
> Created attachment 131573 [details] [review]
> Bug 15261: Trying to fix after rebase
>
> https://bugs.koha-community.org/show_bug.cgi?id=1526
Also missing in opac/opac-reserve.pl :
if ( $canreserve &&
C4::Context->preference("PreventReservesOnSamePeriod") ) {
-if ( ReservesOnSamePeriod($biblioNum, $itemNum, $startdate,
$expiration_date) ) {
+if ( C4::Reserves::ReservesOnSamePeriod($biblioNum, $itemNum,
$startdate, $expiration_date) ) {
$canreserve = 0;
$failed_holds++;
}
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15261] Verify if checkout or hold request periods overlap with existing holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 Fridolin Somers changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #110 from Fridolin Somers --- Ouch, koha-tmpl/intranet-tmpl/prog/en/modules/reserve/placerequest.tt is using obsolete YUI : -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15261] Verify if checkout or hold request periods overlap with existing holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261
--- Comment #109 from Fridolin Somers ---
(In reply to Henri-Damien LAURENT from comment #108)
> Created attachment 131573 [details] [review]
> Bug 15261: Trying to fix after rebase
>
> https://bugs.koha-community.org/show_bug.cgi?id=1526
Careful you added warns (for debug I bet) :
if ( C4::Context->preference("PreventCheckoutOnSameReservePeriod") ) {
+ warn $date_due;
+ warn "Inside";
unless ($date_due) {
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15261] Verify if checkout or hold request periods overlap with existing holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 --- Comment #108 from Henri-Damien LAURENT --- Created attachment 131573 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131573=edit Bug 15261: Trying to fix after rebase https://bugs.koha-community.org/show_bug.cgi?id=1526 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15261] Verify if checkout or hold request periods overlap with existing holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 Henri-Damien LAURENT changed: What|Removed |Added Attachment #125796|0 |1 is obsolete|| --- Comment #107 from Henri-Damien LAURENT --- Created attachment 131572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131572=edit Bug 15261: Always check preference PreventCheckoutOnSameReservePeriod first https://bugs.koha-community.org/show_bug.cgi?id=1526 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15261] Verify if checkout or hold request periods overlap with existing holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 Henri-Damien LAURENT changed: What|Removed |Added Attachment #125795|0 |1 is obsolete|| --- Comment #106 from Henri-Damien LAURENT --- Created attachment 131571 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131571=edit Bug 15261: Prevent checkout only if for a different borrower https://bugs.koha-community.org/show_bug.cgi?id=1526 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15261] Verify if checkout or hold request periods overlap with existing holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 Henri-Damien LAURENT changed: What|Removed |Added Attachment #125794|0 |1 is obsolete|| --- Comment #105 from Henri-Damien LAURENT --- Created attachment 131570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131570=edit Bug 15261: (QA follow-up) https://bugs.koha-community.org/show_bug.cgi?id=1526 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15261] Verify if checkout or hold request periods overlap with existing holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261
Henri-Damien LAURENT changed:
What|Removed |Added
Attachment #125793|0 |1
is obsolete||
--- Comment #104 from Henri-Damien LAURENT ---
Created attachment 131569
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131569=edit
Bug 15261: Check if checkout/reserve request overlaps existing reserves
When checking out or placing hold, we should check if an existing
reserve whose period overlap exists.
- A user places a hold from opac whose requested period overlaps with an
existing reserve period => prevent reserve
- A librarian places a hold from staff whose requested period overlaps
with an existing reserve period => Warn librarian (Ask for
confirmation)
- A librarian makes a checkout from staff whose requested period
overlaps with an existing reserve period => Warn librarian (Ask for
confirmation)
Test plan:
Enable syspref: AllowHoldDateInFuture OPACAllowHoldDateInFuture
PreventChechoutOnSameReservePeriod and PreventReservesOnSamePeriod
1 (staff side):
- Place a hold on title (which has only one items) level with start date
and expiration date.
- Place another hold (also title level) with period overlaping this
reserve.
- Check you are warned about an existing reserve
2 (staff side):
- Place a hold on title (which has more than one items) level with start
date and expiration date.
- Place another hold (also title level) with period overlaping this
reserve.
- Check you are NOT warned about an existing reserve. Because it remains
at least one item not reserved.
3 (staff side):
- Place a hold on item level with start date and expiration date.
- Place another hold on item level with period overlaping this reserve.
- Check you are warned about an existing reserve.
4 (opac side):
- Do the same than for staff side. Instead of a warn, reserve is
prevented.
5:
- Place a hold on title (which has only one items) level with start date
and expiration date.
- Try to checkout the unique item from this title with period overlaping
the reserve period.
- Check you are warned about an existing reserve
6:
- Place a hold on title (which has more than one items) level with start
date and expiration date.
- Checkout an item from this title with period overlaping the reserve
period.
- Check you are NOT warned about an existing reserve.
7:
- Place a hold on item level with start date and expiration date.
- Checkout this item period overlaping the reserve period.
- Check you are warned about an existing reserve
8:
- Create a checkout (i.e from ${TODAY} to ${TODAY + 10 days}),
- Place a hold on the same item from ${TODAY + 11 days} to ${TODAY + 30
days}),
- Check that you cannot renew the checkout.
Signed-off-by: Laurence Rault
https://bugs.koha-community.org/show_bug.cgi?id=1526
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15261] Verify if checkout or hold request periods overlap with existing holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 Fridolin Somers changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=29002 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15261] Verify if checkout or hold request periods overlap with existing holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 --- Comment #103 from Alex Arnaud --- (In reply to Fridolin Somers from comment #98) > Created attachment 123405 [details] [review] > Bug 15261: Always check preference PreventCheckoutOnSameReservePeriod first > > Proposed patch (may not apply on current master) All patches rebased -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15261] Verify if checkout or hold request periods overlap with existing holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 Alex Arnaud changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15261] Verify if checkout or hold request periods overlap with existing holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 Alex Arnaud changed: What|Removed |Added Attachment #123405|0 |1 is obsolete|| --- Comment #102 from Alex Arnaud --- Created attachment 125796 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125796=edit Bug 15261: Always check preference PreventCheckoutOnSameReservePeriod first -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15261] Verify if checkout or hold request periods overlap with existing holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 Alex Arnaud changed: What|Removed |Added Attachment #120822|0 |1 is obsolete|| --- Comment #101 from Alex Arnaud --- Created attachment 125795 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125795=edit Bug 15261: Prevent checkout only if for a different borrower -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15261] Verify if checkout or hold request periods overlap with existing holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 Alex Arnaud changed: What|Removed |Added Attachment #106949|0 |1 is obsolete|| --- Comment #100 from Alex Arnaud --- Created attachment 125794 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125794=edit Bug 15261: (QA follow-up) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15261] Verify if checkout or hold request periods overlap with existing holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261
Alex Arnaud changed:
What|Removed |Added
Attachment #106944|0 |1
is obsolete||
--- Comment #99 from Alex Arnaud ---
Created attachment 125793
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=125793=edit
Bug 15261: Check if checkout/reserve request overlaps existing reserves
When checking out or placing hold, we should check if an existing
reserve whose period overlap exists.
- A user places a hold from opac whose requested period overlaps with an
existing reserve period => prevent reserve
- A librarian places a hold from staff whose requested period overlaps
with an existing reserve period => Warn librarian (Ask for
confirmation)
- A librarian makes a checkout from staff whose requested period
overlaps with an existing reserve period => Warn librarian (Ask for
confirmation)
Test plan:
Enable syspref: AllowHoldDateInFuture OPACAllowHoldDateInFuture
PreventChechoutOnSameReservePeriod and PreventReservesOnSamePeriod
1 (staff side):
- Place a hold on title (which has only one items) level with start date
and expiration date.
- Place another hold (also title level) with period overlaping this
reserve.
- Check you are warned about an existing reserve
2 (staff side):
- Place a hold on title (which has more than one items) level with start
date and expiration date.
- Place another hold (also title level) with period overlaping this
reserve.
- Check you are NOT warned about an existing reserve. Because it remains
at least one item not reserved.
3 (staff side):
- Place a hold on item level with start date and expiration date.
- Place another hold on item level with period overlaping this reserve.
- Check you are warned about an existing reserve.
4 (opac side):
- Do the same than for staff side. Instead of a warn, reserve is
prevented.
5:
- Place a hold on title (which has only one items) level with start date
and expiration date.
- Try to checkout the unique item from this title with period overlaping
the reserve period.
- Check you are warned about an existing reserve
6:
- Place a hold on title (which has more than one items) level with start
date and expiration date.
- Checkout an item from this title with period overlaping the reserve
period.
- Check you are NOT warned about an existing reserve.
7:
- Place a hold on item level with start date and expiration date.
- Checkout this item period overlaping the reserve period.
- Check you are warned about an existing reserve
8:
- Create a checkout (i.e from ${TODAY} to ${TODAY + 10 days}),
- Place a hold on the same item from ${TODAY + 11 days} to ${TODAY + 30
days}),
- Check that you cannot renew the checkout.
Signed-off-by: Laurence Rault
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15261] Verify if checkout or hold request periods overlap with existing holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 --- Comment #98 from Fridolin Somers --- Created attachment 123405 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123405=edit Bug 15261: Always check preference PreventCheckoutOnSameReservePeriod first Proposed patch (may not apply on current master) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15261] Verify if checkout or hold request periods overlap with existing holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 --- Comment #97 from Fridolin Somers --- In CanBookBeRenewed(), $date_due is computed even if system preference PreventCheckoutOnSameReservePeriod is off. This has an impact on performance. We may add if PreventCheckoutOnSameReservePeriod earlier. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15261] Verify if checkout or hold request periods overlap with existing holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 --- Comment #96 from Arthur Suzuki --- Just had a quick check at this patch. Seems the controls on the overlapping reserves is done in the interface code (opac/place-reserve.pl and so on) and not in C4/Reserves. This is then not checked for ILS-DI and RestAPI. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15261] Verify if checkout or hold request periods overlap with existing holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 --- Comment #95 from Fridolin Somers --- @Julian : You had this fix "Prevent checkout only if for a different borrower" on 17.11. All patches need master rebase. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15261] Verify if checkout or hold request periods overlap with existing holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 --- Comment #94 from Fridolin Somers --- Created attachment 120822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=120822=edit Bug 15261: Prevent checkout only if for a different borrower -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15261] Verify if checkout or hold request periods overlap with existing holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261
--- Comment #93 from Fridolin Somers ---
diff --git a/circ/circulation.pl b/circ/circulation.pl
index 5ec80c8f15..abfbb9306c 100755
--- a/circ/circulation.pl
+++ b/circ/circulation.pl
@@ -410,6 +410,10 @@ if (@$barcodes) {
}
unless($confirm_required) {
my $switch_onsite_checkout = exists
$messages->{ONSITE_CHECKOUT_WILL_BE_SWITCHED};
+if ( $cancelreserve eq 'cancel' ) {
+CancelReserve({ reserve_id => $query->param('reserveid') });
+}
+$cancelreserve = $cancelreserve eq 'revert' ? 'revert' : undef;
CancelReserve does not exist anymore, see Bug 19059
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15261] Verify if checkout or hold request periods overlap with existing holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 Fridolin Somers changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply --- Comment #92 from Fridolin Somers --- Bug 25758 changed signature of CanBookBeRenewed() adding $cron Update this patch in C4/Circulation.pm and svc/renew -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15261] Verify if checkout or hold request periods overlap with existing holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 Arthur Suzuki changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15261] Verify if checkout or hold request periods overlap with existing holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 --- Comment #91 from Arthur Suzuki --- Created attachment 106949 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106949=edit Bug 15261: (QA follow-up) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15261] Verify if checkout or hold request periods overlap with existing holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 Arthur Suzuki changed: What|Removed |Added Assignee|alex.arn...@biblibre.com|arthur.suz...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15261] Verify if checkout or hold request periods overlap with existing holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 Arthur Suzuki changed: What|Removed |Added Status|Patch doesn't apply |ASSIGNED --- Comment #90 from Arthur Suzuki --- working on rebase right now :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15261] Verify if checkout or hold request periods overlap with existing holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 Arthur Suzuki changed: What|Removed |Added Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15261] Verify if checkout or hold request periods overlap with existing holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261
Arthur Suzuki changed:
What|Removed |Added
Attachment #98672|0 |1
is obsolete||
--- Comment #89 from Arthur Suzuki ---
Created attachment 106944
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106944=edit
Bug 15261: Check if checkout/reserve request overlaps existing reserves
When checking out or placing hold, we should check if an existing
reserve whose period overlap exists.
- A user places a hold from opac whose requested period overlaps with an
existing reserve period => prevent reserve
- A librarian places a hold from staff whose requested period overlaps
with an existing reserve period => Warn librarian (Ask for
confirmation)
- A librarian makes a checkout from staff whose requested period
overlaps with an existing reserve period => Warn librarian (Ask for
confirmation)
Test plan:
Enable syspref: AllowHoldDateInFuture OPACAllowHoldDateInFuture
PreventChechoutOnSameReservePeriod and PreventReservesOnSamePeriod
1 (staff side):
- Place a hold on title (which has only one items) level with start date
and expiration date.
- Place another hold (also title level) with period overlaping this
reserve.
- Check you are warned about an existing reserve
2 (staff side):
- Place a hold on title (which has more than one items) level with start
date and expiration date.
- Place another hold (also title level) with period overlaping this
reserve.
- Check you are NOT warned about an existing reserve. Because it remains
at least one item not reserved.
3 (staff side):
- Place a hold on item level with start date and expiration date.
- Place another hold on item level with period overlaping this reserve.
- Check you are warned about an existing reserve.
4 (opac side):
- Do the same than for staff side. Instead of a warn, reserve is
prevented.
5:
- Place a hold on title (which has only one items) level with start date
and expiration date.
- Try to checkout the unique item from this title with period overlaping
the reserve period.
- Check you are warned about an existing reserve
6:
- Place a hold on title (which has more than one items) level with start
date and expiration date.
- Checkout an item from this title with period overlaping the reserve
period.
- Check you are NOT warned about an existing reserve.
7:
- Place a hold on item level with start date and expiration date.
- Checkout this item period overlaping the reserve period.
- Check you are warned about an existing reserve
8:
- Create a checkout (i.e from ${TODAY} to ${TODAY + 10 days}),
- Place a hold on the same item from ${TODAY + 11 days} to ${TODAY + 30
days}),
- Check that you cannot renew the checkout.
Signed-off-by: Laurence Rault
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15261] Verify if checkout or hold request periods overlap with existing holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 Katrin Fischer changed: What|Removed |Added Summary|Verify if checkouts or |Verify if checkout or hold |reserves requests periods |request periods overlap |overlap with existing |with existing holds |reserves| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15261] Verify if checkout or hold request periods overlap with existing holds
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Patch doesn't apply --- Comment #88 from Katrin Fischer --- Hi Alex, can you please rebase and test this patch really carefully? I looked at the code a while ago and had a feeling that some things probably weren't quite right due to previous rebasing. 98672 - Bug 15261: Check if checkout/reserve request overlaps existing reserves Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 15261: Check if checkout/reserve request overlaps existing reserves Using index info to reconstruct a base tree... M C4/Circulation.pm M C4/Reserves.pm M Koha/DateUtils.pm M circ/circulation.pl M installer/data/mysql/sysprefs.sql M koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref M koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt M opac/opac-reserve.pl M reserve/placerequest.pl M svc/renew M t/db_dependent/Circulation.t Falling back to patching base and 3-way merge... Auto-merging t/db_dependent/Circulation.t Auto-merging svc/renew Auto-merging reserve/placerequest.pl Auto-merging opac/opac-reserve.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref Auto-merging installer/data/mysql/sysprefs.sql Auto-merging circ/circulation.pl Auto-merging Koha/DateUtils.pm Auto-merging C4/Reserves.pm Auto-merging C4/Circulation.pm CONFLICT (content): Merge conflict in C4/Circulation.pm -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
