[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261

sandbo...@biblibre.com  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #86 from sandbo...@biblibre.com  ---
Patch tested with a sandbox, by Laurence Rault 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261

sandbo...@biblibre.com  changed:

   What|Removed |Added

  Attachment #98383|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261

--- Comment #87 from sandbo...@biblibre.com  ---
Created attachment 98672
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98672=edit
Bug 15261: Check if checkout/reserve request overlaps existing reserves

When checking out or placing hold, we should check if an existing
reserve whose period overlap exists.

- A user places a hold from opac whose requested period overlaps with an
  existing reserve period => prevent reserve
- A librarian places a hold from staff whose requested period overlaps
  with an existing reserve period => Warn librarian (Ask for
  confirmation)
- A librarian makes a checkout from staff whose requested period
  overlaps with an existing reserve period => Warn librarian (Ask for
  confirmation)

Test plan:

Enable syspref: AllowHoldDateInFuture OPACAllowHoldDateInFuture
  PreventChechoutOnSameReservePeriod and PreventReservesOnSamePeriod

1 (staff side):
- Place a hold on title (which has only one items) level with start date
  and expiration date.
- Place another hold (also title level) with period overlaping this
  reserve.
- Check you are warned about an existing reserve

2 (staff side):
- Place a hold on title (which has more than one items) level with start
  date and expiration date.
- Place another hold (also title level) with period overlaping this
  reserve.
- Check you are NOT warned about an existing reserve. Because it remains
  at least one item not reserved.

3 (staff side):
- Place a hold on item level with start date and expiration date.
- Place another hold on item level with period overlaping this reserve.
- Check you are warned about an existing reserve.

4 (opac side):
- Do the same than for staff side. Instead of a warn, reserve is
  prevented.

5:
- Place a hold on title (which has only one items) level with start date
  and expiration date.
- Try to checkout the unique item from this title with period overlaping
  the reserve period.
- Check you are warned about an existing reserve

6:
- Place a hold on title (which has more than one items) level with start
  date and expiration date.
- Checkout an item from this title with period overlaping the reserve
  period.
- Check you are NOT warned about an existing reserve.

7:
- Place a hold on item level with start date and expiration date.
- Checkout this item period overlaping the reserve period.
- Check you are warned about an existing reserve

8:
- Create a checkout (i.e from ${TODAY} to ${TODAY + 10 days}),
- Place a hold on the same item from ${TODAY + 11 days} to ${TODAY + 30
days}),
- Check that you cannot renew the checkout.

Signed-off-by: Laurence Rault 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261

--- Comment #85 from Laurence Rault  ---
tested on biblibre sandbox1

all tests OK

One remark on test 6 : when there are several items, and hold is placed on
title, there is no warn when checking out on item, OK.
I think we could be warned if all items are checked out with overlap, maybe
when checking out the last available item, as no more item is available for
hold then.
But this could be be an improvement.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261

Julian Maurice  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

--- Comment #84 from Julian Maurice  ---
Resetting status to Needs Signoff now that bug 24410 is pushed to master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261

Julian Maurice  changed:

   What|Removed |Added

  Attachment #98383|1   |0
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261

Julian Maurice  changed:

   What|Removed |Added

 Status|BLOCKED |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261

Julian Maurice  changed:

   What|Removed |Added

  Attachment #98424|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261

Julian Maurice  changed:

   What|Removed |Added

 Status|Failed QA   |BLOCKED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261

Julian Maurice  changed:

   What|Removed |Added

 Depends on||24410


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24410
[Bug 24410] Multi holds broken
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261

--- Comment #83 from Julian Maurice  ---
Apparently holds are broken on master (bug 24410). We better wait for this bug
to be resolved before rebasing it again.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261

Laurence Rault  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #82 from Laurence Rault  ---
Patch put on biblibre sandbox 1

1 : impossible to place a hold from staff : 
First click on Place hold button in request.pl do nothing ; second click makes
browser do something but next page never displays and reserve is not added
(tested in firefox and chromium)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261

Julian Maurice  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261

Julian Maurice  changed:

   What|Removed |Added

  Attachment #98383|0   |1
is obsolete||

--- Comment #81 from Julian Maurice  ---
Created attachment 98424
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98424=edit
Bug 15261: Check if checkout/reserve request overlaps existing reserves

When checking out or placing hold, we should check if an existing
reserve whose period overlap exists.

- A user places a hold from opac whose requested period overlaps with an
  existing reserve period => prevent reserve
- A librarian places a hold from staff whose requested period overlaps
  with an existing reserve period => Warn librarian (Ask for
  confirmation)
- A librarian makes a checkout from staff whose requested period
  overlaps with an existing reserve period => Warn librarian (Ask for
  confirmation)

Test plan:

Enable syspref: AllowHoldDateInFuture OPACAllowHoldDateInFuture
  PreventChechoutOnSameReservePeriod and PreventReservesOnSamePeriod

1 (staff side):
- Place a hold on title (which has only one items) level with start date
  and expiration date.
- Place another hold (also title level) with period overlaping this
  reserve.
- Check you are warned about an existing reserve

2 (staff side):
- Place a hold on title (which has more than one items) level with start
  date and expiration date.
- Place another hold (also title level) with period overlaping this
  reserve.
- Check you are NOT warned about an existing reserve. Because it remains
  at least one item not reserved.

3 (staff side):
- Place a hold on item level with start date and expiration date.
- Place another hold on item level with period overlaping this reserve.
- Check you are warned about an existing reserve.

4 (opac side):
- Do the same than for staff side. Instead of a warn, reserve is
  prevented.

5:
- Place a hold on title (which has only one items) level with start date
  and expiration date.
- Try to checkout the unique item from this title with period overlaping
  the reserve period.
- Check you are warned about an existing reserve

6:
- Place a hold on title (which has more than one items) level with start
  date and expiration date.
- Checkout an item from this title with period overlaping the reserve
  period.
- Check you are NOT warned about an existing reserve.

7:
- Place a hold on item level with start date and expiration date.
- Checkout this item period overlaping the reserve period.
- Check you are warned about an existing reserve

8:
- Create a checkout (i.e from ${TODAY} to ${TODAY + 10 days}),
- Place a hold on the same item from ${TODAY + 11 days} to ${TODAY + 30
  days}),
- Check that you cannot renew the checkout.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261

--- Comment #80 from Julian Maurice  ---
Patch rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261

Julian Maurice  changed:

   What|Removed |Added

  Attachment #94871|0   |1
is obsolete||

--- Comment #79 from Julian Maurice  ---
Created attachment 98383
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98383=edit
Bug 15261: Check if checkout/reserve request overlaps existing reserves

When checking out or placing hold, we should check if an existing
reserve whose period overlap exists.

- A user places a hold from opac whose requested period overlaps with an
  existing reserve period => prevent reserve
- A librarian places a hold from staff whose requested period overlaps
  with an existing reserve period => Warn librarian (Ask for
  confirmation)
- A librarian makes a checkout from staff whose requested period
  overlaps with an existing reserve period => Warn librarian (Ask for
  confirmation)

Test plan:

Enable syspref: AllowHoldDateInFuture OPACAllowHoldDateInFuture
  PreventChechoutOnSameReservePeriod and PreventReservesOnSamePeriod

1 (staff side):
- Place a hold on title (which has only one items) level with start date
  and expiration date.
- Place another hold (also title level) with period overlaping this
  reserve.
- Check you are warned about an existing reserve

2 (staff side):
- Place a hold on title (which has more than one items) level with start
  date and expiration date.
- Place another hold (also title level) with period overlaping this
  reserve.
- Check you are NOT warned about an existing reserve. Because it remains
  at least one item not reserved.

3 (staff side):
- Place a hold on item level with start date and expiration date.
- Place another hold on item level with period overlaping this reserve.
- Check you are warned about an existing reserve.

4 (opac side):
- Do the same than for staff side. Instead of a warn, reserve is
  prevented.

5:
- Place a hold on title (which has only one items) level with start date
  and expiration date.
- Try to checkout the unique item from this title with period overlaping
  the reserve period.
- Check you are warned about an existing reserve

6:
- Place a hold on title (which has more than one items) level with start
  date and expiration date.
- Checkout an item from this title with period overlaping the reserve
  period.
- Check you are NOT warned about an existing reserve.

7:
- Place a hold on item level with start date and expiration date.
- Checkout this item period overlaping the reserve period.
- Check you are warned about an existing reserve

8:
- Create a checkout (i.e from ${TODAY} to ${TODAY + 10 days}),
- Place a hold on the same item from ${TODAY + 11 days} to ${TODAY + 30
days}),
- Check that you cannot renew the checkout.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261

Laurence Rault  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

--- Comment #78 from Laurence Rault  ---
Applied on sandbox

CONFLICT (content): Merge conflict in t/db_dependent/Circulation.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261

Julian Maurice  changed:

   What|Removed |Added

  Attachment #93136|0   |1
is obsolete||

--- Comment #77 from Julian Maurice  ---
Created attachment 94871
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94871=edit
Bug 15261: Check if checkout/reserve request overlaps existing reserves

When checking out or placing hold, we should check if an existing
reserve whose period overlap exists.

- A user places a hold from opac whose requested period overlaps with an
  existing reserve period => prevent reserve
- A librarian places a hold from staff whose requested period overlaps
  with an existing reserve period => Warn librarian (Ask for
  confirmation)
- A librarian makes a checkout from staff whose requested period
  overlaps with an existing reserve period => Warn librarian (Ask for
  confirmation)

Test plan:

Enable syspref: AllowHoldDateInFuture OPACAllowHoldDateInFuture
  PreventChechoutOnSameReservePeriod and PreventReservesOnSamePeriod

1 (staff side):
- Place a hold on title (which has only one items) level with start date
  and expiration date.
- Place another hold (also title level) with period overlaping this
  reserve.
- Check you are warned about an existing reserve

2 (staff side):
- Place a hold on title (which has more than one items) level with start
  date and expiration date.
- Place another hold (also title level) with period overlaping this
  reserve.
- Check you are NOT warned about an existing reserve. Because it remains
  at least one item not reserved.

3 (staff side):
- Place a hold on item level with start date and expiration date.
- Place another hold on item level with period overlaping this reserve.
- Check you are warned about an existing reserve.

4 (opac side):
- Do the same than for staff side. Instead of a warn, reserve is
  prevented.

5:
- Place a hold on title (which has only one items) level with start date
  and expiration date.
- Try to checkout the unique item from this title with period overlaping
  the reserve period.
- Check you are warned about an existing reserve

6:
- Place a hold on title (which has more than one items) level with start
  date and expiration date.
- Checkout an item from this title with period overlaping the reserve
  period.
- Check you are NOT warned about an existing reserve.

7:
- Place a hold on item level with start date and expiration date.
- Checkout this item period overlaping the reserve period.
- Check you are warned about an existing reserve

8:
- Create a checkout (i.e from ${TODAY} to ${TODAY + 10 days}),
- Place a hold on the same item from ${TODAY + 11 days} to ${TODAY + 30
days}),
- Check that you cannot renew the checkout.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261

Julian Maurice  changed:

   What|Removed |Added

  Attachment #92584|0   |1
is obsolete||
  Attachment #92585|0   |1
is obsolete||
  Attachment #92664|0   |1
is obsolete||

--- Comment #76 from Julian Maurice  ---
Created attachment 93136
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=93136=edit
Bug 15261: Check if checkout/reserve request overlaps existing reserves

When checking out or placing hold, we should check if an existing
reserve whose period overlap exists.

- A user places a hold from opac whose requested period overlaps with an
  existing reserve period => prevent reserve
- A librarian places a hold from staff whose requested period overlaps
  with an existing reserve period => Warn librarian (Ask for
  confirmation)
- A librarian makes a checkout from staff whose requested period
  overlaps with an existing reserve period => Warn librarian (Ask for
  confirmation)

Test plan:

Enable syspref: AllowHoldDateInFuture OPACAllowHoldDateInFuture
  PreventChechoutOnSameReservePeriod and PreventReservesOnSamePeriod

1 (staff side):
- Place a hold on title (which has only one items) level with start date
  and expiration date.
- Place another hold (also title level) with period overlaping this
  reserve.
- Check you are warned about an existing reserve

2 (staff side):
- Place a hold on title (which has more than one items) level with start
  date and expiration date.
- Place another hold (also title level) with period overlaping this
  reserve.
- Check you are NOT warned about an existing reserve. Because it remains
  at least one item not reserved.

3 (staff side):
- Place a hold on item level with start date and expiration date.
- Place another hold on item level with period overlaping this reserve.
- Check you are warned about an existing reserve.

4 (opac side):
- Do the same than for staff side. Instead of a warn, reserve is
  prevented.

5:
- Place a hold on title (which has only one items) level with start date
  and expiration date.
- Try to checkout the unique item from this title with period overlaping
  the reserve period.
- Check you are warned about an existing reserve

6:
- Place a hold on title (which has more than one items) level with start
  date and expiration date.
- Checkout an item from this title with period overlaping the reserve
  period.
- Check you are NOT warned about an existing reserve.

7:
- Place a hold on item level with start date and expiration date.
- Checkout this item period overlaping the reserve period.
- Check you are warned about an existing reserve

8:
- Create a checkout (i.e from ${TODAY} to ${TODAY + 10 days}),
- Place a hold on the same item from ${TODAY + 11 days} to ${TODAY + 30
days}),
- Check that you cannot renew the checkout.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261

Arthur Suzuki  changed:

   What|Removed |Added

 Blocks||23669


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23669
[Bug 23669] Verify if checkouts or reserves requests from ILS-DI periods
overlap with existing reserves
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261

Arthur Suzuki  changed:

   What|Removed |Added

 CC||arthur.suz...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261

Julian Maurice  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261

--- Comment #75 from Julian Maurice  ---
Created attachment 92664
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92664=edit
Bug 15261: Fix compilation error in reserve/placerequest.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261

Laurence Rault  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #74 from Laurence Rault  ---
1) Place a hold on title (which has only one items) level with start date
and expiration date : 
impossible to validate the hold : 
Global symbol "@realbi" requires explicit package name (did you forget to
declare "my @realbi"?) at /home/koha/src/reserve/placerequest.pl line 107.
Execution of /home/koha/src/reserve/placerequest.pl aborted due to compilation
errors.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261

Julian Maurice  changed:

   What|Removed |Added

  Attachment #92377|0   |1
is obsolete||

--- Comment #73 from Julian Maurice  ---
Created attachment 92585
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92585=edit
Bug 15261: Check reserves while renewing an issue

Test plan:

  - Create an issue (i.e from 15/09/2017 to 04/10/2017),
  - place a reserve on the same item from 05/10/2017 to 30/10/2017),
  - enable PreventCheckoutOnSameReservePeriod,
  - Check that you are not able to renew the issue.

Rebased (2018-03-15)
Rebased (2019-04-18)

Rebased-by: Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261

Julian Maurice  changed:

   What|Removed |Added

  Attachment #92376|0   |1
is obsolete||

--- Comment #72 from Julian Maurice  ---
Created attachment 92584
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92584=edit
Bug 15261: Verify if checkouts/reserves requests periods overlap...

... with existing reserves

When checking out or placing hold, we should check if an existing
reserve whose period overlap exists.

A user place an hold from opac whose requested period overlap an
existing reserve period => prevent reserve,

A librarian place an hold from staff whose requested period overlap an
existing reserve period => Warn librarian (Ask for confirmation),

A librarian make a checkout from staff whose requested period overlap an
existing reserve period => Warn librarian (Ask for confirmation).

Test plan:

Enable syspref: AllowHoldDateInFuture OPACAllowHoldDateInFuture
  PreventChechoutOnSameReservePeriod and PreventReservesOnSamePeriod

1 (staff side):
Place a hold on title (which has only one items) level with start date
and expiration date.
Place another hold (also title level) with period overlaping this
reserve.
Check you are warned about an existing reserve

2 (staff side):
Place a hold on title (which has more than one items) level with start
date and expiration date.
Place another hold (also title level) with period overlaping this
reserve.
Check you are NOT warned about an existing reserve. Because it remains
at least one item not reserved.

3 (staff side):
Place a hold on item level with start date and expiration date.
Place another hold on item level with period overlaping this reserve.
Check you are warned about an existing reserve.

4 (opac side):
Do the same than for staff side. Instead of a warn, reserve is
prevented.

5:
Place a hold on title (which has only one items) level with start date
and expiration date.
Try to checkout the unique item from this title with period overlaping
the reserve period.
Check you are warned about an existing reserve

6:
Place a hold on title (which has more than one items) level with start
date and expiration date.
Checkout an item from this title with period overlaping the reserve
period.
Check you are NOT warned about an existing reserve.

7:
Place a hold on item level with start date and expiration date.
Checkout this item period overlaping the reserve period.
Check you are warned about an existing reserve

Rebased on master (2016-03-11)
Rebased on master (2016-06-23)
Rebased on master (2017-03-23)
Rebased on master (2018-03-15)
Rebased on master (2019-04-18)

Signed-off-by: Séverine QUEUNE 
Rebased-by: Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261

cecile.jo...@biblibre.com changed:

   What|Removed |Added

 CC||cecile.jo...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261

Julian Maurice  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261

Julian Maurice  changed:

   What|Removed |Added

  Attachment #88297|0   |1
is obsolete||

--- Comment #70 from Julian Maurice  ---
Created attachment 92376
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92376=edit
Bug 15261: Verify if checkouts/reserves requests periods overlap...

... with existing reserves

When checking out or placing hold, we should check if an existing
reserve whose period overlap exists.

A user place an hold from opac whose requested period overlap an
existing reserve period => prevent reserve,

A librarian place an hold from staff whose requested period overlap an
existing reserve period => Warn librarian (Ask for confirmation),

A librarian make a checkout from staff whose requested period overlap an
existing reserve period => Warn librarian (Ask for confirmation).

Test plan:

Enable syspref: AllowHoldDateInFuture OPACAllowHoldDateInFuture
  PreventChechoutOnSameReservePeriod and PreventReservesOnSamePeriod

1 (staff side):
Place a hold on title (which has only one items) level with start date
and expiration date.
Place another hold (also title level) with period overlaping this
reserve.
Check you are warned about an existing reserve

2 (staff side):
Place a hold on title (which has more than one items) level with start
date and expiration date.
Place another hold (also title level) with period overlaping this
reserve.
Check you are NOT warned about an existing reserve. Because it remains
at least one item not reserved.

3 (staff side):
Place a hold on item level with start date and expiration date.
Place another hold on item level with period overlaping this reserve.
Check you are warned about an existing reserve.

4 (opac side):
Do the same than for staff side. Instead of a warn, reserve is
prevented.

5:
Place a hold on title (which has only one items) level with start date
and expiration date.
Try to checkout the unique item from this title with period overlaping
the reserve period.
Check you are warned about an existing reserve

6:
Place a hold on title (which has more than one items) level with start
date and expiration date.
Checkout an item from this title with period overlaping the reserve
period.
Check you are NOT warned about an existing reserve.

7:
Place a hold on item level with start date and expiration date.
Checkout this item period overlaping the reserve period.
Check you are warned about an existing reserve

Rebased on master (2016-03-11)
Rebased on master (2016-06-23)
Rebased on master (2017-03-23)
Rebased on master (2018-03-15)
Rebased on master (2019-04-18)

Signed-off-by: Séverine QUEUNE 
Rebased-by: Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261

Julian Maurice  changed:

   What|Removed |Added

  Attachment #88298|0   |1
is obsolete||

--- Comment #71 from Julian Maurice  ---
Created attachment 92377
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92377=edit
Bug 15261: Check reserves while renewing an issue

Test plan:

  - Create an issue (i.e from 15/09/2017 to 04/10/2017),
  - place a reserve on the same item from 05/10/2017 to 30/10/2017),
  - enable PreventCheckoutOnSameReservePeriod,
  - Check that you are not able to renew the issue.

Rebased (2018-03-15)
Rebased (2019-04-18)

Rebased-by: Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261

Laurence Rault  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

--- Comment #69 from Laurence Rault  ---
Conflicts when applying on sandbox : 
CONFLICT (content): Merge conflict in reserve/placerequest.pl
Auto-merging opac/opac-reserve.pl
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
Auto-merging
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261

Julian Maurice  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261

Julian Maurice  changed:

   What|Removed |Added

  Attachment #88293|0   |1
is obsolete||

--- Comment #68 from Julian Maurice  ---
Created attachment 88298
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88298=edit
Bug 15261: Check reserves while renewing an issue

Test plan:

  - Create an issue (i.e from 15/09/2017 to 04/10/2017),
  - place a reserve on the same item from 05/10/2017 to 30/10/2017),
  - enable PreventCheckoutOnSameReservePeriod,
  - Check that you are not able to renew the issue.

Rebased (2018-03-15)
Rebased (2019-04-18)

Rebased-by: Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261

Julian Maurice  changed:

   What|Removed |Added

  Attachment #88292|0   |1
is obsolete||

--- Comment #67 from Julian Maurice  ---
Created attachment 88297
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88297=edit
Bug 15261: Verify if checkouts/reserves requests periods overlap...

... with existing reserves

When checking out or placing hold, we should check if an existing
reserve whose period overlap exists.

A user place an hold from opac whose requested period overlap an
existing reserve period => prevent reserve,

A librarian place an hold from staff whose requested period overlap an
existing reserve period => Warn librarian (Ask for confirmation),

A librarian make a checkout from staff whose requested period overlap an
existing reserve period => Warn librarian (Ask for confirmation).

Test plan:

Enable syspref: AllowHoldDateInFuture OPACAllowHoldDateInFuture
  PreventChechoutOnSameReservePeriod and PreventReservesOnSamePeriod

1 (staff side):
Place a hold on title (which has only one items) level with start date
and expiration date.
Place another hold (also title level) with period overlaping this
reserve.
Check you are warned about an existing reserve

2 (staff side):
Place a hold on title (which has more than one items) level with start
date and expiration date.
Place another hold (also title level) with period overlaping this
reserve.
Check you are NOT warned about an existing reserve. Because it remains
at least one item not reserved.

3 (staff side):
Place a hold on item level with start date and expiration date.
Place another hold on item level with period overlaping this reserve.
Check you are warned about an existing reserve.

4 (opac side):
Do the same than for staff side. Instead of a warn, reserve is
prevented.

5:
Place a hold on title (which has only one items) level with start date
and expiration date.
Try to checkout the unique item from this title with period overlaping
the reserve period.
Check you are warned about an existing reserve

6:
Place a hold on title (which has more than one items) level with start
date and expiration date.
Checkout an item from this title with period overlaping the reserve
period.
Check you are NOT warned about an existing reserve.

7:
Place a hold on item level with start date and expiration date.
Checkout this item period overlaping the reserve period.
Check you are warned about an existing reserve

Rebased on master (2016-03-11)
Rebased on master (2016-06-23)
Rebased on master (2017-03-23)
Rebased on master (2018-03-15)
Rebased on master (2019-04-18)

Signed-off-by: Séverine QUEUNE 
Rebased-by: Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261

Julian Maurice  changed:

   What|Removed |Added

  Attachment #76222|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261

--- Comment #66 from Julian Maurice  ---
Created attachment 88293
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88293=edit
Bug 15261: Check reserves while renewing an issue

Test plan:

  - Create an issue (i.e from 15/09/2017 to 04/10/2017),
  - place a reserve on the same item from 05/10/2017 to 30/10/2017),
  - enable PreventCheckoutOnSameReservePeriod,
  - Check that you are not able to renew the issue.

Rebased (2018-03-15)
Rebased (2019-04-18)

Rebased-by: Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261

Julian Maurice  changed:

   What|Removed |Added

  Attachment #76221|0   |1
is obsolete||

--- Comment #65 from Julian Maurice  ---
Created attachment 88292
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88292=edit
Bug 15261: Verify if checkouts/reserves requests periods overlap...

... with existing reserves

When checking out or placing hold, we should check if an existing
reserve whose period overlap exists.

A user place an hold from opac whose requested period overlap an
existing reserve period => prevent reserve,

A librarian place an hold from staff whose requested period overlap an
existing reserve period => Warn librarian (Ask for confirmation),

A librarian make a checkout from staff whose requested period overlap an
existing reserve period => Warn librarian (Ask for confirmation).

Test plan:

Enable syspref: AllowHoldDateInFuture OPACAllowHoldDateInFuture
  PreventChechoutOnSameReservePeriod and PreventReservesOnSamePeriod

1 (staff side):
Place a hold on title (which has only one items) level with start date
and expiration date.
Place another hold (also title level) with period overlaping this
reserve.
Check you are warned about an existing reserve

2 (staff side):
Place a hold on title (which has more than one items) level with start
date and expiration date.
Place another hold (also title level) with period overlaping this
reserve.
Check you are NOT warned about an existing reserve. Because it remains
at least one item not reserved.

3 (staff side):
Place a hold on item level with start date and expiration date.
Place another hold on item level with period overlaping this reserve.
Check you are warned about an existing reserve.

4 (opac side):
Do the same than for staff side. Instead of a warn, reserve is
prevented.

5:
Place a hold on title (which has only one items) level with start date
and expiration date.
Try to checkout the unique item from this title with period overlaping
the reserve period.
Check you are warned about an existing reserve

6:
Place a hold on title (which has more than one items) level with start
date and expiration date.
Checkout an item from this title with period overlaping the reserve
period.
Check you are NOT warned about an existing reserve.

7:
Place a hold on item level with start date and expiration date.
Checkout this item period overlaping the reserve period.
Check you are warned about an existing reserve

Rebased on master (2016-03-11)
Rebased on master (2016-06-23)
Rebased on master (2017-03-23)
Rebased on master (2018-03-15)
Rebased on master (2019-04-18)

Signed-off-by: Séverine QUEUNE 
Rebased-by: Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261

davep...@asu.edu changed:

   What|Removed |Added

 CC||davep...@asu.edu

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261

Laurence Rault  changed:

   What|Removed |Added

 CC||laurence.ra...@biblibre.com
 Status|Needs Signoff   |Patch doesn't apply

--- Comment #64 from Laurence Rault  ---
Conflict when installing on sandbox

Auto-merging
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261

--- Comment #63 from Fridolin SOMERS  ---
I had dependency on Bug 20724 because it moved code from
reserve/placerequest.pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261

Fridolin SOMERS  changed:

   What|Removed |Added

 Depends on||20724


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20724
[Bug 20724] ReservesNeedReturns syspref breaks "Holds awaiting pickup"
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261

--- Comment #62 from Fridolin SOMERS  ---
A small issue : $borrowernumber is declared twice in reserve/placerequest.pl :
  my ( $template, $borrowernumber, $cookie, $flags ) = get_template_and_user(
  my $borrowernumber=$input->param('borrowernumber');
I think we should rename the second var.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261

--- Comment #61 from Fridolin SOMERS  ---
(In reply to Alex Arnaud from comment #60)
> (In reply to Fridolin SOMERS from comment #57)
> > (In reply to Fridolin SOMERS from comment #55)
> > > Oups, looks like patch makes a lot of unwanted changes in
> > > koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
> > 
> > Oh I found it :
> > Tabs instead of 4 spaces in many places.
> > This brakes the file which is a YAML.
> 
> I have rebased the patches and removed unwanted changes on circulation.pref

Thanks a lot Alex ;)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261

Alex Arnaud  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

--- Comment #60 from Alex Arnaud  ---
(In reply to Fridolin SOMERS from comment #57)
> (In reply to Fridolin SOMERS from comment #55)
> > Oups, looks like patch makes a lot of unwanted changes in
> > koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
> 
> Oh I found it :
> Tabs instead of 4 spaces in many places.
> This brakes the file which is a YAML.

I have rebased the patches and removed unwanted changes on circulation.pref

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #72957|0   |1
is obsolete||

--- Comment #59 from Alex Arnaud  ---
Created attachment 76222
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76222=edit
Bug 15261 - Check reserves while renewing an issue

Test plan:

  - Create an issue (i.e from 15/09/2017 to 04/10/2017),
  - place a reserve on the same item from 05/10/2017 to 30/10/2017),
  - enable PreventCheckoutOnSameReservePeriod,
  - Check that you are not able to renew the issue.

Rebased (2018-03-15)
Rebased-by: Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #72956|0   |1
is obsolete||

--- Comment #58 from Alex Arnaud  ---
Created attachment 76221
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76221=edit
Bug 15261: Verify if checkouts/reserves requests periods overlap...

... with existing reserves

When checking out or placing hold, we should check if an existing
reserve whose period overlap exists.

A user place an hold from opac whose requested period overlap an
existing reserve period => prevent reserve,

A librarian place an hold from staff whose requested period overlap an
existing reserve period => Warn librarian (Ask for confirmation),

A librarian make a checkout from staff whose requested period overlap an
existing reserve period => Warn librarian (Ask for confirmation).

Test plan:

Enable syspref: AllowHoldDateInFuture OPACAllowHoldDateInFuture
  PreventChechoutOnSameReservePeriod and PreventReservesOnSamePeriod

1 (staff side):
Place a hold on title (which has only one items) level with start date
and expiration date.
Place another hold (also title level) with period overlaping this
reserve.
Check you are warned about an existing reserve

2 (staff side):
Place a hold on title (which has more than one items) level with start
date and expiration date.
Place another hold (also title level) with period overlaping this
reserve.
Check you are NOT warned about an existing reserve. Because it remains
at least one item not reserved.

3 (staff side):
Place a hold on item level with start date and expiration date.
Place another hold on item level with period overlaping this reserve.
Check you are warned about an existing reserve.

4 (opac side):
Do the same than for staff side. Instead of a warn, reserve is
prevented.

5:
Place a hold on title (which has only one items) level with start date
and expiration date.
Try to checkout the unique item from this title with period overlaping
the reserve period.
Check you are warned about an existing reserve

6:
Place a hold on title (which has more than one items) level with start
date and expiration date.
Checkout an item from this title with period overlaping the reserve
period.
Check you are NOT warned about an existing reserve.

7:
Place a hold on item level with start date and expiration date.
Checkout this item period overlaping the reserve period.
Check you are warned about an existing reserve

Rabased on master
Rebased on master (2016-06-23)
Rebased on master (2017-03-23)
Rebased on master (2018-03-15)

Signed-off-by: Séverine QUEUNE 
Signed-off-by: Séverine QUEUNE 
Rebased-by: Alex Arnaud 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261

--- Comment #57 from Fridolin SOMERS  ---
(In reply to Fridolin SOMERS from comment #55)
> Oups, looks like patch makes a lot of unwanted changes in
> koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref

Oh I found it :
Tabs instead of 4 spaces in many places.
This brakes the file which is a YAML.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261

--- Comment #56 from Fridolin SOMERS  ---
Oups there is an obsolete : use C4::Branch in
t/db_dependent/Circulation/CanBookBeIssued.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261

Fridolin SOMERS  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261

--- Comment #55 from Fridolin SOMERS  ---
Oups, looks like patch makes a lot of unwanted changes in
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261

Alex Arnaud  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #68853|0   |1
is obsolete||

--- Comment #54 from Alex Arnaud  ---
Created attachment 72957
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72957=edit
Bug 15261 - Check reserves while renewing an issue

Test plan:

  - Create an issue (i.e from 15/09/2017 to 04/10/2017),
  - place a reserve on the same item from 05/10/2017 to 30/10/2017),
  - enable PreventCheckoutOnSameReservePeriod,
  - Check that you are not able to renew the issue.

Rebased (2018-03-15)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #68852|0   |1
is obsolete||

--- Comment #53 from Alex Arnaud  ---
Created attachment 72956
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72956=edit
Bug 15261: Verify if checkouts/reserves requests periods overlap...

... with existing reserves

When checking out or placing hold, we should check if an existing
reserve whose period overlap exists.

A user place an hold from opac whose requested period overlap an
existing reserve period => prevent reserve,

A librarian place an hold from staff whose requested period overlap an
existing reserve period => Warn librarian (Ask for confirmation),

A librarian make a checkout from staff whose requested period overlap an
existing reserve period => Warn librarian (Ask for confirmation).

Test plan:

Enable syspref: AllowHoldDateInFuture OPACAllowHoldDateInFuture
  PreventChechoutOnSameReservePeriod and PreventReservesOnSamePeriod

1 (staff side):
Place a hold on title (which has only one items) level with start date
and expiration date.
Place another hold (also title level) with period overlaping this
reserve.
Check you are warned about an existing reserve

2 (staff side):
Place a hold on title (which has more than one items) level with start
date and expiration date.
Place another hold (also title level) with period overlaping this
reserve.
Check you are NOT warned about an existing reserve. Because it remains
at least one item not reserved.

3 (staff side):
Place a hold on item level with start date and expiration date.
Place another hold on item level with period overlaping this reserve.
Check you are warned about an existing reserve.

4 (opac side):
Do the same than for staff side. Instead of a warn, reserve is
prevented.

5:
Place a hold on title (which has only one items) level with start date
and expiration date.
Try to checkout the unique item from this title with period overlaping
the reserve period.
Check you are warned about an existing reserve

6:
Place a hold on title (which has more than one items) level with start
date and expiration date.
Checkout an item from this title with period overlaping the reserve
period.
Check you are NOT warned about an existing reserve.

7:
Place a hold on item level with start date and expiration date.
Checkout this item period overlaping the reserve period.
Check you are warned about an existing reserve

Rabased on master
Rebased on master (2016-06-23)
Rebased on master (2017-03-23)
Rebased on master (2018-03-15)

Signed-off-by: Séverine QUEUNE 
Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261

Lucie Gay  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||lucie.gay@ens-paris-saclay.
   ||fr

--- Comment #52 from Lucie Gay  ---
The sandbox you've requested is not ready.
Some problems occurred applying patches from bug 15261:
Something went wrong !Applying: Bug 15261: Verify if
checkouts/reserves requests periods overlap...
Using index info to reconstruct a base tree...
M C4/Circulation.pm
M C4/Reserves.pm
M Koha/DateUtils.pm
M circ/circulation.pl
M installer/data/mysql/sysprefs.sql
M koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
M koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
M opac/opac-reserve.pl
M reserve/placerequest.pl
Falling back to patching base and 3-way merge...
Auto-merging reserve/placerequest.pl
Auto-merging opac/opac-reserve.pl
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt
Auto-merging
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
Auto-merging installer/data/mysql/sysprefs.sql
Auto-merging circ/circulation.pl
Auto-merging Koha/DateUtils.pm
Auto-merging C4/Reserves.pm
Auto-merging C4/Circulation.pm
error: Failed to merge in the changes.
Patch failed at 0001 Bug 15261: Verify if checkouts/reserves requests periods
overlap...
The copy of the patch that failed is found in: .git/rebase-apply/patch
When you have resolved this problem run git bz apply --continue.
If you would prefer to skip this patch, instead run git bz apply --skip.
To restore the original branch and stop patching run git bz apply --abort.
Bug 15261 - Verify if checkouts or reserves requests periods overlap with
existing reserves

68852 - Bug 15261: Verify if checkouts/reserves requests periods overlap...
68853 - Bug 15261 - Check reserves while renewing an issue

Apply? [(y)es, (n)o, (i)nteractive] Patch left in
/tmp/Bug-15261-Verify-if-checkoutsreserves-requests-per-9hD_17.patch .

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #68664|0   |1
is obsolete||

--- Comment #51 from Alex Arnaud  ---
Created attachment 68853
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68853=edit
Bug 15261 - Check reserves while renewing an issue

Test plan:

  - Create an issue (i.e from 15/09/2017 to 04/10/2017),
  - place a reserve on the same item from 05/10/2017 to 30/10/2017),
  - enable PreventCheckoutOnSameReservePeriod,
  - Check that you are not able to renew the issue.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #68663|0   |1
is obsolete||

--- Comment #50 from Alex Arnaud  ---
Created attachment 68852
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68852=edit
Bug 15261: Verify if checkouts/reserves requests periods overlap...

... with existing reserves

When checking out or placing hold, we should check if an existing
reserve whose period overlap exists.

A user place an hold from opac whose requested period overlap an
existing reserve period => prevent reserve,

A librarian place an hold from staff whose requested period overlap an
existing reserve period => Warn librarian (Ask for confirmation),

A librarian make a checkout from staff whose requested period overlap an
existing reserve period => Warn librarian (Ask for confirmation).

Test plan:

Enable syspref: AllowHoldDateInFuture OPACAllowHoldDateInFuture
  PreventChechoutOnSameReservePeriod and PreventReservesOnSamePeriod

1 (staff side):
Place a hold on title (which has only one items) level with start date
and expiration date.
Place another hold (also title level) with period overlaping this
reserve.
Check you are warned about an existing reserve

2 (staff side):
Place a hold on title (which has more than one items) level with start
date and expiration date.
Place another hold (also title level) with period overlaping this
reserve.
Check you are NOT warned about an existing reserve. Because it remains
at least one item not reserved.

3 (staff side):
Place a hold on item level with start date and expiration date.
Place another hold on item level with period overlaping this reserve.
Check you are warned about an existing reserve.

4 (opac side):
Do the same than for staff side. Instead of a warn, reserve is
prevented.

5:
Place a hold on title (which has only one items) level with start date
and expiration date.
Try to checkout the unique item from this title with period overlaping
the reserve period.
Check you are warned about an existing reserve

6:
Place a hold on title (which has more than one items) level with start
date and expiration date.
Checkout an item from this title with period overlaping the reserve
period.
Check you are NOT warned about an existing reserve.

7:
Place a hold on item level with start date and expiration date.
Checkout this item period overlaping the reserve period.
Check you are warned about an existing reserve

Rabased on master
Rebased on master (2016-06-23)
Rebased on master (2017-03-23)

Signed-off-by: Séverine QUEUNE 
Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261

Alex Arnaud  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #67143|0   |1
is obsolete||

--- Comment #49 from Alex Arnaud  ---
Created attachment 68664
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68664=edit
Bug 15261 - Check reserves while renewing an issue

Test plan:

  - Create an issue (i.e from 15/09/2017 to 04/10/2017),
  - place a reserve on the same item from 05/10/2017 to 30/10/2017),
  - enable PreventCheckoutOnSameReservePeriod,
  - Check that you are not able to renew the issue.

rebased master (2017-10-27)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #67094|0   |1
is obsolete||

--- Comment #48 from Alex Arnaud  ---
Created attachment 68663
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68663=edit
Bug 15261: Verify if checkouts/reserves requests periods overlap...

... with existing reserves

When checking out or placing hold, we should check if an existing
reserve whose period overlap exists.

A user place an hold from opac whose requested period overlap an
existing reserve period => prevent reserve,

A librarian place an hold from staff whose requested period overlap an
existing reserve period => Warn librarian (Ask for confirmation),

A librarian make a checkout from staff whose requested period overlap an
existing reserve period => Warn librarian (Ask for confirmation).

Test plan:

Enable syspref: AllowHoldDateInFuture OPACAllowHoldDateInFuture
  PreventChechoutOnSameReservePeriod and PreventReservesOnSamePeriod

1 (staff side):
Place a hold on title (which has only one items) level with start date
and expiration date.
Place another hold (also title level) with period overlaping this
reserve.
Check you are warned about an existing reserve

2 (staff side):
Place a hold on title (which has more than one items) level with start
date and expiration date.
Place another hold (also title level) with period overlaping this
reserve.
Check you are NOT warned about an existing reserve. Because it remains
at least one item not reserved.

3 (staff side):
Place a hold on item level with start date and expiration date.
Place another hold on item level with period overlaping this reserve.
Check you are warned about an existing reserve.

4 (opac side):
Do the same than for staff side. Instead of a warn, reserve is
prevented.

5:
Place a hold on title (which has only one items) level with start date
and expiration date.
Try to checkout the unique item from this title with period overlaping
the reserve period.
Check you are warned about an existing reserve

6:
Place a hold on title (which has more than one items) level with start
date and expiration date.
Checkout an item from this title with period overlaping the reserve
period.
Check you are NOT warned about an existing reserve.

7:
Place a hold on item level with start date and expiration date.
Checkout this item period overlaping the reserve period.
Check you are warned about an existing reserve

Rabased on master
Rebased on master (2016-06-23)
Rebased on master (2017-03-23)
Rebased on master (2017-10-27)

Signed-off-by: Séverine QUEUNE 
Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #67094|1   |0
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #67143|1   |0
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #68662|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #67143|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #68661|0   |1
is obsolete||

--- Comment #47 from Alex Arnaud  ---
Created attachment 68662
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68662=edit
Bug 17829: (follow-up) Move GetMember to Koha::Patron

Do not call method on $patron if there is no other reserves

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #68660|0   |1
is obsolete||

--- Comment #46 from Alex Arnaud  ---
Created attachment 68661
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68661=edit
Bug 17829: (follow-up) Move GetMember to Koha::Patron

Do not call method on $patron if there is no other reserves

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #67094|0   |1
is obsolete||

--- Comment #45 from Alex Arnaud  ---
Created attachment 68660
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68660=edit
Bug 17829: (follow-up) Move GetMember to Koha::Patron

Do not call method on $patron if there is no other reserves

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261

Alex Buckley  changed:

   What|Removed |Added

 CC||alexbuck...@catalyst.net.nz
 Status|Needs Signoff   |Patch doesn't apply

--- Comment #44 from Alex Buckley  ---
When applying these patches this error is thrown:

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 15261: Verify if checkouts/reserves requests periods overlap...
Applying: Bug 15261 - Check reserves while renewing an issue
fatal: sha1 information is lacking or useless (C4/Circulation.pm).
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.
Patch failed at 0001 Bug 15261 - Check reserves while renewing an issue
The copy of the patch that failed is found in:
   /home/vagrant/kohaclone/.git/rebase-apply/patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in
/tmp/Bug-15261---Check-reserves-while-renewing-an-issue-b3aCiG.patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261

--- Comment #43 from Alex Arnaud  ---
Created attachment 67143
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67143=edit
Bug 15261 - Check reserves while renewing an issue

Test plan:

  - Create an issue (i.e from 15/09/2017 to 04/10/2017),
  - place a reserve on the same item from 05/10/2017 to 30/10/2017),
  - enable PreventCheckoutOnSameReservePeriod,
  - Check that you are not able to renew the issue.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261

Alex Arnaud  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #67088|0   |1
is obsolete||

--- Comment #42 from Alex Arnaud  ---
Created attachment 67094
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67094=edit
Bug 15261: Verify if checkouts/reserves requests periods overlap...

... with existing reserves

When checking out or placing hold, we should check if an existing
reserve whose period overlap exists.

A user place an hold from opac whose requested period overlap an
existing reserve period => prevent reserve,

A librarian place an hold from staff whose requested period overlap an
existing reserve period => Warn librarian (Ask for confirmation),

A librarian make a checkout from staff whose requested period overlap an
existing reserve period => Warn librarian (Ask for confirmation).

Test plan:

Enable syspref: AllowHoldDateInFuture OPACAllowHoldDateInFuture
  PreventChechoutOnSameReservePeriod and PreventReservesOnSamePeriod

1 (staff side):
Place a hold on title (which has only one items) level with start date
and expiration date.
Place another hold (also title level) with period overlaping this
reserve.
Check you are warned about an existing reserve

2 (staff side):
Place a hold on title (which has more than one items) level with start
date and expiration date.
Place another hold (also title level) with period overlaping this
reserve.
Check you are NOT warned about an existing reserve. Because it remains
at least one item not reserved.

3 (staff side):
Place a hold on item level with start date and expiration date.
Place another hold on item level with period overlaping this reserve.
Check you are warned about an existing reserve.

4 (opac side):
Do the same than for staff side. Instead of a warn, reserve is
prevented.

5:
Place a hold on title (which has only one items) level with start date
and expiration date.
Try to checkout the unique item from this title with period overlaping
the reserve period.
Check you are warned about an existing reserve

6:
Place a hold on title (which has more than one items) level with start
date and expiration date.
Checkout an item from this title with period overlaping the reserve
period.
Check you are NOT warned about an existing reserve.

7:
Place a hold on item level with start date and expiration date.
Checkout this item period overlaping the reserve period.
Check you are warned about an existing reserve

Rabased on master
Rebased on master (2016-06-23)
Rebased on master (2017-03-23)

Signed-off-by: Séverine QUEUNE 
Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #61544|0   |1
is obsolete||

--- Comment #41 from Alex Arnaud  ---
Created attachment 67088
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67088=edit
Bug 15261: Verify if checkouts/reserves requests periods overlap...

... with existing reserves

When checking out or placing hold, we should check if an existing
reserve whose period overlap exists.

A user place an hold from opac whose requested period overlap an
existing reserve period => prevent reserve,

A librarian place an hold from staff whose requested period overlap an
existing reserve period => Warn librarian (Ask for confirmation),

A librarian make a checkout from staff whose requested period overlap an
existing reserve period => Warn librarian (Ask for confirmation).

Test plan:

Enable syspref: AllowHoldDateInFuture OPACAllowHoldDateInFuture
  PreventChechoutOnSameReservePeriod and PreventReservesOnSamePeriod

1 (staff side):
Place a hold on title (which has only one items) level with start date
and expiration date.
Place another hold (also title level) with period overlaping this
reserve.
Check you are warned about an existing reserve

2 (staff side):
Place a hold on title (which has more than one items) level with start
date and expiration date.
Place another hold (also title level) with period overlaping this
reserve.
Check you are NOT warned about an existing reserve. Because it remains
at least one item not reserved.

3 (staff side):
Place a hold on item level with start date and expiration date.
Place another hold on item level with period overlaping this reserve.
Check you are warned about an existing reserve.

4 (opac side):
Do the same than for staff side. Instead of a warn, reserve is
prevented.

5:
Place a hold on title (which has only one items) level with start date
and expiration date.
Try to checkout the unique item from this title with period overlaping
the reserve period.
Check you are warned about an existing reserve

6:
Place a hold on title (which has more than one items) level with start
date and expiration date.
Checkout an item from this title with period overlaping the reserve
period.
Check you are NOT warned about an existing reserve.

7:
Place a hold on item level with start date and expiration date.
Checkout this item period overlaping the reserve period.
Check you are warned about an existing reserve

Rabased on master
Rebased on master (2016-06-23)
Rebased on master (2017-03-23)

Signed-off-by: Séverine QUEUNE 
Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Patch doesn't apply

--- Comment #40 from Marcel de Rooy  ---
No longer applies and typo mentioned in previous comment

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261

--- Comment #39 from Marcel de Rooy  ---
Typo: PreventChechoutOnSameReservePeriod

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261

--- Comment #38 from sandbo...@biblibre.com  ---
Created attachment 61544
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61544=edit
Bug 15261: Verify if checkouts/reserves requests periods overlap...

... with existing reserves

When checking out or placing hold, we should check if an existing
reserve whose period overlap exists.

A user place an hold from opac whose requested period overlap an
existing reserve period => prevent reserve,

A librarian place an hold from staff whose requested period overlap an
existing reserve period => Warn librarian (Ask for confirmation),

A librarian make a checkout from staff whose requested period overlap an
existing reserve period => Warn librarian (Ask for confirmation).

Test plan:

Enable syspref: AllowHoldDateInFuture OPACAllowHoldDateInFuture
  PreventChechoutOnSameReservePeriod and PreventReservesOnSamePeriod

1 (staff side):
Place a hold on title (which has only one items) level with start date
and expiration date.
Place another hold (also title level) with period overlaping this
reserve.
Check you are warned about an existing reserve

2 (staff side):
Place a hold on title (which has more than one items) level with start
date and expiration date.
Place another hold (also title level) with period overlaping this
reserve.
Check you are NOT warned about an existing reserve. Because it remains
at least one item not reserved.

3 (staff side):
Place a hold on item level with start date and expiration date.
Place another hold on item level with period overlaping this reserve.
Check you are warned about an existing reserve.

4 (opac side):
Do the same than for staff side. Instead of a warn, reserve is
prevented.

5:
Place a hold on title (which has only one items) level with start date
and expiration date.
Try to checkout the unique item from this title with period overlaping
the reserve period.
Check you are warned about an existing reserve

6:
Place a hold on title (which has more than one items) level with start
date and expiration date.
Checkout an item from this title with period overlaping the reserve
period.
Check you are NOT warned about an existing reserve.

7:
Place a hold on item level with start date and expiration date.
Checkout this item period overlaping the reserve period.
Check you are warned about an existing reserve

Rabased on master
Rebased on master (2016-06-23)
Rebased on master (2017-03-23)

Signed-off-by: Séverine QUEUNE 
Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261

sandbo...@biblibre.com  changed:

   What|Removed |Added

  Attachment #61539|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261

sandbo...@biblibre.com  changed:

   What|Removed |Added

 CC||sandbo...@biblibre.com
 Status|Needs Signoff   |Signed Off

--- Comment #37 from sandbo...@biblibre.com  ---
Patch tested with a sandbox, by Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #61534|0   |1
is obsolete||

--- Comment #36 from Alex Arnaud  ---
Created attachment 61539
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61539=edit
Bug 15261: Verify if checkouts/reserves requests periods overlap...

... with existing reserves

When checking out or placing hold, we should check if an existing
reserve whose period overlap exists.

A user place an hold from opac whose requested period overlap an
existing reserve period => prevent reserve,

A librarian place an hold from staff whose requested period overlap an
existing reserve period => Warn librarian (Ask for confirmation),

A librarian make a checkout from staff whose requested period overlap an
existing reserve period => Warn librarian (Ask for confirmation).

Test plan:

Enable syspref: AllowHoldDateInFuture OPACAllowHoldDateInFuture
  PreventChechoutOnSameReservePeriod and PreventReservesOnSamePeriod

1 (staff side):
Place a hold on title (which has only one items) level with start date
and expiration date.
Place another hold (also title level) with period overlaping this
reserve.
Check you are warned about an existing reserve

2 (staff side):
Place a hold on title (which has more than one items) level with start
date and expiration date.
Place another hold (also title level) with period overlaping this
reserve.
Check you are NOT warned about an existing reserve. Because it remains
at least one item not reserved.

3 (staff side):
Place a hold on item level with start date and expiration date.
Place another hold on item level with period overlaping this reserve.
Check you are warned about an existing reserve.

4 (opac side):
Do the same than for staff side. Instead of a warn, reserve is
prevented.

5:
Place a hold on title (which has only one items) level with start date
and expiration date.
Try to checkout the unique item from this title with period overlaping
the reserve period.
Check you are warned about an existing reserve

6:
Place a hold on title (which has more than one items) level with start
date and expiration date.
Checkout an item from this title with period overlaping the reserve
period.
Check you are NOT warned about an existing reserve.

7:
Place a hold on item level with start date and expiration date.
Checkout this item period overlaping the reserve period.
Check you are warned about an existing reserve

Rabased on master
Rebased on master (2016-06-23)
Rebased on master (2017-03-23)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #59643|0   |1
is obsolete||

--- Comment #35 from Alex Arnaud  ---
Created attachment 61534
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61534=edit
Bug 15261: Verify if checkouts/reserves requests periods overlap...

... with existing reserves

When checking out or placing hold, we should check if an existing
reserve whose period overlap exists.

A user place an hold from opac whose requested period overlap an
existing reserve period => prevent reserve,

A librarian place an hold from staff whose requested period overlap an
existing reserve period => Warn librarian (Ask for confirmation),

A librarian make a checkout from staff whose requested period overlap an
existing reserve period => Warn librarian (Ask for confirmation).

Test plan:

Enable syspref: AllowHoldDateInFuture OPACAllowHoldDateInFuture
  PreventChechoutOnSameReservePeriod and PreventReservesOnSamePeriod

1 (staff side):
Place a hold on title (which has only one items) level with start date
and expiration date.
Place another hold (also title level) with period overlaping this
reserve.
Check you are warned about an existing reserve

2 (staff side):
Place a hold on title (which has more than one items) level with start
date and expiration date.
Place another hold (also title level) with period overlaping this
reserve.
Check you are NOT warned about an existing reserve. Because it remains
at least one item not reserved.

3 (staff side):
Place a hold on item level with start date and expiration date.
Place another hold on item level with period overlaping this reserve.
Check you are warned about an existing reserve.

4 (opac side):
Do the same than for staff side. Instead of a warn, reserve is
prevented.

5:
Place a hold on title (which has only one items) level with start date
and expiration date.
Try to checkout the unique item from this title with period overlaping
the reserve period.
Check you are warned about an existing reserve

6:
Place a hold on title (which has more than one items) level with start
date and expiration date.
Checkout an item from this title with period overlaping the reserve
period.
Check you are NOT warned about an existing reserve.

7:
Place a hold on item level with start date and expiration date.
Checkout this item period overlaping the reserve period.
Check you are warned about an existing reserve

Rabased on master
Rebased on master (2016-06-23)
Rebased on master (2017-03-23)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #52704|0   |1
is obsolete||

--- Comment #34 from Alex Arnaud  ---
Created attachment 59643
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=59643=edit
Bug 15261: Verify if checkouts/reserves requests periods overlap...

... with existing reserves

When checking out or placing hold, we should check if an existing
reserve whose period overlap exists.

A user place an hold from opac whose requested period overlap an
existing reserve period => prevent reserve,

A librarian place an hold from staff whose requested period overlap an
existing reserve period => Warn librarian (Ask for confirmation),

A librarian make a checkout from staff whose requested period overlap an
existing reserve period => Warn librarian (Ask for confirmation).

Test plan:

Enable syspref: AllowHoldDateInFuture OPACAllowHoldDateInFuture
  PreventChechoutOnSameReservePeriod and PreventReservesOnSamePeriod

1 (staff side):
Place a hold on title (which has only one items) level with start date
and expiration date.
Place another hold (also title level) with period overlaping this
reserve.
Check you are warned about an existing reserve

2 (staff side):
Place a hold on title (which has more than one items) level with start
date and expiration date.
Place another hold (also title level) with period overlaping this
reserve.
Check you are NOT warned about an existing reserve. Because it remains
at least one item not reserved.

3 (staff side):
Place a hold on item level with start date and expiration date.
Place another hold on item level with period overlaping this reserve.
Check you are warned about an existing reserve.

4 (opac side):
Do the same than for staff side. Instead of a warn, reserve is
prevented.

5:
Place a hold on title (which has only one items) level with start date
and expiration date.
Try to checkout the unique item from this title with period overlaping
the reserve period.
Check you are warned about an existing reserve

6:
Place a hold on title (which has more than one items) level with start
date and expiration date.
Checkout an item from this title with period overlaping the reserve
period.
Check you are NOT warned about an existing reserve.

7:
Place a hold on item level with start date and expiration date.
Checkout this item period overlaping the reserve period.
Check you are warned about an existing reserve

Rabased on master
Rebased on master (2016-06-23)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261

--- Comment #33 from Alex Arnaud  ---
(In reply to Fridolin SOMERS from comment #32)
> Change in C4/Installer/PerlDependencies.pm is useless I think

I think you are right Frido

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261

Fridolin SOMERS  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #32 from Fridolin SOMERS  ---
Change in C4/Installer/PerlDependencies.pm is useless I think

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #49001|0   |1
is obsolete||
  Attachment #49002|0   |1
is obsolete||
  Attachment #49003|0   |1
is obsolete||

--- Comment #31 from Alex Arnaud  ---
Created attachment 52704
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52704=edit
Bug 15261: Verify if checkouts/reserves requests periods overlap...

... with existing reserves

When checking out or placing hold, we should check if an existing
reserve whose period overlap exists.

A user place an hold from opac whose requested period overlap an
existing reserve period => prevent reserve,

A librarian place an hold from staff whose requested period overlap an
existing reserve period => Warn librarian (Ask for confirmation),

A librarian make a checkout from staff whose requested period overlap an
existing reserve period => Warn librarian (Ask for confirmation).

Test plan:

Enable syspref: AllowHoldDateInFuture OPACAllowHoldDateInFuture
  PreventChechoutOnSameReservePeriod and PreventReservesOnSamePeriod

1 (staff side):
Place a hold on title (which has only one items) level with start date
and expiration date.
Place another hold (also title level) with period overlaping this
reserve.
Check you are warned about an existing reserve

2 (staff side):
Place a hold on title (which has more than one items) level with start
date and expiration date.
Place another hold (also title level) with period overlaping this
reserve.
Check you are NOT warned about an existing reserve. Because it remains
at least one item not reserved.

3 (staff side):
Place a hold on item level with start date and expiration date.
Place another hold on item level with period overlaping this reserve.
Check you are warned about an existing reserve.

4 (opac side):
Do the same than for staff side. Instead of a warn, reserve is
prevented.

5:
Place a hold on title (which has only one items) level with start date
and expiration date.
Try to checkout the unique item from this title with period overlaping
the reserve period.
Check you are warned about an existing reserve

6:
Place a hold on title (which has more than one items) level with start
date and expiration date.
Checkout an item from this title with period overlaping the reserve
period.
Check you are NOT warned about an existing reserve.

7:
Place a hold on item level with start date and expiration date.
Checkout this item period overlaping the reserve period.
Check you are warned about an existing reserve

Rabased on master
Rebased on master (2016-06-23)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261

Alex Arnaud  changed:

   What|Removed |Added

 Status|In Discussion   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #46442|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261

--- Comment #30 from Alex Arnaud  ---
Created attachment 49003
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49003=edit
Bug 15261: Add PreventChechoutOnSameReservePeriod and
PreventReservesOnSamePeriod system preferences

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261

--- Comment #29 from Alex Arnaud  ---
Created attachment 49002
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49002=edit
Bug 15261: remove Date::Range and Date::Simple dependencies

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261

Alex Arnaud  changed:

   What|Removed |Added

  Attachment #46441|0   |1
is obsolete||

--- Comment #28 from Alex Arnaud  ---
Created attachment 49001
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49001=edit
Bug 15261: Verify if checkouts/reserves requests periods overlap...

... with existing reserves

When checking out or placing hold, we should check if an existing
reserve whose period overlap exists.

A user place an hold from opac whose requested period overlap an
existing reserve period => prevent reserve,

A librarian place an hold from staff whose requested period overlap an
existing reserve period => Warn librarian (Ask for confirmation),

A librarian make a checkout from staff whose requested period overlap an
existing reserve period => Warn librarian (Ask for confirmation).

Test plan:

Enable syspref: AllowHoldDateInFuture OPACAllowHoldDateInFuture

1 (staff side):
Place a hold on title (which has only one items) level with start date
and expiration date.
Place another hold (also title level) with period overlaping this
reserve.
Check you are warned about an existing reserve

2 (staff side):
Place a hold on title (which has more than one items) level with start
date and expiration date.
Place another hold (also title level) with period overlaping this
reserve.
Check you are NOT warned about an existing reserve. Because it remains
at least one item not reserved.

3 (staff side):
Place a hold on item level with start date and expiration date.
Place another hold on item level with period overlaping this reserve.
Check you are warned about an existing reserve.

4 (opac side):
Do the same than for staff side. Instead of a warn, reserve is
prevented.

5:
Place a hold on title (which has only one items) level with start date
and expiration date.
Try to checkout the unique item from this title with period overlaping
the reserve period.
Check you are warned about an existing reserve

6:
Place a hold on title (which has more than one items) level with start
date and expiration date.
Checkout an item from this title with period overlaping the reserve
period.
Check you are NOT warned about an existing reserve.

7:
Place a hold on item level with start date and expiration date.
Checkout this item period overlaping the reserve period.
Check you are warned about an existing reserve

Rabased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261

--- Comment #27 from Julian Maurice  ---
(In reply to Marcel de Rooy from comment #26)
> No. Patron2 may receive the book before patron1. That is no problem. Patron1
> will probably have it the next day.

For a 1-day loan that is true.

Looks like we are going to need another reserves syspref :(

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261

--- Comment #26 from Marcel de Rooy  ---
(In reply to Julian Maurice from comment #24)
Thx for your response.

> Let's take an example:
> - Patron 1 place a hold that starts on 2016-03-01 and ends on 2016-03-07
> - Patron 2 place a hold that starts on 2016-03-02 and ends on 2016-03-06
> If patron 1 get the book, patron 2 will never have it (unless patron 1
> returns the book very quickly, which is very unlikely to happen imo) and is
> never informed about the high probability that this will happen.
"Unlikely to happen imo " is the problem here. As a special library we loan the
book and it will normally be returned the same day. (The book does not really
leave the building.)

> Another issue:
> - Patron 1 place a hold that starts on 2016-03-02 and ends on 2016-03-08
> - Patron 2 place a hold (after patron 1 has placed their hold) that starts
> on 2016-03-01 (we don't care about the end date here)
> If priority is based on start date, then patron 2 will "steal" the book from
> patron 1. Patron 1 will never get the book while they have placed their hold
> first.
No. Patron2 may receive the book before patron1. That is no problem. Patron1
will probably have it the next day.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261

--- Comment #25 from Katrin Fischer  ---
I think ideally we shoudl have a proper reservation system that maybe even
works separately from the holds system. But my main concern here is that the
new behavioru should be optional - so we honor the different workflows. If the
books is not checked out or only used on-site, the library can coordinate
overlapping holds.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261

Julian Maurice  changed:

   What|Removed |Added

 CC|sandbo...@biblibre.com  |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261

--- Comment #24 from Julian Maurice  ---
Why Koha should allow to place hold that will be (probably) impossible to
satisfy ?

Let's take an example:
- Patron 1 place a hold that starts on 2016-03-01 and ends on 2016-03-07
- Patron 2 place a hold that starts on 2016-03-02 and ends on 2016-03-06
If patron 1 get the book, patron 2 will never have it (unless patron 1 returns
the book very quickly, which is very unlikely to happen imo) and is never
informed about the high probability that this will happen.

Another issue:
- Patron 1 place a hold that starts on 2016-03-02 and ends on 2016-03-08
- Patron 2 place a hold (after patron 1 has placed their hold) that starts on
2016-03-01 (we don't care about the end date here)
If priority is based on start date, then patron 2 will "steal" the book from
patron 1. Patron 1 will never get the book while they have placed their hold
first.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261

--- Comment #23 from Marcel de Rooy  ---
(In reply to Katrin Fischer from comment #19)
> can you maybe explain the usual use case for the HoldDateInFuture setting?
> Maybe this will help to clear things up about the differences even more. I
> am not quite sure about myself and would like to understand better how it's
> currently used.

We have enabled a.o.: AllowHoldDateInFuture, ConfirmFutureHolds=2,
OPACAllowHoldDateInFuture.
This offers the user to supply two additional dates with a hold request: Hold
starts on date, and Hold not needed after.

What does that mean? The patron tells us here that he would like to have the
book only in the indicated (future) period. So we do not put the book in
waiting status for him until this period is very close (ConfirmFutureHolds). In
the meantime we can issue the book to someone else or let others place holds.
Similarly, another patron can also say: I want this book between A and B. No
problem if this overlaps the period of patron 1. Priority is here based on
[future] start date.
If the book could not be put in waiting status for patron 1 in the indicated
period somehow, the expired hold will be cancelled.

This is imo just a straightforward use of the two dates as Koha offers by
default. Our specific local situation is not relevant in this discussion.

Note that I am still missing any response from the authors of this patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261

--- Comment #22 from Kyle M Hall  ---
(In reply to Katrin Fischer from comment #21)
> Ah, I thought it was yours - Holds... must be Kyle! Sorry!

lol, I can understand why ; )

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261

--- Comment #17 from Kyle M Hall  ---
(In reply to Marcel de Rooy from comment #16)
> Could you please clarify why an existing reserve and a new one should not be
> allowed to have some overlap in the period?
> In our case this may happen frequently.

It seems to me that this is more like treating a hold as a true reservation
than a hold. It's saying "This item will go to this patron on this date, so
nobody else can have it on that date". Kind of like reserving a conference
room.

Now, whether we should have that behavior or not is a the real question or not. 

This link is for another ILS and at seems to explain Holds vs Reserves vs
Reservations pretty well:
http://www.goalexandria.com/totw/tips/2009/100509.html

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261

--- Comment #18 from Kyle M Hall  ---
I should also note, we have Holds ( of course! ), we have Reserves ( aka Course
Reserves ) but Koha doesn't really have Reservations as a first class feature.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261

--- Comment #19 from Katrin Fischer  ---
Hi Kyle or Marcel,

can you maybe explain the usual use case for the HoldDateInFuture setting?
Maybe this will help to clear things up about the differences even more. I am
not quite sure about myself and would like to understand better how it's
currently used.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261

--- Comment #20 from Kyle M Hall  ---
(In reply to Katrin Fischer from comment #19)
> Hi Kyle or Marcel,
> 
> can you maybe explain the usual use case for the HoldDateInFuture setting?
> Maybe this will help to clear things up about the differences even more. I
> am not quite sure about myself and would like to understand better how it's
> currently used.

I'm not the author of HoldDateInFuture ( iirc ), so I don't really know. I
think that it is basically shoehorning Reservations behavior into holds, but
since I don't have a use case, I may be wrong.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261

--- Comment #21 from Katrin Fischer  ---
Ah, I thought it was yours - Holds... must be Kyle! Sorry!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/